From a00537e412e4ef6761ad35cc7148637ad75434a1 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 13 Jan 2022 12:14:38 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- GITLAB_PAGES_VERSION | 2 +- .../components/board_filtered_search.vue | 17 +- app/assets/javascripts/boards/constants.js | 1 + .../components/path_navigation.vue | 2 +- .../components/value_stream_filters.vue | 4 +- app/assets/javascripts/experimental_flags.js | 15 - .../jobs/bridge/components/sidebar.vue | 23 +- .../pages/admin/runners/edit/index.js | 4 +- .../admin_runner_edit_app.vue} | 2 +- .../index.js | 6 +- .../components/cells/runner_actions_cell.vue | 4 +- .../runner/components/runner_update_form.vue | 2 +- .../runner/graphql/get_runners.query.graphql | 1 + .../runner_update_form_utils.js | 0 app/assets/javascripts/tree.js | 64 ----- .../tokens/author_token.vue | 4 +- app/controllers/admin/runners_controller.rb | 2 +- .../security/configuration_controller.rb | 31 +++ app/models/concerns/routable.rb | 5 + app/models/email.rb | 8 +- app/models/namespace.rb | 2 +- app/views/admin/runners/edit.html.haml | 15 +- app/views/admin/runners/show.html.haml | 8 + app/workers/email_receiver_worker.rb | 33 +-- .../runner_read_only_admin_view.yml | 8 + .../unify_security_configuration.yml | 8 + ...16_remove_projects_ci_pending_builds_fk.rb | 15 + ...oken_project_scope_links_added_by_id_fk.rb | 15 + ...users_ci_pipeline_schedules_owner_id_fk.rb | 15 + db/schema_migrations/20220111221516 | 1 + db/schema_migrations/20220113035519 | 1 + db/schema_migrations/20220113040447 | 1 + db/structure.sql | 9 - doc/administration/clusters/kas.md | 2 +- doc/tutorials/index.md | 1 - doc/user/clusters/agent/ci_cd_tunnel.md | 7 +- doc/user/clusters/agent/install/index.md | 259 ++---------------- lib/api/internal/mail_room.rb | 10 +- .../database/gitlab_loose_foreign_keys.yml | 3 + lib/gitlab/email.rb | 1 + lib/gitlab/email/failure_handler.rb | 46 ++++ locale/gitlab.pot | 33 +-- .../admin/runners_controller_spec.rb | 11 +- .../profiles/emails_controller_spec.rb | 2 +- .../security/configuration_controller_spec.rb | 25 ++ spec/features/admin/admin_runners_spec.rb | 3 +- spec/features/boards/board_filters_spec.rb | 4 +- spec/features/profiles/emails_spec.rb | 2 +- .../components/board_filtered_search_spec.js | 22 +- .../jobs/bridge/components/sidebar_spec.js | 19 ++ .../admin_runner_edit_app_spec.js} | 8 +- .../cells/runner_actions_cell_spec.js | 8 +- .../runner_update_form_utils_spec.js | 7 +- .../tokens/author_token_spec.js | 12 +- spec/lib/gitlab/email/failure_handler_spec.rb | 69 +++++ .../ci/job_token/project_scope_link_spec.rb | 5 + spec/models/ci/pending_build_spec.rb | 5 + spec/models/ci/pipeline_schedule_spec.rb | 5 + spec/models/concerns/routable_spec.rb | 33 +-- spec/models/email_spec.rb | 2 +- spec/models/user_spec.rb | 2 +- spec/requests/api/internal/mail_room_spec.rb | 21 +- spec/workers/email_receiver_worker_spec.rb | 78 ++---- 63 files changed, 498 insertions(+), 535 deletions(-) delete mode 100644 app/assets/javascripts/experimental_flags.js rename app/assets/javascripts/runner/{runner_details/runner_details_app.vue => admin_runner_edit/admin_runner_edit_app.vue} (97%) rename app/assets/javascripts/runner/{runner_details => admin_runner_edit}/index.js (73%) rename app/assets/javascripts/runner/{runner_details => }/runner_update_form_utils.js (100%) delete mode 100644 app/assets/javascripts/tree.js create mode 100644 app/views/admin/runners/show.html.haml create mode 100644 config/feature_flags/development/runner_read_only_admin_view.yml create mode 100644 config/feature_flags/development/unify_security_configuration.yml create mode 100644 db/post_migrate/20220111221516_remove_projects_ci_pending_builds_fk.rb create mode 100644 db/post_migrate/20220113035519_remove_users_ci_job_token_project_scope_links_added_by_id_fk.rb create mode 100644 db/post_migrate/20220113040447_remove_users_ci_pipeline_schedules_owner_id_fk.rb create mode 100644 db/schema_migrations/20220111221516 create mode 100644 db/schema_migrations/20220113035519 create mode 100644 db/schema_migrations/20220113040447 create mode 100644 lib/gitlab/email/failure_handler.rb rename spec/frontend/runner/{runner_detail/runner_details_app_spec.js => admin_runner_edit/admin_runner_edit_app_spec.js} (92%) rename spec/frontend/runner/{runner_detail => }/runner_update_form_utils_spec.js (92%) create mode 100644 spec/lib/gitlab/email/failure_handler_spec.rb diff --git a/GITLAB_PAGES_VERSION b/GITLAB_PAGES_VERSION index 5a5c7211dc6..ba0a719118c 100644 --- a/GITLAB_PAGES_VERSION +++ b/GITLAB_PAGES_VERSION @@ -1 +1 @@ -1.50.0 +1.51.0 diff --git a/app/assets/javascripts/boards/components/board_filtered_search.vue b/app/assets/javascripts/boards/components/board_filtered_search.vue index 09ec385bbba..2599d1c80b8 100644 --- a/app/assets/javascripts/boards/components/board_filtered_search.vue +++ b/app/assets/javascripts/boards/components/board_filtered_search.vue @@ -6,6 +6,7 @@ import { updateHistory, setUrlParams } from '~/lib/utils/url_utility'; import { __ } from '~/locale'; import { FILTERED_SEARCH_TERM } from '~/vue_shared/components/filtered_search_bar/constants'; import FilteredSearch from '~/vue_shared/components/filtered_search_bar/filtered_search_bar_root.vue'; +import { AssigneeFilterType } from '~/boards/constants'; export default { i18n: { @@ -37,6 +38,7 @@ export default { authorUsername, labelName, assigneeUsername, + assigneeId, search, milestoneTitle, iterationId, @@ -63,6 +65,13 @@ export default { }); } + if (assigneeId) { + filteredSearchValue.push({ + type: 'assignee', + value: { data: assigneeId, operator: '=' }, + }); + } + if (types) { filteredSearchValue.push({ type: 'type', @@ -211,6 +220,7 @@ export default { authorUsername, labelName, assigneeUsername, + assigneeId, search, milestoneTitle, types, @@ -246,6 +256,7 @@ export default { author_username: authorUsername, 'label_name[]': labelName, assignee_username: assigneeUsername, + assignee_id: assigneeId, milestone_title: milestoneTitle, iteration_id: iterationId, search, @@ -295,7 +306,11 @@ export default { filterParams.authorUsername = filter.value.data; break; case 'assignee': - filterParams.assigneeUsername = filter.value.data; + if (Object.values(AssigneeFilterType).includes(filter.value.data)) { + filterParams.assigneeId = filter.value.data; + } else { + filterParams.assigneeUsername = filter.value.data; + } break; case 'type': filterParams.types = filter.value.data; diff --git a/app/assets/javascripts/boards/constants.js b/app/assets/javascripts/boards/constants.js index 80559795cf0..e0eea761b31 100644 --- a/app/assets/javascripts/boards/constants.js +++ b/app/assets/javascripts/boards/constants.js @@ -120,6 +120,7 @@ export const FilterFields = { /* eslint-disable @gitlab/require-i18n-strings */ export const AssigneeFilterType = { any: 'Any', + none: 'None', }; export const MilestoneFilterType = { diff --git a/app/assets/javascripts/cycle_analytics/components/path_navigation.vue b/app/assets/javascripts/cycle_analytics/components/path_navigation.vue index f8f89772fd6..af7334ecf2e 100644 --- a/app/assets/javascripts/cycle_analytics/components/path_navigation.vue +++ b/app/assets/javascripts/cycle_analytics/components/path_navigation.vue @@ -57,7 +57,7 @@ export default { };