Set the issuable sidebar to remain collapsed on mobile devices
This commit is contained in:
parent
c57e66bebb
commit
a63b18b14f
|
|
@ -211,6 +211,14 @@ $(function () {
|
|||
}
|
||||
});
|
||||
|
||||
if (bootstrapBreakpoint === 'xs') {
|
||||
const $rightSidebar = $('aside.right-sidebar, .page-with-sidebar');
|
||||
|
||||
$rightSidebar
|
||||
.removeClass('right-sidebar-expanded')
|
||||
.addClass('right-sidebar-collapsed');
|
||||
}
|
||||
|
||||
// prevent default action for disabled buttons
|
||||
$('.btn').click(function(e) {
|
||||
if ($(this).hasClass('disabled')) {
|
||||
|
|
|
|||
|
|
@ -0,0 +1,4 @@
|
|||
---
|
||||
title: Set the issuable sidebar to remain closed for mobile devices
|
||||
merge_request:
|
||||
author:
|
||||
|
|
@ -120,6 +120,20 @@ feature 'Issue Sidebar', feature: true do
|
|||
end
|
||||
end
|
||||
|
||||
context 'as a allowed mobile user', js: true do
|
||||
before do
|
||||
project.team << [user, :developer]
|
||||
resize_screen_xs
|
||||
visit_issue(project, issue)
|
||||
end
|
||||
|
||||
context 'mobile sidebar' do
|
||||
it 'collapses the sidebar for small screens' do
|
||||
expect(page).not_to have_css('aside.right-sidebar.right-sidebar-collapsed')
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'as a guest' do
|
||||
before do
|
||||
project.team << [user, :guest]
|
||||
|
|
|
|||
|
|
@ -1,4 +1,8 @@
|
|||
module MobileHelpers
|
||||
def resize_screen_xs
|
||||
resize_window(767, 768)
|
||||
end
|
||||
|
||||
def resize_screen_sm
|
||||
resize_window(900, 768)
|
||||
end
|
||||
|
|
|
|||
Loading…
Reference in New Issue