diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 5b5fca8cc77..5dc4cf6e056 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -3,70 +3,6 @@ Style/PercentLiteralDelimiters: Exclude: - 'metrics_server/metrics_server.rb' - - 'spec/graphql/mutations/alert_management/update_alert_status_spec.rb' - - 'spec/graphql/mutations/ci/runner/update_spec.rb' - - 'spec/graphql/mutations/commits/create_spec.rb' - - 'spec/graphql/resolvers/board_lists_resolver_spec.rb' - - 'spec/graphql/resolvers/container_repository_tags_resolver_spec.rb' - - 'spec/graphql/resolvers/projects/jira_projects_resolver_spec.rb' - - 'spec/graphql/resolvers/projects_resolver_spec.rb' - - 'spec/graphql/types/boards/board_issue_input_type_spec.rb' - - 'spec/graphql/types/design_management/design_collection_copy_state_enum_spec.rb' - - 'spec/graphql/types/issue_type_spec.rb' - - 'spec/helpers/appearances_helper_spec.rb' - - 'spec/helpers/application_settings_helper_spec.rb' - - 'spec/helpers/auth_helper_spec.rb' - - 'spec/helpers/breadcrumbs_helper_spec.rb' - - 'spec/helpers/ci/pipelines_helper_spec.rb' - - 'spec/helpers/clusters_helper_spec.rb' - - 'spec/helpers/diff_helper_spec.rb' - - 'spec/helpers/emails_helper_spec.rb' - - 'spec/helpers/issuables_description_templates_helper_spec.rb' - - 'spec/helpers/issues_helper_spec.rb' - - 'spec/helpers/nav_helper_spec.rb' - - 'spec/helpers/page_layout_helper_spec.rb' - - 'spec/helpers/profiles_helper_spec.rb' - - 'spec/helpers/releases_helper_spec.rb' - - 'spec/helpers/tracking_helper_spec.rb' - - 'spec/initializers/direct_upload_support_spec.rb' - - 'spec/initializers/enumerator_next_patch_spec.rb' - - 'spec/initializers/rack_multipart_patch_spec.rb' - - 'spec/lib/api/ci/helpers/runner_helpers_spec.rb' - - 'spec/lib/api/entities/user_spec.rb' - - 'spec/lib/api/helpers/common_helpers_spec.rb' - - 'spec/lib/backup/files_spec.rb' - - 'spec/lib/backup/manager_spec.rb' - - 'spec/lib/backup/repositories_spec.rb' - - 'spec/lib/banzai/filter/asset_proxy_filter_spec.rb' - - 'spec/lib/banzai/filter/autolink_filter_spec.rb' - - 'spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb' - - 'spec/lib/banzai/filter/image_link_filter_spec.rb' - - 'spec/lib/banzai/filter/references/alert_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/commit_range_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/commit_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/design_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/external_issue_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/feature_flag_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/merge_request_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/milestone_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/project_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/snippet_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/references/user_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/syntax_highlight_filter_spec.rb' - - 'spec/lib/banzai/filter_array_spec.rb' - - 'spec/lib/banzai/pipeline/description_pipeline_spec.rb' - - 'spec/lib/banzai/pipeline/full_pipeline_spec.rb' - - 'spec/lib/banzai/pipeline/gfm_pipeline_spec.rb' - - 'spec/lib/banzai/pipeline/plain_markdown_pipeline_spec.rb' - - 'spec/lib/banzai/reference_parser/base_parser_spec.rb' - - 'spec/lib/banzai/reference_parser/issue_parser_spec.rb' - - 'spec/lib/banzai/reference_parser/merge_request_parser_spec.rb' - - 'spec/lib/bitbucket/collection_spec.rb' - - 'spec/lib/bitbucket/representation/repo_spec.rb' - - 'spec/lib/bulk_imports/common/pipelines/boards_pipeline_spec.rb' - - 'spec/lib/bulk_imports/common/transformers/prohibited_attributes_transformer_spec.rb' - 'spec/lib/gitlab/alert_management/payload/base_spec.rb' - 'spec/lib/gitlab/asset_proxy_spec.rb' - 'spec/lib/gitlab/auth/ldap/auth_hash_spec.rb' @@ -186,7 +122,6 @@ Style/PercentLiteralDelimiters: - 'spec/lib/gitlab/popen_spec.rb' - 'spec/lib/gitlab/process_management_spec.rb' - 'spec/lib/gitlab/process_supervisor_spec.rb' - - 'spec/lib/gitlab/prometheus/query_variables_spec.rb' - 'spec/lib/gitlab/quick_actions/extractor_spec.rb' - 'spec/lib/gitlab/reference_extractor_spec.rb' - 'spec/lib/gitlab/repository_cache_adapter_spec.rb' @@ -261,7 +196,6 @@ Style/PercentLiteralDelimiters: - 'spec/models/diff_viewer/base_spec.rb' - 'spec/models/environment_spec.rb' - 'spec/models/group_label_spec.rb' - - 'spec/models/group_spec.rb' - 'spec/models/instance_configuration_spec.rb' - 'spec/models/integration_spec.rb' - 'spec/models/integrations/buildkite_spec.rb' @@ -279,7 +213,6 @@ Style/PercentLiteralDelimiters: - 'spec/models/project_feature_spec.rb' - 'spec/models/project_label_spec.rb' - 'spec/models/project_spec.rb' - - 'spec/models/project_team_spec.rb' - 'spec/models/projects/topic_spec.rb' - 'spec/models/prometheus_metric_spec.rb' - 'spec/models/releases/link_spec.rb' @@ -320,13 +253,11 @@ Style/PercentLiteralDelimiters: - 'spec/requests/api/graphql/project/terraform/state_spec.rb' - 'spec/requests/api/graphql/project/terraform/states_spec.rb' - 'spec/requests/api/internal/base_spec.rb' - - 'spec/requests/api/invitations_spec.rb' - 'spec/requests/api/issues/get_group_issues_spec.rb' - 'spec/requests/api/issues/get_project_issues_spec.rb' - 'spec/requests/api/issues/issues_spec.rb' - 'spec/requests/api/issues/post_projects_issues_spec.rb' - 'spec/requests/api/issues/put_projects_issues_spec.rb' - - 'spec/requests/api/members_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/metadata_spec.rb' - 'spec/requests/api/project_container_repositories_spec.rb' @@ -377,8 +308,6 @@ Style/PercentLiteralDelimiters: - 'spec/services/issues/export_csv_service_spec.rb' - 'spec/services/jira/requests/projects/list_service_spec.rb' - 'spec/services/lfs/file_transformer_spec.rb' - - 'spec/services/members/create_service_spec.rb' - - 'spec/services/members/invite_service_spec.rb' - 'spec/services/merge_requests/conflicts/resolve_service_spec.rb' - 'spec/services/merge_requests/merge_service_spec.rb' - 'spec/services/merge_requests/pushed_branches_service_spec.rb' @@ -422,7 +351,6 @@ Style/PercentLiteralDelimiters: - 'spec/support/shared_examples/metrics/transaction_metrics_with_labels_shared_examples.rb' - 'spec/support/shared_examples/models/application_setting_shared_examples.rb' - 'spec/support/shared_examples/models/diff_positionable_note_shared_examples.rb' - - 'spec/support/shared_examples/models/member_shared_examples.rb' - 'spec/support/shared_examples/models/project_ci_cd_settings_shared_examples.rb' - 'spec/support/shared_examples/models/wiki_shared_examples.rb' - 'spec/support/shared_examples/path_extraction_shared_examples.rb' diff --git a/app/assets/javascripts/analytics/cycle_analytics/components/base.vue b/app/assets/javascripts/analytics/cycle_analytics/components/base.vue index 84ee8f41b11..39fbc217278 100644 --- a/app/assets/javascripts/analytics/cycle_analytics/components/base.vue +++ b/app/assets/javascripts/analytics/cycle_analytics/components/base.vue @@ -56,6 +56,7 @@ export default { 'hasNoAccessError', 'groupPath', 'namespace', + 'predefinedDateRange', ]), ...mapGetters(['pathNavigationData', 'filterParams']), isLoaded() { @@ -132,6 +133,7 @@ export default { 'fetchStageData', 'setSelectedStage', 'setDateRange', + 'setPredefinedDateRange', 'updateStageTablePagination', ]), onSetDateRange({ startDate, endDate }) { @@ -170,7 +172,9 @@ export default { :start-date="createdAfter" :end-date="createdBefore" :group-path="groupPath" + :predefined-date-range="predefinedDateRange" @setDateRange="onSetDateRange" + @setPredefinedDateRange="setPredefinedDateRange" />
}
+ %(
)
)
end
@@ -326,8 +326,8 @@ RSpec.describe EmailsHelper do
create :appearance, header_message: 'Foo', footer_message: 'Bar', email_header_and_footer_enabled: true
aggregate_failures do
- expect(html_header_message).to eq(%{})
- expect(html_footer_message).to eq(%{})
+ expect(html_header_message).to eq(%())
+ expect(html_footer_message).to eq(%())
expect(text_header_message).to eq('Foo')
expect(text_footer_message).to eq('Bar')
end
diff --git a/spec/helpers/issuables_description_templates_helper_spec.rb b/spec/helpers/issuables_description_templates_helper_spec.rb
index b32a99fe989..4634ff83469 100644
--- a/spec/helpers/issuables_description_templates_helper_spec.rb
+++ b/spec/helpers/issuables_description_templates_helper_spec.rb
@@ -85,7 +85,7 @@ RSpec.describe IssuablesDescriptionTemplatesHelper, :clean_gitlab_redis_cache do
end
describe '#selected_template_name' do
- let(:template_names) { %w(another_issue_template custom_issue_template) }
+ let(:template_names) { %w[another_issue_template custom_issue_template] }
context 'when no issuable_template parameter is provided' do
it 'does not select a template' do
@@ -118,7 +118,7 @@ RSpec.describe IssuablesDescriptionTemplatesHelper, :clean_gitlab_redis_cache do
describe '#default_template_name' do
context 'when a default template is available' do
- let(:template_names) { %w(another_issue_template deFault) }
+ let(:template_names) { %w[another_issue_template deFault] }
it 'returns the default template' do
issue = build(:issue)
@@ -140,7 +140,7 @@ RSpec.describe IssuablesDescriptionTemplatesHelper, :clean_gitlab_redis_cache do
end
context 'when there is no default template' do
- let(:template_names) { %w(another_issue_template) }
+ let(:template_names) { %w[another_issue_template] }
it 'returns nil' do
expect(helper.default_template_name(template_names, build(:issue))).to be_nil
diff --git a/spec/helpers/issues_helper_spec.rb b/spec/helpers/issues_helper_spec.rb
index 72fa264698d..62d94b59c2a 100644
--- a/spec/helpers/issues_helper_spec.rb
+++ b/spec/helpers/issues_helper_spec.rb
@@ -78,7 +78,7 @@ RSpec.describe IssuesHelper, feature_category: :team_planning do
describe 'awards_sort' do
it 'sorts a hash so thumbsup and thumbsdown are always on top' do
data = { 'thumbsdown' => 'some value', 'lifter' => 'some value', 'thumbsup' => 'some value' }
- expect(awards_sort(data).keys).to eq(%w(thumbsup thumbsdown lifter))
+ expect(awards_sort(data).keys).to eq(%w[thumbsup thumbsdown lifter])
end
end
diff --git a/spec/helpers/nav_helper_spec.rb b/spec/helpers/nav_helper_spec.rb
index 950d8b77d01..12ab7ca93c0 100644
--- a/spec/helpers/nav_helper_spec.rb
+++ b/spec/helpers/nav_helper_spec.rb
@@ -115,13 +115,13 @@ RSpec.describe NavHelper, feature_category: :navigation do
describe '#page_has_markdown?' do
using RSpec::Parameterized::TableSyntax
- where path: %w(
+ where path: %w[
projects/merge_requests#show
projects/merge_requests/conflicts#show
issues#show
milestones#show
issues#designs
- )
+ ]
with_them do
before do
diff --git a/spec/helpers/page_layout_helper_spec.rb b/spec/helpers/page_layout_helper_spec.rb
index 43500d98591..a4f10933be6 100644
--- a/spec/helpers/page_layout_helper_spec.rb
+++ b/spec/helpers/page_layout_helper_spec.rb
@@ -55,7 +55,7 @@ RSpec.describe PageLayoutHelper do
expect(helper.page_image).to match_asset_path 'assets/twitter_card.jpg'
end
- %w(project user group).each do |type|
+ %w[project user group].each do |type|
context "with @#{type} assigned" do
let(:object) { build(type, trait) }
let(:trait) { :with_avatar }
@@ -116,11 +116,11 @@ RSpec.describe PageLayoutHelper do
it 'escapes content' do
allow(helper).to receive(:page_card_attributes)
- .and_return(foo: %q{foo" http-equiv="refresh}.html_safe)
+ .and_return(foo: %q(foo" http-equiv="refresh).html_safe)
tags = helper.page_card_meta_tags
- expect(tags).to include(%q{content="foo" http-equiv="refresh"})
+ expect(tags).to include(%q(content="foo" http-equiv="refresh"))
end
end
diff --git a/spec/helpers/profiles_helper_spec.rb b/spec/helpers/profiles_helper_spec.rb
index 15ca5f61b51..ece6574ee38 100644
--- a/spec/helpers/profiles_helper_spec.rb
+++ b/spec/helpers/profiles_helper_spec.rb
@@ -106,9 +106,9 @@ RSpec.describe ProfilesHelper do
using RSpec::Parameterized::TableSyntax
where(:stacking, :breakpoint, :expected) do
- nil | nil | %w(gl-mb-3 gl-display-inline-block middle-dot-divider)
- true | nil | %w(gl-mb-3 middle-dot-divider-sm gl-display-block gl-sm-display-inline-block)
- nil | :sm | %w(gl-mb-3 gl-display-inline-block middle-dot-divider-sm)
+ nil | nil | %w[gl-mb-3 gl-display-inline-block middle-dot-divider]
+ true | nil | %w[gl-mb-3 middle-dot-divider-sm gl-display-block gl-sm-display-inline-block]
+ nil | :sm | %w[gl-mb-3 gl-display-inline-block middle-dot-divider-sm]
end
with_them do
diff --git a/spec/helpers/releases_helper_spec.rb b/spec/helpers/releases_helper_spec.rb
index 5a9deb5c63b..daf034edbb1 100644
--- a/spec/helpers/releases_helper_spec.rb
+++ b/spec/helpers/releases_helper_spec.rb
@@ -59,7 +59,7 @@ RSpec.describe ReleasesHelper do
describe '#data_for_edit_release_page' do
it 'has the needed data to display the "edit release" page' do
- keys = %i(project_id
+ keys = %i[project_id
group_id
group_milestones_available
project_path
@@ -72,7 +72,7 @@ RSpec.describe ReleasesHelper do
new_milestone_path
upcoming_release_docs_path
edit_release_docs_path
- delete_release_docs_path)
+ delete_release_docs_path]
expect(helper.data_for_edit_release_page.keys).to match_array(keys)
end
@@ -80,7 +80,7 @@ RSpec.describe ReleasesHelper do
describe '#data_for_new_release_page' do
it 'has the needed data to display the "new release" page' do
- keys = %i(project_id
+ keys = %i[project_id
group_id
group_milestones_available
project_path
@@ -93,7 +93,7 @@ RSpec.describe ReleasesHelper do
new_milestone_path
default_branch
upcoming_release_docs_path
- edit_release_docs_path)
+ edit_release_docs_path]
expect(helper.data_for_new_release_page.keys).to match_array(keys)
end
@@ -101,9 +101,9 @@ RSpec.describe ReleasesHelper do
describe '#data_for_show_page' do
it 'has the needed data to display the individual "release" page' do
- keys = %i(project_id
+ keys = %i[project_id
project_path
- tag_name)
+ tag_name]
expect(helper.data_for_show_page.keys).to match_array(keys)
end
diff --git a/spec/helpers/tracking_helper_spec.rb b/spec/helpers/tracking_helper_spec.rb
index 81121275c92..9d3f2d07cbe 100644
--- a/spec/helpers/tracking_helper_spec.rb
+++ b/spec/helpers/tracking_helper_spec.rb
@@ -6,7 +6,7 @@ RSpec.describe TrackingHelper do
describe '#tracking_attrs' do
using RSpec::Parameterized::TableSyntax
- let(:input) { %w(a b c) }
+ let(:input) { %w[a b c] }
let(:result) { { data: { track_label: 'a', track_action: 'b', track_property: 'c' } } }
before do
diff --git a/spec/initializers/direct_upload_support_spec.rb b/spec/initializers/direct_upload_support_spec.rb
index 68dd12fdb6e..29d19c8397c 100644
--- a/spec/initializers/direct_upload_support_spec.rb
+++ b/spec/initializers/direct_upload_support_spec.rb
@@ -8,7 +8,7 @@ RSpec.describe 'Direct upload support' do
end
where(:config_name) do
- %w(artifacts lfs uploads)
+ %w[artifacts lfs uploads]
end
with_them do
diff --git a/spec/initializers/enumerator_next_patch_spec.rb b/spec/initializers/enumerator_next_patch_spec.rb
index 99e73af5e86..bf8ab823e53 100644
--- a/spec/initializers/enumerator_next_patch_spec.rb
+++ b/spec/initializers/enumerator_next_patch_spec.rb
@@ -33,15 +33,15 @@ RSpec.describe 'Enumerator#next patch fix' do
end
def have_been_raised_by_next_and_not_fixed_up
- contain_unique_method_calls_in_order %w(call_enum_method)
+ contain_unique_method_calls_in_order %w[call_enum_method]
end
def have_been_raised_by_enum_object_and_fixed_up
- contain_unique_method_calls_in_order %w(make_error call_enum_method)
+ contain_unique_method_calls_in_order %w[make_error call_enum_method]
end
def have_been_raised_by_nested_next_and_fixed_up
- contain_unique_method_calls_in_order %w(call_nested_next call_enum_method)
+ contain_unique_method_calls_in_order %w[call_nested_next call_enum_method]
end
methods = [
diff --git a/spec/initializers/rack_multipart_patch_spec.rb b/spec/initializers/rack_multipart_patch_spec.rb
index 862fdc7901b..4b46da73236 100644
--- a/spec/initializers/rack_multipart_patch_spec.rb
+++ b/spec/initializers/rack_multipart_patch_spec.rb
@@ -37,7 +37,7 @@ EOF
expect(described_class).not_to receive(:log_multipart_warning)
params = described_class.parse_multipart(env)
- expect(params.keys).to include(*%w(reply fileupload))
+ expect(params.keys).to include(*%w[reply fileupload])
end
end
@@ -56,7 +56,7 @@ EOF
})
params = described_class.parse_multipart(env)
- expect(params.keys).to include(*%w(reply fileupload))
+ expect(params.keys).to include(*%w[reply fileupload])
end
end
diff --git a/spec/lib/api/ci/helpers/runner_helpers_spec.rb b/spec/lib/api/ci/helpers/runner_helpers_spec.rb
index c36c8d23e88..e05be65bf19 100644
--- a/spec/lib/api/ci/helpers/runner_helpers_spec.rb
+++ b/spec/lib/api/ci/helpers/runner_helpers_spec.rb
@@ -62,7 +62,7 @@ RSpec.describe API::Ci::Helpers::Runner, feature_category: :runner do
it 'extracts the runner details', :aggregate_failures do
expect(details.keys).to match_array(
- %w(system_id name version revision platform architecture executor config ip_address)
+ %w[system_id name version revision platform architecture executor config ip_address]
)
expect(details['system_id']).to eq(system_id)
expect(details['name']).to eq(name)
diff --git a/spec/lib/api/entities/user_spec.rb b/spec/lib/api/entities/user_spec.rb
index 063a11918ba..c5a98e6e42e 100644
--- a/spec/lib/api/entities/user_spec.rb
+++ b/spec/lib/api/entities/user_spec.rb
@@ -29,7 +29,7 @@ RSpec.describe API::Entities::User do
allow(Ability).to receive(:allowed?).with(current_user, :read_user_profile, user).and_return(can_read_user_profile)
end
- %i(followers following is_followed).each do |relationship|
+ %i[followers following is_followed].each do |relationship|
shared_examples 'does not expose relationship' do
it "does not expose #{relationship}" do
expect(subject).not_to include(relationship)
diff --git a/spec/lib/api/helpers/common_helpers_spec.rb b/spec/lib/api/helpers/common_helpers_spec.rb
index 5162d2f1000..04a1837dec9 100644
--- a/spec/lib/api/helpers/common_helpers_spec.rb
+++ b/spec/lib/api/helpers/common_helpers_spec.rb
@@ -44,7 +44,7 @@ RSpec.describe API::Helpers::CommonHelpers do
get '/test?array=&array_of_strings=test,me&array_of_ints=1,2'
expect(json_response['array']).to eq([])
- expect(json_response['array_of_strings']).to eq(%w(test me))
+ expect(json_response['array_of_strings']).to eq(%w[test me])
expect(json_response['array_of_ints']).to eq([1, 2])
end
end
diff --git a/spec/lib/backup/files_spec.rb b/spec/lib/backup/files_spec.rb
index 9cb57baba25..48c89e06dfa 100644
--- a/spec/lib/backup/files_spec.rb
+++ b/spec/lib/backup/files_spec.rb
@@ -68,7 +68,7 @@ RSpec.describe Backup::Files, feature_category: :backup_restore do
it 'calls tar command with unlink' do
expect(subject).to receive(:tar).and_return('blabla-tar')
- expect(subject).to receive(:run_pipeline!).with([%w(gzip -cd), %w(blabla-tar --unlink-first --recursive-unlink -C /var/gitlab-registry -xf -)], any_args)
+ expect(subject).to receive(:run_pipeline!).with([%w[gzip -cd], %w[blabla-tar --unlink-first --recursive-unlink -C /var/gitlab-registry -xf -]], any_args)
expect(subject).to receive(:pipeline_succeeded?).and_return(true)
subject.restore('registry.tar.gz', 'backup_id')
end
@@ -124,7 +124,7 @@ RSpec.describe Backup::Files, feature_category: :backup_restore do
it 'excludes tmp dirs from archive' do
expect(subject).to receive(:tar).and_return('blabla-tar')
- expect(subject).to receive(:run_pipeline!).with([%w(blabla-tar --exclude=lost+found --exclude=./@pages.tmp -C /var/gitlab-pages -cf - .), 'gzip -c -1'], any_args)
+ expect(subject).to receive(:run_pipeline!).with([%w[blabla-tar --exclude=lost+found --exclude=./@pages.tmp -C /var/gitlab-pages -cf - .], 'gzip -c -1'], any_args)
subject.dump('registry.tar.gz', 'backup_id')
end
@@ -146,7 +146,7 @@ RSpec.describe Backup::Files, feature_category: :backup_restore do
it 'excludes tmp dirs from rsync' do
expect(Gitlab::Popen).to receive(:popen)
- .with(%w(rsync -a --delete --exclude=lost+found --exclude=/gitlab-pages/@pages.tmp /var/gitlab-pages /var/gitlab-backup))
+ .with(%w[rsync -a --delete --exclude=lost+found --exclude=/gitlab-pages/@pages.tmp /var/gitlab-pages /var/gitlab-backup])
.and_return(['', 0])
subject.dump('registry.tar.gz', 'backup_id')
@@ -154,7 +154,7 @@ RSpec.describe Backup::Files, feature_category: :backup_restore do
it 'retries if rsync fails due to vanishing files' do
expect(Gitlab::Popen).to receive(:popen)
- .with(%w(rsync -a --delete --exclude=lost+found --exclude=/gitlab-pages/@pages.tmp /var/gitlab-pages /var/gitlab-backup))
+ .with(%w[rsync -a --delete --exclude=lost+found --exclude=/gitlab-pages/@pages.tmp /var/gitlab-pages /var/gitlab-backup])
.and_return(['rsync failed', 24], ['', 0])
expect do
@@ -164,7 +164,7 @@ RSpec.describe Backup::Files, feature_category: :backup_restore do
it 'raises an error and outputs an error message if rsync failed' do
allow(Gitlab::Popen).to receive(:popen)
- .with(%w(rsync -a --delete --exclude=lost+found --exclude=/gitlab-pages/@pages.tmp /var/gitlab-pages /var/gitlab-backup))
+ .with(%w[rsync -a --delete --exclude=lost+found --exclude=/gitlab-pages/@pages.tmp /var/gitlab-pages /var/gitlab-backup])
.and_return(['rsync failed', 1])
expect do
diff --git a/spec/lib/backup/manager_spec.rb b/spec/lib/backup/manager_spec.rb
index 6061441d5f5..8f85cd9d8b3 100644
--- a/spec/lib/backup/manager_spec.rb
+++ b/spec/lib/backup/manager_spec.rb
@@ -156,7 +156,7 @@ RSpec.describe Backup::Manager, feature_category: :backup_restore do
describe '#create' do
let(:incremental_env) { 'false' }
- let(:expected_backup_contents) { %w{backup_information.yml task1.tar.gz task2.tar.gz} }
+ let(:expected_backup_contents) { %w[backup_information.yml task1.tar.gz task2.tar.gz] }
let(:backup_time) { Time.zone.parse('2019-1-1') }
let(:backup_id) { "1546300800_2019_01_01_#{Gitlab::VERSION}" }
let(:full_backup_id) { backup_id }
@@ -223,7 +223,7 @@ RSpec.describe Backup::Manager, feature_category: :backup_restore do
end
context 'when SKIP env is set' do
- let(:expected_backup_contents) { %w{backup_information.yml task1.tar.gz} }
+ let(:expected_backup_contents) { %w[backup_information.yml task1.tar.gz] }
before do
stub_env('SKIP', 'task2')
@@ -237,7 +237,7 @@ RSpec.describe Backup::Manager, feature_category: :backup_restore do
end
context 'when the destination is optional' do
- let(:expected_backup_contents) { %w{backup_information.yml task1.tar.gz} }
+ let(:expected_backup_contents) { %w[backup_information.yml task1.tar.gz] }
let(:definitions) do
{
'task1' => Backup::Manager::TaskDefinition.new(task: task1, destination_path: 'task1.tar.gz'),
@@ -1015,7 +1015,7 @@ RSpec.describe Backup::Manager, feature_category: :backup_restore do
end
context 'when BACKUP variable is set to a correct file' do
- let(:tar_cmdline) { %w{tar -xf 1451606400_2016_01_01_1.2.3_gitlab_backup.tar} }
+ let(:tar_cmdline) { %w[tar -xf 1451606400_2016_01_01_1.2.3_gitlab_backup.tar] }
let(:backup_id) { "1451606400_2016_01_01_1.2.3" }
before do
diff --git a/spec/lib/backup/repositories_spec.rb b/spec/lib/backup/repositories_spec.rb
index b549f2d355d..ad5fb8ea84e 100644
--- a/spec/lib/backup/repositories_spec.rb
+++ b/spec/lib/backup/repositories_spec.rb
@@ -85,7 +85,7 @@ RSpec.describe Backup::Repositories, feature_category: :backup_restore do
end
describe 'storages' do
- let(:storages) { %w{default} }
+ let(:storages) { %w[default] }
let_it_be(:project) { create(:project_with_design, :repository) }
@@ -280,7 +280,7 @@ RSpec.describe Backup::Repositories, feature_category: :backup_restore do
end
context 'storages' do
- let(:storages) { %w{default} }
+ let(:storages) { %w[default] }
before do
stub_storage_settings('test_second_storage' => {
diff --git a/spec/lib/banzai/filter/asset_proxy_filter_spec.rb b/spec/lib/banzai/filter/asset_proxy_filter_spec.rb
index 7a34bf13c8f..baa22e08971 100644
--- a/spec/lib/banzai/filter/asset_proxy_filter_spec.rb
+++ b/spec/lib/banzai/filter/asset_proxy_filter_spec.rb
@@ -28,14 +28,14 @@ RSpec.describe Banzai::Filter::AssetProxyFilter, feature_category: :team_plannin
stub_application_setting(asset_proxy_enabled: true)
stub_application_setting(asset_proxy_secret_key: 'shared-secret')
stub_application_setting(asset_proxy_url: 'https://assets.example.com')
- stub_application_setting(asset_proxy_allowlist: %w(gitlab.com *.mydomain.com))
+ stub_application_setting(asset_proxy_allowlist: %w[gitlab.com *.mydomain.com])
described_class.initialize_settings
expect(Gitlab.config.asset_proxy.enabled).to be_truthy
expect(Gitlab.config.asset_proxy.secret_key).to eq 'shared-secret'
expect(Gitlab.config.asset_proxy.url).to eq 'https://assets.example.com'
- expect(Gitlab.config.asset_proxy.allowlist).to eq %w(gitlab.com *.mydomain.com)
+ expect(Gitlab.config.asset_proxy.allowlist).to eq %w[gitlab.com *.mydomain.com]
expect(Gitlab.config.asset_proxy.domain_regexp).to eq(/^(gitlab\.com|.*?\.mydomain\.com)$/i)
end
@@ -52,12 +52,12 @@ RSpec.describe Banzai::Filter::AssetProxyFilter, feature_category: :team_plannin
it 'supports deprecated whitelist settings' do
stub_application_setting(asset_proxy_enabled: true)
- stub_application_setting(asset_proxy_whitelist: %w(foo.com bar.com))
+ stub_application_setting(asset_proxy_whitelist: %w[foo.com bar.com])
stub_application_setting(asset_proxy_allowlist: [])
described_class.initialize_settings
- expect(Gitlab.config.asset_proxy.allowlist).to eq %w(foo.com bar.com)
+ expect(Gitlab.config.asset_proxy.allowlist).to eq %w[foo.com bar.com]
end
end
@@ -66,7 +66,7 @@ RSpec.describe Banzai::Filter::AssetProxyFilter, feature_category: :team_plannin
stub_asset_proxy_setting(enabled: true)
stub_asset_proxy_setting(secret_key: 'shared-secret')
stub_asset_proxy_setting(url: 'https://assets.example.com')
- stub_asset_proxy_setting(allowlist: %W(gitlab.com *.mydomain.com #{Gitlab.config.gitlab.host}))
+ stub_asset_proxy_setting(allowlist: %W[gitlab.com *.mydomain.com #{Gitlab.config.gitlab.host}])
stub_asset_proxy_setting(domain_regexp: described_class.compile_allowlist(Gitlab.config.asset_proxy.allowlist))
@context = described_class.transform_context({})
end
diff --git a/spec/lib/banzai/filter/autolink_filter_spec.rb b/spec/lib/banzai/filter/autolink_filter_spec.rb
index fe642855f3b..89a9099a1f4 100644
--- a/spec/lib/banzai/filter/autolink_filter_spec.rb
+++ b/spec/lib/banzai/filter/autolink_filter_spec.rb
@@ -178,7 +178,7 @@ RSpec.describe Banzai::Filter::AutolinkFilter, feature_category: :team_planning
it 'does not double-encode HTML entities' do
encoded_link = "#{link}?foo=bar&baz=quux"
- expected_encoded_link = %{#{encoded_link}}
+ expected_encoded_link = %(#{encoded_link})
actual = unescape(filter(encoded_link).to_html)
expect(actual).to eq(Rinku.auto_link(encoded_link))
diff --git a/spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb b/spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb
index 3b054862a26..69afddf2406 100644
--- a/spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb
+++ b/spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb
@@ -14,13 +14,13 @@ RSpec.describe Banzai::Filter::BroadcastMessageSanitizationFilter, feature_categ
subject { filter(exp).to_html }
context 'allows `a` elements' do
- let(:exp) { %q{Link} }
+ let(:exp) { %q(Link) }
it { is_expected.to eq(exp) }
end
context 'allows `br` elements' do
- let(:exp) { %q{Hello#{reference}
.") - expect(doc.to_html).to match(%r(This is a test})
+ result = filter(%(This is a test))
copy_code_btn = 'This is a test#{copy_code_btn}This is a test#{copy_code_btn}