From af97e4dd4beb0ba1aa0cb3c31df413333cbce77d Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 8 Oct 2021 12:11:10 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/static-analysis.gitlab-ci.yml | 14 +- Gemfile | 2 +- Gemfile.lock | 4 +- .../javascripts/cycle_analytics/constants.js | 2 +- .../components/details_page/tags_list_row.vue | 46 +- .../registry/explorer/constants/common.js | 3 +- .../registry/explorer/constants/details.js | 6 +- app/assets/javascripts/right_sidebar.js | 2 +- .../admin_runners/admin_runners_app.vue | 17 +- .../runner/components/runner_type_help.vue | 74 -- .../group_runners/group_runners_app.vue | 14 +- .../sidebar/components/todo_toggle/todo.vue | 2 +- .../components/extensions/base.vue | 9 +- .../extensions/issues.js | 1 + .../components/sidebar/copyable_field.vue | 2 +- app/models/ci/pipeline.rb | 11 - app/services/ci/pipelines/hook_service.rb | 34 + ...rop_service.rb => drop_pending_service.rb} | 4 +- .../terraform/remote_state_handler.rb | 4 +- app/views/shared/issuable/_sidebar.html.haml | 2 +- .../shared/milestones/_sidebar.html.haml | 2 +- app/workers/pipeline_hooks_worker.rb | 7 +- app/workers/stuck_ci_jobs_worker.rb | 2 +- bin/rails | 5 + bin/rake | 5 + ...ble_joins_upstream_downstream_projects.yml | 8 - .../counts_all/20210216182112_sast_jobs.yml | 22 - .../20210216182114_secret_detection_jobs.yml | 22 - doc/development/contributing/design.md | 35 +- doc/development/snowplow/implementation.md | 519 ++++++++++++++ doc/development/snowplow/index.md | 666 +----------------- doc/development/snowplow/review_guidelines.md | 10 +- doc/development/snowplow/schemas.md | 161 +++++ doc/user/analytics/index.md | 2 +- lib/gitlab/popen/runner.rb | 17 +- lib/tasks/lint.rake | 7 - locale/gitlab.pot | 23 +- qa/qa/page/project/registry/show.rb | 5 + spec/controllers/every_controller_spec.rb | 2 +- .../groups/container_registry_spec.rb | 1 + .../projects/container_registry_spec.rb | 1 + .../commit_pipeline_status_component_spec.js | 4 +- .../commit/pipelines/pipelines_table_spec.js | 4 +- spec/frontend/monitoring/fixture_data.js | 6 +- spec/frontend/notebook/cells/code_spec.js | 5 +- spec/frontend/notebook/cells/markdown_spec.js | 9 +- .../notebook/cells/output/index_spec.js | 7 +- spec/frontend/notebook/index_spec.js | 9 +- .../notes/components/diff_with_note_spec.js | 9 +- .../components/noteable_discussion_spec.js | 7 +- spec/frontend/notes/stores/getters_spec.js | 5 +- .../pipeline_mini_graph_spec.js | 2 +- spec/frontend/pipelines/pipelines_spec.js | 2 +- .../pipelines/pipelines_table_spec.js | 6 +- .../test_reports/stores/actions_spec.js | 3 +- .../test_reports/stores/getters_spec.js | 4 +- .../test_reports/stores/mutations_spec.js | 4 +- .../test_reports/test_reports_spec.js | 4 +- .../test_reports/test_suite_table_spec.js | 4 +- .../test_reports/test_summary_spec.js | 4 +- .../test_reports/test_summary_table_spec.js | 4 +- .../details_page/tags_list_row_spec.js | 70 +- .../admin_runners/admin_runners_app_spec.js | 6 - .../components/runner_type_help_spec.js | 32 - .../group_runners/group_runners_app_spec.js | 6 - spec/frontend/sidebar/todo_spec.js | 2 +- spec/lib/api/every_api_endpoint_spec.rb | 2 +- .../etag_caching/router/graphql_spec.rb | 2 +- .../etag_caching/router/restful_spec.rb | 2 +- .../metrics/requests_rack_middleware_spec.rb | 2 +- spec/models/ci/pipeline_spec.rb | 127 +--- .../ci/pipelines/hook_service_spec.rb | 47 ++ ...e_spec.rb => drop_pending_service_spec.rb} | 2 +- spec/workers/every_sidekiq_worker_spec.rb | 3 +- spec/workers/pipeline_hooks_worker_spec.rb | 8 +- spec/workers/stuck_ci_jobs_worker_spec.rb | 4 +- 76 files changed, 1031 insertions(+), 1161 deletions(-) delete mode 100644 app/assets/javascripts/runner/components/runner_type_help.vue create mode 100644 app/services/ci/pipelines/hook_service.rb rename app/services/ci/stuck_builds/{drop_service.rb => drop_pending_service.rb} (91%) delete mode 100644 config/feature_flags/development/disable_joins_upstream_downstream_projects.yml delete mode 100644 config/metrics/counts_all/20210216182112_sast_jobs.yml delete mode 100644 config/metrics/counts_all/20210216182114_secret_detection_jobs.yml create mode 100644 doc/development/snowplow/implementation.md create mode 100644 doc/development/snowplow/schemas.md delete mode 100644 spec/frontend/runner/components/runner_type_help_spec.js create mode 100644 spec/services/ci/pipelines/hook_service_spec.rb rename spec/services/ci/stuck_builds/{drop_service_spec.rb => drop_pending_service_spec.rb} (99%) diff --git a/.gitlab/ci/static-analysis.gitlab-ci.yml b/.gitlab/ci/static-analysis.gitlab-ci.yml index 85df68e9030..79f578d09dc 100644 --- a/.gitlab/ci/static-analysis.gitlab-ci.yml +++ b/.gitlab/ci/static-analysis.gitlab-ci.yml @@ -24,8 +24,11 @@ static-analysis: extends: - .static-analysis-base - .static-analysis:rules:ee-and-foss + - .use-pg12 stage: test parallel: 4 + variables: + SETUP_DB: "true" script: - run_timed_command "retry yarn install --frozen-lockfile" - scripts/static-analysis @@ -35,17 +38,6 @@ static-analysis: paths: - tmp/feature_flags/ -static-analysis-with-database: - extends: - - .static-analysis-base - - .static-analysis:rules:ee-and-foss - - .use-pg12 - stage: test - script: - - bundle exec rake lint:static_verification_with_database - variables: - SETUP_DB: "true" - static-analysis as-if-foss: extends: - static-analysis diff --git a/Gemfile b/Gemfile index 45dc4dfebed..8d20e98a5c8 100644 --- a/Gemfile +++ b/Gemfile @@ -424,7 +424,7 @@ group :test do gem 'webmock', '~> 3.9.1' gem 'rails-controller-testing' gem 'concurrent-ruby', '~> 1.1' - gem 'test-prof', '~> 0.12.0' + gem 'test-prof', '~> 1.0.7' gem 'rspec_junit_formatter' gem 'guard-rspec' diff --git a/Gemfile.lock b/Gemfile.lock index fc13e8d6ecc..dbed17712f7 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1251,7 +1251,7 @@ GEM unicode-display_width (~> 1.1, >= 1.1.1) terser (1.0.2) execjs (>= 0.3.0, < 3) - test-prof (0.12.0) + test-prof (1.0.7) test_file_finder (0.1.4) faraday (~> 1.0) text (1.3.1) @@ -1628,7 +1628,7 @@ DEPENDENCIES state_machines-activerecord (~> 0.8.0) sys-filesystem (~> 1.1.6) terser (= 1.0.2) - test-prof (~> 0.12.0) + test-prof (~> 1.0.7) test_file_finder (~> 0.1.3) thin (~> 1.8.0) thrift (>= 0.14.0) diff --git a/app/assets/javascripts/cycle_analytics/constants.js b/app/assets/javascripts/cycle_analytics/constants.js index c1be2ce7096..c205aa1e831 100644 --- a/app/assets/javascripts/cycle_analytics/constants.js +++ b/app/assets/javascripts/cycle_analytics/constants.js @@ -44,7 +44,7 @@ export const METRICS_POPOVER_CONTENT = { }, 'cycle-time': { description: s__( - 'ValueStreamAnalytics|Median time from issue first merge request created to issue closed.', + "ValueStreamAnalytics|Median time from the earliest commit of a linked issue's merge request to when that issue is closed.", ), }, 'new-issue': { description: s__('ValueStreamAnalytics|Number of new issues created.') }, diff --git a/app/assets/javascripts/registry/explorer/components/details_page/tags_list_row.vue b/app/assets/javascripts/registry/explorer/components/details_page/tags_list_row.vue index 45eb2ce51e4..81546151acf 100644 --- a/app/assets/javascripts/registry/explorer/components/details_page/tags_list_row.vue +++ b/app/assets/javascripts/registry/explorer/components/details_page/tags_list_row.vue @@ -1,5 +1,12 @@