diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index 9b2c8340af8..cc138678fc9 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -1469,11 +1469,11 @@ lib/gitlab/checks/** # opportunity to refine specific rules defined in this section. # Note that frontend, CI templates and other concerns should be kept within # the same section. -/app/**/ci/*.rb -/ee/app/**/ci/*.rb +/app/**/ci/**/*.rb +/ee/app/**/ci/**/*.rb /lib/**/ci/ /ee/lib/**/ci/ -/ee/app/**/merge_trains/*.rb +/ee/app/**/merge_trains/**/*.rb /app/controllers/admin/jobs_controller.rb /app/controllers/admin/runner_projects_controller.rb /app/controllers/admin/runners_controller.rb diff --git a/.rubocop_todo/database/avoid_using_pluck_without_limit.yml b/.rubocop_todo/database/avoid_using_pluck_without_limit.yml index 2e2586b5d0a..871037f7efd 100644 --- a/.rubocop_todo/database/avoid_using_pluck_without_limit.yml +++ b/.rubocop_todo/database/avoid_using_pluck_without_limit.yml @@ -146,7 +146,6 @@ Database/AvoidUsingPluckWithoutLimit: - 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb' - 'ee/app/services/security/security_orchestration_policies/protected_branches_deletion_check_service.rb' - 'ee/app/services/security/security_orchestration_policies/protected_branches_push_service.rb' - - 'ee/app/services/security/security_orchestration_policies/rule_schedule_service.rb' - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' - 'ee/app/services/vulnerabilities/bulk_dismiss_service.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' diff --git a/.rubocop_todo/gitlab/feature_flag_without_actor.yml b/.rubocop_todo/gitlab/feature_flag_without_actor.yml index 4b7b05718ed..d7da9540a11 100644 --- a/.rubocop_todo/gitlab/feature_flag_without_actor.yml +++ b/.rubocop_todo/gitlab/feature_flag_without_actor.yml @@ -95,7 +95,6 @@ Gitlab/FeatureFlagWithoutActor: - 'ee/app/graphql/resolvers/ai/user_chat_access_resolver.rb' - 'ee/app/graphql/types/epic_type.rb' - 'ee/app/helpers/billing_plans_helper.rb' - - 'ee/app/helpers/gitlab_subscriptions/code_suggestions_helper.rb' - 'ee/app/models/concerns/geo/replicable_model.rb' - 'ee/app/models/ee/application_setting.rb' - 'ee/app/models/integrations/git_guardian.rb' @@ -122,7 +121,6 @@ Gitlab/FeatureFlagWithoutActor: - 'ee/app/workers/search/zoekt/scheduling_worker.rb' - 'ee/app/workers/zoekt/indexer_worker.rb' - 'ee/lib/api/code_suggestions.rb' - - 'ee/lib/api/epics.rb' - 'ee/lib/api/internal/search/zoekt.rb' - 'ee/lib/api/internal/suggested_reviewers.rb' - 'ee/lib/ee/api/entities/application_setting.rb' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index d5477a47faf..608b8407084 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -25,7 +25,6 @@ Gitlab/StrongMemoizeAttr: - 'app/finders/ci/pipelines_for_merge_request_finder.rb' - 'app/finders/cluster_ancestors_finder.rb' - 'app/finders/concerns/finder_with_group_hierarchy.rb' - - 'app/finders/crm/organizations_finder.rb' - 'app/finders/groups/accepting_group_transfers_finder.rb' - 'app/finders/issuable_finder.rb' - 'app/finders/issuable_finder/params.rb' diff --git a/.rubocop_todo/layout/array_alignment.yml b/.rubocop_todo/layout/array_alignment.yml index 5fa3151f5d4..7296b30d34a 100644 --- a/.rubocop_todo/layout/array_alignment.yml +++ b/.rubocop_todo/layout/array_alignment.yml @@ -123,7 +123,6 @@ Layout/ArrayAlignment: - 'spec/graphql/resolvers/project_issues_resolver_spec.rb' - 'spec/graphql/types/blob_viewer_type_spec.rb' - 'spec/graphql/types/boards/board_issue_input_type_spec.rb' - - 'spec/graphql/types/container_repository_type_spec.rb' - 'spec/graphql/types/issuable_sort_enum_spec.rb' - 'spec/graphql/types/issue_type_spec.rb' - 'spec/graphql/types/project_type_spec.rb' diff --git a/.rubocop_todo/layout/class_structure.yml b/.rubocop_todo/layout/class_structure.yml index d70cef4d165..5966d54aaee 100644 --- a/.rubocop_todo/layout/class_structure.yml +++ b/.rubocop_todo/layout/class_structure.yml @@ -418,7 +418,6 @@ Layout/ClassStructure: - 'lib/gitlab/query_limiting/transaction.rb' - 'lib/gitlab/repository_cache.rb' - 'lib/gitlab/sidekiq_daemon/monitor.rb' - - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - 'lib/gitlab/slash_commands/base_command.rb' - 'lib/gitlab/sql/set_operator.rb' - 'lib/gitlab/suggestions/commit_message.rb' diff --git a/.rubocop_todo/layout/line_break_after_final_mixin.yml b/.rubocop_todo/layout/line_break_after_final_mixin.yml index e6b1ba128fb..32a79266c93 100644 --- a/.rubocop_todo/layout/line_break_after_final_mixin.yml +++ b/.rubocop_todo/layout/line_break_after_final_mixin.yml @@ -6,7 +6,6 @@ Layout/LineBreakAfterFinalMixin: - 'app/graphql/resolvers/projects/deploy_key_resolver.rb' - 'app/models/alert_management/metric_image.rb' - 'app/models/integrations/pushover.rb' - - 'app/models/integrations/telegram.rb' - 'app/models/protected_branch/merge_access_level.rb' - 'app/models/protected_branch/push_access_level.rb' - 'app/policies/project_member_policy.rb' diff --git a/.rubocop_todo/layout/line_continuation_spacing.yml b/.rubocop_todo/layout/line_continuation_spacing.yml index 45a70b5e182..38d86505bfa 100644 --- a/.rubocop_todo/layout/line_continuation_spacing.yml +++ b/.rubocop_todo/layout/line_continuation_spacing.yml @@ -26,7 +26,6 @@ Layout/LineContinuationSpacing: - 'ee/app/models/ee/epic.rb' - 'ee/app/models/ee/group_group_link.rb' - 'ee/app/models/ee/project_group_link.rb' - - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/incident_management/oncall_shift.rb' - 'ee/app/services/audit_events/protected_branch_audit_event_service.rb' - 'ee/app/services/boards/epic_lists/destroy_service.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index 2174f6c93e3..316ead18b49 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -119,7 +119,6 @@ Layout/LineEndStringConcatenationIndentation: - 'ee/app/graphql/types/dast/site_profile_auth_type.rb' - 'ee/app/graphql/types/dast_scanner_profile_type.rb' - 'ee/app/graphql/types/dast_site_profile_type.rb' - - 'ee/app/graphql/types/epic_type.rb' - 'ee/app/graphql/types/geo/geo_node_type.rb' - 'ee/app/graphql/types/google_cloud/artifact_registry/repository_type.rb' - 'ee/app/graphql/types/protected_environment_type.rb' @@ -141,7 +140,6 @@ Layout/LineEndStringConcatenationIndentation: - 'ee/app/models/concerns/audit_events/gcp_externally_destinationable.rb' - 'ee/app/models/ee/member.rb' - 'ee/app/models/ee/merge_request.rb' - - 'ee/app/models/ee/vulnerability.rb' - 'ee/app/models/incident_management/oncall_shift.rb' - 'ee/app/models/integrations/google_cloud_platform/artifact_registry.rb' - 'ee/app/models/members/member_role.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 45fdf5f047e..c0e41337428 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -176,7 +176,6 @@ Layout/LineLength: - 'app/models/merge_requests_closing_issues.rb' - 'app/models/milestone.rb' - 'app/models/namespace.rb' - - 'app/models/namespace/package_setting.rb' - 'app/models/namespace_setting.rb' - 'app/models/namespaces/traversal/linear.rb' - 'app/models/notification_setting.rb' @@ -501,7 +500,6 @@ Layout/LineLength: - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/create.rb' - 'ee/app/graphql/mutations/boards/scoped_issue_board_arguments.rb' - 'ee/app/graphql/mutations/compliance_management/frameworks/destroy.rb' - - 'ee/app/graphql/mutations/concerns/mutations/shared_epic_arguments.rb' - 'ee/app/graphql/mutations/dast/profiles/update.rb' - 'ee/app/graphql/mutations/dast_scanner_profiles/create.rb' - 'ee/app/graphql/mutations/dast_scanner_profiles/update.rb' @@ -748,7 +746,6 @@ Layout/LineLength: - 'ee/app/services/ee/resource_access_tokens/create_service.rb' - 'ee/app/services/ee/system_note_service.rb' - 'ee/app/services/ee/users/update_service.rb' - - 'ee/app/services/elastic/indexing_control_service.rb' - 'ee/app/services/epics/issue_promote_service.rb' - 'ee/app/services/epics/update_service.rb' - 'ee/app/services/external_status_checks/create_service.rb' @@ -2412,7 +2409,6 @@ Layout/LineLength: - 'qa/qa/resource/file.rb' - 'qa/qa/resource/protected_branch.rb' - 'qa/qa/resource/registry_repository.rb' - - 'qa/qa/resource/repository/push.rb' - 'qa/qa/resource/snippet.rb' - 'qa/qa/resource/user_runners.rb' - 'qa/qa/resource/wiki/group_page.rb' @@ -2436,7 +2432,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/custom_issue_template_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/export_as_csv_spec.rb' - - 'qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/real_time_assignee_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/related_issues/related_issues_spec.rb' @@ -3550,7 +3545,6 @@ Layout/LineLength: - 'spec/models/import_export_upload_spec.rb' - 'spec/models/import_failure_spec.rb' - 'spec/models/instance_configuration_spec.rb' - - 'spec/models/integrations/base_chat_notification_spec.rb' - 'spec/models/integrations/base_issue_tracker_spec.rb' - 'spec/models/integrations/chat_message/base_message_spec.rb' - 'spec/models/integrations/chat_message/deployment_message_spec.rb' diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index 1fb50dbba97..bbee0e01aca 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -1,5 +1,10 @@ --- # Cop supports --autocorrect. Lint/RedundantCopDisableDirective: - # Temporarily disabled + # Offense count: 3 + # Temporarily disabled due to too many offenses Enabled: false + Exclude: + - 'ee/app/controllers/admin/gitlab_duo/configuration_controller.rb' + - 'ee/app/presenters/ee/onboarding/status_presenter.rb' + - 'ee/spec/helpers/admin/application_settings_helper_spec.rb' diff --git a/.rubocop_todo/performance/string_identifier_argument.yml b/.rubocop_todo/performance/string_identifier_argument.yml index 55873c24cfb..c913b506b2c 100644 --- a/.rubocop_todo/performance/string_identifier_argument.yml +++ b/.rubocop_todo/performance/string_identifier_argument.yml @@ -121,10 +121,8 @@ Performance/StringIdentifierArgument: - 'lib/sidebars/context.rb' - 'qa/qa/page/component/ci_icon.rb' - 'qa/qa/page/component/note.rb' - - 'qa/qa/resource/base.rb' - 'qa/qa/resource/integrations/web_hook/smockerable.rb' - 'qa/qa/runtime/address.rb' - - 'qa/qa/specs/features/browser_ui/10_govern/login/login_via_oauth_and_oidc_with_gitlab_as_idp_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/9_data_stores/group/prevent_forking_outside_group_spec.rb' - 'qa/qa/support/matchers/have_matcher.rb' - 'scripts/perf/gc/print_gc_stats.rb' diff --git a/.rubocop_todo/rake/require.yml b/.rubocop_todo/rake/require.yml index 192184e38cb..6988292d875 100644 --- a/.rubocop_todo/rake/require.yml +++ b/.rubocop_todo/rake/require.yml @@ -7,7 +7,6 @@ Rake/Require: - 'lib/tasks/contracts/pipelines.rake' - 'lib/tasks/gitlab/artifacts/migrate.rake' - 'lib/tasks/gitlab/backup.rake' - - 'lib/tasks/gitlab/cleanup.rake' - 'lib/tasks/gitlab/docs/redirect.rake' - 'lib/tasks/gitlab/graphql.rake' - 'lib/tasks/gitlab/lfs/migrate.rake' diff --git a/.rubocop_todo/rspec/any_instance_of.yml b/.rubocop_todo/rspec/any_instance_of.yml index 3f848069b3a..04eede40f1e 100644 --- a/.rubocop_todo/rspec/any_instance_of.yml +++ b/.rubocop_todo/rspec/any_instance_of.yml @@ -22,7 +22,6 @@ RSpec/AnyInstanceOf: - 'ee/spec/lib/gitlab/geo/log_cursor/daemon_spec.rb' - 'ee/spec/lib/gitlab/legacy_github_import/project_creator_spec.rb' - 'ee/spec/models/geo_node_status_spec.rb' - - 'ee/spec/models/issue_spec.rb' - 'ee/spec/models/merge_request_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' - 'ee/spec/models/push_rule_spec.rb' diff --git a/.rubocop_todo/rspec/avoid_conditional_statements.yml b/.rubocop_todo/rspec/avoid_conditional_statements.yml index 32ce10a6339..f784dc21dab 100644 --- a/.rubocop_todo/rspec/avoid_conditional_statements.yml +++ b/.rubocop_todo/rspec/avoid_conditional_statements.yml @@ -10,7 +10,6 @@ RSpec/AvoidConditionalStatements: - 'ee/spec/features/epic_boards/epic_boards_spec.rb' - 'ee/spec/features/epics/gfm_autocomplete_spec.rb' - 'ee/spec/features/group_protected_branches_spec.rb' - - 'ee/spec/features/groups/analytics/cycle_analytics/multiple_value_streams_spec.rb' - 'ee/spec/features/groups/iterations/user_views_iteration_spec.rb' - 'ee/spec/features/incidents/incident_details_spec.rb' - 'ee/spec/features/issues/user_sees_empty_state_spec.rb' @@ -70,4 +69,3 @@ RSpec/AvoidConditionalStatements: - 'spec/features/search/user_uses_header_search_field_spec.rb' - 'spec/features/usage_stats_consent_spec.rb' - 'spec/features/users/login_spec.rb' - - 'spec/features/users/overview_spec.rb' diff --git a/.rubocop_todo/rspec/be_eq.yml b/.rubocop_todo/rspec/be_eq.yml index ec399141fb5..e43e107a502 100644 --- a/.rubocop_todo/rspec/be_eq.yml +++ b/.rubocop_todo/rspec/be_eq.yml @@ -345,8 +345,6 @@ RSpec/BeEq: - 'ee/spec/requests/api/graphql/merge_trains/trains_spec.rb' - 'ee/spec/requests/api/graphql/mutations/analytics/devops_adoption/enabled_namespaces/disable_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/instance/amazon_s3_configurations/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/ci/namespace_ci_cd_settings_update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/compliance_management/standards/refresh_adherence_checks_spec.rb' - 'ee/spec/requests/api/graphql/mutations/dast_scanner_profiles/create_spec.rb' diff --git a/.rubocop_todo/rspec/change_by_zero.yml b/.rubocop_todo/rspec/change_by_zero.yml index 0929c483dbf..74acf4d504e 100644 --- a/.rubocop_todo/rspec/change_by_zero.yml +++ b/.rubocop_todo/rspec/change_by_zero.yml @@ -37,7 +37,6 @@ RSpec/ChangeByZero: - 'ee/spec/services/search/zoekt/indexing_task_service_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_cvs_security_scanners_spec.rb' - 'ee/spec/services/security/orchestration/create_bot_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/rule_schedule_service_spec.rb' - 'ee/spec/services/software_license_policies/bulk_create_scan_result_policy_service_spec.rb' - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' - 'ee/spec/services/vulnerabilities/security_finding/create_merge_request_service_spec.rb' diff --git a/.rubocop_todo/rspec/contain_exactly.yml b/.rubocop_todo/rspec/contain_exactly.yml index df37f8b848f..211870cfbdb 100644 --- a/.rubocop_todo/rspec/contain_exactly.yml +++ b/.rubocop_todo/rspec/contain_exactly.yml @@ -84,7 +84,6 @@ RSpec/ContainExactly: - 'spec/finders/ci/job_artifacts_finder_spec.rb' - 'spec/finders/ci/pipelines_finder_spec.rb' - 'spec/finders/merge_requests_finder_spec.rb' - - 'spec/finders/organizations/user_organizations_finder_spec.rb' - 'spec/finders/personal_access_tokens_finder_spec.rb' - 'spec/finders/projects_finder_spec.rb' - 'spec/finders/repositories/branch_names_finder_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 56d2e2f16e5..3b5c598ba31 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -1989,7 +1989,6 @@ RSpec/ContextWording: - 'spec/models/identity_spec.rb' - 'spec/models/import_export_upload_spec.rb' - 'spec/models/import_failure_spec.rb' - - 'spec/models/integrations/base_chat_notification_spec.rb' - 'spec/models/integrations/chat_message/issue_message_spec.rb' - 'spec/models/integrations/chat_message/merge_message_spec.rb' - 'spec/models/integrations/chat_message/note_message_spec.rb' diff --git a/.rubocop_todo/rspec/excessive_docstring_spacing.yml b/.rubocop_todo/rspec/excessive_docstring_spacing.yml index 3eff1f86de8..e3262c4235f 100644 --- a/.rubocop_todo/rspec/excessive_docstring_spacing.yml +++ b/.rubocop_todo/rspec/excessive_docstring_spacing.yml @@ -35,7 +35,6 @@ RSpec/ExcessiveDocstringSpacing: - 'ee/spec/services/users/service_accounts/create_service_spec.rb' - 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/protected_ref_access_shared_examples.rb' - - 'ee/spec/views/gitlab_subscriptions/trials/duo_enterprise/_lead_form.html.haml_spec.rb.haml_spec.rb' - 'ee/spec/views/shared/promotions/_promotion_link_project.html.haml_spec.rb' - 'ee/spec/workers/analytics/code_review_metrics_worker_spec.rb' - 'ee/spec/workers/security/scan_execution_policies/create_pipeline_worker_spec.rb' @@ -87,7 +86,6 @@ RSpec/ExcessiveDocstringSpacing: - 'spec/services/git/wiki_push_service_spec.rb' - 'spec/services/groups/nested_create_service_spec.rb' - 'spec/services/issues/update_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_ci_status_service_spec.rb' - 'spec/services/ml/experiment_tracking/candidate_repository_spec.rb' - 'spec/services/quick_actions/interpret_service_spec.rb' - 'spec/support/shared_examples/requests/projects/google_cloud/google_oauth2_config_examples.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 80f81cc953f..9133fd16272 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -132,7 +132,6 @@ RSpec/ExpectChange: - 'ee/spec/services/security/orchestration/unassign_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/process_rule_service_spec.rb' - - 'ee/spec/services/security/security_orchestration_policies/rule_schedule_service_spec.rb' - 'ee/spec/services/security/store_findings_service_spec.rb' - 'ee/spec/services/users/email_verification/send_custom_confirmation_instructions_service_spec.rb' - 'ee/spec/services/vulnerabilities/find_or_create_from_security_finding_service_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index be1bd6c2b10..abae7f6fcd1 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -341,7 +341,6 @@ RSpec/ExpectInHook: - 'spec/services/members/destroy_service_spec.rb' - 'spec/services/merge_requests/cleanup_refs_service_spec.rb' - 'spec/services/merge_requests/merge_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_ci_status_service_spec.rb' - 'spec/services/merge_requests/mergeability/check_draft_status_service_spec.rb' - 'spec/services/merge_requests/mergeability/check_open_status_service_spec.rb' - 'spec/services/merge_requests/mergeability/run_checks_service_spec.rb' diff --git a/.rubocop_todo/rspec/feature_category.yml b/.rubocop_todo/rspec/feature_category.yml index 0ec7d883fe7..3ecf12aa4a4 100644 --- a/.rubocop_todo/rspec/feature_category.yml +++ b/.rubocop_todo/rspec/feature_category.yml @@ -481,7 +481,6 @@ RSpec/FeatureCategory: - 'ee/spec/lib/ee/gitlab/group_search_results_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/group_member_builder_spec.rb' - 'ee/spec/lib/ee/gitlab/hook_data/issue_builder_spec.rb' - - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/project/tree_saver_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/repo_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/wiki_repo_saver_spec.rb' @@ -679,7 +678,6 @@ RSpec/FeatureCategory: - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_groups_with_assigned_security_policy_project_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_groups_with_event_streaming_destinations_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_merge_requests_with_applied_scan_result_policies_metric_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_projects_with_applied_scan_result_policies_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_projects_with_assigned_security_policy_project_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_projects_with_external_status_checks_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_saml_group_links_metric_spec.rb' @@ -1026,7 +1024,6 @@ RSpec/FeatureCategory: - 'ee/spec/services/audit_events/user_impersonation_group_audit_event_service_spec.rb' - 'ee/spec/services/award_emojis/add_service_spec.rb' - 'ee/spec/services/award_emojis/destroy_service_spec.rb' - - 'ee/spec/services/billable_members/destroy_service_spec.rb' - 'ee/spec/services/boards/create_service_spec.rb' - 'ee/spec/services/boards/epic_boards/create_service_spec.rb' - 'ee/spec/services/boards/epic_boards/destroy_service_spec.rb' @@ -1211,7 +1208,6 @@ RSpec/FeatureCategory: - 'spec/controllers/help_controller_spec.rb' - 'spec/controllers/invites_controller_spec.rb' - 'spec/controllers/metrics_controller_spec.rb' - - 'spec/controllers/oauth/authorizations_controller_spec.rb' - 'spec/controllers/oauth/authorized_applications_controller_spec.rb' - 'spec/controllers/oauth/token_info_controller_spec.rb' - 'spec/controllers/profiles/accounts_controller_spec.rb' @@ -1317,7 +1313,6 @@ RSpec/FeatureCategory: - 'spec/finders/concerns/finder_with_group_hierarchy_spec.rb' - 'spec/finders/container_repositories_finder_spec.rb' - 'spec/finders/context_commits_finder_spec.rb' - - 'spec/finders/crm/organizations_finder_spec.rb' - 'spec/finders/database/batched_background_migrations_finder_spec.rb' - 'spec/finders/deploy_tokens/tokens_finder_spec.rb' - 'spec/finders/design_management/designs_finder_spec.rb' @@ -2553,7 +2548,6 @@ RSpec/FeatureCategory: - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb' - 'spec/lib/gitlab/form_builders/gitlab_ui_form_builder_spec.rb' - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb' - - 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb' - 'spec/lib/gitlab/git/attributes_at_ref_parser_spec.rb' - 'spec/lib/gitlab/git/attributes_parser_spec.rb' - 'spec/lib/gitlab/git/base_error_spec.rb' @@ -2963,7 +2957,6 @@ RSpec/FeatureCategory: - 'spec/lib/gitlab/search_context/builder_spec.rb' - 'spec/lib/gitlab/search_context/controller_concern_spec.rb' - 'spec/lib/gitlab/security/scan_configuration_spec.rb' - - 'spec/lib/gitlab/seeder_spec.rb' - 'spec/lib/gitlab/seeders/ci/daily_build_group_report_result_spec.rb' - 'spec/lib/gitlab/serializer/ci/variables_spec.rb' - 'spec/lib/gitlab/serializer/pagination_spec.rb' @@ -3429,7 +3422,6 @@ RSpec/FeatureCategory: - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - 'spec/models/integrations/chat_message/push_message_spec.rb' - 'spec/models/integrations/chat_message/wiki_page_message_spec.rb' - - 'spec/models/integrations/emails_on_push_spec.rb' - 'spec/models/integrations/ewm_spec.rb' - 'spec/models/integrations/harbor_spec.rb' - 'spec/models/integrations/issue_tracker_data_spec.rb' @@ -3575,7 +3567,6 @@ RSpec/FeatureCategory: - 'spec/policies/award_emoji_policy_spec.rb' - 'spec/policies/base_policy_spec.rb' - 'spec/policies/blob_policy_spec.rb' - - 'spec/policies/board_policy_spec.rb' - 'spec/policies/ci/bridge_policy_spec.rb' - 'spec/policies/clusters/agent_policy_spec.rb' - 'spec/policies/clusters/agent_token_policy_spec.rb' diff --git a/.rubocop_todo/rspec/instance_variable.yml b/.rubocop_todo/rspec/instance_variable.yml index c6446e263f7..2c8b8e15eed 100644 --- a/.rubocop_todo/rspec/instance_variable.yml +++ b/.rubocop_todo/rspec/instance_variable.yml @@ -28,8 +28,6 @@ RSpec/InstanceVariable: - 'ee/spec/views/projects/security/dast_profiles/show.html.haml_spec.rb' - 'ee/spec/views/projects/security/dast_scanner_profiles/new.html.haml_spec.rb' - 'ee/spec/views/projects/security/dast_site_profiles/new.html.haml_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_ssh_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/user_views_commit_diff_patch_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/project_issue_boards_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/more_than_four_assignees_spec.rb' - 'spec/commands/metrics_server/metrics_server_spec.rb' diff --git a/.rubocop_todo/rspec/named_subject.yml b/.rubocop_todo/rspec/named_subject.yml index 95e387e8b4c..2abc9a4f504 100644 --- a/.rubocop_todo/rspec/named_subject.yml +++ b/.rubocop_todo/rspec/named_subject.yml @@ -226,7 +226,6 @@ RSpec/NamedSubject: - 'ee/spec/lib/api/entities/protected_environments/approval_rule_spec.rb' - 'ee/spec/lib/api/entities/protected_environments/deploy_access_level_spec.rb' - 'ee/spec/lib/audit_events/base_changes_auditor_spec.rb' - - 'ee/spec/lib/audit_events/external_destination_streamer_spec.rb' - 'ee/spec/lib/audit_events/strategies/amazon_s3_destination_strategy_spec.rb' - 'ee/spec/lib/audit_events/strategies/external_destination_strategy_spec.rb' - 'ee/spec/lib/audit_events/strategies/google_cloud_logging_destination_strategy_spec.rb' @@ -1142,7 +1141,6 @@ RSpec/NamedSubject: - 'ee/spec/workers/vulnerabilities/mark_dropped_as_resolved_worker_spec.rb' - 'ee/spec/workers/vulnerabilities/update_namespace_ids_of_vulnerability_reads_worker_spec.rb' - 'qa/spec/ee/runtime/geo_spec.rb' - - 'qa/spec/factory/resource/user_spec.rb' - 'qa/spec/page/base_spec.rb' - 'qa/spec/page/element_spec.rb' - 'qa/spec/page/logging_spec.rb' @@ -2199,7 +2197,6 @@ RSpec/NamedSubject: - 'spec/lib/gitlab/sidekiq_middleware/admin_mode/client_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/admin_mode/server_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/client_metrics_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/extra_done_log_metadata_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/instrumentation_logger_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/monitor_spec.rb' @@ -2507,7 +2504,6 @@ RSpec/NamedSubject: - 'spec/models/integrations/asana_spec.rb' - 'spec/models/integrations/assembla_spec.rb' - 'spec/models/integrations/bamboo_spec.rb' - - 'spec/models/integrations/base_chat_notification_spec.rb' - 'spec/models/integrations/base_issue_tracker_spec.rb' - 'spec/models/integrations/bugzilla_spec.rb' - 'spec/models/integrations/buildkite_spec.rb' diff --git a/.rubocop_todo/rspec/no_expectation_example.yml b/.rubocop_todo/rspec/no_expectation_example.yml index e3006dd1364..a60724b1597 100644 --- a/.rubocop_todo/rspec/no_expectation_example.yml +++ b/.rubocop_todo/rspec/no_expectation_example.yml @@ -54,7 +54,6 @@ RSpec/NoExpectationExample: - 'qa/qa/specs/features/ee/browser_ui/10_govern/group/group_ldap_sync_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/10_govern/security_reports_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/wiki_ssh_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/cvs_dependency_scanning_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/9_data_stores/group/prevent_forking_outside_group_spec.rb' - 'qa/spec/specs/helpers/context_selector_spec.rb' - 'qa/spec/specs/helpers/feature_flag_spec.rb' diff --git a/.rubocop_todo/rspec/receive_messages.yml b/.rubocop_todo/rspec/receive_messages.yml index e1975dc43fd..c88a1663ce8 100644 --- a/.rubocop_todo/rspec/receive_messages.yml +++ b/.rubocop_todo/rspec/receive_messages.yml @@ -406,7 +406,6 @@ RSpec/ReceiveMessages: - 'spec/models/concerns/participable_spec.rb' - 'spec/models/concerns/require_email_verification_spec.rb' - 'spec/models/diff_viewer/base_spec.rb' - - 'spec/models/integrations/base_chat_notification_spec.rb' - 'spec/models/integrations/chat_message/pipeline_message_spec.rb' - 'spec/models/integrations/discord_spec.rb' - 'spec/models/issue_spec.rb' @@ -503,7 +502,6 @@ RSpec/ReceiveMessages: - 'spec/services/issuable/import_csv/base_service_spec.rb' - 'spec/services/issues/relative_position_rebalancing_service_spec.rb' - 'spec/services/merge_requests/after_create_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_ci_status_service_spec.rb' - 'spec/services/merge_requests/mergeability/check_commits_status_service_spec.rb' - 'spec/services/merge_requests/mergeability/check_lfs_file_locks_service_spec.rb' - 'spec/services/merge_requests/mergeability/run_checks_service_spec.rb' diff --git a/.rubocop_todo/style/arguments_forwarding.yml b/.rubocop_todo/style/arguments_forwarding.yml index 0b0890b919b..7f08ab95cca 100644 --- a/.rubocop_todo/style/arguments_forwarding.yml +++ b/.rubocop_todo/style/arguments_forwarding.yml @@ -2,205 +2,7 @@ # Cop supports --autocorrect. Style/ArgumentsForwarding: Exclude: - - 'app/controllers/admin/users_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/controllers/concerns/product_analytics_tracking.rb' - - 'app/controllers/concerns/sessionless_authentication.rb' - - 'app/controllers/oauth/applications_controller.rb' - - 'app/controllers/repositories/git_http_client_controller.rb' - - 'app/graphql/types/permission_types/base_permission_type.rb' - - 'app/helpers/application_helper.rb' - - 'app/helpers/merge_requests_helper.rb' - - 'app/mailers/application_mailer.rb' - - 'app/models/application_record.rb' - - 'app/models/ci/build_trace_chunk.rb' - - 'app/models/ci/partition.rb' - - 'app/models/ci/unlock_pipeline_request.rb' - - 'app/models/commit.rb' - - 'app/models/commit_collection.rb' - - 'app/models/concerns/after_commit_queue.rb' - - 'app/models/concerns/cross_database_ignored_tables.rb' - - 'app/models/concerns/redis_cacheable.rb' - - 'app/models/network/commit.rb' - - 'app/models/project.rb' - - 'app/models/system/broadcast_message.rb' - - 'app/presenters/gitlab/blame_presenter.rb' - - 'app/services/base_count_service.rb' - - 'app/services/concerns/projects/remove_refs.rb' - - 'app/services/packages/terraform_module/process_package_file_service.rb' - - 'app/services/projects/forks/sync_service.rb' - - 'app/services/projects/lfs_pointers/lfs_download_link_list_service.rb' - - 'app/services/projects/lfs_pointers/lfs_download_service.rb' - - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' - - 'app/services/protected_branches/cache_service.rb' - - 'app/services/user_project_access_changed_service.rb' - - 'app/services/users/update_service.rb' - - 'app/workers/authorized_project_update/user_refresh_from_replica_worker.rb' - - 'app/workers/concerns/limited_capacity/job_tracker.rb' - - 'app/workers/container_expiration_policies/cleanup_container_repository_worker.rb' - - 'app/workers/container_expiration_policy_worker.rb' - - 'app/workers/gitlab_performance_bar_stats_worker.rb' - - 'app/workers/packages/cleanup/delete_orphaned_dependencies_worker.rb' - - 'app/workers/projects/inactive_projects_deletion_cron_worker.rb' - - 'config/initializers/6_labkit_middleware.rb' - - 'config/initializers/mail_starttls_patch.rb' - - 'config/initializers/rest-client-hostname_override.rb' - - 'ee/app/controllers/ee/application_controller.rb' - - 'ee/app/models/ci/instance_runner_failed_jobs.rb' - - 'ee/app/models/dast_site_profile.rb' - - 'ee/app/models/ee/group.rb' - - 'ee/app/models/elastic/migration_record.rb' - - 'ee/app/models/license.rb' - - 'ee/app/models/security/orchestration_policy_configuration.rb' - - 'ee/app/services/elastic/indexing_control_service.rb' - - 'ee/app/services/elastic/process_bookkeeping_service.rb' - - 'ee/app/services/external_status_checks/base_service.rb' - - 'ee/app/services/vulnerability_exports/exporters/csv_service.rb' - - 'ee/app/workers/compliance_management/merge_requests/compliance_violations_consistency_worker.rb' - - 'ee/lib/ee/gitlab/auth/ldap/user.rb' - - 'ee/lib/gitlab/elastic/elasticsearch_enabled_cache.rb' - - 'ee/lib/gitlab/elastic/expr_name.rb' - - 'ee/lib/gitlab/license_scanning/package_licenses.rb' - - 'ee/lib/gitlab/llm/chain/concerns/ai_dependent.rb' - - 'ee/lib/gitlab/llm/chain/tools/tool.rb' - - 'ee/lib/gitlab/llm/chat_storage.rb' - - 'ee/lib/gitlab/llm/concerns/exponential_backoff.rb' - - 'ee/lib/gitlab/package_metadata/connector/gcp.rb' - - 'ee/lib/search/zoekt/cache.rb' - - 'ee/lib/security/scan_result_policies/policy_violation_comment.rb' - - 'lib/api/helpers/internal_helpers.rb' - - 'lib/backup/targets/database.rb' - - 'lib/banzai/reference_parser/base_parser.rb' - - 'lib/bitbucket/exponential_backoff.rb' - - 'lib/bitbucket_server/retry_with_delay.rb' - - 'lib/bulk_imports/clients/http.rb' - - 'lib/error_tracking/sentry_client.rb' - - 'lib/gitlab/application_context.rb' - - 'lib/gitlab/application_rate_limiter/base_strategy.rb' - - 'lib/gitlab/auth/ldap/dn.rb' - - 'lib/gitlab/avatar_cache.rb' - - 'lib/gitlab/background_migration/job_coordinator.rb' - - 'lib/gitlab/cache/ci/project_pipeline_status.rb' - - 'lib/gitlab/cache/import/caching.rb' - - 'lib/gitlab/changes_list.rb' - - 'lib/gitlab/ci/config/interpolation/config.rb' - - 'lib/gitlab/ci/pipeline/logger.rb' - - 'lib/gitlab/ci/secure_files/migration_helper.rb' - - 'lib/gitlab/ci/trace.rb' - - 'lib/gitlab/ci/variables/collection.rb' - - 'lib/gitlab/ci/variables/collection/sort.rb' - - 'lib/gitlab/ci/yaml_processor/dag.rb' - - 'lib/gitlab/circuit_breaker.rb' - - 'lib/gitlab/circuit_breaker/store.rb' - - 'lib/gitlab/cluster/lifecycle_events.rb' - - 'lib/gitlab/color_modes.rb' - - 'lib/gitlab/color_schemes.rb' - - 'lib/gitlab/config/entry/inheritable.rb' - - 'lib/gitlab/config/entry/simplifiable.rb' - - 'lib/gitlab/config/entry/validatable.rb' - - 'lib/gitlab/container_repository/tags/cache.rb' - - 'lib/gitlab/counters/buffered_counter.rb' - 'lib/gitlab/current_settings.rb' - - 'lib/gitlab/database/async_indexes/index_creator.rb' - - 'lib/gitlab/database/async_indexes/index_destructor.rb' - - 'lib/gitlab/database/background_migration/batch_metrics.rb' - - 'lib/gitlab/database/consistency.rb' - 'lib/gitlab/database/load_balancing/connection_proxy.rb' - - 'lib/gitlab/database/load_balancing/load_balancer.rb' - - 'lib/gitlab/database/load_balancing/sticking.rb' - - 'lib/gitlab/database/lock_writes_manager.rb' - - 'lib/gitlab/database/migrations/lock_retry_mixin.rb' - - 'lib/gitlab/database/migrations/runner_backoff/communicator.rb' - - 'lib/gitlab/database/migrations/test_batched_background_runner.rb' - - 'lib/gitlab/database/partitioning/detached_partition_dropper.rb' - - 'lib/gitlab/database/partitioning/list/locking_configuration.rb' - - 'lib/gitlab/database/partitioning/partition_manager.rb' - - 'lib/gitlab/database/partitioning/sliding_list_strategy.rb' - - 'lib/gitlab/database/partitioning_migration_helpers/index_helpers.rb' - - 'lib/gitlab/database/postgres_partitioned_table.rb' - - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - - 'lib/gitlab/database/tables_locker.rb' - - 'lib/gitlab/database/tables_sorted_by_foreign_keys.rb' - - 'lib/gitlab/diff/highlight_cache.rb' - - 'lib/gitlab/diff/position_collection.rb' - - 'lib/gitlab/discussions_diff/file_collection.rb' - - 'lib/gitlab/discussions_diff/highlight_cache.rb' - - 'lib/gitlab/encrypted_configuration.rb' - - 'lib/gitlab/etag_caching/store.rb' - - 'lib/gitlab/external_authorization/cache.rb' - - 'lib/gitlab/git/cross_repo.rb' - - 'lib/gitlab/git/diff_collection.rb' - - 'lib/gitlab/git/diff_stats_collection.rb' - - 'lib/gitlab/gitaly_client/cleanup_service.rb' - - 'lib/gitlab/gitaly_client/storage_settings.rb' - - 'lib/gitlab/gpg.rb' - - 'lib/gitlab/graphql/laziness.rb' - - 'lib/gitlab/graphql/lazy.rb' - - 'lib/gitlab/health_checks/base_abstract_check.rb' - - 'lib/gitlab/http.rb' - - 'lib/gitlab/i18n.rb' - - 'lib/gitlab/import_export/json/streaming_serializer.rb' - - 'lib/gitlab/issues/rebalancing/state.rb' - - 'lib/gitlab/kubernetes/node.rb' - - 'lib/gitlab/legacy_github_import/client.rb' - - 'lib/gitlab/markdown_cache/redis/store.rb' - 'lib/gitlab/memory/watchdog/configuration.rb' - - 'lib/gitlab/merge_requests/mergeability/redis_interface.rb' - - 'lib/gitlab/metrics/subscribers/active_record.rb' - - 'lib/gitlab/metrics/transaction.rb' - - 'lib/gitlab/namespaced_session_store.rb' - - 'lib/gitlab/pagination/keyset/in_operator_optimization/order_by_columns.rb' - - 'lib/gitlab/popen.rb' - - 'lib/gitlab/rack_attack.rb' - - 'lib/gitlab/rack_attack/store.rb' - 'lib/gitlab/redis/multi_store.rb' - - 'lib/gitlab/repository_archive_rate_limiter.rb' - - 'lib/gitlab/repository_cache.rb' - - 'lib/gitlab/repository_hash_cache.rb' - - 'lib/gitlab/repository_set_cache.rb' - - 'lib/gitlab/safe_request_loader.rb' - - 'lib/gitlab/search/recent_items.rb' - - 'lib/gitlab/set_cache.rb' - - 'lib/gitlab/shard_health_cache.rb' - - 'lib/gitlab/sidekiq_middleware/concurrency_limit/client.rb' - - 'lib/gitlab/sidekiq_middleware/concurrency_limit/server.rb' - - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/client.rb' - - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb' - - 'lib/gitlab/sidekiq_middleware/duplicate_jobs/server.rb' - - 'lib/gitlab/sidekiq_middleware/pause_control/client.rb' - - 'lib/gitlab/sidekiq_middleware/pause_control/pause_control_service.rb' - - 'lib/gitlab/sidekiq_middleware/pause_control/server.rb' - - 'lib/gitlab/sidekiq_middleware/pause_control/strategy_handler.rb' - - 'lib/gitlab/sidekiq_middleware/worker_context.rb' - - 'lib/gitlab/sidekiq_sharding/validator.rb' - - 'lib/gitlab/terraform/state_migration_helper.rb' - - 'lib/gitlab/themes.rb' - - 'lib/gitlab/utils/measuring.rb' - - 'lib/gitlab/workhorse.rb' - - 'lib/gitlab_settings.rb' - - 'lib/mattermost/client.rb' - - 'lib/object_storage/pending_direct_upload.rb' - - 'lib/uploaded_file.rb' - - 'lib/users/internal.rb' - - 'qa/qa/ee/page/insights/show.rb' - - 'qa/qa/ee/page/operations_dashboard.rb' - - 'qa/qa/page/admin/overview/users/show.rb' - - 'qa/qa/page/base.rb' - - 'qa/qa/page/component/blob_content.rb' - - 'qa/qa/page/component/snippet.rb' - - 'qa/qa/page/project/web_ide/vscode.rb' - - 'qa/qa/resource/protected_branch.rb' - - 'qa/qa/scenario/actable.rb' - - 'rubocop/code_reuse_helpers.rb' - - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - - 'spec/support/database/prevent_cross_database_modification.rb' - - 'spec/support/helpers/form_builder_helpers.rb' - - 'spec/support/helpers/git_http_helpers.rb' - - 'spec/support/helpers/graphql_helpers.rb' - - 'spec/support/helpers/query_recorder.rb' - - 'spec/support/helpers/redis_commands/recorder.rb' - - 'spec/support/helpers/routes_helpers.rb' - - 'spec/support/helpers/stub_method_calls.rb' - - 'spec/support/matchers/internal_events_cli_matchers.rb' - - 'spec/support/protected_branch_helpers.rb' - - 'spec/support/sidekiq_middleware.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index 6444b6f8608..b2065d154ae 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -132,7 +132,6 @@ Style/FormatString: - 'ee/app/helpers/billing_plans_helper.rb' - 'ee/app/helpers/ee/application_helper.rb' - 'ee/app/helpers/ee/geo_helper.rb' - - 'ee/app/helpers/ee/groups/settings_helper.rb' - 'ee/app/helpers/ee/groups_helper.rb' - 'ee/app/helpers/ee/import_helper.rb' - 'ee/app/helpers/ee/profiles_helper.rb' diff --git a/.rubocop_todo/style/guard_clause.yml b/.rubocop_todo/style/guard_clause.yml index 42e551789da..4b6bebe726c 100644 --- a/.rubocop_todo/style/guard_clause.yml +++ b/.rubocop_todo/style/guard_clause.yml @@ -509,7 +509,6 @@ Style/GuardClause: - 'scripts/setup/find-jh-branch.rb' - 'scripts/trigger-build.rb' - 'spec/features/issuables/issuable_list_spec.rb' - - 'spec/features/projects/blobs/edit_spec.rb' - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' - 'spec/services/issues/relative_position_rebalancing_service_spec.rb' - 'spec/services/packages/maven/metadata/append_package_file_service_spec.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 94d36bea145..4b0b0fdd25c 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -316,7 +316,6 @@ Style/IfUnlessModifier: - 'ee/app/services/ee/protected_branches/create_service.rb' - 'ee/app/services/ee/todo_service.rb' - 'ee/app/services/ee/users/update_service.rb' - - 'ee/app/services/elastic/indexing_control_service.rb' - 'ee/app/services/epics/base_service.rb' - 'ee/app/services/epics/create_service.rb' - 'ee/app/services/epics/epic_links/create_service.rb' @@ -685,7 +684,6 @@ Style/IfUnlessModifier: - 'qa/qa/page/page_concern.rb' - 'qa/qa/page/view.rb' - 'qa/qa/resource/registry_repository.rb' - - 'qa/qa/resource/repository/push.rb' - 'qa/qa/resource/snippet.rb' - 'qa/qa/scenario/bootable.rb' - 'qa/qa/service/praefect_manager.rb' diff --git a/.rubocop_todo/style/inline_disable_annotation.yml b/.rubocop_todo/style/inline_disable_annotation.yml index 847e54693ce..48721104063 100644 --- a/.rubocop_todo/style/inline_disable_annotation.yml +++ b/.rubocop_todo/style/inline_disable_annotation.yml @@ -55,7 +55,6 @@ Style/InlineDisableAnnotation: - 'app/controllers/dashboard/projects_controller.rb' - 'app/controllers/explore/projects_controller.rb' - 'app/controllers/graphql_controller.rb' - - 'app/controllers/groups/milestones_controller.rb' - 'app/controllers/groups_controller.rb' - 'app/controllers/help_controller.rb' - 'app/controllers/import/base_controller.rb' @@ -465,7 +464,6 @@ Style/InlineDisableAnnotation: - 'app/policies/email_policy.rb' - 'app/policies/event_policy.rb' - 'app/policies/group_group_link_policy.rb' - - 'app/policies/issue_policy.rb' - 'app/policies/list_policy.rb' - 'app/policies/namespace_ci_cd_setting_policy.rb' - 'app/policies/project_group_link_policy.rb' @@ -1330,14 +1328,11 @@ Style/InlineDisableAnnotation: - 'ee/app/services/security/security_orchestration_policies/fetch_policy_approvers_service.rb' - 'ee/app/services/security/security_orchestration_policies/policy_branches_service.rb' - 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb' - - 'ee/app/services/security/security_orchestration_policies/rule_schedule_service.rb' - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' - - 'ee/app/services/security/token_revocation_service.rb' - 'ee/app/services/security/update_training_service.rb' - 'ee/app/services/status_page/publish_base_service.rb' - 'ee/app/services/timebox/event_aggregation_service.rb' - 'ee/app/services/timebox_report_service.rb' - - 'ee/app/services/vulnerabilities/bulk_dismiss_service.rb' - 'ee/app/services/vulnerabilities/create_service_base.rb' - 'ee/app/services/vulnerabilities/manually_create_service.rb' - 'ee/app/validators/user_existence_validator.rb' @@ -1361,7 +1356,6 @@ Style/InlineDisableAnnotation: - 'ee/app/workers/compliance_management/merge_requests/compliance_violations_consistency_worker.rb' - 'ee/app/workers/compliance_management/timeout_pending_status_check_responses_worker.rb' - 'ee/app/workers/concerns/elastic/bulk_cron_worker.rb' - - 'ee/app/workers/concerns/elastic/indexing_control.rb' - 'ee/app/workers/concerns/geo/base_registry_sync_worker.rb' - 'ee/app/workers/create_github_webhook_worker.rb' - 'ee/app/workers/ee/post_receive.rb' @@ -1574,9 +1568,7 @@ Style/InlineDisableAnnotation: - 'ee/spec/factories/security_scans.rb' - 'ee/spec/features/dependency_proxy/packages/maven_spec.rb' - 'ee/spec/features/groups/group_settings_spec.rb' - - 'ee/spec/features/groups/settings/domain_verification_spec.rb' - 'ee/spec/features/merge_request/draft_comments_spec.rb' - - 'ee/spec/features/projects/mirror_spec.rb' - 'ee/spec/features/registrations/combined_registration_spec.rb' - 'ee/spec/features/registrations/saas/standard_flow_with_2fa_spec.rb' - 'ee/spec/finders/audit_event_finder_spec.rb' @@ -1604,8 +1596,6 @@ Style/InlineDisableAnnotation: - 'ee/spec/lib/gitlab/patch/database_config_spec.rb' - 'ee/spec/lib/gitlab/sitemaps/sitemap_file_spec.rb' - 'ee/spec/lib/gitlab/timebox/snapshot_builder_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_secure_pipelines_metric_spec.rb' - - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb' - 'ee/spec/lib/repositories/group_push_rules_changes_auditor_spec.rb' - 'ee/spec/lib/repositories/project_push_rules_changes_auditor_spec.rb' @@ -1756,7 +1746,6 @@ Style/InlineDisableAnnotation: - 'lib/api/protected_branches.rb' - 'lib/api/protected_tags.rb' - 'lib/api/resource_access_tokens.rb' - - 'lib/api/rubygem_packages.rb' - 'lib/api/settings.rb' - 'lib/api/sidekiq_metrics.rb' - 'lib/api/snippet_repository_storage_moves.rb' @@ -2007,7 +1996,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/legacy_github_import/issuable_formatter.rb' - 'lib/gitlab/lets_encrypt/client.rb' - - 'lib/gitlab/lfs_token.rb' - 'lib/gitlab/local_and_remote_storage_migration/base_migrater.rb' - 'lib/gitlab/marginalia/comment.rb' - 'lib/gitlab/markdown_cache/redis/store.rb' @@ -2033,7 +2021,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/patch/sidekiq_cron_poller.rb' - 'lib/gitlab/performance_bar.rb' - 'lib/gitlab/performance_bar/redis_adapter_when_peek_enabled.rb' - - 'lib/gitlab/popen/runner.rb' - 'lib/gitlab/profiler.rb' - 'lib/gitlab/project_search_results.rb' - 'lib/gitlab/project_stats_refresh_conflicts_logger.rb' @@ -2144,14 +2131,11 @@ Style/InlineDisableAnnotation: - 'qa/qa/scenario/test/integration/ldap_no_tls.rb' - 'qa/qa/scenario/test/integration/ldap_tls.rb' - 'qa/qa/scenario/test/integration/registry_with_cdn.rb' - - 'qa/qa/service/docker_run/gitlab_runner.rb' - 'qa/qa/service/shellout.rb' - 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_large_project_spec.rb' - 'qa/qa/specs/features/browser_ui/10_govern/user/user_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb' - - 'qa/qa/specs/features/ee/api/10_govern/instance_audit_event_streaming_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/10_govern/create_merge_request_with_secure_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/10_govern/group/group_audit_event_streaming_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/10_govern/group/group_audit_logs_1_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/10_govern/instance/instance_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/integrations/jira_issues_list_spec.rb' @@ -2162,7 +2146,6 @@ Style/InlineDisableAnnotation: - 'qa/qa/support/run.rb' - 'qa/qa/support/wait_for_requests.rb' - 'qa/qa/tools/reliable_report.rb' - - 'qa/qa/vendor/one_password/cli.rb' - 'qa/spec/ee/resource/mixins/group_base_spec.rb' - 'qa/spec/page/base_spec.rb' - 'qa/spec/resource/project_web_hook_spec.rb' @@ -2204,7 +2187,6 @@ Style/InlineDisableAnnotation: - 'spec/factories/projects/ci_feature_usages.rb' - 'spec/factories/wiki_pages.rb' - 'spec/features/markdown/math_spec.rb' - - 'spec/features/merge_request/user_edits_mr_spec.rb' - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' - 'spec/features/merge_request/user_sees_merge_request_pipelines_spec.rb' - 'spec/features/projects/members/import_project_members_spec.rb' @@ -2270,8 +2252,6 @@ Style/InlineDisableAnnotation: - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - 'spec/lib/gitlab/database/migrations/instrumentation_spec.rb' - 'spec/lib/gitlab/database_spec.rb' - - 'spec/lib/gitlab/doorkeeper_secret_storing/secret/pbkdf2_sha512_spec.rb' - - 'spec/lib/gitlab/doorkeeper_secret_storing/token/pbkdf2_sha512_spec.rb' - 'spec/lib/gitlab/encoding_helper_spec.rb' - 'spec/lib/gitlab/git/object_pool_spec.rb' - 'spec/lib/gitlab/git/remote_mirror_spec.rb' @@ -2306,11 +2286,9 @@ Style/InlineDisableAnnotation: - 'spec/lib/gitlab/memory/reports_daemon_spec.rb' - 'spec/lib/gitlab/memory/reports_uploader_spec.rb' - 'spec/lib/gitlab/memory/watchdog/handlers/puma_handler_spec.rb' - - 'spec/lib/gitlab/merge_requests/message_generator_spec.rb' - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' - 'spec/lib/gitlab/pagination/keyset/order_spec.rb' - 'spec/lib/gitlab/patch/database_config_spec.rb' - - 'spec/lib/gitlab/search/abuse_detection_spec.rb' - 'spec/lib/gitlab/shard_health_cache_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/count_deployments_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/gitaly_apdex_metric_spec.rb' @@ -2332,7 +2310,6 @@ Style/InlineDisableAnnotation: - 'spec/models/ci/persistent_ref_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/concerns/bulk_insertable_associations_spec.rb' - - 'spec/models/concerns/encrypted_user_password_spec.rb' - 'spec/models/concerns/legacy_bulk_insert_spec.rb' - 'spec/models/concerns/manual_inverse_association_spec.rb' - 'spec/models/concerns/noteable_spec.rb' @@ -2353,7 +2330,6 @@ Style/InlineDisableAnnotation: - 'spec/presenters/member_presenter_spec.rb' - 'spec/presenters/ml/candidates_csv_presenter_spec.rb' - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' - - 'spec/requests/api/alert_management_alerts_spec.rb' - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' - 'spec/requests/api/graphql/groups_query_spec.rb' - 'spec/requests/api/graphql/issues_spec.rb' @@ -2438,7 +2414,6 @@ Style/InlineDisableAnnotation: - 'spec/support/helpers/stub_feature_flags.rb' - 'spec/support/helpers/stub_object_storage.rb' - 'spec/support/helpers/stub_snowplow.rb' - - 'spec/support/helpers/wait_for_requests.rb' - 'spec/support/shared_contexts/controllers/ambiguous_ref_controller_shared_context.rb' - 'spec/support/shared_contexts/disable_user_tracking.rb' - 'spec/support/shared_contexts/policies/project_policy_table_shared_context.rb' @@ -2448,7 +2423,6 @@ Style/InlineDisableAnnotation: - 'spec/support/shared_examples/db/seeds/data_seeder_shared_examples.rb' - 'spec/support/shared_examples/deployments/create_for_job_shared_examples.rb' - 'spec/support/shared_examples/environments/create_for_job_shared_examples.rb' - - 'spec/support/shared_examples/features/milestone_editing_shared_examples.rb' - 'spec/support/shared_examples/features/wiki/user_previews_wiki_changes_shared_examples.rb' - 'spec/support/shared_examples/features/wiki/user_updates_wiki_page_shared_examples.rb' - 'spec/support/shared_examples/features/wiki/user_views_asciidoc_page_with_includes_shared_examples.rb' @@ -2508,7 +2482,6 @@ Style/InlineDisableAnnotation: - 'spec/workers/repository_check/single_repository_worker_spec.rb' - 'tooling/danger/database_dictionary.rb' - 'tooling/danger/saas_feature.rb' - - 'tooling/danger/sidekiq_queues.rb' - 'tooling/danger/stable_branch.rb' - 'tooling/lib/tooling/fast_quarantine.rb' - 'tooling/lib/tooling/find_changes.rb' diff --git a/.rubocop_todo/style/map_into_array.yml b/.rubocop_todo/style/map_into_array.yml index 5082e181e1b..5f5ccc05785 100644 --- a/.rubocop_todo/style/map_into_array.yml +++ b/.rubocop_todo/style/map_into_array.yml @@ -4,12 +4,18 @@ Style/MapIntoArray: Exclude: - 'app/finders/projects/members/effective_access_level_finder.rb' - 'app/services/packages/nuget/extract_metadata_content_service.rb' + - 'app/services/snippets/base_service.rb' - 'config/settings.rb' + - 'ee/app/workers/product_analytics/move_funnels_worker.rb' + - 'ee/lib/elastic/latest/user_class_proxy.rb' + - 'ee/lib/gitlab/search/zoekt/client.rb' - 'ee/spec/lib/search/elastic/references/embedding_spec.rb' - 'lib/gitlab/database/query_analyzers/prevent_set_operator_mismatch/node.rb' - 'lib/gitlab/git/blame.rb' - 'lib/gitlab/grape_logging/loggers/exception_logger.rb' - 'lib/google_api/cloud_platform/client.rb' - 'qa/qa/tools/delete_user_projects.rb' + - 'qa/qa/tools/generate_perf_testdata.rb' - 'spec/lib/gitlab/color_schemes_spec.rb' + - 'spec/lib/gitlab/git/blame_spec.rb' - 'spec/lib/gitlab/themes_spec.rb' diff --git a/GITLAB_KAS_VERSION b/GITLAB_KAS_VERSION index 89b4cc04091..a3c93503315 100644 --- a/GITLAB_KAS_VERSION +++ b/GITLAB_KAS_VERSION @@ -1 +1 @@ -456a8af358cfde87bef3b63373bdf8b7b3ab9032 +4fe9bfd64a3a6ed177743db3f0905aaffb2c10c2 diff --git a/Gemfile.checksum b/Gemfile.checksum index 5851869209b..c1633e7243c 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -238,7 +238,7 @@ {"name":"gitlab-net-dns","version":"0.9.2","platform":"ruby","checksum":"f726d978479d43810819f12a45c0906d775a07e34df111bbe693fffbbef3059d"}, {"name":"gitlab-sdk","version":"0.3.1","platform":"ruby","checksum":"48ba49084f4ab92df7c7ef9f347020d9dfdf6ed9c1e782b67264e98ffe6ea710"}, {"name":"gitlab-security_report_schemas","version":"0.1.2.min15.0.0.max15.2.1","platform":"ruby","checksum":"300037487ec9d51a814f648514ff521cb82b94fc51d9fe53389175b36ac680ae"}, -{"name":"gitlab-styles","version":"13.0.1","platform":"ruby","checksum":"bf1840fe97b215ab76fe1f1a83af0aee30d33ded905415918462b832004b68bd"}, +{"name":"gitlab-styles","version":"13.0.2","platform":"ruby","checksum":"e662b9334643763b55a861f9e26091096547f98179bd89b0fa8d6c6fb8cec861"}, {"name":"gitlab_chronic_duration","version":"0.12.0","platform":"ruby","checksum":"0d766944d415b5c831f176871ee8625783fc0c5bfbef2d79a3a616f207ffc16d"}, {"name":"gitlab_omniauth-ldap","version":"2.2.0","platform":"ruby","checksum":"bb4d20acb3b123ed654a8f6a47d3fac673ece7ed0b6992edb92dca14bad2838c"}, {"name":"gitlab_quality-test_tooling","version":"2.2.0","platform":"ruby","checksum":"d8fdaa7e5b529d0157485db4c81876a492303b53f30d9e8246f91f37f689295a"}, @@ -610,7 +610,7 @@ {"name":"rspec-support","version":"3.13.1","platform":"ruby","checksum":"48877d4f15b772b7538f3693c22225f2eda490ba65a0515c4e7cf6f2f17de70f"}, {"name":"rspec_junit_formatter","version":"0.6.0","platform":"ruby","checksum":"40dde674e6ae4e6cc0ff560da25497677e34fefd2338cc467a8972f602b62b15"}, {"name":"rspec_profiling","version":"0.0.9","platform":"ruby","checksum":"6199be2daeaa14bac3d10d704dbb0a8df052cf046332c505603263aea24f7590"}, -{"name":"rubocop","version":"1.67.0","platform":"ruby","checksum":"8ccca7226e76d0a9974af960ea446d1fb38adf0c491214294e2fed75a85c378c"}, +{"name":"rubocop","version":"1.68.0","platform":"ruby","checksum":"07df508504d81e97174e8d21030f25d52c1be7ee8615939db43f3b377ea6c12b"}, {"name":"rubocop-ast","version":"1.32.3","platform":"ruby","checksum":"40201e861c73a3c2d59428c7627828ef81fb2f8a306bc4a1c1801452afe3fe0f"}, {"name":"rubocop-capybara","version":"2.21.0","platform":"ruby","checksum":"5d264efdd8b6c7081a3d4889decf1451a1cfaaec204d81534e236bc825b280ab"}, {"name":"rubocop-factory_bot","version":"2.26.1","platform":"ruby","checksum":"8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa"}, diff --git a/Gemfile.lock b/Gemfile.lock index 91a57ee4b98..22d646d7d71 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -777,8 +777,8 @@ GEM gitlab-security_report_schemas (0.1.2.min15.0.0.max15.2.1) activesupport (>= 6, < 8) json_schemer (~> 2.3.0) - gitlab-styles (13.0.1) - rubocop (~> 1.67.0) + gitlab-styles (13.0.2) + rubocop (~> 1.68.0) rubocop-capybara (~> 2.21.0) rubocop-factory_bot (~> 2.26.1) rubocop-graphql (~> 1.5.4) @@ -1636,7 +1636,7 @@ GEM activerecord get_process_mem rails - rubocop (1.67.0) + rubocop (1.68.0) json (~> 2.3) language_server-protocol (>= 3.17.0) parallel (~> 1.10) diff --git a/Gemfile.next.checksum b/Gemfile.next.checksum index 130d3eb2905..e6ba3b995f5 100644 --- a/Gemfile.next.checksum +++ b/Gemfile.next.checksum @@ -239,7 +239,7 @@ {"name":"gitlab-net-dns","version":"0.9.2","platform":"ruby","checksum":"f726d978479d43810819f12a45c0906d775a07e34df111bbe693fffbbef3059d"}, {"name":"gitlab-sdk","version":"0.3.1","platform":"ruby","checksum":"48ba49084f4ab92df7c7ef9f347020d9dfdf6ed9c1e782b67264e98ffe6ea710"}, {"name":"gitlab-security_report_schemas","version":"0.1.2.min15.0.0.max15.2.1","platform":"ruby","checksum":"300037487ec9d51a814f648514ff521cb82b94fc51d9fe53389175b36ac680ae"}, -{"name":"gitlab-styles","version":"13.0.1","platform":"ruby","checksum":"bf1840fe97b215ab76fe1f1a83af0aee30d33ded905415918462b832004b68bd"}, +{"name":"gitlab-styles","version":"13.0.2","platform":"ruby","checksum":"e662b9334643763b55a861f9e26091096547f98179bd89b0fa8d6c6fb8cec861"}, {"name":"gitlab_chronic_duration","version":"0.12.0","platform":"ruby","checksum":"0d766944d415b5c831f176871ee8625783fc0c5bfbef2d79a3a616f207ffc16d"}, {"name":"gitlab_omniauth-ldap","version":"2.2.0","platform":"ruby","checksum":"bb4d20acb3b123ed654a8f6a47d3fac673ece7ed0b6992edb92dca14bad2838c"}, {"name":"gitlab_quality-test_tooling","version":"2.2.0","platform":"ruby","checksum":"d8fdaa7e5b529d0157485db4c81876a492303b53f30d9e8246f91f37f689295a"}, @@ -620,7 +620,7 @@ {"name":"rspec-support","version":"3.13.1","platform":"ruby","checksum":"48877d4f15b772b7538f3693c22225f2eda490ba65a0515c4e7cf6f2f17de70f"}, {"name":"rspec_junit_formatter","version":"0.6.0","platform":"ruby","checksum":"40dde674e6ae4e6cc0ff560da25497677e34fefd2338cc467a8972f602b62b15"}, {"name":"rspec_profiling","version":"0.0.9","platform":"ruby","checksum":"6199be2daeaa14bac3d10d704dbb0a8df052cf046332c505603263aea24f7590"}, -{"name":"rubocop","version":"1.67.0","platform":"ruby","checksum":"8ccca7226e76d0a9974af960ea446d1fb38adf0c491214294e2fed75a85c378c"}, +{"name":"rubocop","version":"1.68.0","platform":"ruby","checksum":"07df508504d81e97174e8d21030f25d52c1be7ee8615939db43f3b377ea6c12b"}, {"name":"rubocop-ast","version":"1.32.3","platform":"ruby","checksum":"40201e861c73a3c2d59428c7627828ef81fb2f8a306bc4a1c1801452afe3fe0f"}, {"name":"rubocop-capybara","version":"2.21.0","platform":"ruby","checksum":"5d264efdd8b6c7081a3d4889decf1451a1cfaaec204d81534e236bc825b280ab"}, {"name":"rubocop-factory_bot","version":"2.26.1","platform":"ruby","checksum":"8de13cd4edcee5ca800f255188167ecef8dbfc3d1fae9f15734e9d2e755392aa"}, diff --git a/Gemfile.next.lock b/Gemfile.next.lock index 7a6f70d3c54..a73ab81b1a6 100644 --- a/Gemfile.next.lock +++ b/Gemfile.next.lock @@ -787,8 +787,8 @@ GEM gitlab-security_report_schemas (0.1.2.min15.0.0.max15.2.1) activesupport (>= 6, < 8) json_schemer (~> 2.3.0) - gitlab-styles (13.0.1) - rubocop (~> 1.67.0) + gitlab-styles (13.0.2) + rubocop (~> 1.68.0) rubocop-capybara (~> 2.21.0) rubocop-factory_bot (~> 2.26.1) rubocop-graphql (~> 1.5.4) @@ -1662,7 +1662,7 @@ GEM activerecord get_process_mem rails - rubocop (1.67.0) + rubocop (1.68.0) json (~> 2.3) language_server-protocol (>= 3.17.0) parallel (~> 1.10) diff --git a/app/assets/javascripts/ci/pipeline_editor/components/file_tree/container.vue b/app/assets/javascripts/ci/pipeline_editor/components/file_tree/container.vue index 59653c2b2d9..12627172982 100644 --- a/app/assets/javascripts/ci/pipeline_editor/components/file_tree/container.vue +++ b/app/assets/javascripts/ci/pipeline_editor/components/file_tree/container.vue @@ -54,7 +54,7 @@ export default {
diff --git a/app/assets/javascripts/ci/pipeline_editor/components/file_tree/file_item.vue b/app/assets/javascripts/ci/pipeline_editor/components/file_tree/file_item.vue index 3a57a36fb61..78eb9d6c56a 100644 --- a/app/assets/javascripts/ci/pipeline_editor/components/file_tree/file_item.vue +++ b/app/assets/javascripts/ci/pipeline_editor/components/file_tree/file_item.vue @@ -34,7 +34,7 @@ export default { :href="filePath" :title="fileName" target="_blank" - class="file-tree-includes-link gl-flex gl-justify-between gl-rounded-base gl-px-3 gl-py-2 gl-text-default hover:gl-bg-gray-50 hover:gl-text-gray-900 hover:gl-no-underline" + class="file-tree-includes-link gl-flex gl-justify-between gl-rounded-base gl-px-3 gl-py-2 gl-text-default hover:gl-bg-strong hover:gl-text-strong hover:gl-no-underline" > diff --git a/app/assets/javascripts/content_editor/components/wrappers/code_block.vue b/app/assets/javascripts/content_editor/components/wrappers/code_block.vue index 6b78897fd49..91f7db00def 100644 --- a/app/assets/javascripts/content_editor/components/wrappers/code_block.vue +++ b/app/assets/javascripts/content_editor/components/wrappers/code_block.vue @@ -290,8 +290,11 @@ export default { diff --git a/app/assets/javascripts/content_editor/constants/code_block_languages.js b/app/assets/javascripts/content_editor/constants/code_block_languages.js index 1a4dbe4fa22..caa43b1c87e 100644 --- a/app/assets/javascripts/content_editor/constants/code_block_languages.js +++ b/app/assets/javascripts/content_editor/constants/code_block_languages.js @@ -66,6 +66,7 @@ const CODE_BLOCK_LANGUAGES = [ { syntax: 'gauss', variants: 'gss', label: 'GAUSS' }, { syntax: 'gcode', variants: 'nc', label: 'G-code (ISO 6983)' }, { syntax: 'gherkin', variants: 'feature', label: 'Gherkin' }, + { syntax: 'glql', label: 'GitLab Query Language (GLQL)' }, { syntax: 'glsl', label: 'GLSL' }, { syntax: 'gml', label: 'GML' }, { syntax: 'go', variants: 'golang', label: 'Go' }, diff --git a/app/assets/javascripts/diffs/components/app.vue b/app/assets/javascripts/diffs/components/app.vue index be2a2309383..3adf1530687 100644 --- a/app/assets/javascripts/diffs/components/app.vue +++ b/app/assets/javascripts/diffs/components/app.vue @@ -4,6 +4,7 @@ import { GlBreakpointInstance as bp } from '@gitlab/ui/dist/utils'; import { debounce, throttle } from 'lodash'; // eslint-disable-next-line no-restricted-imports import { mapState, mapGetters, mapActions } from 'vuex'; +import FindingsDrawer from 'ee_component/diffs/components/shared/findings_drawer.vue'; import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin'; import { convertToGraphQLId } from '~/graphql_shared/utils'; import api from '~/api'; @@ -51,7 +52,6 @@ import { reviewStatuses } from '../utils/file_reviews'; import { diffsApp } from '../utils/performance'; import { updateChangesTabCount, extractFileHash } from '../utils/merge_request'; import { queueRedisHllEvents } from '../utils/queue_events'; -import FindingsDrawer from './shared/findings_drawer.vue'; import CollapsedFilesWarning from './collapsed_files_warning.vue'; import CommitWidget from './commit_widget.vue'; import CompareVersions from './compare_versions.vue'; diff --git a/app/assets/javascripts/diffs/components/diff_file_header.vue b/app/assets/javascripts/diffs/components/diff_file_header.vue index 3ab00261aac..8c248162cb0 100644 --- a/app/assets/javascripts/diffs/components/diff_file_header.vue +++ b/app/assets/javascripts/diffs/components/diff_file_header.vue @@ -340,7 +340,7 @@ export default { v-if="isModeChanged" ref="fileMode" v-gl-tooltip.hover.focus - class="mr-1" + class="gl-mr-2 gl-text-subtle" :title="$options.i18n.fileModeTooltip" > {{ diffFile.a_mode }} → {{ diffFile.b_mode }} diff --git a/app/assets/javascripts/diffs/components/diff_file_row.vue b/app/assets/javascripts/diffs/components/diff_file_row.vue index 21f062233cc..92de29e1a4c 100644 --- a/app/assets/javascripts/diffs/components/diff_file_row.vue +++ b/app/assets/javascripts/diffs/components/diff_file_row.vue @@ -43,7 +43,7 @@ export default { fileClasses() { return this.file.type === 'blob' && !this.viewedFiles[this.file.fileHash] ? 'gl-font-bold' - : ''; + : 'gl-text-subtle'; }, isActive() { return this.currentDiffFileId === this.file.fileHash; @@ -62,7 +62,7 @@ export default { :file-classes="fileClasses" v-on="$listeners" > - + diff --git a/app/assets/javascripts/diffs/components/shared/findings_drawer.vue b/app/assets/javascripts/diffs/components/shared/findings_drawer.vue deleted file mode 100644 index 578b559fa85..00000000000 --- a/app/assets/javascripts/diffs/components/shared/findings_drawer.vue +++ /dev/null @@ -1,138 +0,0 @@ - - diff --git a/app/assets/javascripts/diffs/components/shared/findings_drawer_details.vue b/app/assets/javascripts/diffs/components/shared/findings_drawer_details.vue deleted file mode 100644 index 1b48f5ffe57..00000000000 --- a/app/assets/javascripts/diffs/components/shared/findings_drawer_details.vue +++ /dev/null @@ -1,119 +0,0 @@ - - - diff --git a/app/assets/javascripts/diffs/components/shared/findings_drawer_item.vue b/app/assets/javascripts/diffs/components/shared/findings_drawer_item.vue deleted file mode 100644 index 65ba461b871..00000000000 --- a/app/assets/javascripts/diffs/components/shared/findings_drawer_item.vue +++ /dev/null @@ -1,28 +0,0 @@ - - diff --git a/app/assets/javascripts/repository/components/blob_button_group.vue b/app/assets/javascripts/repository/components/blob_button_group.vue index 3aec35ee960..f8d43a0922e 100644 --- a/app/assets/javascripts/repository/components/blob_button_group.vue +++ b/app/assets/javascripts/repository/components/blob_button_group.vue @@ -1,6 +1,8 @@