root
/
gitlab-ce
mirror of https://gitlab.com/free-releases/gitlab-ce.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Don't call anything on a block, use simple if 

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7333#note_20058743
This commit is contained in:
Lin Jen-Shin 2016-12-15 18:38:26 +08:00
parent cc6f578d5f
commit b4a7e7cfbf
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/models/ci/pipeline.rb
View File

@ -89,13 +89,15 @@ module Ci
# ref can't be HEAD or SHA, can only be branch/tag name # ref can't be HEAD or SHA, can only be branch/tag name
scope :latest, ->(ref = nil) do scope :latest, ->(ref = nil) do
max_id = unscope(:select).select("max(#{quoted_table_name}.id)") max_id = unscope(:select)
.select("max(#{quoted_table_name}.id)")
.group(:ref, :sha)
if ref if ref
where(ref: ref) where(id: max_id, ref: ref)
else else
self where(id: max_id)
end.where(id: max_id.group(:ref, :sha)) end
end end
def self.latest_status(ref = nil) def self.latest_status(ref = nil)