From b53b2fbb6b393f28211fa2c2c5bdb519b6e7bc08 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 12 Jan 2023 00:07:21 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../issue_templates/Broken Master - Flaky.md | 4 +- .../Broken Master - Non-flaky.md | 2 +- .../artifacts/components/feedback_banner.vue | 41 ++++ .../components/job_artifacts_table.vue | 3 + app/assets/javascripts/artifacts/constants.js | 7 + app/assets/javascripts/artifacts/index.js | 3 +- .../nav/components/new_nav_toggle.vue | 7 + .../javascripts/pages/groups/show/index.js | 2 + app/assets/javascripts/read_more.js | 4 +- app/assets/javascripts/search/index.js | 10 +- .../components/confidentiality_filter.vue | 2 +- .../sidebar/components/results_filters.vue | 2 +- .../sidebar/components/scope_navigation.vue | 17 +- .../sidebar/components/status_filter.vue | 2 +- .../search/sidebar/constants/index.js | 13 +- .../javascripts/search/sidebar/index.js | 6 +- .../javascripts/search/store/constants.js | 2 + app/assets/javascripts/search/store/utils.js | 24 +- .../components/mr_collapsible_extension.vue | 23 +- app/models/ci/artifact_blob.rb | 2 +- app/models/deploy_key.rb | 8 +- app/models/pages/lookup_path.rb | 2 +- app/models/project.rb | 18 +- app/views/groups/_home_panel.html.haml | 16 +- app/views/projects/artifacts/index.html.haml | 3 +- app/views/search/_results.html.haml | 4 +- .../validate_release_with_author.yml | 2 +- ...precate-merge-request-approvals-fields.yml | 14 ++ ...47_partition_pm_package_metadata_tables.rb | 13 ++ db/schema_migrations/20221215210347 | 1 + doc/api/merge_request_approvals.md | 217 +++++++++--------- doc/development/documentation/testing.md | 4 +- doc/operations/metrics/alerts.md | 13 +- doc/update/deprecations.md | 14 ++ lib/gitlab/database/migration_helpers.rb | 19 +- .../ci/runner/runner_fleet_pipeline_seeder.rb | 30 ++- locale/gitlab.pot | 18 ++ .../1_manage/user_inherited_access_spec.rb | 2 +- .../specs/features/api/1_manage/users_spec.rb | 2 +- .../1_manage/group/transfer_group_spec.rb | 2 +- .../1_manage/group/transfer_project_spec.rb | 2 +- .../project/add_project_member_spec.rb | 2 +- .../project/create_project_badge_spec.rb | 2 +- .../1_manage/project/create_project_spec.rb | 2 +- .../1_manage/project/dashboard_images_spec.rb | 2 +- .../project/invite_group_to_project_spec.rb | 2 +- .../project/project_owner_permissions_spec.rb | 2 +- .../project/view_project_activity_spec.rb | 2 +- .../user/follow_user_activity_spec.rb | 2 +- .../parent_group_access_termination_spec.rb | 2 +- .../user/user_inherited_access_spec.rb | 2 +- .../projects/deploy_keys_controller_spec.rb | 5 +- .../components/feedback_banner_spec.js | 63 +++++ .../components/job_artifacts_table_spec.js | 14 +- .../components/related_merge_requests_spec.js | 12 +- spec/frontend/read_more_spec.js | 33 ++- spec/frontend/search/store/utils_spec.js | 22 ++ .../mr_collapsible_extension_spec.js | 8 +- .../gitlab/database/migration_helpers_spec.rb | 77 ++++++- .../runner_fleet_pipeline_seeder_spec.rb | 3 + spec/models/pages/lookup_path_spec.rb | 10 +- spec/models/project_spec.rb | 113 ++++++--- .../create_pipeline_trackers_service_spec.rb | 2 +- .../packages/conan/search_service_spec.rb | 2 +- spec/services/projects/create_service_spec.rb | 2 +- 65 files changed, 694 insertions(+), 272 deletions(-) create mode 100644 app/assets/javascripts/artifacts/components/feedback_banner.vue create mode 100644 data/deprecations/15-8-deprecate-merge-request-approvals-fields.yml create mode 100644 db/migrate/20221215210347_partition_pm_package_metadata_tables.rb create mode 100644 db/schema_migrations/20221215210347 create mode 100644 spec/frontend/artifacts/components/feedback_banner_spec.js diff --git a/.gitlab/issue_templates/Broken Master - Flaky.md b/.gitlab/issue_templates/Broken Master - Flaky.md index bea12615e41..b1ca0305db4 100644 --- a/.gitlab/issue_templates/Broken Master - Flaky.md +++ b/.gitlab/issue_templates/Broken Master - Flaky.md @@ -16,7 +16,7 @@ Please read the below documentations for a workflow of triaging and resolving br -Please refer to [Flaky tests documentation](https://docs.gitlab.com/ee/development/testing_guide/flaky_tests.html) to +Please refer to [Flaky tests documentation](https://docs.gitlab.com/ee/development/testing_guide/flaky_tests.html) to learn more about how to reproduce them. ### Proposed Resolution @@ -25,4 +25,4 @@ learn more about how to reproduce them. Please refer to the [Resolution guidance](https://about.gitlab.com/handbook/engineering/workflow/#resolution-of-broken-master) to learn more about resolution of broken master. -/label ~"failure::flaky-test" ~"Engineering Productivity" ~"priority::2" ~"severity::3" ~"type::bug" ~"bug::transient" +/label ~"type::maintenance" ~"failure::flaky-test" ~"priority::3" ~"severity::3" diff --git a/.gitlab/issue_templates/Broken Master - Non-flaky.md b/.gitlab/issue_templates/Broken Master - Non-flaky.md index 43e73fc5c5a..d2dc616ead8 100644 --- a/.gitlab/issue_templates/Broken Master - Non-flaky.md +++ b/.gitlab/issue_templates/Broken Master - Non-flaky.md @@ -21,4 +21,4 @@ Please read the below documentations for a workflow of triaging and resolving br Please refer to the [Resolution guidance](https://about.gitlab.com/handbook/engineering/workflow/#resolution-of-broken-master) to learn more about resolution of broken master. -/label ~"master:broken" ~"Engineering Productivity" ~"priority::1" ~"severity::1" ~"type::bug" ~"bug::transient" +/label ~"master:broken" ~"Engineering Productivity" ~"priority::1" ~"severity::1" ~"type::maintenance" ~"maintenance::pipelines" diff --git a/app/assets/javascripts/artifacts/components/feedback_banner.vue b/app/assets/javascripts/artifacts/components/feedback_banner.vue new file mode 100644 index 00000000000..d2c96b1a201 --- /dev/null +++ b/app/assets/javascripts/artifacts/components/feedback_banner.vue @@ -0,0 +1,41 @@ + + diff --git a/app/assets/javascripts/artifacts/components/job_artifacts_table.vue b/app/assets/javascripts/artifacts/components/job_artifacts_table.vue index 34e443f4e58..3b5c5f54a82 100644 --- a/app/assets/javascripts/artifacts/components/job_artifacts_table.vue +++ b/app/assets/javascripts/artifacts/components/job_artifacts_table.vue @@ -35,6 +35,7 @@ import { INITIAL_LAST_PAGE_SIZE, } from '../constants'; import ArtifactsTableRowDetails from './artifacts_table_row_details.vue'; +import FeedbackBanner from './feedback_banner.vue'; const INITIAL_PAGINATION_STATE = { currentPage: INITIAL_CURRENT_PAGE, @@ -58,6 +59,7 @@ export default { CiIcon, TimeAgo, ArtifactsTableRowDetails, + FeedbackBanner, }, inject: ['projectPath'], apollo: { @@ -214,6 +216,7 @@ export default {