Unused got variable with very bad performance
In any case if just want the value which is always ‘gitlab’
require 'benchmark/ips'
Project.first # To load database things
GitlabIssueTrackerService.first # To load database things
Benchmark.ips do |x|
  x.config(:time => 5, :warmup => 2)
  x.report("current") do
    Project.new.default_issue_tracker.to_param
  end
  x.report("") do
    'gitlab'
  end
  x.compare!
end
Calculating -------------------------------------
             current     4.000  i/100ms
                        30.938k i/100ms
-------------------------------------------------
             current     47.298  (±10.6%) i/s -    232.000 
                          4.366M (±20.9%) i/s -     17.202M
Comparison:
                    :  4366456.0 i/s
             current:       47.3 i/s - 92318.26x slower
			
			
This commit is contained in:
		
							parent
							
								
									365015e3c9
								
							
						
					
					
						commit
						b5fa56eb3f
					
				| 
						 | 
				
			
			@ -13,6 +13,7 @@ v 8.10.0 (unreleased)
 | 
			
		|||
  - Fix changing issue state columns in milestone view
 | 
			
		||||
  - Fix user creation with stronger minimum password requirements !4054 (nathan-pmt)
 | 
			
		||||
  - Check for conflicts with existing Project's wiki path when creating a new project.
 | 
			
		||||
  - Remove unused front-end variable -> default_issues_tracker
 | 
			
		||||
  - Add API endpoint for a group issues !4520 (mahcsig)
 | 
			
		||||
  - Allow [ci skip] to be in any case and allow [skip ci]. !4785 (simon_w)
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -3,7 +3,6 @@ module Gitlab
 | 
			
		|||
    def add_gon_variables
 | 
			
		||||
      gon.api_version            = API::API.version
 | 
			
		||||
      gon.default_avatar_url     = URI::join(Gitlab.config.gitlab.url, ActionController::Base.helpers.image_path('no_avatar.png')).to_s
 | 
			
		||||
      gon.default_issues_tracker = Project.new.default_issue_tracker.to_param
 | 
			
		||||
      gon.max_file_size          = current_application_settings.max_attachment_size
 | 
			
		||||
      gon.relative_url_root      = Gitlab.config.gitlab.relative_url_root
 | 
			
		||||
      gon.shortcuts_path         = help_shortcuts_path
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue