diff --git a/.gitlab/ci/setup.gitlab-ci.yml b/.gitlab/ci/setup.gitlab-ci.yml index 585d1d1a357..e8f9e94d188 100644 --- a/.gitlab/ci/setup.gitlab-ci.yml +++ b/.gitlab/ci/setup.gitlab-ci.yml @@ -131,32 +131,25 @@ detect-tests: image: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images/ci/${BUILD_OS}-${OS_VERSION}-slim-ruby-${RUBY_VERSION}:rubygems-${RUBYGEMS_VERSION}-git-${GIT_VERSION} needs: [] stage: prepare - variables: - RSPEC_TESTS_MAPPING_ENABLED: "true" - MAPPING_ARCHIVE: $RSPEC_PACKED_TESTS_MAPPING_PATH before_script: - - apt update && apt install -y curl - source ./scripts/utils.sh - source ./scripts/rspec_helpers.sh - - retrieve_frontend_fixtures_mapping # Use alternative coverage based mappings for tier-2 pipeline - | - echo "Fetching crystalball mappings" if echo "$CI_MERGE_REQUEST_LABELS" | grep -q "pipeline::tier-2"; then - echo "Using alternative coverage based mapping path: $RSPEC_PACKED_TESTS_MAPPING_ALT_PATH" - MAPPING_ARCHIVE=$(echo "$RSPEC_PACKED_TESTS_MAPPING_ALT_PATH") + echo "Using alternative coverage based mappings" + MAPPING_TYPE=coverage else - echo "Using standard described_class based mapping path: $RSPEC_PACKED_TESTS_MAPPING_PATH" - MAPPING_ARCHIVE=$(echo "$RSPEC_PACKED_TESTS_MAPPING_PATH") + echo "Using standard described_class based mappings" + MAPPING_TYPE=described_class fi - retrieve_tests_mapping "$MAPPING_ARCHIVE" script: - | # $FIND_CHANGES_MERGE_REQUEST_IID is defined in as-if-foss.gitlab-ci.yml if [ -n "$CI_MERGE_REQUEST_IID" ] || [ -n "$FIND_CHANGES_MERGE_REQUEST_IID" ]; then mkdir -p $(dirname "$RSPEC_CHANGED_FILES_PATH") - tooling/bin/predictive_tests --select-tests + tooling/bin/predictive_tests --select-tests --with-crystalball-mappings --mapping-type $MAPPING_TYPE filter_rspec_matched_foss_tests ${RSPEC_MATCHING_TEST_FILES_PATH} ${RSPEC_MATCHING_TESTS_FOSS_PATH}; filter_rspec_matched_ee_tests ${RSPEC_MATCHING_TEST_FILES_PATH} ${RSPEC_MATCHING_TESTS_EE_PATH}; diff --git a/.rubocop_todo/internal_affairs/node_type_predicate.yml b/.rubocop_todo/internal_affairs/node_type_predicate.yml deleted file mode 100644 index df2c4400f44..00000000000 --- a/.rubocop_todo/internal_affairs/node_type_predicate.yml +++ /dev/null @@ -1,21 +0,0 @@ ---- -# Cop supports --autocorrect. -InternalAffairs/NodeTypePredicate: - Details: grace period - Exclude: - - 'rubocop/cop/avoid_break_from_strong_memoize.rb' - - 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb' - - 'rubocop/cop/avoid_return_from_blocks.rb' - - 'rubocop/cop/graphql/descriptions.rb' - - 'rubocop/cop/migration/add_limit_to_text_columns.rb' - - 'rubocop/cop/migration/add_reference.rb' - - 'rubocop/cop/migration/background_migration_missing_active_concern.rb' - - 'rubocop/cop/migration/datetime.rb' - - 'rubocop/cop/migration/prevent_adding_columns.rb' - - 'rubocop/cop/migration/prevent_strings.rb' - - 'rubocop/cop/migration/refer_to_index_by_name.rb' - - 'rubocop/cop/prefer_class_methods_over_module.rb' - - 'rubocop/cop/project_path_helper.rb' - - 'rubocop/cop/rspec/have_gitlab_http_status.rb' - - 'rubocop/cop/static_translation_definition.rb' - - 'rubocop/cop/usage_data/distinct_count_by_large_foreign_key.rb' diff --git a/app/assets/javascripts/content_editor/components/toolbar_more_dropdown.vue b/app/assets/javascripts/content_editor/components/toolbar_more_dropdown.vue index aa705b6f712..a458b9343c6 100644 --- a/app/assets/javascripts/content_editor/components/toolbar_more_dropdown.vue +++ b/app/assets/javascripts/content_editor/components/toolbar_more_dropdown.vue @@ -47,7 +47,7 @@ export default { action: () => this.execute('setHorizontalRule', 'horizontalRule'), }, { - text: __('GitLab Query Language (GLQL) view'), + text: __('Embedded view'), action: () => this.execute('insertGLQLView', 'glqlView'), badge: { text: __('Beta'), diff --git a/app/assets/javascripts/content_editor/constants/code_block_languages.js b/app/assets/javascripts/content_editor/constants/code_block_languages.js index caa43b1c87e..1016b8d20b8 100644 --- a/app/assets/javascripts/content_editor/constants/code_block_languages.js +++ b/app/assets/javascripts/content_editor/constants/code_block_languages.js @@ -66,7 +66,7 @@ const CODE_BLOCK_LANGUAGES = [ { syntax: 'gauss', variants: 'gss', label: 'GAUSS' }, { syntax: 'gcode', variants: 'nc', label: 'G-code (ISO 6983)' }, { syntax: 'gherkin', variants: 'feature', label: 'Gherkin' }, - { syntax: 'glql', label: 'GitLab Query Language (GLQL)' }, + { syntax: 'glql', label: 'Embedded view (GLQL)' }, { syntax: 'glsl', label: 'GLSL' }, { syntax: 'gml', label: 'GML' }, { syntax: 'go', variants: 'golang', label: 'Go' }, diff --git a/app/assets/javascripts/diffs/components/diff_file.vue b/app/assets/javascripts/diffs/components/diff_file.vue index 108b916eda6..e55b9bc7e93 100644 --- a/app/assets/javascripts/diffs/components/diff_file.vue +++ b/app/assets/javascripts/diffs/components/diff_file.vue @@ -215,7 +215,12 @@ export default { return !this.isCollapsed || this.automaticallyCollapsed; }, showWarning() { - return this.isCollapsed && this.automaticallyCollapsed && !this.viewDiffsFileByFile; + return ( + !this.reviewed && + this.isCollapsed && + this.automaticallyCollapsed && + !this.viewDiffsFileByFile + ); }, expandableWarning() { return this.file.viewer?.generated @@ -629,7 +634,7 @@ export default {