root
/
gitlab-ce
mirror of https://gitlab.com/free-releases/gitlab-ce.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Fix specs for pipeline processing with manual actions

This commit is contained in:
Grzegorz Bizon 2017-03-03 10:20:22 +01:00
parent 50c393e58b
commit b8dc2ab93f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
spec/services/ci/process_pipeline_service_spec.rb
View File

@ -62,7 +62,7 @@ describe Ci::ProcessPipelineService, :services do
end
end
context 'properly creates builds when "when" is defined' do
context 'properly creates builds when optional actions are defined' do
before do
create_build('build', stage_idx: 0)
create_build('test', stage_idx: 1)
@ -192,7 +192,7 @@ describe Ci::ProcessPipelineService, :services do
end
end
context 'when listing manual actions' do
context 'when listing optional manual actions' do
it 'returns only for skipped builds' do
# currently all builds are created
expect(process_pipeline).to be_truthy
@ -220,9 +220,9 @@ describe Ci::ProcessPipelineService, :services do
builds.each(&:reload)
end
context 'when first stage has only manual jobs' do
context 'when first stage has only optional manual actions' do
let(:builds) do
[create_build('build', stage_idx: 0, when: 'manual'),
[create_build('build', stage_idx: 0, when: 'manual', allow_failure: true),
create_build('check', stage_idx: 1),
create_build('test', stage_idx: 2)]
end
@ -232,10 +232,10 @@ describe Ci::ProcessPipelineService, :services do
end
end
context 'when second stage has only manual jobs' do
context 'when second stage has only optional manual actions' do
let(:builds) do
[create_build('check', stage_idx: 0),
create_build('build', stage_idx: 1, when: 'manual'),
create_build('build', stage_idx: 1, when: 'manual', allow_failure: true),
create_build('test', stage_idx: 2)]
end