From bb915e6375fe65053937c6bf8a7d0771dc9e4713 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 19 Apr 2023 18:08:48 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/CODEOWNERS | 16 ++ .../layout/empty_line_after_magic_comment.yml | 2 +- GITALY_SERVER_VERSION | 2 +- .../components/service_desk_root.vue | 2 +- .../components/service_desk_setting.vue | 4 +- .../search/sidebar/components/app.vue | 3 + .../sidebar/components/checkbox_filter.vue | 4 +- .../components/confidentiality_filter.vue | 8 +- .../components/language_filter/index.vue | 6 +- .../sidebar/components/radio_filter.vue | 4 +- .../sidebar/components/results_filters.vue | 8 +- .../sidebar/components/status_filter.vue | 8 +- app/assets/stylesheets/framework/flash.scss | 16 +- .../stylesheets/framework/variables.scss | 1 - .../stylesheets/startup/startup-signin.scss | 7 +- .../resolvers/ci/runner_projects_resolver.rb | 15 +- .../concerns/resolves_merge_requests.rb | 1 + app/graphql/types/merge_request_type.rb | 4 + app/views/search/_results_list.html.haml | 4 +- app/views/search/_results_status.html.haml | 4 +- ...ance_external_audit_event_destinations.yml | 10 ++ ...tance_external_audit_event_destinations.rb | 14 ++ db/schema_migrations/20230406060452 | 1 + db/structure.sql | 24 +++ .../raketasks/service_desk_email.md | 2 +- doc/api/graphql/reference/index.md | 1 + doc/user/admin_area/settings/email.md | 9 +- .../settings/sign_in_restrictions.md | 2 +- doc/user/gitlab_com/index.md | 2 +- doc/user/project/service_desk.md | 71 +++++--- locale/gitlab.pot | 3 - package.json | 2 +- scripts/review_apps/base-config.yaml | 87 +++++++-- spec/frontend/admin/users/new_spec.js | 7 +- .../components/service_desk_root_spec.js | 2 +- .../prometheus_metrics/custom_metrics_spec.js | 6 +- .../prometheus_metrics_spec.js | 7 +- .../components/confidentiality_filter_spec.js | 35 +++- .../sidebar/components/status_filter_spec.js | 35 +++- .../ci/runner_projects_resolver_spec.rb | 26 ++- spec/graphql/types/merge_request_type_spec.rb | 4 +- .../gitlab/graphql/known_operations_spec.rb | 1 - .../graphql/tracers/metrics_tracer_spec.rb | 1 - .../graphql/tracers/timer_tracer_spec.rb | 2 - .../api/graphql/project/merge_request_spec.rb | 27 +++ .../graphql/project/merge_requests_spec.rb | 2 +- spec/services/clusters/create_service_spec.rb | 2 +- .../chunked_io_helpers.rb | 0 .../test_generation.rb | 166 ++++++++++++++++++ .../google_api/cloud_platform_helpers.rb | 106 +++++------ .../{ => helpers}/graphql/arguments.rb | 0 .../{ => helpers}/graphql/fake_query_type.rb | 1 + .../{ => helpers}/graphql/fake_tracer.rb | 0 .../{ => helpers}/graphql/field_inspection.rb | 0 .../{ => helpers}/graphql/field_selection.rb | 0 .../graphql/resolver_factories.rb | 0 .../action_cable/mock_action_cable.rb | 4 +- .../action_cable/mock_gitlab_schema.rb | 0 .../graphql/subscriptions/notes/helper.rb | 0 spec/support/{ => helpers}/graphql/var.rb | 0 .../{http_io => helpers}/http_io_helpers.rb | 4 +- .../migrations_helpers/cluster_helpers.rb | 0 .../migrations_helpers/namespaces_helper.rb | 15 ++ .../schema_version_finder.rb | 3 +- .../vulnerabilities_findings_helper.rb | 12 +- .../ci/partitioning_testing/cascade_check.rb | 2 +- .../partition_identifiers.rb | 0 .../ci/partitioning_testing/rspec_hooks.rb | 0 .../ci/partitioning_testing/schema_helpers.rb | 0 ...erge_request_without_merge_request_diff.rb | 2 +- .../prometheus/metric_builders.rb | 4 +- .../{redis => helpers}/redis_helpers.rb | 0 .../test_reports_helper.rb | 8 +- .../{trace => helpers}/trace_helpers.rb | 0 .../migrations_helpers/namespaces_helper.rb | 14 -- .../clusters/create_service_shared_context.rb | 19 ++ .../filter_timeout_shared_examples.rb | 0 .../reference_filter_shared_examples.rb | 10 +- ...ect_import_rate_limiter_shared_examples.rb | 0 ...metrics_instrumentation_shared_examples.rb | 0 .../additional_metrics_shared_examples.rb | 20 ++- .../access_control_ce_shared_examples.rb | 0 .../redis_new_instance_shared_examples.rb | 2 +- .../redis/redis_shared_examples.rb | 24 +-- .../create_service_shared_examples.rb} | 36 ---- .../services/deploy_token_shared_examples.rb | 6 +- .../import_csv_service_shared_examples.rb | 0 ...scription_quick_actions_shared_examples.rb | 0 ...able_import_csv_service_shared_examples.rb | 6 +- ...issuable_update_service_shared_examples.rb | 46 ++++- .../update_service_shared_examples.rb | 29 --- ...move_and_clone_services_shared_examples.rb | 0 ...e_to_ghost_user_service_shared_examples.rb | 4 +- .../service_response_shared_examples.rb | 8 +- yarn.lock | 45 +---- 95 files changed, 748 insertions(+), 352 deletions(-) create mode 100644 db/docs/audit_events_instance_external_audit_event_destinations.yml create mode 100644 db/migrate/20230406060452_create_instance_external_audit_event_destinations.rb create mode 100644 db/schema_migrations/20230406060452 rename spec/support/{chunked_io => helpers}/chunked_io_helpers.rb (100%) create mode 100644 spec/support/helpers/cycle_analytics_helpers/test_generation.rb rename spec/support/{ => helpers}/google_api/cloud_platform_helpers.rb (58%) rename spec/support/{ => helpers}/graphql/arguments.rb (100%) rename spec/support/{ => helpers}/graphql/fake_query_type.rb (99%) rename spec/support/{ => helpers}/graphql/fake_tracer.rb (100%) rename spec/support/{ => helpers}/graphql/field_inspection.rb (100%) rename spec/support/{ => helpers}/graphql/field_selection.rb (100%) rename spec/support/{ => helpers}/graphql/resolver_factories.rb (100%) rename spec/support/{ => helpers}/graphql/subscriptions/action_cable/mock_action_cable.rb (94%) rename spec/support/{ => helpers}/graphql/subscriptions/action_cable/mock_gitlab_schema.rb (100%) rename spec/support/{ => helpers}/graphql/subscriptions/notes/helper.rb (100%) rename spec/support/{ => helpers}/graphql/var.rb (100%) rename spec/support/{http_io => helpers}/http_io_helpers.rb (92%) rename spec/support/{ => helpers}/migrations_helpers/cluster_helpers.rb (100%) create mode 100644 spec/support/helpers/migrations_helpers/namespaces_helper.rb rename spec/support/{ => helpers}/migrations_helpers/schema_version_finder.rb (89%) rename spec/support/{ => helpers}/migrations_helpers/vulnerabilities_findings_helper.rb (92%) rename spec/support/{ => helpers}/models/ci/partitioning_testing/cascade_check.rb (90%) rename spec/support/{ => helpers}/models/ci/partitioning_testing/partition_identifiers.rb (100%) rename spec/support/{ => helpers}/models/ci/partitioning_testing/rspec_hooks.rb (100%) rename spec/support/{ => helpers}/models/ci/partitioning_testing/schema_helpers.rb (100%) rename spec/support/{ => helpers}/models/merge_request_without_merge_request_diff.rb (53%) rename spec/support/{ => helpers}/prometheus/metric_builders.rb (84%) rename spec/support/{redis => helpers}/redis_helpers.rb (100%) rename spec/support/{test_reports => helpers}/test_reports_helper.rb (96%) rename spec/support/{trace => helpers}/trace_helpers.rb (100%) delete mode 100644 spec/support/migrations_helpers/namespaces_helper.rb create mode 100644 spec/support/shared_contexts/services/clusters/create_service_shared_context.rb rename spec/support/{banzai => shared_examples/banzai/filters}/filter_timeout_shared_examples.rb (100%) rename spec/support/{banzai => shared_examples/banzai/filters}/reference_filter_shared_examples.rb (90%) rename spec/support/{ => shared_examples}/controllers/project_import_rate_limiter_shared_examples.rb (100%) rename spec/support/{gitlab/usage => shared_examples}/metrics_instrumentation_shared_examples.rb (100%) rename spec/support/{ => shared_examples}/prometheus/additional_metrics_shared_examples.rb (88%) rename spec/support/{ => shared_examples}/protected_tags/access_control_ce_shared_examples.rb (100%) rename spec/support/{ => shared_examples}/redis/redis_new_instance_shared_examples.rb (98%) rename spec/support/{ => shared_examples}/redis/redis_shared_examples.rb (95%) rename spec/support/{services/clusters/create_service_shared.rb => shared_examples/services/clusters/create_service_shared_examples.rb} (56%) rename spec/support/{ => shared_examples}/services/deploy_token_shared_examples.rb (93%) rename spec/support/{ => shared_examples}/services/import_csv_service_shared_examples.rb (100%) rename spec/support/{services => shared_examples/services/issuable}/issuable_description_quick_actions_shared_examples.rb (100%) rename spec/support/{services => shared_examples/services/issuable}/issuable_import_csv_service_shared_examples.rb (95%) rename spec/support/{services => shared_examples/services/issuable}/issuable_update_service_shared_examples.rb (66%) delete mode 100644 spec/support/shared_examples/services/issuable/update_service_shared_examples.rb rename spec/support/{ => shared_examples}/services/issues/move_and_clone_services_shared_examples.rb (100%) rename spec/support/{ => shared_examples}/services/migrate_to_ghost_user_service_shared_examples.rb (95%) rename spec/support/{ => shared_examples}/services/service_response_shared_examples.rb (75%) diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index 80ce947db8c..e58dd1780b9 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -1445,3 +1445,19 @@ ee/lib/ee/api/entities/project.rb @gitlab-org/manage/manage-workspace/backend-ap [Manage::Foundations] /lib/sidebars/ @gitlab-org/manage/foundations/engineering /ee/lib/sidebars/ @gitlab-org/manage/foundations/engineering + +# JiHu GitLab rules. See https://gitlab.com/gitlab-jh/gitlab-jh-enablement/-/issues/213#note_1024367528 + +[JH Frontend] @jihulab/maintainers/frontend +/jh/app/assets/ +/jh/*.scss +/jh/*.js +/jh/*.vue + +[JH Rails Backend] @jihulab/maintainers/rails-backend +/jh/*.rb +/jh/*.rake +/jh/qa/ @jihulab/maintainers/quality + +[JH Technical Writer] @jihulab/maintainers/technical-writer +/jh/doc/ diff --git a/.rubocop_todo/layout/empty_line_after_magic_comment.yml b/.rubocop_todo/layout/empty_line_after_magic_comment.yml index 021869e6885..0f6447df6ab 100644 --- a/.rubocop_todo/layout/empty_line_after_magic_comment.yml +++ b/.rubocop_todo/layout/empty_line_after_magic_comment.yml @@ -841,7 +841,7 @@ Layout/EmptyLineAfterMagicComment: - 'spec/services/wikis/create_attachment_service_spec.rb' - 'spec/support/fips.rb' - 'spec/support/generate-seed-repo-rb' - - 'spec/support/graphql/fake_query_type.rb' + - 'spec/support/helpers/graphql/fake_query_type.rb' - 'spec/support/helpers/fake_webauthn_device.rb' - 'spec/support/helpers/features/access_token_helpers.rb' - 'spec/support/helpers/features/iteration_helpers.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index b893cfbf038..8124f290c40 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -24badf7502c1864dc59e4f19bbebe53a1d36b638 +5660b156be328c7be18df892ccb7149fea21e491 diff --git a/app/assets/javascripts/projects/settings_service_desk/components/service_desk_root.vue b/app/assets/javascripts/projects/settings_service_desk/components/service_desk_root.vue index b79b3fa4573..79ece99e6ec 100644 --- a/app/assets/javascripts/projects/settings_service_desk/components/service_desk_root.vue +++ b/app/assets/javascripts/projects/settings_service_desk/components/service_desk_root.vue @@ -8,7 +8,7 @@ import ServiceDeskSetting from './service_desk_setting.vue'; export default { customEmailHelpPath: helpPagePath('/user/project/service_desk.html', { - anchor: 'using-a-custom-email-address', + anchor: 'use-a-custom-email-address', }), components: { GlAlert, diff --git a/app/assets/javascripts/projects/settings_service_desk/components/service_desk_setting.vue b/app/assets/javascripts/projects/settings_service_desk/components/service_desk_setting.vue index 85550e262e6..8af2e787740 100644 --- a/app/assets/javascripts/projects/settings_service_desk/components/service_desk_setting.vue +++ b/app/assets/javascripts/projects/settings_service_desk/components/service_desk_setting.vue @@ -102,12 +102,12 @@ export default { }, emailSuffixHelpUrl() { return helpPagePath('user/project/service_desk.html', { - anchor: 'configuring-a-custom-email-address-suffix', + anchor: 'configure-a-custom-email-address-suffix', }); }, customEmailAddressHelpUrl() { return helpPagePath('user/project/service_desk.html', { - anchor: 'using-a-custom-email-address', + anchor: 'use-a-custom-email-address', }); }, }, diff --git a/app/assets/javascripts/search/sidebar/components/app.vue b/app/assets/javascripts/search/sidebar/components/app.vue index 81a57e96b3c..317145d4cd1 100644 --- a/app/assets/javascripts/search/sidebar/components/app.vue +++ b/app/assets/javascripts/search/sidebar/components/app.vue @@ -25,6 +25,9 @@ export default { showBlobFilter() { return this.currentScope === SCOPE_BLOB; }, + showOldNavigation() { + return Boolean(this.currentScope); + }, }, }; diff --git a/app/assets/javascripts/search/sidebar/components/checkbox_filter.vue b/app/assets/javascripts/search/sidebar/components/checkbox_filter.vue index 08a943d58f8..feff3f77dd2 100644 --- a/app/assets/javascripts/search/sidebar/components/checkbox_filter.vue +++ b/app/assets/javascripts/search/sidebar/components/checkbox_filter.vue @@ -27,7 +27,7 @@ export default { }, }, computed: { - ...mapState(['query']), + ...mapState(['query', 'useNewNavigation']), ...mapGetters(['queryLanguageFilters']), dataFilters() { return Object.values(this.filtersData?.filters || []); @@ -69,7 +69,7 @@ export default {