root
/
gitlab-ce
mirror of https://gitlab.com/free-releases/gitlab-ce.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

fix transient test failures caused by wrong dropdown trigger

This commit is contained in:
Simon Knox 2017-08-28 15:03:33 +10:00
parent ef8eb3f6f7
commit bcd2135e08
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spec/features/snippets/notes_on_personal_snippets_spec.rb
View File

@ -91,7 +91,7 @@ describe 'Comments on personal snippets', :js do
context 'when editing a note' do context 'when editing a note' do
it 'changes the text' do it 'changes the text' do
find('.js-note-edit').click find('.js-note-edit').trigger('click')
page.within('.current-note-edit-form') do page.within('.current-note-edit-form') do
fill_in 'note[note]', with: 'new content' fill_in 'note[note]', with: 'new content'

2
spec/support/features/reportable_note_shared_examples.rb
View File

@ -34,7 +34,7 @@ shared_examples 'reportable note' do
end end
def open_dropdown(dropdown) def open_dropdown(dropdown)
dropdown.click dropdown.find('.more-actions-toggle').trigger('click')
dropdown.find('.dropdown-menu li', match: :first) dropdown.find('.dropdown-menu li', match: :first)
end end
end end

2
spec/support/helpers/note_interaction_helpers.rb
View File

@ -2,7 +2,7 @@ module NoteInteractionHelpers
def open_more_actions_dropdown(note) def open_more_actions_dropdown(note)
note_element = find("#note_#{note.id}") note_element = find("#note_#{note.id}")
note_element.find('.more-actions').click note_element.find('.more-actions-toggle').trigger('click')
note_element.find('.more-actions .dropdown-menu li', match: :first) note_element.find('.more-actions .dropdown-menu li', match: :first)
end end
end end