Merge branch 'remove-jquery-globals' into 'master'

Require jQuery to be explicitly imported

See merge request gitlab-org/gitlab-ce!17674

.eslintrc

@@ -1,6 +1,5 @@
 {
   "env": {
-    "jquery": true,
     "browser": true,
     "es6": true
   },

app/assets/javascripts/activities.js

@@ -1,5 +1,6 @@
 /* eslint-disable no-param-reassign, class-methods-use-this */
 
+import $ from 'jquery';
 import Cookies from 'js-cookie';
 import Pager from './pager';
 import { localTimeAgo } from './lib/utils/datetime_utility';

app/assets/javascripts/ajax_loading_spinner.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 export default class AjaxLoadingSpinner {
   static init() {
     const $elements = $('.js-ajax-loading-spinner');

app/assets/javascripts/api.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import _ from 'underscore';
 import axios from './lib/utils/axios_utils';
 

app/assets/javascripts/awards_handler.js

@@ -1,4 +1,6 @@
 /* eslint-disable class-methods-use-this */
+
+import $ from 'jquery';
 import _ from 'underscore';
 import Cookies from 'js-cookie';
 import { __ } from './locale';

app/assets/javascripts/behaviors/copy_as_gfm.js

@@ -1,5 +1,6 @@
 /* eslint-disable class-methods-use-this, object-shorthand, no-unused-vars, no-use-before-define, no-new, max-len, no-restricted-syntax, guard-for-in, no-continue */
 
+import $ from 'jquery';
 import _ from 'underscore';
 import { insertText, getSelectedFragment, nodeMatchesSelector } from '../lib/utils/common_utils';
 import { placeholderImage } from '../lazy_loader';

app/assets/javascripts/behaviors/copy_to_clipboard.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import Clipboard from 'clipboard';
 
 function showTooltip(target, title) {

app/assets/javascripts/behaviors/details_behavior.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 
 $(() => {
   $('body').on('click', '.js-details-target', function target() {

app/assets/javascripts/behaviors/quick_submit.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import '../commons/bootstrap';
 import { isInIssuePage } from '../lib/utils/common_utils';
 

app/assets/javascripts/behaviors/requires_input.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import _ from 'underscore';
 import '../commons/bootstrap';
 

app/assets/javascripts/behaviors/toggler_behavior.js

@@ -1,3 +1,6 @@
+import $ from 'jquery';
+import { getLocationHash } from '../lib/utils/url_utility';
+
 // Toggle button. Show/hide content inside parent container.
 // Button does not change visibility. If button has icon - it changes chevron style.
 //
@@ -5,7 +8,6 @@
 //   %button.js-toggle-button
 //   %div.js-toggle-content
 //
-import { getLocationHash } from '../lib/utils/url_utility';
 
 $(() => {
   function toggleContainer(container, toggleState) {

app/assets/javascripts/blob/blob_file_dropzone.js

@@ -1,4 +1,6 @@
 /* eslint-disable func-names, object-shorthand, prefer-arrow-callback */
+
+import $ from 'jquery';
 import Dropzone from 'dropzone';
 import { visitUrl } from '../lib/utils/url_utility';
 import { HIDDEN_CLASS } from '../lib/utils/constants';

app/assets/javascripts/blob/blob_fork_suggestion.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 const defaults = {
   // Buttons that will show the `suggestionSections`
   // has `data-fork-path`, and `data-action`

app/assets/javascripts/blob/file_template_mediator.js

@@ -1,4 +1,6 @@
 /* eslint-disable class-methods-use-this */
+
+import $ from 'jquery';
 import Flash from '../flash';
 import FileTemplateTypeSelector from './template_selectors/type_selector';
 import BlobCiYamlSelector from './template_selectors/ci_yaml_selector';

app/assets/javascripts/blob/file_template_selector.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 export default class FileTemplateSelector {
   constructor(mediator) {
     this.mediator = mediator;

app/assets/javascripts/blob/template_selector.js

@@ -1,5 +1,7 @@
 /* eslint-disable class-methods-use-this, no-unused-vars */
 
+import $ from 'jquery';
+
 export default class TemplateSelector {
   constructor({ dropdown, data, pattern, wrapper, editor, $input } = {}) {
     this.pattern = pattern;
@@ -76,7 +78,7 @@ export default class TemplateSelector {
 
     if (!skipFocus) this.editor.focus();
 
-    if (this.editor instanceof jQuery) {
+    if (this.editor instanceof $) {
       this.editor.get(0).dispatchEvent(this.autosizeUpdateEvent);
     }
   }

app/assets/javascripts/blob/viewer/index.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import Flash from '../../flash';
 import { handleLocationHash } from '../../lib/utils/common_utils';
 import axios from '../../lib/utils/axios_utils';

app/assets/javascripts/blob_edit/blob_bundle.js

@@ -1,5 +1,7 @@
 /* eslint-disable func-names, space-before-function-paren, prefer-arrow-callback, no-var, quotes, vars-on-top, no-unused-vars, no-new, max-len */
 /* global EditBlob */
+
+import $ from 'jquery';
 import NewCommitForm from '../new_commit_form';
 import EditBlob from './edit_blob';
 import BlobFileDropzone from '../blob/blob_file_dropzone';

app/assets/javascripts/blob_edit/edit_blob.js

@@ -1,5 +1,6 @@
 /* global ace */
 
+import $ from 'jquery';
 import axios from '~/lib/utils/axios_utils';
 import createFlash from '~/flash';
 import { __ } from '~/locale';

app/assets/javascripts/boards/components/board.js

@@ -1,4 +1,6 @@
 /* eslint-disable comma-dangle, space-before-function-paren, one-var */
+
+import $ from 'jquery';
 import Sortable from 'vendor/Sortable';
 import Vue from 'vue';
 import AccessorUtilities from '../../lib/utils/accessor';

app/assets/javascripts/boards/components/board_delete.js

@@ -1,5 +1,6 @@
 /* eslint-disable comma-dangle, space-before-function-paren, no-alert */
 
+import $ from 'jquery';
 import Vue from 'vue';
 
 window.gl = window.gl || {};

app/assets/javascripts/boards/components/board_new_issue.vue

@@ -1,4 +1,5 @@
 <script>
+import $ from 'jquery';
 import eventHub from '../eventhub';
 import ProjectSelect from './project_select.vue';
 import ListIssue from '../models/issue';

app/assets/javascripts/boards/components/board_sidebar.js

@@ -1,5 +1,6 @@
 /* eslint-disable comma-dangle, space-before-function-paren, no-new */
 
+import $ from 'jquery';
 import Vue from 'vue';
 import Flash from '../../flash';
 import { __ } from '../../locale';

app/assets/javascripts/boards/components/issue_card_inner.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import Vue from 'vue';
 import userAvatarLink from '../../vue_shared/components/user_avatar/user_avatar_link.vue';
 import eventHub from '../eventhub';

app/assets/javascripts/boards/components/new_list_dropdown.js

@@ -1,5 +1,6 @@
-/* eslint-disable func-names, no-new, space-before-function-paren, one-var,
-   promise/catch-or-return */
+/* eslint-disable func-names, no-new, space-before-function-paren, one-var, promise/catch-or-return, max-len */
+
+import $ from 'jquery';
 import axios from '~/lib/utils/axios_utils';
 import _ from 'underscore';
 import CreateLabelDropdown from '../../create_label';

app/assets/javascripts/boards/components/project_select.vue

@@ -1,5 +1,7 @@
 <script>
   /* global ListIssue */
+
+  import $ from 'jquery';
   import _ from 'underscore';
   import eventHub from '../eventhub';
   import loadingIcon from '../../vue_shared/components/loading_icon.vue';

app/assets/javascripts/boards/index.js

@@ -1,5 +1,6 @@
 /* eslint-disable one-var, quote-props, comma-dangle, space-before-function-paren */
 
+import $ from 'jquery';
 import _ from 'underscore';
 import Vue from 'vue';
 

app/assets/javascripts/boards/mixins/sortable_default_options.js

@@ -1,6 +1,7 @@
 /* eslint-disable no-unused-vars, no-mixed-operators, comma-dangle */
 /* global DocumentTouch */
 
+import $ from 'jquery';
 import sortableConfig from '../../sortable/sortable_config';
 
 window.gl = window.gl || {};

app/assets/javascripts/boards/stores/boards_store.js

@@ -1,5 +1,7 @@
 /* eslint-disable comma-dangle, space-before-function-paren, one-var, no-shadow, dot-notation, max-len */
 /* global List */
+
+import $ from 'jquery';
 import _ from 'underscore';
 import Cookies from 'js-cookie';
 import { getUrlParamsArray } from '~/lib/utils/common_utils';

app/assets/javascripts/branches/branches_delete_modal.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 const MODAL_SELECTOR = '#modal-delete-branch';
 
 class DeleteModal {

app/assets/javascripts/breadcrumb.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 export const addTooltipToEl = (el) => {
   const textEl = el.querySelector('.js-breadcrumb-item-text');
 

app/assets/javascripts/build_artifacts.js

@@ -1,4 +1,6 @@
 /* eslint-disable func-names, prefer-arrow-callback, no-return-assign */
+
+import $ from 'jquery';
 import { visitUrl } from './lib/utils/url_utility';
 import { convertPermissionToBoolean } from './lib/utils/common_utils';
 

app/assets/javascripts/build_variables.js

@@ -1,9 +1,9 @@
-/* eslint-disable func-names*/
+import $ from 'jquery';
 
 export default function handleRevealVariables() {
   $('.js-reveal-variables')
     .off('click')
-    .on('click', function () {
+    .on('click', function click() {
       $('.js-build-variables').toggle();
       $(this).hide();
     });

app/assets/javascripts/ci_variable_list/native_form_variable_list.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import VariableList from './ci_variable_list';
 
 // Used for the variable list on scheduled pipeline edit page

app/assets/javascripts/commit/image_file.js

@@ -1,5 +1,7 @@
 /* eslint-disable func-names, space-before-function-paren, wrap-iife, no-var, no-use-before-define, prefer-arrow-callback, no-else-return, consistent-return, prefer-template, quotes, one-var, one-var-declaration-per-line, no-unused-vars, no-return-assign, comma-dangle, quote-props, no-unused-expressions, no-sequences, object-shorthand, max-len */
 
+import $ from 'jquery';
+
 // Width where images must fits in, for 2-up this gets divided by 2
 const availWidth = 900;
 const viewModes = ['two-up', 'swipe'];

app/assets/javascripts/commit_merge_requests.js

@@ -1,5 +1,6 @@
 /* global Flash */
 
+import $ from 'jquery';
 import axios from './lib/utils/axios_utils';
 import { n__, s__ } from './locale';
 

app/assets/javascripts/commits.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import { pluralize } from './lib/utils/text_utility';
 import { localTimeAgo } from './lib/utils/datetime_utility';
 import Pager from './pager';

app/assets/javascripts/compare.js

@@ -1,4 +1,6 @@
 /* eslint-disable func-names, space-before-function-paren, wrap-iife, quotes, no-var, object-shorthand, consistent-return, no-unused-vars, comma-dangle, vars-on-top, prefer-template, max-len */
+
+import $ from 'jquery';
 import { localTimeAgo } from './lib/utils/datetime_utility';
 import axios from './lib/utils/axios_utils';
 

app/assets/javascripts/compare_autocomplete.js

@@ -1,4 +1,6 @@
 /* eslint-disable func-names, space-before-function-paren, one-var, no-var, one-var-declaration-per-line, object-shorthand, comma-dangle, prefer-arrow-callback, no-else-return, newline-per-chained-call, wrap-iife, max-len */
+
+import $ from 'jquery';
 import { __ } from './locale';
 import axios from './lib/utils/axios_utils';
 import flash from './flash';

app/assets/javascripts/confirm_danger_modal.js

@@ -1,4 +1,6 @@
 /* eslint-disable func-names, space-before-function-paren, wrap-iife, one-var, no-var, camelcase, one-var-declaration-per-line, no-else-return, max-len */
+
+import $ from 'jquery';
 import { rstrip } from './lib/utils/common_utils';
 
 window.ConfirmDangerModal = (function() {

app/assets/javascripts/contextual_sidebar.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import Cookies from 'js-cookie';
 import _ from 'underscore';
 import bp from './breakpoints';

app/assets/javascripts/create_label.js

@@ -1,4 +1,6 @@
 /* eslint-disable func-names, prefer-arrow-callback */
+
+import $ from 'jquery';
 import Api from './api';
 import { humanize } from './lib/utils/text_utility';
 

app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import Vue from 'vue';
 import Cookies from 'js-cookie';
 import Flash from '../flash';

app/assets/javascripts/diff.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import axios from '~/lib/utils/axios_utils';
 import flash from '~/flash';
 import { __ } from '~/locale';

app/assets/javascripts/diff_notes/components/comment_resolve_btn.js

@@ -1,6 +1,7 @@
 /* eslint-disable comma-dangle, object-shorthand, func-names, no-else-return, quotes, no-lonely-if, max-len */
 /* global CommentsStore */
 
+import $ from 'jquery';
 import Vue from 'vue';
 
 const CommentAndResolveBtn = Vue.extend({

app/assets/javascripts/diff_notes/components/diff_note_avatars.js

@@ -1,5 +1,6 @@
 /* global CommentsStore */
 
+import $ from 'jquery';
 import Vue from 'vue';
 import collapseIcon from '../icons/collapse_icon.svg';
 import Notes from '../../notes';

app/assets/javascripts/diff_notes/components/jump_to_discussion.js

@@ -2,6 +2,7 @@
 /* global DiscussionMixins */
 /* global CommentsStore */
 
+import $ from 'jquery';
 import Vue from 'vue';
 
 import '../mixins/discussion';

app/assets/javascripts/diff_notes/components/resolve_btn.js

@@ -2,6 +2,7 @@
 /* global CommentsStore */
 /* global ResolveService */
 
+import $ from 'jquery';
 import Vue from 'vue';
 import Flash from '../../flash';
 

app/assets/javascripts/diff_notes/diff_notes_bundle.js

@@ -1,6 +1,7 @@
 /* eslint-disable func-names, comma-dangle, new-cap, no-new, max-len */
 /* global ResolveCount */
 
+import $ from 'jquery';
 import Vue from 'vue';
 import './models/discussion';
 import './models/note';

app/assets/javascripts/diff_notes/models/discussion.js

@@ -1,6 +1,7 @@
 /* eslint-disable space-before-function-paren, camelcase, guard-for-in, no-restricted-syntax, no-unused-vars, max-len */
 /* global NoteModel */
 
+import $ from 'jquery';
 import Vue from 'vue';
 import { localTimeAgo } from '../../lib/utils/datetime_utility';
 

app/assets/javascripts/dispatcher.js

@@ -1,4 +1,6 @@
 /* eslint-disable func-names, space-before-function-paren, no-var, prefer-arrow-callback, wrap-iife, no-shadow, consistent-return, one-var, one-var-declaration-per-line, camelcase, default-case, no-new, quotes, no-duplicate-case, no-case-declarations, no-fallthrough, max-len */
+
+import $ from 'jquery';
 import Flash from './flash';
 import GfmAutoComplete from './gfm_auto_complete';
 import { convertPermissionToBoolean } from './lib/utils/common_utils';

app/assets/javascripts/dropzone_input.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import Dropzone from 'dropzone';
 import _ from 'underscore';
 import './preview_markdown';

app/assets/javascripts/due_date_select.js

@@ -1,5 +1,6 @@
 /* global dateFormat */
 
+import $ from 'jquery';
 import Pikaday from 'pikaday';
 import axios from './lib/utils/axios_utils';
 import { parsePikadayDate, pikadayToString } from './lib/utils/datefix';

app/assets/javascripts/environments/components/environment_stop.vue

@@ -3,6 +3,8 @@
   * Renders the stop "button" that allows stop an environment.
   * Used in environments table.
   */
+
+  import $ from 'jquery';
   import eventHub from '../event_hub';
   import loadingIcon from '../../vue_shared/components/loading_icon.vue';
   import tooltip from '../../vue_shared/directives/tooltip';

app/assets/javascripts/experimental_flags.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import Cookies from 'js-cookie';
 
 export default () => {

app/assets/javascripts/feature_highlight/feature_highlight.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import _ from 'underscore';
 import {
   getSelector,

app/assets/javascripts/feature_highlight/feature_highlight_helper.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import axios from '../lib/utils/axios_utils';
 import { __ } from '../locale';
 import Flash from '../flash';

app/assets/javascripts/filterable_list.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import _ from 'underscore';
 import axios from './lib/utils/axios_utils';
 

app/assets/javascripts/gfm_auto_complete.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import _ from 'underscore';
 import glRegexp from './lib/utils/regexp';
 import AjaxCache from './lib/utils/ajax_cache';

app/assets/javascripts/gl_dropdown.js

@@ -1,5 +1,7 @@
 /* eslint-disable func-names, no-underscore-dangle, space-before-function-paren, no-var, one-var, one-var-declaration-per-line, prefer-rest-params, max-len, vars-on-top, wrap-iife, no-unused-vars, quotes, no-shadow, no-cond-assign, prefer-arrow-callback, no-return-assign, no-else-return, camelcase, comma-dangle, no-lonely-if, guard-for-in, no-restricted-syntax, consistent-return, prefer-template, no-param-reassign, no-loop-func, no-mixed-operators */
 /* global fuzzaldrinPlus */
+
+import $ from 'jquery';
 import _ from 'underscore';
 import fuzzaldrinPlus from 'fuzzaldrin-plus';
 import axios from './lib/utils/axios_utils';
@@ -576,7 +578,7 @@ GitLabDropdown = (function() {
       for (var i = 0; i < html.length; i += 1) {
         var el = html[i];
 
-        if (el instanceof jQuery) {
+        if (el instanceof $) {
           el = el.get(0);
         }
 

app/assets/javascripts/gl_field_error.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 /**
  * This class overrides the browser's validation error bubbles, displaying custom
  * error messages for invalid fields instead. To begin validating any form, add the

app/assets/javascripts/gl_field_errors.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import GlFieldError from './gl_field_error';
 
 const customValidationFlag = 'gl-field-error-ignore';

app/assets/javascripts/gl_form.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import autosize from 'autosize';
 import GfmAutoComplete from './gfm_auto_complete';
 import dropzoneInput from './dropzone_input';

app/assets/javascripts/gpg_badges.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import { parseQueryStringIntoObject } from '~/lib/utils/common_utils';
 import axios from '~/lib/utils/axios_utils';
 import flash from '~/flash';

app/assets/javascripts/group.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 export default class Group {
   constructor() {
     this.groupPath = $('#group_path');

app/assets/javascripts/group_avatar.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 export default function groupAvatar() {
   $('.js-choose-group-avatar-button').on('click', function onClickGroupAvatar() {
     const form = $(this).closest('form');

app/assets/javascripts/group_label_subscription.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import axios from './lib/utils/axios_utils';
 import flash from './flash';
 import { __ } from './locale';

app/assets/javascripts/groups/components/app.vue

@@ -1,6 +1,7 @@
 <script>
 /* global Flash */
 
+import $ from 'jquery';
 import { s__ } from '~/locale';
 import loadingIcon from '~/vue_shared/components/loading_icon.vue';
 import modal from '~/vue_shared/components/modal.vue';

app/assets/javascripts/groups/groups_filterable_list.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import FilterableList from '~/filterable_list';
 import eventHub from './event_hub';
 import { normalizeHeaders, getParameterByName } from '../lib/utils/common_utils';

app/assets/javascripts/groups/transfer_dropdown.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 export default class TransferDropdown {
   constructor() {
     this.groupDropdown = $('.js-groups-dropdown');

app/assets/javascripts/groups_select.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import axios from './lib/utils/axios_utils';
 import Api from './api';
 import { normalizeHeaders } from './lib/utils/common_utils';

app/assets/javascripts/header.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import { highCountTrim } from '~/lib/utils/text_utility';
 
 /**

app/assets/javascripts/help/help.js

@@ -1,4 +1,7 @@
 // We will render the icons list here
+
+import $ from 'jquery';
+
 export default () => {
   if ($('#user-content-gitlab-icons').length > 0) {
     const $iconsHeader = $('#user-content-gitlab-icons');

app/assets/javascripts/how_to_merge.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 export default () => {
   const modal = $('#modal_merge_info');
 

app/assets/javascripts/image_diff/image_diff.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import imageDiffHelper from './helpers/index';
 import ImageBadge from './image_badge';
 import { isImageLoaded } from '../lib/utils/image_utility';

app/assets/javascripts/importer_status.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import _ from 'underscore';
 import { __, sprintf } from './locale';
 import axios from './lib/utils/axios_utils';

app/assets/javascripts/init_changes_dropdown.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import stickyMonitor from './lib/utils/sticky';
 
 export default (stickyTop) => {

app/assets/javascripts/init_labels.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import LabelManager from './label_manager';
 import GroupLabelSubscription from './group_label_subscription';
 import ProjectLabelSubscription from './project_label_subscription';

app/assets/javascripts/integrations/integration_settings_form.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import axios from '../lib/utils/axios_utils';
 import flash from '../flash';
 

app/assets/javascripts/issuable/auto_width_dropdown_select.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 let instanceCount = 0;
 
 class AutoWidthDropdownSelect {

app/assets/javascripts/issuable_bulk_update_actions.js

@@ -1,4 +1,6 @@
 /* eslint-disable comma-dangle, quotes, consistent-return, func-names, array-callback-return, space-before-function-paren, prefer-arrow-callback, max-len, no-unused-expressions, no-sequences, no-underscore-dangle, no-unused-vars, no-param-reassign */
+
+import $ from 'jquery';
 import _ from 'underscore';
 import axios from './lib/utils/axios_utils';
 import Flash from './flash';

app/assets/javascripts/issuable_bulk_update_sidebar.js

@@ -1,5 +1,6 @@
 /* eslint-disable class-methods-use-this, no-new */
 
+import $ from 'jquery';
 import IssuableBulkUpdateActions from './issuable_bulk_update_actions';
 import MilestoneSelect from './milestone_select';
 import issueStatusSelect from './issue_status_select';

app/assets/javascripts/issuable_context.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import Cookies from 'js-cookie';
 import bp from './breakpoints';
 import UsersSelect from './users_select';

app/assets/javascripts/issuable_form.js

@@ -1,6 +1,7 @@
 /* eslint-disable func-names, prefer-rest-params, wrap-iife, no-use-before-define, no-useless-escape, no-new, object-shorthand, no-unused-vars, comma-dangle, no-alert, consistent-return, no-else-return, prefer-template, one-var, one-var-declaration-per-line, curly, max-len */
 /* global GitLab */
 
+import $ from 'jquery';
 import Pikaday from 'pikaday';
 import Autosave from './autosave';
 import UsersSelect from './users_select';

app/assets/javascripts/issuable_index.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import axios from './lib/utils/axios_utils';
 import flash from './flash';
 import { __ } from './locale';

app/assets/javascripts/issue.js

@@ -1,4 +1,6 @@
 /* eslint-disable func-names, space-before-function-paren, no-var, prefer-rest-params, wrap-iife, one-var, no-underscore-dangle, one-var-declaration-per-line, object-shorthand, no-unused-vars, no-new, comma-dangle, consistent-return, quotes, dot-notation, quote-props, prefer-arrow-callback, max-len */
+
+import $ from 'jquery';
 import axios from './lib/utils/axios_utils';
 import { addDelimiter } from './lib/utils/text_utility';
 import flash from './flash';

app/assets/javascripts/issue_show/components/description.vue

@@ -1,4 +1,5 @@
 <script>
+  import $ from 'jquery';
   import animateMixin from '../mixins/animate';
   import TaskList from '../../task_list';
   import recaptchaModalImplementor from '../../vue_shared/mixins/recaptcha_modal_implementor';

app/assets/javascripts/issue_show/components/fields/description_template.vue

@@ -1,4 +1,5 @@
 <script>
+  import $ from 'jquery';
   import IssuableTemplateSelectors from '../../../templates/issuable_template_selectors';
 
   export default {

app/assets/javascripts/issue_status_select.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 export default function issueStatusSelect() {
   $('.js-issue-status').each((i, el) => {
     const fieldName = $(el).data('fieldName');

app/assets/javascripts/job.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import _ from 'underscore';
 import axios from './lib/utils/axios_utils';
 import { visitUrl } from './lib/utils/url_utility';

app/assets/javascripts/label_manager.js

@@ -1,4 +1,6 @@
 /* eslint-disable comma-dangle, class-methods-use-this, no-underscore-dangle, no-param-reassign, no-unused-vars, consistent-return, func-names, space-before-function-paren, max-len */
+
+import $ from 'jquery';
 import Sortable from 'vendor/Sortable';
 
 import flash from './flash';

app/assets/javascripts/labels.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 export default class Labels {
   constructor() {
     this.setSuggestedColor = this.setSuggestedColor.bind(this);

app/assets/javascripts/labels_select.js

@@ -1,6 +1,8 @@
 /* eslint-disable no-useless-return, func-names, space-before-function-paren, wrap-iife, no-var, no-underscore-dangle, prefer-arrow-callback, max-len, one-var, no-unused-vars, one-var-declaration-per-line, prefer-template, no-new, consistent-return, object-shorthand, comma-dangle, no-shadow, no-param-reassign, brace-style, vars-on-top, quotes, no-lonely-if, no-else-return, dot-notation, no-empty, no-return-assign, camelcase, prefer-spread */
 /* global Issuable */
 /* global ListLabel */
+
+import $ from 'jquery';
 import _ from 'underscore';
 import { __ } from './locale';
 import axios from './lib/utils/axios_utils';

app/assets/javascripts/layout_nav.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import ContextualSidebar from './contextual_sidebar';
 import initFlyOutNav from './fly_out_nav';
 

app/assets/javascripts/lib/utils/bootstrap_linked_tabs.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 /**
  * Linked Tabs
  *

app/assets/javascripts/lib/utils/common_utils.js

@@ -1,4 +1,4 @@
-import jQuery from 'jquery';
+import $ from 'jquery';
 import Cookies from 'js-cookie';
 import axios from './axios_utils';
 import { getLocationHash } from './url_utility';
@@ -142,7 +142,7 @@ export const isMetaClick = e => e.metaKey || e.ctrlKey || e.which === 2;
 
 export const scrollToElement = (element) => {
   let $el = element;
-  if (!(element instanceof jQuery)) {
+  if (!(element instanceof $)) {
     $el = $(element);
   }
   const top = $el.offset().top;

app/assets/javascripts/lib/utils/csrf.js

@@ -1,3 +1,5 @@
+import $ from 'jquery';
+
 /*
 This module provides easy access to the CSRF token and caches
 it for re-use. It also exposes some values commonly used in relation

app/assets/javascripts/lib/utils/datetime_utility.js

@@ -1,3 +1,4 @@
+import $ from 'jquery';
 import timeago from 'timeago.js';
 import dateFormat from 'vendor/date.format';
 import { pluralize } from './text_utility';

app/assets/javascripts/lib/utils/text_markdown.js

@@ -1,5 +1,7 @@
 /* eslint-disable import/prefer-default-export, func-names, space-before-function-paren, wrap-iife, no-var, no-param-reassign, no-cond-assign, quotes, one-var, one-var-declaration-per-line, operator-assignment, no-else-return, prefer-template, prefer-arrow-callback, no-empty, max-len, consistent-return, no-unused-vars, no-return-assign, max-len, vars-on-top */
 
+import $ from 'jquery';
+
 const textUtils = {};
 
 textUtils.selectedText = function(text, textarea) {

app/assets/javascripts/line_highlighter.js

@@ -1,5 +1,7 @@
 /* eslint-disable func-names, space-before-function-paren, no-var, prefer-rest-params, wrap-iife, no-use-before-define, no-underscore-dangle, no-param-reassign, prefer-template, quotes, comma-dangle, prefer-arrow-callback, consistent-return, one-var, one-var-declaration-per-line, no-else-return, max-len */
 
+import $ from 'jquery';
+
 // LineHighlighter
 //
 // Handles single- and multi-line selection and highlight for blob views.