diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 7f77f69c267..67ed227a284 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -284,315 +284,6 @@ Performance/Detect: RSpec/ContextWording: Enabled: false -# Offense count: 638 -# Cop supports --auto-correct. -RSpec/EmptyLineAfterLetBlock: - Enabled: true - Exclude: - - 'spec/config/object_store_settings_spec.rb' - - 'spec/controllers/boards/issues_controller_spec.rb' - - 'spec/controllers/groups/milestones_controller_spec.rb' - - 'spec/controllers/groups/settings/repository_controller_spec.rb' - - 'spec/controllers/import/gitlab_controller_spec.rb' - - 'spec/controllers/projects/forks_controller_spec.rb' - - 'spec/controllers/projects/logs_controller_spec.rb' - - 'spec/controllers/projects/notes_controller_spec.rb' - - 'spec/controllers/projects/protected_branches_controller_spec.rb' - - 'spec/controllers/projects/serverless/functions_controller_spec.rb' - - 'spec/controllers/projects/settings/repository_controller_spec.rb' - - 'spec/controllers/projects/variables_controller_spec.rb' - - 'spec/controllers/repositories/git_http_controller_spec.rb' - - 'spec/controllers/sent_notifications_controller_spec.rb' - - 'spec/features/admin/admin_mode/login_spec.rb' - - 'spec/features/atom/users_spec.rb' - - 'spec/features/markdown/metrics_spec.rb' - - 'spec/features/merge_request/user_comments_on_diff_spec.rb' - - 'spec/features/merge_request/user_customizes_merge_commit_message_spec.rb' - - 'spec/features/merge_request/user_merges_immediately_spec.rb' - - 'spec/features/merge_request/user_merges_when_pipeline_succeeds_spec.rb' - - 'spec/features/merge_request/user_posts_notes_spec.rb' - - 'spec/features/merge_request/user_resolves_wip_mr_spec.rb' - - 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb' - - 'spec/features/merge_request/user_sees_closing_issues_message_spec.rb' - - 'spec/features/merge_request/user_sees_discussions_spec.rb' - - 'spec/features/merge_request/user_sees_merge_request_pipelines_spec.rb' - - 'spec/features/merge_request/user_sees_pipelines_from_forked_project_spec.rb' - - 'spec/features/merge_request/user_sees_versions_spec.rb' - - 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb' - - 'spec/features/merge_request/user_tries_to_access_private_project_info_through_new_mr_spec.rb' - - 'spec/features/merge_request/user_views_diffs_file_by_file_spec.rb' - - 'spec/features/merge_request/user_views_diffs_spec.rb' - - 'spec/features/merge_requests/user_views_diffs_commit_spec.rb' - - 'spec/features/profiles/chat_names_spec.rb' - - 'spec/features/projects/classification_label_on_project_pages_spec.rb' - - 'spec/features/projects/commit/mini_pipeline_graph_spec.rb' - - 'spec/features/projects/files/user_browses_files_spec.rb' - - 'spec/features/projects/files/user_creates_directory_spec.rb' - - 'spec/features/projects/files/user_creates_files_spec.rb' - - 'spec/features/projects/files/user_deletes_files_spec.rb' - - 'spec/features/projects/files/user_replaces_files_spec.rb' - - 'spec/features/projects/import_export/export_file_spec.rb' - - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' - - 'spec/features/projects/pipelines/pipeline_spec.rb' - - 'spec/features/projects/wiki/user_views_wiki_pages_spec.rb' - - 'spec/finders/fork_targets_finder_spec.rb' - - 'spec/frontend/fixtures/merge_requests.rb' - - 'spec/graphql/features/authorization_spec.rb' - - 'spec/graphql/mutations/issues/update_spec.rb' - - 'spec/graphql/resolvers/commit_pipelines_resolver_spec.rb' - - 'spec/graphql/types/design_management/design_at_version_type_spec.rb' - - 'spec/graphql/types/snippet_type_spec.rb' - - 'spec/helpers/blame_helper_spec.rb' - - 'spec/helpers/groups_helper_spec.rb' - - 'spec/helpers/namespaces_helper_spec.rb' - - 'spec/lib/api/entities/nuget/dependency_group_spec.rb' - - 'spec/lib/api/entities/nuget/dependency_spec.rb' - - 'spec/lib/api/entities/nuget/metadatum_spec.rb' - - 'spec/lib/api/entities/nuget/search_result_spec.rb' - - 'spec/lib/banzai/filter/absolute_link_filter_spec.rb' - - 'spec/lib/banzai/filter/merge_request_reference_filter_spec.rb' - - 'spec/lib/banzai/issuable_extractor_spec.rb' - - 'spec/lib/banzai/object_renderer_spec.rb' - - 'spec/lib/banzai/pipeline/full_pipeline_spec.rb' - - 'spec/lib/container_registry/client_spec.rb' - - 'spec/lib/gitlab/alert_management/alert_params_spec.rb' - - 'spec/lib/gitlab/application_rate_limiter_spec.rb' - - 'spec/lib/gitlab/asciidoc/include_processor_spec.rb' - - 'spec/lib/gitlab/asciidoc_spec.rb' - - 'spec/lib/gitlab/auth/auth_finders_spec.rb' - - 'spec/lib/gitlab/auth/ldap/user_spec.rb' - - 'spec/lib/gitlab/auth/o_auth/auth_hash_spec.rb' - - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' - - 'spec/lib/gitlab/auth/request_authenticator_spec.rb' - - 'spec/lib/gitlab/auth/saml/user_spec.rb' - - 'spec/lib/gitlab/auth_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - - 'spec/lib/gitlab/background_migration/migrate_issue_trackers_sensitive_data_spec.rb' - - 'spec/lib/gitlab/background_migration_spec.rb' - - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - - 'spec/lib/gitlab/ci/ansi2html_spec.rb' - - 'spec/lib/gitlab/ci/config/entry/service_spec.rb' - - 'spec/lib/gitlab/ci/config/external/file/local_spec.rb' - - 'spec/lib/gitlab/ci/config/external/processor_spec.rb' - - 'spec/lib/gitlab/ci/pipeline/chain/validate/repository_spec.rb' - - 'spec/lib/gitlab/ci/reports/accessibility_reports_comparer_spec.rb' - - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - - 'spec/lib/gitlab/cleanup/remote_uploads_spec.rb' - - 'spec/lib/gitlab/cross_project_access/class_methods_spec.rb' - - 'spec/lib/gitlab/danger/commit_linter_spec.rb' - - 'spec/lib/gitlab/danger/roulette_spec.rb' - - 'spec/lib/gitlab/danger/teammate_spec.rb' - - 'spec/lib/gitlab/database/count/tablesample_count_strategy_spec.rb' - - 'spec/lib/gitlab/database/custom_structure_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - - 'spec/lib/gitlab/database/postgresql_adapter/force_disconnectable_mixin_spec.rb' - - 'spec/lib/gitlab/diff/file_collection/commit_spec.rb' - - 'spec/lib/gitlab/diff/file_collection/compare_spec.rb' - - 'spec/lib/gitlab/diff/file_collection/merge_request_diff_spec.rb' - - 'spec/lib/gitlab/diff/file_spec.rb' - - 'spec/lib/gitlab/diff/position_collection_spec.rb' - - 'spec/lib/gitlab/diff/suggestion_spec.rb' - - 'spec/lib/gitlab/email/message/repository_push_spec.rb' - - 'spec/lib/gitlab/encoding_helper_spec.rb' - - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb' - - 'spec/lib/gitlab/git/branch_spec.rb' - - 'spec/lib/gitlab/git/commit_spec.rb' - - 'spec/lib/gitlab/git/conflict/parser_spec.rb' - - 'spec/lib/gitlab/git/diff_spec.rb' - - 'spec/lib/gitlab/git/patches/collection_spec.rb' - - 'spec/lib/gitlab/git/patches/commit_patches_spec.rb' - - 'spec/lib/gitlab/git/patches/patch_spec.rb' - - 'spec/lib/gitlab/git/repository_spec.rb' - - 'spec/lib/gitlab/gitaly_client/commit_service_spec.rb' - - 'spec/lib/gitlab/gitaly_client/conflicts_service_spec.rb' - - 'spec/lib/gitlab/gitaly_client/operation_service_spec.rb' - - 'spec/lib/gitlab/gitaly_client/wiki_service_spec.rb' - - 'spec/lib/gitlab/gitlab_import/project_creator_spec.rb' - - 'spec/lib/gitlab/google_code_import/importer_spec.rb' - - 'spec/lib/gitlab/google_code_import/project_creator_spec.rb' - - 'spec/lib/gitlab/grape_logging/formatters/lograge_with_timestamp_spec.rb' - - 'spec/lib/gitlab/graphql/authorize/authorize_resource_spec.rb' - - 'spec/lib/gitlab/graphql/find_argument_in_parent_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb' - - 'spec/lib/gitlab/hook_data/issuable_builder_spec.rb' - - 'spec/lib/gitlab/import_export/base/object_builder_spec.rb' - - 'spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' - - 'spec/lib/gitlab/incident_management/pager_duty/incident_issue_description_spec.rb' - - 'spec/lib/gitlab/issuable_sorter_spec.rb' - - 'spec/lib/gitlab/jira_import/issue_serializer_spec.rb' - - 'spec/lib/gitlab/jira_import/metadata_collector_spec.rb' - - 'spec/lib/gitlab/kubernetes/network_policy_spec.rb' - - 'spec/lib/gitlab/language_detection_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/issuable_formatter_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/milestone_formatter_spec.rb' - - 'spec/lib/gitlab/lograge/custom_options_spec.rb' - - 'spec/lib/gitlab/markdown_cache/redis/store_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/finder_spec.rb' - - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' - - 'spec/lib/gitlab/phabricator_import/user_finder_spec.rb' - - 'spec/lib/gitlab/project_search_results_spec.rb' - - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' - - 'spec/lib/gitlab/prometheus_client_spec.rb' - - 'spec/lib/gitlab/sidekiq_cluster_spec.rb' - - 'spec/lib/gitlab/sidekiq_logging/structured_logger_spec.rb' - - 'spec/lib/gitlab/sidekiq_middleware_spec.rb' - - 'spec/lib/gitlab/url_blocker_spec.rb' - - 'spec/lib/gitlab/usage_data/topology_spec.rb' - - 'spec/lib/json_web_token/rsa_token_spec.rb' - - 'spec/lib/mattermost/session_spec.rb' - - 'spec/lib/omni_auth/strategies/jwt_spec.rb' - - 'spec/lib/rspec_flaky/example_spec.rb' - - 'spec/lib/rspec_flaky/flaky_example_spec.rb' - - 'spec/lib/rspec_flaky/flaky_examples_collection_spec.rb' - - 'spec/lib/rspec_flaky/listener_spec.rb' - - 'spec/lib/rspec_flaky/report_spec.rb' - - 'spec/lib/sentry/client/event_spec.rb' - - 'spec/lib/sentry/client/issue_spec.rb' - - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20190924152703_migrate_issue_trackers_data_spec.rb' - - 'spec/migrations/20200123155929_remove_invalid_jira_data_spec.rb' - - 'spec/migrations/20200127090233_remove_invalid_issue_tracker_data_spec.rb' - - 'spec/migrations/20200130145430_reschedule_migrate_issue_trackers_data_spec.rb' - - 'spec/migrations/migrate_k8s_service_integration_spec.rb' - - 'spec/migrations/remove_duplicate_labels_from_project_spec.rb' - - 'spec/migrations/remove_orphaned_invited_members_spec.rb' - - 'spec/models/ability_spec.rb' - - 'spec/models/alert_management/alert_spec.rb' - - 'spec/models/blob_viewer/composer_json_spec.rb' - - 'spec/models/blob_viewer/gemspec_spec.rb' - - 'spec/models/blob_viewer/go_mod_spec.rb' - - 'spec/models/blob_viewer/package_json_spec.rb' - - 'spec/models/blob_viewer/podspec_json_spec.rb' - - 'spec/models/blob_viewer/podspec_spec.rb' - - 'spec/models/blob_viewer/route_map_spec.rb' - - 'spec/models/ci/build_spec.rb' - - 'spec/models/ci/daily_build_group_report_result_spec.rb' - - 'spec/models/ci/pipeline_spec.rb' - - 'spec/models/clusters/platforms/kubernetes_spec.rb' - - 'spec/models/commit_collection_spec.rb' - - 'spec/models/commit_with_pipeline_spec.rb' - - 'spec/models/concerns/featurable_spec.rb' - - 'spec/models/concerns/issuable_spec.rb' - - 'spec/models/design_management/design_at_version_spec.rb' - - 'spec/models/merge_request_diff_commit_spec.rb' - - 'spec/models/merge_request_spec.rb' - - 'spec/models/namespace_spec.rb' - - 'spec/models/note_spec.rb' - - 'spec/models/pages_domain_spec.rb' - - 'spec/models/project_services/jira_service_spec.rb' - - 'spec/models/project_services/microsoft_teams_service_spec.rb' - - 'spec/models/project_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/models/snippet_repository_spec.rb' - - 'spec/models/wiki_page_spec.rb' - - 'spec/policies/design_management/design_policy_spec.rb' - - 'spec/policies/project_policy_spec.rb' - - 'spec/presenters/blob_presenter_spec.rb' - - 'spec/presenters/packages/detail/package_presenter_spec.rb' - - 'spec/requests/api/ci/runner_spec.rb' - - 'spec/requests/api/commits_spec.rb' - - 'spec/requests/api/deploy_keys_spec.rb' - - 'spec/requests/api/files_spec.rb' - - 'spec/requests/api/go_proxy_spec.rb' - - 'spec/requests/api/graphql/mutations/container_expiration_policy/update_spec.rb' - - 'spec/requests/api/graphql/mutations/discussions/toggle_resolve_spec.rb' - - 'spec/requests/api/graphql/mutations/merge_requests/create_spec.rb' - - 'spec/requests/api/graphql/mutations/notes/update/image_diff_note_spec.rb' - - 'spec/requests/api/graphql/mutations/snippets/update_spec.rb' - - 'spec/requests/api/graphql/project/container_expiration_policy_spec.rb' - - 'spec/requests/api/graphql/project/issue/designs/designs_spec.rb' - - 'spec/requests/api/graphql/project/issues_spec.rb' - - 'spec/requests/api/graphql/project/jira_import_spec.rb' - - 'spec/requests/api/graphql/project/repository_spec.rb' - - 'spec/requests/api/graphql/project/tree/tree_spec.rb' - - 'spec/requests/api/graphql/user_query_spec.rb' - - 'spec/requests/api/group_import_spec.rb' - - 'spec/requests/api/groups_spec.rb' - - 'spec/requests/api/helpers_spec.rb' - - 'spec/requests/api/internal/base_spec.rb' - - 'spec/requests/api/internal/pages_spec.rb' - - 'spec/requests/api/issues/get_group_issues_spec.rb' - - 'spec/requests/api/issues/get_project_issues_spec.rb' - - 'spec/requests/api/issues/issues_spec.rb' - - 'spec/requests/api/issues/post_projects_issues_spec.rb' - - 'spec/requests/api/notes_spec.rb' - - 'spec/requests/api/pages_domains_spec.rb' - - 'spec/requests/api/projects_spec.rb' - - 'spec/requests/api/snippets_spec.rb' - - 'spec/requests/groups/milestones_controller_spec.rb' - - 'spec/requests/lfs_http_spec.rb' - - 'spec/requests/rack_attack_global_spec.rb' - - 'spec/rubocop/cop/gitlab/finder_with_find_by_spec.rb' - - 'spec/rubocop/cop/rspec/any_instance_of_spec.rb' - - 'spec/serializers/accessibility_reports_comparer_entity_spec.rb' - - 'spec/serializers/accessibility_reports_comparer_serializer_spec.rb' - - 'spec/serializers/ci/daily_build_group_report_result_serializer_spec.rb' - - 'spec/serializers/commit_entity_spec.rb' - - 'spec/serializers/diff_file_base_entity_spec.rb' - - 'spec/serializers/environment_serializer_spec.rb' - - 'spec/serializers/import/bitbucket_provider_repo_entity_spec.rb' - - 'spec/serializers/import/bitbucket_server_provider_repo_entity_spec.rb' - - 'spec/serializers/import/fogbugz_provider_repo_entity_spec.rb' - - 'spec/serializers/paginated_diff_entity_spec.rb' - - 'spec/services/ci/create_pipeline_service_spec.rb' - - 'spec/services/ci/daily_build_group_report_result_service_spec.rb' - - 'spec/services/clusters/cleanup/project_namespace_service_spec.rb' - - 'spec/services/clusters/cleanup/service_account_service_spec.rb' - - 'spec/services/commits/commit_patch_service_spec.rb' - - 'spec/services/git/base_hooks_service_spec.rb' - - 'spec/services/git/process_ref_changes_service_spec.rb' - - 'spec/services/groups/group_links/create_service_spec.rb' - - 'spec/services/issuable/clone/content_rewriter_spec.rb' - - 'spec/services/merge_requests/conflicts/resolve_service_spec.rb' - - 'spec/services/merge_requests/create_service_spec.rb' - - 'spec/services/merge_requests/ff_merge_service_spec.rb' - - 'spec/services/merge_requests/rebase_service_spec.rb' - - 'spec/services/merge_requests/refresh_service_spec.rb' - - 'spec/services/merge_requests/squash_service_spec.rb' - - 'spec/services/metrics/dashboard/cluster_metrics_embed_service_spec.rb' - - 'spec/services/notes/create_service_spec.rb' - - 'spec/services/packages/create_dependency_service_spec.rb' - - 'spec/services/packages/npm/create_package_service_spec.rb' - - 'spec/services/pod_logs/elasticsearch_service_spec.rb' - - 'spec/services/preview_markdown_service_spec.rb' - - 'spec/services/projects/alerting/notify_service_spec.rb' - - 'spec/services/projects/fork_service_spec.rb' - - 'spec/services/projects/operations/update_service_spec.rb' - - 'spec/services/releases/create_service_spec.rb' - - 'spec/services/snippets/create_service_spec.rb' - - 'spec/services/snippets/update_service_spec.rb' - - 'spec/services/spam/spam_action_service_spec.rb' - - 'spec/services/spam/spam_verdict_service_spec.rb' - - 'spec/services/suggestions/create_service_spec.rb' - - 'spec/services/system_notes/design_management_service_spec.rb' - - 'spec/services/users/create_service_spec.rb' - - 'spec/services/web_hook_service_spec.rb' - - 'spec/services/wikis/create_attachment_service_spec.rb' - - 'spec/support/shared_contexts/finders/merge_requests_finder_shared_contexts.rb' - - 'spec/support/shared_contexts/policies/group_policy_shared_context.rb' - - 'spec/support/shared_examples/controllers/metrics/dashboard/prometheus_api_proxy_shared_examples.rb' - - 'spec/support/shared_examples/controllers/variables_shared_examples.rb' - - 'spec/support/shared_examples/graphql/design_fields_shared_examples.rb' - - 'spec/support/shared_examples/graphql/notes_on_noteables_shared_examples.rb' - - 'spec/support/shared_examples/models/chat_service_shared_examples.rb' - - 'spec/support/shared_examples/models/issuable_hook_data_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/milestones_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb' - - 'spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb' - - 'spec/support/shared_examples/services/wikis/create_attachment_service_shared_examples.rb' - - 'spec/tasks/gitlab/backup_rake_spec.rb' - - 'spec/tooling/lib/tooling/helm3_client_spec.rb' - - 'spec/uploaders/file_mover_spec.rb' - - 'spec/validators/qualified_domain_array_validator_spec.rb' - - 'spec/workers/pages_domain_ssl_renewal_cron_worker_spec.rb' - - 'spec/workers/remove_unreferenced_lfs_objects_worker_spec.rb' - - 'spec/workers/update_highest_role_worker_spec.rb' - # Offense count: 1121 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. diff --git a/app/assets/javascripts/error_tracking_settings/components/app.vue b/app/assets/javascripts/error_tracking_settings/components/app.vue index 34dff6c58d5..db90ac1c740 100644 --- a/app/assets/javascripts/error_tracking_settings/components/app.vue +++ b/app/assets/javascripts/error_tracking_settings/components/app.vue @@ -1,6 +1,6 @@