From c0e21fd75eeac758353b603172b14383f4c4626c Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 15 Aug 2024 18:10:49 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/gitlab/rails/safe_format.yml | 1 - .rubocop_todo/layout/line_length.yml | 1 - .rubocop_todo/rails/output_safety.yml | 1 - .rubocop_todo/style/format_string.yml | 1 - .rubocop_todo/style/if_unless_modifier.yml | 1 - .../components/pipeline_operations.vue | 6 +- .../components/pipeline_stop_modal.vue | 1 + .../javascripts/groups/group_name_rules.js | 13 ++ .../components/topics_token_selector.vue | 2 +- .../super_sidebar/super_sidebar_bundle.js | 9 +- .../vue_shared/components/markdown/field.vue | 2 +- app/helpers/reminder_emails_helper.rb | 77 ---------- app/mailers/emails/members.rb | 23 --- app/mailers/members/invite_reminder_mailer.rb | 132 ++++++++++++++++ app/mailers/notify.rb | 2 - .../members/invite_reminder_mailer_preview.rb | 23 +++ app/mailers/previews/notify_preview.rb | 2 +- app/models/member.rb | 5 +- app/models/repository.rb | 8 - .../ci/list_config_variables_service.rb | 15 +- app/services/notification_service.rb | 4 - app/views/groups/edit.html.haml | 2 +- app/views/groups/settings/_general.html.haml | 33 ++-- .../invite_reminder_mailer/email.html.haml | 12 ++ .../invite_reminder_mailer/email.text.erb | 13 ++ .../member_invited_reminder_email.html.haml | 9 -- .../member_invited_reminder_email.text.erb | 6 - app/views/projects/edit.html.haml | 6 +- .../projects/settings/_general.html.haml | 44 +++--- .../shared/_auto_devops_callout.html.haml | 2 +- app/views/shared/_captcha_check.html.haml | 2 +- app/views/shared/_divider.html.haml | 6 +- app/views/shared/_event_filter.html.haml | 2 +- app/views/shared/_file_highlight.html.haml | 2 +- app/views/shared/_ide_root.html.haml | 2 +- .../shared/_issuable_meta_data.html.haml | 8 +- app/views/shared/_label.html.haml | 6 +- app/views/shared/_label_full_path.html.haml | 2 +- app/views/shared/_label_row.html.haml | 2 +- app/views/shared/_md_preview.html.haml | 6 +- .../_merge_request_pipeline_status.html.haml | 4 +- app/views/shared/_milestones_filter.html.haml | 2 +- .../shared/_silent_mode_banner.html.haml | 2 +- app/views/shared/_web_ide_button.html.haml | 2 +- .../deploy_keys/_project_group_form.html.haml | 2 +- .../doorkeeper/applications/_form.html.haml | 2 +- .../doorkeeper/applications/_show.html.haml | 2 +- .../form_elements/_description.html.haml | 2 +- app/views/shared/groups/_group.html.haml | 12 +- app/views/shared/hook_logs/_content.html.haml | 4 +- app/views/shared/integrations/edit.html.haml | 2 +- .../_slack_integration_form.html.haml | 10 +- .../_installation_info.html.haml | 2 +- .../shared/integrations/overrides.html.haml | 2 +- app/views/shared/issuable/_nav.html.haml | 2 +- .../shared/issuable/_search_bar.html.haml | 10 +- app/views/shared/issuable/_sidebar.html.haml | 8 +- .../issuable/_sidebar_assignees.html.haml | 2 +- .../issuable/_sidebar_reviewers.html.haml | 2 +- .../_metadata_issuable_assignee.html.haml | 2 +- app/views/shared/labels/_form.html.haml | 4 +- app/views/shared/labels/_nav.html.haml | 2 +- app/views/shared/members/_member.html.haml | 4 +- .../members/tab_pane/_form_item.html.haml | 2 +- .../shared/members/tab_pane/_header.html.haml | 2 +- .../shared/members/tab_pane/_title.html.haml | 2 +- app/views/shared/milestones/_header.html.haml | 2 +- .../shared/milestones/_issuables.html.haml | 4 +- .../shared/milestones/_labels_tab.html.haml | 6 +- .../shared/milestones/_milestone.html.haml | 2 +- .../milestones/_participants_tab.html.haml | 4 +- .../shared/milestones/_sidebar.html.haml | 4 +- .../shared/notes/_comment_button.html.haml | 2 +- app/views/shared/notes/_form.html.haml | 4 +- app/views/shared/notes/_hints.html.haml | 12 +- app/views/shared/notes/_note.html.haml | 6 +- app/views/shared/projects/_dropdown.html.haml | 2 +- app/views/shared/projects/_list.html.haml | 2 +- app/views/shared/projects/_project.html.haml | 32 ++-- .../shared/projects/_project_card.html.haml | 8 +- .../shared/projects/_search_form.html.haml | 2 +- app/views/shared/projects/_topics.html.haml | 2 +- .../shared/runners/_runner_details.html.haml | 2 +- app/views/shared/snippets/_snippet.html.haml | 18 +-- app/views/shared/topics/_topic.html.haml | 2 +- .../shared/usage_quotas/_index.html.haml | 2 +- app/views/shared/web_hooks/_hook.html.haml | 2 +- app/views/shared/wikis/diff.html.haml | 2 +- app/views/shared/wikis/git_error.html.haml | 4 +- .../prompt_migration_refactor_code.yml} | 14 +- data/whats_new/202408150001_17_03.yml | 100 ++++++++++++ db/docs/ci_cost_settings.yml | 2 +- .../dedicated/configure_instance.md | 27 +++- doc/administration/internal_users.md | 13 +- doc/api/lint.md | 2 +- doc/ci/pipelines/cicd_minutes.md | 11 -- .../documentation/styleguide/word_list.md | 2 +- doc/editor_extensions/visual_studio/index.md | 4 +- doc/integration/ding_talk.md | 11 -- doc/topics/gitlab_flow.md | 11 -- .../api_security/api_discovery/index.md | 2 +- .../api_security/index.md | 2 +- doc/user/application_security/dast/index.md | 4 +- .../application_security/dast/proxy-based.md | 6 +- .../checks/application_information_check.md | 11 -- .../checks/authentication_token_check.md | 11 -- .../checks/cleartext_authentication_check.md | 11 -- .../dast_api/checks/cors_check.md | 11 -- .../dast_api/checks/dns_rebinding_check.md | 11 -- .../checks/framework_debug_mode_check.md | 11 -- .../checks/heartbleed_open_ssl_check.md | 11 -- .../dast_api/checks/html_injection_check.md | 11 -- .../dast_api/checks/index.md | 11 -- .../checks/insecure_http_methods_check.md | 11 -- .../dast_api/checks/json_hijacking_check.md | 11 -- .../dast_api/checks/json_injection_check.md | 11 -- .../dast_api/checks/open_redirect_check.md | 11 -- .../checks/os_command_injection_check.md | 11 -- .../dast_api/checks/path_traversal_check.md | 11 -- .../checks/sensitive_file_disclosure_check.md | 11 -- .../sensitive_information_disclosure_check.md | 11 -- .../dast_api/checks/session_cookie_check.md | 11 -- .../dast_api/checks/shellshock_check.md | 11 -- .../dast_api/checks/sql_injection_check.md | 11 -- .../checks/tls_server_configuration_check.md | 11 -- .../dast_api/checks/xml_external_entity.md | 11 -- .../dast_api/checks/xml_injection_check.md | 11 -- .../customizing_analyzer_settings.md | 11 -- .../configuration/enabling_the_analyzer.md | 11 -- .../dast_api/configuration/index.md | 11 -- .../configuration/offline_configuration.md | 11 -- .../configuration/overriding_analyzer_jobs.md | 11 -- .../dast_api/configuration/requirements.md | 11 -- .../dast_api/configuration/variables.md | 11 -- .../application_security/dast_api/index.md | 11 -- .../dast_api/performance.md | 11 -- .../dast_api/troubleshooting.md | 11 -- doc/user/application_security/index.md | 2 +- .../vulnerabilities/severities.md | 2 +- .../repository/code_suggestions/data.md | 11 -- .../ci/build/rules/rule/clause/exists.rb | 32 +--- lib/gitlab/git.rb | 4 +- lib/search/group_settings.rb | 2 +- lib/search/project_settings.rb | 2 +- locale/gitlab.pot | 34 ++++- public/robots.txt | 72 ++++++--- spec/factories/group_members.rb | 4 + .../projects/pipelines/pipelines_spec.rb | 37 ++++- .../components/markdown/field_spec.js | 142 +++++++++--------- .../ci/build/rules/rule/clause/exists_spec.rb | 8 - .../database/no_cross_db_foreign_keys_spec.rb | 53 ++++++- spec/lib/gitlab/git_spec.rb | 27 +--- .../members/invite_reminder_mailer_spec.rb | 98 ++++++++++++ spec/mailers/notify_spec.rb | 82 ---------- spec/mailers/previews_spec.rb | 6 +- spec/models/member_spec.rb | 27 +++- spec/models/repository_spec.rb | 46 ------ .../ci/create_pipeline_service/rules_spec.rb | 13 +- .../ci/list_config_variables_service_spec.rb | 4 +- spec/services/notification_service_spec.rb | 19 --- .../helpers/database/duplicate_indexes.yml | 3 - 161 files changed, 914 insertions(+), 1102 deletions(-) create mode 100644 app/assets/javascripts/groups/group_name_rules.js delete mode 100644 app/helpers/reminder_emails_helper.rb create mode 100644 app/mailers/members/invite_reminder_mailer.rb create mode 100644 app/mailers/previews/members/invite_reminder_mailer_preview.rb create mode 100644 app/views/members/invite_reminder_mailer/email.html.haml create mode 100644 app/views/members/invite_reminder_mailer/email.text.erb delete mode 100644 app/views/notify/member_invited_reminder_email.html.haml delete mode 100644 app/views/notify/member_invited_reminder_email.text.erb rename config/feature_flags/{gitlab_com_derisk/rules_exist_expand_globs_early.yml => experiment/prompt_migration_refactor_code.yml} (60%) create mode 100644 data/whats_new/202408150001_17_03.yml delete mode 100644 doc/ci/pipelines/cicd_minutes.md delete mode 100644 doc/integration/ding_talk.md delete mode 100644 doc/topics/gitlab_flow.md delete mode 100644 doc/user/application_security/dast_api/checks/application_information_check.md delete mode 100644 doc/user/application_security/dast_api/checks/authentication_token_check.md delete mode 100644 doc/user/application_security/dast_api/checks/cleartext_authentication_check.md delete mode 100644 doc/user/application_security/dast_api/checks/cors_check.md delete mode 100644 doc/user/application_security/dast_api/checks/dns_rebinding_check.md delete mode 100644 doc/user/application_security/dast_api/checks/framework_debug_mode_check.md delete mode 100644 doc/user/application_security/dast_api/checks/heartbleed_open_ssl_check.md delete mode 100644 doc/user/application_security/dast_api/checks/html_injection_check.md delete mode 100644 doc/user/application_security/dast_api/checks/index.md delete mode 100644 doc/user/application_security/dast_api/checks/insecure_http_methods_check.md delete mode 100644 doc/user/application_security/dast_api/checks/json_hijacking_check.md delete mode 100644 doc/user/application_security/dast_api/checks/json_injection_check.md delete mode 100644 doc/user/application_security/dast_api/checks/open_redirect_check.md delete mode 100644 doc/user/application_security/dast_api/checks/os_command_injection_check.md delete mode 100644 doc/user/application_security/dast_api/checks/path_traversal_check.md delete mode 100644 doc/user/application_security/dast_api/checks/sensitive_file_disclosure_check.md delete mode 100644 doc/user/application_security/dast_api/checks/sensitive_information_disclosure_check.md delete mode 100644 doc/user/application_security/dast_api/checks/session_cookie_check.md delete mode 100644 doc/user/application_security/dast_api/checks/shellshock_check.md delete mode 100644 doc/user/application_security/dast_api/checks/sql_injection_check.md delete mode 100644 doc/user/application_security/dast_api/checks/tls_server_configuration_check.md delete mode 100644 doc/user/application_security/dast_api/checks/xml_external_entity.md delete mode 100644 doc/user/application_security/dast_api/checks/xml_injection_check.md delete mode 100644 doc/user/application_security/dast_api/configuration/customizing_analyzer_settings.md delete mode 100644 doc/user/application_security/dast_api/configuration/enabling_the_analyzer.md delete mode 100644 doc/user/application_security/dast_api/configuration/index.md delete mode 100644 doc/user/application_security/dast_api/configuration/offline_configuration.md delete mode 100644 doc/user/application_security/dast_api/configuration/overriding_analyzer_jobs.md delete mode 100644 doc/user/application_security/dast_api/configuration/requirements.md delete mode 100644 doc/user/application_security/dast_api/configuration/variables.md delete mode 100644 doc/user/application_security/dast_api/index.md delete mode 100644 doc/user/application_security/dast_api/performance.md delete mode 100644 doc/user/application_security/dast_api/troubleshooting.md delete mode 100644 doc/user/project/repository/code_suggestions/data.md create mode 100644 spec/mailers/members/invite_reminder_mailer_spec.rb diff --git a/.rubocop_todo/gitlab/rails/safe_format.yml b/.rubocop_todo/gitlab/rails/safe_format.yml index 52b45e351a7..91893f755a6 100644 --- a/.rubocop_todo/gitlab/rails/safe_format.yml +++ b/.rubocop_todo/gitlab/rails/safe_format.yml @@ -13,7 +13,6 @@ Gitlab/Rails/SafeFormat: - 'app/helpers/merge_requests_helper.rb' - 'app/helpers/profiles_helper.rb' - 'app/helpers/projects_helper.rb' - - 'app/helpers/reminder_emails_helper.rb' - 'app/helpers/search_helper.rb' - 'app/helpers/sourcegraph_helper.rb' - 'app/helpers/whats_new_helper.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 0b9f56bc415..3cb145b0b6b 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -218,7 +218,6 @@ Layout/LineLength: - 'app/helpers/projects/security/configuration_helper.rb' - 'app/helpers/projects_helper.rb' - 'app/helpers/registrations_helper.rb' - - 'app/helpers/reminder_emails_helper.rb' - 'app/helpers/repository_languages_helper.rb' - 'app/helpers/routing/pseudonymization_helper.rb' - 'app/helpers/search_helper.rb' diff --git a/.rubocop_todo/rails/output_safety.yml b/.rubocop_todo/rails/output_safety.yml index def4e0d249d..55028aa9d7c 100644 --- a/.rubocop_todo/rails/output_safety.yml +++ b/.rubocop_todo/rails/output_safety.yml @@ -31,7 +31,6 @@ Rails/OutputSafety: - 'app/helpers/page_layout_helper.rb' - 'app/helpers/profiles_helper.rb' - 'app/helpers/projects_helper.rb' - - 'app/helpers/reminder_emails_helper.rb' - 'app/helpers/safe_format_helper.rb' - 'app/helpers/search_helper.rb' - 'app/helpers/sidebars_helper.rb' diff --git a/.rubocop_todo/style/format_string.yml b/.rubocop_todo/style/format_string.yml index 422f8c1951d..b42d44002be 100644 --- a/.rubocop_todo/style/format_string.yml +++ b/.rubocop_todo/style/format_string.yml @@ -44,7 +44,6 @@ Style/FormatString: - 'app/helpers/projects/project_members_helper.rb' - 'app/helpers/projects_helper.rb' - 'app/helpers/registrations_helper.rb' - - 'app/helpers/reminder_emails_helper.rb' - 'app/helpers/search_helper.rb' - 'app/helpers/ssh_keys_helper.rb' - 'app/helpers/tags_helper.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index 79ebcc59ad2..751851f8cd5 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -21,7 +21,6 @@ Style/IfUnlessModifier: - 'app/helpers/preferences_helper.rb' - 'app/helpers/projects_helper.rb' - 'app/helpers/releases_helper.rb' - - 'app/helpers/reminder_emails_helper.rb' - 'app/helpers/routing/artifacts_helper.rb' - 'app/helpers/search_helper.rb' - 'app/helpers/snippets_helper.rb' diff --git a/app/assets/javascripts/ci/pipelines_page/components/pipeline_operations.vue b/app/assets/javascripts/ci/pipelines_page/components/pipeline_operations.vue index 8945bb06862..82ba602ae32 100644 --- a/app/assets/javascripts/ci/pipelines_page/components/pipeline_operations.vue +++ b/app/assets/javascripts/ci/pipelines_page/components/pipeline_operations.vue @@ -30,6 +30,7 @@ export default { isCanceling: false, isRetrying: false, showConfirmationModal: false, + pipelineToCancel: this.pipeline, }; }, computed: { @@ -55,10 +56,11 @@ export default { this.isCanceling = true; this.showConfirmationModal = false; - this.$emit('cancel-pipeline', this.pipeline); + this.$emit('cancel-pipeline', this.pipelineToCancel); }, handleCancelClick() { this.showConfirmationModal = true; + this.pipelineToCancel = this.pipeline; this.trackClick('click_cancel_button'); }, @@ -79,7 +81,7 @@ export default {