From c1ce2b78fa7fa462d4c5789bd7a083dafea0e1a0 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 16 May 2024 06:14:41 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../release-environments/main.gitlab-ci.yml | 10 --- .rubocop.yml | 1 + .../layout/first_hash_element_indentation.yml | 13 ---- .../feature_flags/components/strategy.vue | 4 +- .../feature_flags/store/index/mutations.js | 5 +- .../list/components/issues_list_app.vue | 12 ++-- .../components/service_desk_list_app.vue | 14 ++--- app/assets/stylesheets/framework/tables.scss | 6 +- .../stylesheets/framework/variables.scss | 1 - .../page_bundles/merge_requests.scss | 2 +- .../admin/system_info_controller.rb | 10 +-- app/controllers/concerns/milestone_actions.rb | 24 ++++---- .../concerns/render_service_results.rb | 24 ++++---- .../concerns/sourcegraph_decorator.rb | 4 +- app/controllers/groups_controller.rb | 1 - app/controllers/projects/badges_controller.rb | 32 +++++----- app/controllers/projects/issues_controller.rb | 1 - .../repositories/lfs_locks_api_controller.rb | 6 +- app/finders/issuable_finder.rb | 19 +----- app/finders/issuables/assignee_filter.rb | 2 +- app/finders/issuables/author_filter.rb | 2 +- app/finders/issuables/base_filter.rb | 7 +-- app/finders/issuables/label_filter.rb | 2 +- .../mutations/notes/create/diff_note.rb | 8 +-- .../mutations/notes/create/image_diff_note.rb | 6 +- app/graphql/mutations/notes/create/note.rb | 6 +- .../resolvers/board_list_issues_resolver.rb | 2 +- app/graphql/resolvers/board_list_resolver.rb | 2 +- app/graphql/resolvers/board_lists_resolver.rb | 2 +- .../concerns/board_item_filterable.rb | 7 +-- .../resolvers/group_packages_resolver.rb | 6 +- app/graphql/resolvers/issues/base_resolver.rb | 13 ---- .../development/or_issuable_queries.yml | 8 --- .../active_record_database_tasks.rb | 39 ++++++++++++ .../initializers/active_record_migrations.rb | 22 +------ doc/api/graphql/reference/index.md | 14 ++--- doc/user/group/epics/manage_epics.md | 11 +--- doc/user/project/issues/managing_issues.md | 9 +-- lib/gitlab/database/migration.rb | 5 ++ .../migrations/migration_order_mixin.rb | 61 +++++++++++++++++++ .../database/migrations/milestone_mixin.rb | 15 ++++- lib/gitlab/database/migrations/version.rb | 15 +++-- .../tasks/database_tasks_spec.rb | 11 ++++ spec/features/groups/issues_spec.rb | 4 -- ..._users_dropdowns_in_issuables_list_spec.rb | 1 - .../filtered_search/dropdown_assignee_spec.rb | 4 -- .../filtered_search/dropdown_author_spec.rb | 1 - .../filtered_search/dropdown_base_spec.rb | 1 - .../filtered_search/dropdown_emoji_spec.rb | 1 - .../filtered_search/dropdown_hint_spec.rb | 5 +- .../filtered_search/dropdown_label_spec.rb | 1 - .../dropdown_milestone_spec.rb | 1 - .../filtered_search/dropdown_release_spec.rb | 1 - .../filtered_search/filter_issues_spec.rb | 1 - .../filtered_search/visual_tokens_spec.rb | 7 +-- spec/features/labels_hierarchy_spec.rb | 5 +- spec/finders/merge_requests_finder_spec.rb | 10 --- .../30000000000000_ordering_test_one.rb | 7 +++ .../30000000000001_ordering_test_two.rb | 7 +++ .../feature_flags/components/strategy_spec.js | 38 ++++++++++-- .../migrations/lock_retry_mixin_spec.rb | 4 +- .../migrations/milestone_mixin_spec.rb | 28 ++++++++- .../database/migrations/version_spec.rb | 53 ++++++++++------ .../boards/board_list_issues_query_spec.rb | 10 --- .../graphql/boards/board_lists_query_spec.rb | 17 ------ .../helpers/filtered_search_helpers.rb | 22 +++---- .../multiple_issue_boards_shared_examples.rb | 4 ++ .../finders/issues_finder_shared_examples.rb | 20 ------ .../api/graphql/issue_list_shared_examples.rb | 14 ----- 69 files changed, 375 insertions(+), 356 deletions(-) delete mode 100644 config/feature_flags/development/or_issuable_queries.yml create mode 100644 lib/gitlab/database/migrations/migration_order_mixin.rb create mode 100644 spec/config/initializers/active_record/tasks/database_tasks_spec.rb create mode 100644 spec/fixtures/migrations/db/migration_ordering/migrate/30000000000000_ordering_test_one.rb create mode 100644 spec/fixtures/migrations/db/migration_ordering/migrate/30000000000001_ordering_test_two.rb diff --git a/.gitlab/ci/release-environments/main.gitlab-ci.yml b/.gitlab/ci/release-environments/main.gitlab-ci.yml index 49e7070d664..b343fac9f60 100644 --- a/.gitlab/ci/release-environments/main.gitlab-ci.yml +++ b/.gitlab/ci/release-environments/main.gitlab-ci.yml @@ -18,10 +18,6 @@ stages: - GIT_DEPTH - GIT_STRATEGY -workflow: - auto_cancel: - on_new_commit: none - variables: GIT_DEPTH: 20 GIT_STRATEGY: fetch @@ -66,16 +62,11 @@ release-environments-deploy: variables: VERSIONS: "${VERSIONS}" ENVIRONMENT: "${ENVIRONMENT}" - before_script: - # Make sure pipelines run in order - # See https://docs.gitlab.com/ee/ci/resource_groups/index.html#change-the-process-mode - - curl --request PUT --data "process_mode=oldest_first" --header "PRIVATE-TOKEN:${ENVIRONMENT_API_TOKEN}" "https://gitlab.com/api/v4/projects/${CI_PROJECT_ID}/resource_groups/release-environment-${CI_COMMIT_REF_SLUG}" trigger: project: gitlab-com/gl-infra/release-environments branch: main strategy: depend needs: ["release-environments-deploy-env"] - resource_group: release-environment-${CI_COMMIT_REF_SLUG} release-environments-qa: stage: qa @@ -89,7 +80,6 @@ release-environments-qa: GITLAB_INITIAL_ROOT_PASSWORD: "${RELEASE_ENVIRONMENTS_ROOT_PASSWORD}" QA_PRAEFECT_REPOSITORY_STORAGE: "default" SIGNUP_DISABLED: "true" - resource_group: release-environment-${CI_COMMIT_REF_SLUG} release-environments-notification-failure: stage: finish diff --git a/.rubocop.yml b/.rubocop.yml index d120670a9b5..18a30c88ae4 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -934,6 +934,7 @@ Gitlab/NamespacedClass: - 'ee/db/**/*.rb' - 'ee/elastic/**/*.rb' - 'scripts/**/*' + - 'spec/fixtures/migrations/**/*.rb' - 'spec/migrations/**/*.rb' - 'app/experiments/**/*_experiment.rb' - 'ee/app/experiments/**/*_experiment.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index d98c41b9314..390be2bef4a 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -2,19 +2,6 @@ # Cop supports --autocorrect. Layout/FirstHashElementIndentation: Exclude: - - 'app/controllers/admin/system_info_controller.rb' - - 'app/controllers/concerns/milestone_actions.rb' - - 'app/controllers/concerns/render_service_results.rb' - - 'app/controllers/concerns/sourcegraph_decorator.rb' - - 'app/controllers/projects/badges_controller.rb' - - 'app/controllers/projects/merge_requests_controller.rb' - - 'app/controllers/repositories/lfs_locks_api_controller.rb' - - 'app/graphql/mutations/notes/create/diff_note.rb' - - 'app/graphql/mutations/notes/create/image_diff_note.rb' - - 'app/graphql/mutations/notes/create/note.rb' - - 'app/graphql/resolvers/ci/runner_projects_resolver.rb' - - 'app/graphql/resolvers/group_packages_resolver.rb' - - 'app/helpers/commits_helper.rb' - 'app/helpers/projects/project_members_helper.rb' - 'app/helpers/search_helper.rb' - 'app/helpers/ssh_keys_helper.rb' diff --git a/app/assets/javascripts/feature_flags/components/strategy.vue b/app/assets/javascripts/feature_flags/components/strategy.vue index 4594719a247..15723c466a4 100644 --- a/app/assets/javascripts/feature_flags/components/strategy.vue +++ b/app/assets/javascripts/feature_flags/components/strategy.vue @@ -2,7 +2,6 @@