Remove explicit `require` calls, and use `require_dependency` when needed

See
http://guides.rubyonrails.org/autoloading_and_reloading_constants.html
for more info.

Signed-off-by: Rémy Coutable <remy@rymai.me>
This commit is contained in:
Rémy Coutable 2017-03-13 14:07:38 +01:00
parent 32da760268
commit c5e34da01d
No known key found for this signature in database
GPG Key ID: 46DF07E5CD9E96AB
5 changed files with 6 additions and 13 deletions

View File

@ -1,5 +1,3 @@
require 'project_wiki'
class Projects::WikisController < Projects::ApplicationController class Projects::WikisController < Projects::ApplicationController
before_action :authorize_read_wiki! before_action :authorize_read_wiki!
before_action :authorize_create_wiki!, only: [:edit, :create, :history] before_action :authorize_create_wiki!, only: [:edit, :create, :history]

View File

@ -120,9 +120,9 @@ if Gitlab::Metrics.enabled?
# These are manually require'd so the classes are registered properly with # These are manually require'd so the classes are registered properly with
# ActiveSupport. # ActiveSupport.
require 'gitlab/metrics/subscribers/action_view' require_dependency 'gitlab/metrics/subscribers/action_view'
require 'gitlab/metrics/subscribers/active_record' require_dependency 'gitlab/metrics/subscribers/active_record'
require 'gitlab/metrics/subscribers/rails_cache' require_dependency 'gitlab/metrics/subscribers/rails_cache'
Gitlab::Application.configure do |config| Gitlab::Application.configure do |config|
config.middleware.use(Gitlab::Metrics::RackMiddleware) config.middleware.use(Gitlab::Metrics::RackMiddleware)

View File

@ -20,15 +20,12 @@ OmniAuth.config.before_request_phase do |env|
end end
if Gitlab.config.omniauth.enabled if Gitlab.config.omniauth.enabled
Gitlab.config.omniauth.providers.each do |provider| provider_names = Gitlab.config.omniauth.providers.map(&:name)
if provider['name'] == 'kerberos' require 'omniauth-kerberos' if provider_names.include?('kerberos')
require 'omniauth-kerberos'
end
end
end end
module OmniAuth module OmniAuth
module Strategies module Strategies
autoload :Bitbucket, Rails.root.join('lib', 'omniauth', 'strategies', 'bitbucket') autoload :Bitbucket, Rails.root.join('lib', 'omni_auth', 'strategies', 'bitbucket')
end end
end end

View File

@ -1,5 +1,3 @@
require 'gitlab/o_auth/user'
# LDAP extension for User model # LDAP extension for User model
# #
# * Find or create user from omniauth.auth data # * Find or create user from omniauth.auth data