From c72613147447f060da53873ba698133198cf416c Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 9 Sep 2022 00:10:07 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/frontend.gitlab-ci.yml | 2 +- .gitlab/ci/rules.gitlab-ci.yml | 11 +-- Gemfile | 2 +- Gemfile.lock | 8 ++- .../nav/components/top_nav_app.vue | 17 +++-- .../notes/components/note_header.vue | 13 +++- app/assets/stylesheets/framework/header.scss | 4 -- .../stylesheets/startup/startup-dark.scss | 3 - .../stylesheets/startup/startup-general.scss | 3 - .../projects/incidents_controller.rb | 1 + app/controllers/projects/issues_controller.rb | 1 + .../projects/merge_requests_controller.rb | 1 + app/views/layouts/nav/_top_nav.html.haml | 7 +- config/application.rb | 1 + config/environments/development.rb | 2 + .../development/new_navbar_layout.yml | 8 +++ .../development/remove_user_attributes.yml | 8 +++ config/initializers/lookbook.rb | 14 ---- doc/administration/troubleshooting/ssl.md | 10 +++ doc/ci/examples/deployment/index.md | 4 ++ .../end_to_end_testing_webdriverio/index.md | 1 + doc/ci/variables/index.md | 18 +++++ .../application_security/api_fuzzing/index.md | 69 +++++++++++++----- .../application_security/dast_api/index.md | 71 ++++++++++++++----- .../compliance/license_compliance/index.md | 14 ++++ lib/gitlab/nav/top_nav_view_model_builder.rb | 7 +- locale/gitlab.pot | 3 + .../project_archive_compare_spec.rb | 11 ++- .../discussion_comments/issue_spec.rb | 1 + .../discussion_comments/merge_request_spec.rb | 1 + .../markdown_references/jira_spec.rb | 2 + .../issues/resource_label_events_spec.rb | 1 + .../user_comments_on_diff_spec.rb | 1 + .../user_comments_on_merge_request_spec.rb | 1 + ...views_user_status_on_merge_request_spec.rb | 4 ++ .../profiles/user_edit_profile_spec.rb | 1 + .../nav/components/top_nav_app_spec.js | 5 +- spec/frontend/nav/mock_data.js | 2 +- .../notes/components/note_header_spec.js | 27 ++++++- spec/helpers/nav/top_nav_helper_spec.rb | 10 +-- ..._on_merge_request_files_shared_examples.rb | 4 ++ .../discussion_comments_shared_example.rb | 4 ++ 42 files changed, 285 insertions(+), 93 deletions(-) create mode 100644 config/feature_flags/development/new_navbar_layout.yml create mode 100644 config/feature_flags/development/remove_user_attributes.yml delete mode 100644 config/initializers/lookbook.rb diff --git a/.gitlab/ci/frontend.gitlab-ci.yml b/.gitlab/ci/frontend.gitlab-ci.yml index a4f21709a59..04bd44a24ae 100644 --- a/.gitlab/ci/frontend.gitlab-ci.yml +++ b/.gitlab/ci/frontend.gitlab-ci.yml @@ -247,7 +247,7 @@ coverage-frontend: extends: - .default-retry - .yarn-cache - - .frontend:rules:ee-mr-and-default-branch-only + - .frontend:rules:coverage-frontend needs: - job: "jest" optional: true diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index c5214b9e10b..754e623c5ad 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -839,13 +839,14 @@ - <<: *if-merge-request changes: *frontend-patterns-for-as-if-foss -.frontend:rules:ee-mr-and-default-branch-only: +.frontend:rules:coverage-frontend: rules: - <<: *if-not-ee when: never + - <<: *if-merge-request-labels-pipeline-revert + when: never - <<: *if-merge-request changes: *code-backstage-patterns - when: always - <<: *if-default-branch-refs changes: *code-backstage-patterns @@ -1374,12 +1375,12 @@ rules: - <<: *if-not-ee when: never + - <<: *if-merge-request-labels-pipeline-revert + when: never - <<: *if-merge-request changes: *code-backstage-patterns - when: always - <<: *if-default-branch-schedule-maintenance - <<: *if-merge-request-labels-run-all-rspec - when: always .rails:rules:rspec-undercoverage: rules: @@ -1419,6 +1420,8 @@ rules: - <<: *if-not-ee when: never + - <<: *if-merge-request-labels-pipeline-revert + when: never - if: '$SKIP_FLAKY_TESTS_AUTOMATICALLY == "true" || $RETRY_FAILED_TESTS_IN_NEW_PROCESS == "true"' changes: *code-backstage-patterns when: always diff --git a/Gemfile b/Gemfile index 5cb6aa6512e..156c85e8383 100644 --- a/Gemfile +++ b/Gemfile @@ -349,7 +349,7 @@ group :development do gem 'solargraph', '~> 0.46.0', require: false gem 'letter_opener_web', '~> 2.0.0' - gem 'lookbook' + gem 'lookbook', '~> 1.0' # Better errors handler gem 'better_errors', '~> 2.9.1' diff --git a/Gemfile.lock b/Gemfile.lock index 0f9a887fcbb..4c314e4d4af 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -815,9 +815,11 @@ GEM loofah (2.18.0) crass (~> 1.0.2) nokogiri (>= 1.5.9) - lookbook (0.9.3) + lookbook (1.0.3) actioncable + css_parser htmlbeautifier (~> 1.3) + htmlentities (~> 4.3.4) listen (~> 3.0) railties (>= 5.0) redcarpet (~> 3.5) @@ -1095,7 +1097,7 @@ GEM randexp (0.1.7) rash_alt (0.4.12) hashie (>= 3.4) - rb-fsevent (0.11.1) + rb-fsevent (0.11.2) rb-inotify (0.10.1) ffi (~> 1.0) rbtrace (0.4.14) @@ -1648,7 +1650,7 @@ DEPENDENCIES lockbox (~> 0.6.2) lograge (~> 0.5) loofah (~> 2.18.0) - lookbook + lookbook (~> 1.0) lru_redux mail (= 2.7.1) mail-smtp_pool (~> 0.1.0)! diff --git a/app/assets/javascripts/nav/components/top_nav_app.vue b/app/assets/javascripts/nav/components/top_nav_app.vue index 08a2c6952c8..ca6e6567f74 100644 --- a/app/assets/javascripts/nav/components/top_nav_app.vue +++ b/app/assets/javascripts/nav/components/top_nav_app.vue @@ -1,14 +1,18 @@