diff --git a/.gitlab/ci/cng/main.gitlab-ci.yml b/.gitlab/ci/cng/main.gitlab-ci.yml index 77e661ca726..806f7157b30 100644 --- a/.gitlab/ci/cng/main.gitlab-ci.yml +++ b/.gitlab/ci/cng/main.gitlab-ci.yml @@ -17,11 +17,6 @@ include: .build-cng-env: image: ${GITLAB_DEPENDENCY_PROXY_ADDRESS}ruby:${RUBY_VERSION}-slim-bookworm stage: prepare - needs: - # We need this job because we need its `cached-assets-hash.txt` artifact, so that we can pass the assets image tag to the downstream CNG pipeline. - # TODO: refactor to pass assets hash as environment variable to not download all of the actual assets needlessly - - pipeline: $PARENT_PIPELINE_ID - job: compile-production-assets variables: BUILD_ENV: build.env CNG_PROJECT_PATH: "${CI_PROJECT_NAMESPACE}/$[[ inputs.cng_path ]]" @@ -32,7 +27,6 @@ include: - install_gitlab_gem script: - 'ruby -r./scripts/trigger-build.rb -e "puts Trigger.variables_for_env_file(Trigger::CNG.new.variables)" > $BUILD_ENV' - - echo "GITLAB_ASSETS_TAG=$(assets_image_tag)" >> $BUILD_ENV - echo -e "section_start:`date +%s`:cng_var_setup_log[collapsed=true]\r\e[0KCNG Variables Script Log Output" - cat $CNG_VAR_SETUP_LOG_FILE - echo -e "section_end:`date +%s`:cng_var_setup_log\r\e[0K" @@ -58,6 +52,7 @@ include: GITLAB_VERSION: "${GITLAB_VERSION}" GITLAB_TAG: "${GITLAB_TAG}" GITLAB_ASSETS_TAG: "${GITLAB_ASSETS_TAG}" + COMPILE_ASSETS: "${COMPILE_ASSETS}" CE_PIPELINE: "${CE_PIPELINE}" # Based on https://docs.gitlab.com/ee/ci/jobs/job_control.html#check-if-a-variable-exists, `if: '$CE_PIPELINE'` will evaluate to `false` when this variable is empty EE_PIPELINE: "${EE_PIPELINE}" # Based on https://docs.gitlab.com/ee/ci/jobs/job_control.html#check-if-a-variable-exists, `if: '$EE_PIPELINE'` will evaluate to `false` when this variable is empty GITLAB_ELASTICSEARCH_INDEXER_VERSION: "${GITLAB_ELASTICSEARCH_INDEXER_VERSION}" diff --git a/.gitlab/ci/frontend.gitlab-ci.yml b/.gitlab/ci/frontend.gitlab-ci.yml index 9ebdf6b46b5..5fac7247bd5 100644 --- a/.gitlab/ci/frontend.gitlab-ci.yml +++ b/.gitlab/ci/frontend.gitlab-ci.yml @@ -43,10 +43,14 @@ compile-production-assets: - $GLCI_PRODUCTION_ASSETS_RUNNER_OPTIONAL variables: GLCI_BUILD_ASSETS_IMAGE: "true" + GLCI_ASSETS_TAG_ENV_FILE_PATH: "assets-tag-env.env" ARCH: linux/amd64,linux/arm64 before_script: - !reference [.compile-assets-base, before_script] - !reference [.buildx-setup, before_script] + after_script: + - source scripts/utils.sh + - echo "GLCI_ASSETS_IMAGE_TAG=$(assets_image_tag)" > $GLCI_ASSETS_TAG_ENV_FILE_PATH artifacts: name: webpack-report expire_in: 31d @@ -58,6 +62,8 @@ compile-production-assets: - public/assets/ - "${WEBPACK_COMPILE_LOG_PATH}" when: always + reports: + dotenv: $GLCI_ASSETS_TAG_ENV_FILE_PATH compile-production-assets as-if-foss: extends: diff --git a/.gitlab/ci/qa-common/omnibus.gitlab-ci.yml b/.gitlab/ci/qa-common/omnibus.gitlab-ci.yml index db9498d93bd..3f0f8a3ced8 100644 --- a/.gitlab/ci/qa-common/omnibus.gitlab-ci.yml +++ b/.gitlab/ci/qa-common/omnibus.gitlab-ci.yml @@ -91,7 +91,6 @@ trigger-omnibus: USE_SPECIFIED_RUBY_VERSION: "true" RUBY_VERSION: $FULL_RUBY_VERSION BUILD_ON_ALL_OS: $OMNIBUS_GITLAB_BUILD_ON_ALL_OS - SKIP_QA_TEST: "true" # Deprecated: It'll be removed once rolling out `inputs.skip_qa_test`. ee: $EE trigger: project: gitlab-org/build/omnibus-gitlab-mirror diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index e8297a1348b..8b01dd8019f 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -35,6 +35,7 @@ DYNAMIC_PIPELINE_YML: "${CI_PROJECT_DIR}/qa/tmp/test-on-omnibus-pipeline.yml" # yml files are generated by generate_e2e_pipelines task in qa/tasks/ci.rake PARENT_PIPELINE_ID: $CI_PIPELINE_ID # This is needed by trigger-omnibus-env and build-cng-env jobs QA_EXPORT_TEST_METRICS: "true" # Export test metrics directly to influxdb by default + GLCI_ASSETS_IMAGE_TAG: $GLCI_ASSETS_IMAGE_TAG inherit: variables: false trigger: diff --git a/.gitlab/ci/release-environments.gitlab-ci.yml b/.gitlab/ci/release-environments.gitlab-ci.yml index 41bad114f9d..7afdb1d227d 100644 --- a/.gitlab/ci/release-environments.gitlab-ci.yml +++ b/.gitlab/ci/release-environments.gitlab-ci.yml @@ -8,6 +8,8 @@ start-release-environments-security-pipeline: # as they cannot be overridden. See this issue for more context: # # https://gitlab.com/gitlab-org/gitlab/-/issues/387183 + needs: + - compile-production-assets inherit: variables: - RUBY_VERSION_DEFAULT @@ -18,8 +20,8 @@ start-release-environments-security-pipeline: # They need to be explicitly passed on to the child pipeline. # https://docs.gitlab.com/ci/pipelines/downstream_pipelines/#pass-yaml-defined-cicd-variables variables: - # This is needed by `release-environments-build-cng-env` (`.gitlab/ci/release-environments/security.gitlab-ci.yml`). - PARENT_PIPELINE_ID: $CI_PIPELINE_ID + # used by build-cng-env to pass assets image tag to downstream CNG build pipeline + GLCI_ASSETS_IMAGE_TAG: $GLCI_ASSETS_IMAGE_TAG trigger: strategy: depend include: diff --git a/app/assets/javascripts/work_items/components/work_item_development/work_item_create_branch_merge_request_modal.vue b/app/assets/javascripts/work_items/components/work_item_development/work_item_create_branch_merge_request_modal.vue index 9bc284483f6..093331a1f88 100644 --- a/app/assets/javascripts/work_items/components/work_item_development/work_item_create_branch_merge_request_modal.vue +++ b/app/assets/javascripts/work_items/components/work_item_development/work_item_create_branch_merge_request_modal.vue @@ -1,5 +1,5 @@