From cd9a4ce166af1a166d9445818da4ba1135c26aef Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 30 May 2024 18:15:18 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/CODEOWNERS | 1 + .rubocop_todo/gitlab/bounded_contexts.yml | 1 - .rubocop_todo/layout/argument_alignment.yml | 12 - GITALY_SERVER_VERSION | 2 +- .../admin/users/components/user_actions.vue | 2 +- .../components/recovery_codes.vue | 2 +- .../components/job_cells/job_cell.vue | 2 +- .../components/job_cells/pipeline_cell.vue | 2 +- .../header/components/header_badges.vue | 7 +- .../header/pipeline_header.vue | 3 - .../test_reports/test_case_details.vue | 12 +- app/assets/javascripts/constants.js | 18 + .../feature_flags/components/form.vue | 6 +- .../subgroups_and_projects_empty_state.vue | 2 +- .../groups/components/overview_tabs.vue | 2 +- .../components/related_merge_requests.vue | 2 +- .../components/workload_stats.vue | 2 +- .../action_buttons/action_button_group.vue | 2 +- .../members/components/members_tabs.vue | 6 +- .../components/table/member_actions.vue | 12 +- .../components/table/members_table_cell.vue | 10 +- app/assets/javascripts/members/constants.js | 8 +- .../javascripts/members/tabs_metadata.js | 12 +- .../packages_protection_rule_form.vue | 27 +- .../pages/groups/group_members/index.js | 12 +- .../pages/projects/project_members/index.js | 12 +- .../javascripts/profile/components/follow.vue | 2 +- .../components/custom_email_wrapper.vue | 2 +- .../components/related_issues_list.vue | 2 +- .../super_sidebar/components/flyout_menu.vue | 2 +- .../components/sectioned_percentage_bar.vue | 2 +- .../components/blob_viewers/simple_viewer.vue | 2 +- .../groups_list/groups_list_item.vue | 2 +- .../projects_list/projects_list_item.vue | 6 +- .../source_viewer/components/chunk_line.vue | 2 +- app/helpers/application_helper.rb | 6 +- app/helpers/events_helper.rb | 2 +- app/helpers/listbox_helper.rb | 11 +- app/helpers/merge_requests_helper.rb | 2 +- app/views/admin/users/_head.html.haml | 2 +- app/views/dashboard/todos/index.html.haml | 2 +- .../_signup_omniauth_provider_list.haml | 2 +- app/views/devise/shared/_tab_single.html.haml | 2 +- app/views/devise/shared/_tabs_ldap.html.haml | 2 +- .../profiles/two_factor_auths/show.html.haml | 2 +- .../issues/_related_branches.html.haml | 2 +- app/views/shared/projects/_topics.html.haml | 2 +- config/locales/doorkeeper.en.yml | 7 + .../temp_notes_backup.yml | 2 + ...tification_at_column_to_namespace_limit.rb | 9 + ...0527213416_drop_temp_notes_backup_table.rb | 16 + db/schema_migrations/20240516163929 | 1 + db/schema_migrations/20240527213416 | 1 + db/structure.sql | 40 +- .../install_infrastructure.md | 3 + doc/api/runners.md | 76 +++- .../pagination_performance_guidelines.md | 73 ++++ .../merge_request_widget_extensions.md | 10 +- doc/development/fe_guide/style/html.md | 2 +- doc/integration/oauth_provider.md | 1 + doc/user/ai_features.md | 37 +- doc/user/group/import/index.md | 4 + .../group/settings/group_access_tokens.md | 1 + .../package_protection_rules.md | 16 + doc/user/profile/personal_access_tokens.md | 1 + .../project/settings/project_access_tokens.md | 1 + .../lib/click_house/client/query.rb | 6 +- lib/api/ci/runners.rb | 13 +- lib/gitlab/auth.rb | 19 +- lib/gitlab/ci/yaml_processor/result.rb | 6 +- lib/gitlab/config/entry/node.rb | 6 +- lib/gitlab/conflict/file.rb | 6 +- lib/gitlab/cross_project_access.rb | 10 +- lib/gitlab/data_builder/push.rb | 12 +- lib/gitlab/database/consistency_checker.rb | 2 +- .../count/reltuples_count_strategy.rb | 2 +- .../database/load_balancing/configuration.rb | 4 +- .../load_balancing/service_discovery.rb | 2 +- lib/gitlab/database/migration_helpers.rb | 12 +- .../migrations/base_background_runner.rb | 8 +- .../detached_partition_dropper.rb | 12 +- lib/gitlab/gon_helper.rb | 3 + locale/gitlab.pot | 3 + .../admin/groups_controller_spec.rb | 2 +- spec/db/schema_spec.rb | 2 - .../user_creates_merge_request_spec.rb | 2 +- .../header/components/header_badges_spec.js | 22 +- .../approve_access_request_button_spec.js | 6 +- .../remove_group_link_button_spec.js | 6 +- .../remove_member_button_spec.js | 6 +- .../resend_invite_button_spec.js | 6 +- .../remove_member_dropdown_item_spec.js | 6 +- spec/frontend/members/components/app_spec.js | 10 +- .../filter_sort/filter_sort_container_spec.js | 6 +- .../members_filtered_search_bar_spec.js | 6 +- .../filter_sort/sort_dropdown_spec.js | 6 +- .../members/components/members_tabs_spec.js | 18 +- .../components/modals/leave_modal_spec.js | 6 +- .../modals/remove_group_link_modal_spec.js | 6 +- .../modals/remove_member_modal_spec.js | 6 +- .../table/expiration_datepicker_spec.js | 6 +- .../members/components/table/max_role_spec.js | 6 +- .../table/member_action_buttons_spec.js | 12 +- .../components/table/member_avatar_spec.js | 12 +- .../table/members_table_cell_spec.js | 10 +- .../components/table/members_table_spec.js | 6 +- spec/frontend/members/index_spec.js | 8 +- spec/frontend/members/mock_data.js | 4 +- spec/frontend/members/utils_spec.js | 4 +- .../__snapshots__/simple_viewer_spec.js.snap | 6 +- spec/helpers/application_helper_spec.rb | 2 +- spec/helpers/events_helper_spec.rb | 6 +- spec/helpers/listbox_helper_spec.rb | 17 +- spec/lib/gitlab/auth_spec.rb | 83 +++- ...move_notes_with_null_noteable_type_spec.rb | 4 +- spec/lib/gitlab/database/sharding_key_spec.rb | 2 - spec/requests/api/ci/runners_spec.rb | 371 +++++++++++++++++- spec/requests/openid_connect_spec.rb | 2 +- .../shared/groups/_dropdown.html.haml_spec.rb | 2 +- 119 files changed, 995 insertions(+), 355 deletions(-) rename db/docs/{ => deleted_tables}/temp_notes_backup.yml (80%) create mode 100644 db/migrate/20240516163929_add_all_seats_used_notification_at_column_to_namespace_limit.rb create mode 100644 db/post_migrate/20240527213416_drop_temp_notes_backup_table.rb create mode 100644 db/schema_migrations/20240516163929 create mode 100644 db/schema_migrations/20240527213416 diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index e8ab5174ce7..39aafe4120c 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -1405,6 +1405,7 @@ lib/gitlab/checks/** # Overrides for Verify. These files below require approval from teams outside Verify. /**/lib/**/ci/reports/**/ @gitlab-org/maintainers/rails-backend /**/lib/**/ci/parsers/**/ @gitlab-org/maintainers/rails-backend +/**/app/views/ci/**/ @gitlab-org/maintainers/rails-backend /ee/lib/gitlab/ci/parsers/license_compliance/ @gitlab-org/secure/composition-analysis-be /ee/lib/gitlab/ci/parsers/security/ @gitlab-org/govern/threat-insights-backend-team /ee/lib/gitlab/ci/reports/coverage_fuzzing/ @gitlab-org/secure/fuzzing-be diff --git a/.rubocop_todo/gitlab/bounded_contexts.yml b/.rubocop_todo/gitlab/bounded_contexts.yml index 1978bef1261..4faa2028c2e 100644 --- a/.rubocop_todo/gitlab/bounded_contexts.yml +++ b/.rubocop_todo/gitlab/bounded_contexts.yml @@ -2267,7 +2267,6 @@ Gitlab/BoundedContexts: - 'ee/app/experiments/issues_mrs_empty_state_experiment.rb' - 'ee/app/experiments/project_templates_during_registration_experiment.rb' - 'ee/app/experiments/signup_intent_step_one_experiment.rb' - - 'ee/app/experiments/trial_discover_page_experiment.rb' - 'ee/app/finders/app_sec/fuzzing/coverage/corpuses_finder.rb' - 'ee/app/finders/approval_rules/group_finder.rb' - 'ee/app/finders/audit_event_finder.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index 2bc42612ce9..2042f7634e1 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -180,19 +180,7 @@ Layout/ArgumentAlignment: - 'lib/api/entities/pull_mirror.rb' - 'lib/api/entities/release.rb' - 'lib/api/entities/resource_access_token.rb' - - 'lib/gitlab/ci/yaml_processor/result.rb' - - 'lib/gitlab/config/entry/node.rb' - 'lib/gitlab/config_checker/external_database_checker.rb' - - 'lib/gitlab/conflict/file.rb' - - 'lib/gitlab/cross_project_access.rb' - - 'lib/gitlab/data_builder/push.rb' - - 'lib/gitlab/database/consistency_checker.rb' - - 'lib/gitlab/database/count/reltuples_count_strategy.rb' - - 'lib/gitlab/database/load_balancing/configuration.rb' - - 'lib/gitlab/database/load_balancing/service_discovery.rb' - - 'lib/gitlab/database/migration_helpers.rb' - - 'lib/gitlab/database/migrations/base_background_runner.rb' - - 'lib/gitlab/database/partitioning/detached_partition_dropper.rb' - 'lib/gitlab/database/partitioning/partition_manager.rb' - 'lib/gitlab/database/partitioning/replace_table.rb' - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 8f2dd6f72d5..e62050253c8 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -5449172da31e92e636d7a04bf460e359bc44aa1b +42a2e519ca55a42f8cf420012b1f14af0830be59 diff --git a/app/assets/javascripts/admin/users/components/user_actions.vue b/app/assets/javascripts/admin/users/components/user_actions.vue index 97b29a9df28..578ca3b42a7 100644 --- a/app/assets/javascripts/admin/users/components/user_actions.vue +++ b/app/assets/javascripts/admin/users/components/user_actions.vue @@ -91,7 +91,7 @@ export default {