diff --git a/.rubocop_todo/graphql/resource_not_available_error.yml b/.rubocop_todo/graphql/resource_not_available_error.yml index 5a9d2f9b1a2..316cd4a99cb 100644 --- a/.rubocop_todo/graphql/resource_not_available_error.yml +++ b/.rubocop_todo/graphql/resource_not_available_error.yml @@ -40,4 +40,3 @@ Graphql/ResourceNotAvailableError: - 'ee/app/graphql/mutations/projects/set_locked.rb' - 'ee/app/graphql/resolvers/incident_management/oncall_shifts_resolver.rb' - 'ee/app/graphql/resolvers/product_analytics/visualization_resolver.rb' - - 'ee/app/graphql/resolvers/remote_development/workspaces_resolver.rb' diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml index 870cb7a1989..19b93eaad6d 100644 --- a/.rubocop_todo/rspec/before_all_role_assignment.yml +++ b/.rubocop_todo/rspec/before_all_role_assignment.yml @@ -149,7 +149,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/features/projects/wiki/user_views_wiki_empty_spec.rb' - 'ee/spec/features/projects_spec.rb' - 'ee/spec/features/protected_branches_spec.rb' - - 'ee/spec/features/remote_development/workspaces_spec.rb' - 'ee/spec/features/search/user_searches_for_epics_spec.rb' - 'ee/spec/features/search/zoekt/search_spec.rb' - 'ee/spec/features/subscriptions/expiring_subscription_message_spec.rb' @@ -360,7 +359,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/policies/merge_requests/external_status_check_policy_spec.rb' - 'ee/spec/policies/packages/policies/project_policy_spec.rb' - 'ee/spec/policies/project_policy_spec.rb' - - 'ee/spec/policies/remote_development/workspace_policy_spec.rb' - 'ee/spec/policies/requirements_management/requirement_policy_spec.rb' - 'ee/spec/policies/resource_iteration_event_policy_spec.rb' - 'ee/spec/policies/resource_weight_event_policy_spec.rb' @@ -465,8 +463,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/requests/api/graphql/mutations/projects/set_compliance_framework_spec.rb' - 'ee/spec/requests/api/graphql/mutations/releases/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/remote_development/workspaces/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/remote_development/workspaces/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/requirements_management/create_requirement_spec.rb' - 'ee/spec/requests/api/graphql/mutations/requirements_management/export_requirements_spec.rb' - 'ee/spec/requests/api/graphql/mutations/requirements_management/update_requirement_spec.rb' diff --git a/app/assets/javascripts/members/components/table/members_table.vue b/app/assets/javascripts/members/components/table/members_table.vue index c973d58fcd2..f6fd84c46cb 100644 --- a/app/assets/javascripts/members/components/table/members_table.vue +++ b/app/assets/javascripts/members/components/table/members_table.vue @@ -127,10 +127,15 @@ export default { }, actionsFieldTdClass(value, key, member) { if (this.hasActionButtons(member)) { - return 'col-actions'; + return ['col-actions', 'gl-vertical-align-middle!']; } - return ['col-actions', 'gl-display-none!', 'gl-lg-display-table-cell!']; + return [ + 'col-actions', + 'gl-display-none!', + 'gl-lg-display-table-cell!', + 'gl-vertical-align-middle!', + ]; }, tbodyTrAttr(member) { return { diff --git a/app/assets/javascripts/members/constants.js b/app/assets/javascripts/members/constants.js index 8e5b88d362e..e1f7e81d831 100644 --- a/app/assets/javascripts/members/constants.js +++ b/app/assets/javascripts/members/constants.js @@ -32,12 +32,13 @@ export const FIELDS = [ asc: 'name_asc', desc: 'name_desc', }, + tdClass: 'gl-vertical-align-middle!', }, { key: FIELD_KEY_SOURCE, label: __('Source'), thClass: 'col-meta', - tdClass: 'col-meta', + tdClass: 'col-meta gl-vertical-align-middle!', }, { key: FIELD_KEY_GRANTED, @@ -46,24 +47,25 @@ export const FIELDS = [ asc: 'last_joined', desc: 'oldest_joined', }, + tdClass: 'gl-vertical-align-middle!', }, { key: FIELD_KEY_INVITED, label: __('Invited'), thClass: 'col-meta', - tdClass: 'col-meta', + tdClass: 'col-meta gl-vertical-align-middle!', }, { key: FIELD_KEY_REQUESTED, label: __('Requested'), thClass: 'col-meta', - tdClass: 'col-meta', + tdClass: 'col-meta gl-vertical-align-middle!', }, { key: FIELD_KEY_MAX_ROLE, label: __('Max role'), thClass: 'col-max-role', - tdClass: 'col-max-role', + tdClass: 'col-max-role gl-vertical-align-middle!', sort: { asc: 'access_level_asc', desc: 'access_level_desc', @@ -73,13 +75,13 @@ export const FIELDS = [ key: FIELD_KEY_EXPIRATION, label: __('Expiration'), thClass: 'col-expiration', - tdClass: 'col-expiration', + tdClass: 'col-expiration gl-vertical-align-middle!', }, { key: FIELD_KEY_ACTIVITY, label: s__('Members|Activity'), thClass: 'col-activity', - tdClass: 'col-activity', + tdClass: 'col-activity gl-vertical-align-middle!', }, { key: FIELD_KEY_USER_CREATED_AT, diff --git a/app/assets/javascripts/super_sidebar/components/frequent_items_list.vue b/app/assets/javascripts/super_sidebar/components/frequent_items_list.vue index 02adebc50af..342e1284e86 100644 --- a/app/assets/javascripts/super_sidebar/components/frequent_items_list.vue +++ b/app/assets/javascripts/super_sidebar/components/frequent_items_list.vue @@ -105,7 +105,6 @@ export default { icon="dash" :aria-label="$options.i18n.removeItem" :title="$options.i18n.removeItem" - class="gl-align-self-center gl-mr-2" data-testid="item-remove" @click.stop.prevent="handleItemRemove(item)" /> diff --git a/app/assets/javascripts/super_sidebar/components/items_list.vue b/app/assets/javascripts/super_sidebar/components/items_list.vue index 7d5af883651..764db490751 100644 --- a/app/assets/javascripts/super_sidebar/components/items_list.vue +++ b/app/assets/javascripts/super_sidebar/components/items_list.vue @@ -19,13 +19,7 @@ export default {