From d111e00680d2b3e46a7ee37af5499407c4a93a22 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 6 Jul 2023 06:08:29 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../graphql/resource_not_available_error.yml | 1 - .../rspec/before_all_role_assignment.yml | 4 - .../components/table/members_table.vue | 9 +- app/assets/javascripts/members/constants.js | 14 +- .../components/frequent_items_list.vue | 1 - .../super_sidebar/components/items_list.vue | 9 +- .../super_sidebar/components/menu_section.vue | 10 +- .../super_sidebar/components/nav_item.vue | 18 +-- app/controllers/projects/pages_controller.rb | 10 -- app/graphql/mutations/environments/create.rb | 5 + app/graphql/mutations/environments/update.rb | 5 + app/graphql/types/environment_type.rb | 3 + app/models/ci/build_trace_chunk.rb | 2 +- app/models/environment.rb | 10 +- app/services/environments/create_service.rb | 2 +- app/services/environments/update_service.rb | 2 +- app/views/projects/edit.html.haml | 10 +- app/views/projects/pages/new.html.haml | 8 +- app/views/projects/pages/show.html.haml | 2 +- .../show_pages_in_deployments_menu.yml | 8 - config/initializers/sidekiq.rb | 2 +- ..._push_notified_unique_projects_monthly.yml | 25 +++ ...t_push_notified_unique_projects_weekly.yml | 25 +++ ...rnetes_namespace_column_to_environments.rb | 17 ++ db/schema_migrations/20230701195315 | 1 + db/structure.sql | 4 +- doc/.vale/gitlab/FirstPerson.yml | 3 - .../monitoring/prometheus/gitlab_metrics.md | 2 +- doc/administration/pages/index.md | 5 +- doc/api/graphql/reference/index.md | 3 + .../documentation/styleguide/word_list.md | 6 +- doc/development/feature_flags/index.md | 24 ++- doc/development/internal_api/index.md | 1 + .../index.md | 28 +--- .../lets_encrypt_integration.md | 15 +- .../getting_started/pages_ci_cd_template.md | 4 +- .../pages_forked_sample_project.md | 4 +- .../getting_started/pages_from_scratch.md | 4 +- .../pages_new_project_template.md | 4 +- .../project/pages/getting_started/pages_ui.md | 4 +- doc/user/project/pages/index.md | 7 - doc/user/project/pages/introduction.md | 7 +- lib/api/internal/kubernetes.rb | 4 +- .../sidekiq_logging/structured_logger.rb | 2 + lib/gitlab/sidekiq_middleware.rb | 4 +- lib/gitlab/sidekiq_middleware/defer_jobs.rb | 89 ----------- lib/gitlab/sidekiq_middleware/skip_jobs.rb | 125 +++++++++++++++ .../known_events/kubernetes_agent.yml | 4 + .../projects/menus/deployments_menu.rb | 9 +- lib/sidebars/projects/menus/settings_menu.rb | 18 --- locale/gitlab.pot | 3 + .../2_plan/pages/new_static_page_spec.rb | 9 +- spec/features/projects/navbar_spec.rb | 6 +- .../pages/user_edits_settings_spec.rb | 40 +++-- .../user_searches_in_settings_spec.rb | 11 -- .../components/table/members_table_spec.js | 2 + .../version_resolver_spec.rb | 3 +- .../lib/gitlab/database/health_status_spec.rb | 4 +- .../sidekiq_logging/structured_logger_spec.rb | 17 +- .../sidekiq_middleware/defer_jobs_spec.rb | 95 ----------- .../sidekiq_middleware/server_metrics_spec.rb | 2 +- .../sidekiq_middleware/skip_jobs_spec.rb | 151 ++++++++++++++++++ spec/lib/gitlab/sidekiq_middleware_spec.rb | 11 +- .../projects/menus/deployments_menu_spec.rb | 26 +++ .../projects/menus/settings_menu_spec.rb | 30 ---- spec/models/environment_spec.rb | 2 + spec/requests/api/internal/kubernetes_spec.rb | 3 +- .../environments/create_service_spec.rb | 3 +- .../environments/update_service_spec.rb | 15 ++ spec/spec_helper.rb | 2 +- .../structured_logger_shared_context.rb | 7 + spec/views/projects/edit.html.haml_spec.rb | 22 +-- 72 files changed, 582 insertions(+), 465 deletions(-) delete mode 100644 config/feature_flags/experiment/show_pages_in_deployments_menu.yml create mode 100644 config/metrics/counts_28d/20230630153556_flux_git_push_notified_unique_projects_monthly.yml create mode 100644 config/metrics/counts_7d/20230630153554_flux_git_push_notified_unique_projects_weekly.yml create mode 100644 db/migrate/20230701195315_add_kubernetes_namespace_column_to_environments.rb create mode 100644 db/schema_migrations/20230701195315 delete mode 100644 lib/gitlab/sidekiq_middleware/defer_jobs.rb create mode 100644 lib/gitlab/sidekiq_middleware/skip_jobs.rb delete mode 100644 spec/lib/gitlab/sidekiq_middleware/defer_jobs_spec.rb create mode 100644 spec/lib/gitlab/sidekiq_middleware/skip_jobs_spec.rb diff --git a/.rubocop_todo/graphql/resource_not_available_error.yml b/.rubocop_todo/graphql/resource_not_available_error.yml index 5a9d2f9b1a2..316cd4a99cb 100644 --- a/.rubocop_todo/graphql/resource_not_available_error.yml +++ b/.rubocop_todo/graphql/resource_not_available_error.yml @@ -40,4 +40,3 @@ Graphql/ResourceNotAvailableError: - 'ee/app/graphql/mutations/projects/set_locked.rb' - 'ee/app/graphql/resolvers/incident_management/oncall_shifts_resolver.rb' - 'ee/app/graphql/resolvers/product_analytics/visualization_resolver.rb' - - 'ee/app/graphql/resolvers/remote_development/workspaces_resolver.rb' diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml index 870cb7a1989..19b93eaad6d 100644 --- a/.rubocop_todo/rspec/before_all_role_assignment.yml +++ b/.rubocop_todo/rspec/before_all_role_assignment.yml @@ -149,7 +149,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/features/projects/wiki/user_views_wiki_empty_spec.rb' - 'ee/spec/features/projects_spec.rb' - 'ee/spec/features/protected_branches_spec.rb' - - 'ee/spec/features/remote_development/workspaces_spec.rb' - 'ee/spec/features/search/user_searches_for_epics_spec.rb' - 'ee/spec/features/search/zoekt/search_spec.rb' - 'ee/spec/features/subscriptions/expiring_subscription_message_spec.rb' @@ -360,7 +359,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/policies/merge_requests/external_status_check_policy_spec.rb' - 'ee/spec/policies/packages/policies/project_policy_spec.rb' - 'ee/spec/policies/project_policy_spec.rb' - - 'ee/spec/policies/remote_development/workspace_policy_spec.rb' - 'ee/spec/policies/requirements_management/requirement_policy_spec.rb' - 'ee/spec/policies/resource_iteration_event_policy_spec.rb' - 'ee/spec/policies/resource_weight_event_policy_spec.rb' @@ -465,8 +463,6 @@ RSpec/BeforeAllRoleAssignment: - 'ee/spec/requests/api/graphql/mutations/projects/set_compliance_framework_spec.rb' - 'ee/spec/requests/api/graphql/mutations/releases/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/remote_development/workspaces/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/remote_development/workspaces/update_spec.rb' - 'ee/spec/requests/api/graphql/mutations/requirements_management/create_requirement_spec.rb' - 'ee/spec/requests/api/graphql/mutations/requirements_management/export_requirements_spec.rb' - 'ee/spec/requests/api/graphql/mutations/requirements_management/update_requirement_spec.rb' diff --git a/app/assets/javascripts/members/components/table/members_table.vue b/app/assets/javascripts/members/components/table/members_table.vue index c973d58fcd2..f6fd84c46cb 100644 --- a/app/assets/javascripts/members/components/table/members_table.vue +++ b/app/assets/javascripts/members/components/table/members_table.vue @@ -127,10 +127,15 @@ export default { }, actionsFieldTdClass(value, key, member) { if (this.hasActionButtons(member)) { - return 'col-actions'; + return ['col-actions', 'gl-vertical-align-middle!']; } - return ['col-actions', 'gl-display-none!', 'gl-lg-display-table-cell!']; + return [ + 'col-actions', + 'gl-display-none!', + 'gl-lg-display-table-cell!', + 'gl-vertical-align-middle!', + ]; }, tbodyTrAttr(member) { return { diff --git a/app/assets/javascripts/members/constants.js b/app/assets/javascripts/members/constants.js index 8e5b88d362e..e1f7e81d831 100644 --- a/app/assets/javascripts/members/constants.js +++ b/app/assets/javascripts/members/constants.js @@ -32,12 +32,13 @@ export const FIELDS = [ asc: 'name_asc', desc: 'name_desc', }, + tdClass: 'gl-vertical-align-middle!', }, { key: FIELD_KEY_SOURCE, label: __('Source'), thClass: 'col-meta', - tdClass: 'col-meta', + tdClass: 'col-meta gl-vertical-align-middle!', }, { key: FIELD_KEY_GRANTED, @@ -46,24 +47,25 @@ export const FIELDS = [ asc: 'last_joined', desc: 'oldest_joined', }, + tdClass: 'gl-vertical-align-middle!', }, { key: FIELD_KEY_INVITED, label: __('Invited'), thClass: 'col-meta', - tdClass: 'col-meta', + tdClass: 'col-meta gl-vertical-align-middle!', }, { key: FIELD_KEY_REQUESTED, label: __('Requested'), thClass: 'col-meta', - tdClass: 'col-meta', + tdClass: 'col-meta gl-vertical-align-middle!', }, { key: FIELD_KEY_MAX_ROLE, label: __('Max role'), thClass: 'col-max-role', - tdClass: 'col-max-role', + tdClass: 'col-max-role gl-vertical-align-middle!', sort: { asc: 'access_level_asc', desc: 'access_level_desc', @@ -73,13 +75,13 @@ export const FIELDS = [ key: FIELD_KEY_EXPIRATION, label: __('Expiration'), thClass: 'col-expiration', - tdClass: 'col-expiration', + tdClass: 'col-expiration gl-vertical-align-middle!', }, { key: FIELD_KEY_ACTIVITY, label: s__('Members|Activity'), thClass: 'col-activity', - tdClass: 'col-activity', + tdClass: 'col-activity gl-vertical-align-middle!', }, { key: FIELD_KEY_USER_CREATED_AT, diff --git a/app/assets/javascripts/super_sidebar/components/frequent_items_list.vue b/app/assets/javascripts/super_sidebar/components/frequent_items_list.vue index 02adebc50af..342e1284e86 100644 --- a/app/assets/javascripts/super_sidebar/components/frequent_items_list.vue +++ b/app/assets/javascripts/super_sidebar/components/frequent_items_list.vue @@ -105,7 +105,6 @@ export default { icon="dash" :aria-label="$options.i18n.removeItem" :title="$options.i18n.removeItem" - class="gl-align-self-center gl-mr-2" data-testid="item-remove" @click.stop.prevent="handleItemRemove(item)" /> diff --git a/app/assets/javascripts/super_sidebar/components/items_list.vue b/app/assets/javascripts/super_sidebar/components/items_list.vue index 7d5af883651..764db490751 100644 --- a/app/assets/javascripts/super_sidebar/components/items_list.vue +++ b/app/assets/javascripts/super_sidebar/components/items_list.vue @@ -19,13 +19,7 @@ export default {