diff --git a/.rubocop_todo/gitlab/bounded_contexts.yml b/.rubocop_todo/gitlab/bounded_contexts.yml index 3d996595e11..5b75fcfca33 100644 --- a/.rubocop_todo/gitlab/bounded_contexts.yml +++ b/.rubocop_todo/gitlab/bounded_contexts.yml @@ -1703,6 +1703,7 @@ Gitlab/BoundedContexts: - 'app/services/bulk_imports/repository_bundle_export_service.rb' - 'app/services/bulk_imports/tree_export_service.rb' - 'app/services/bulk_imports/uploads_export_service.rb' + - 'app/services/bulk_imports/user_contributions_export_service.rb' - 'app/services/bulk_push_event_payload_service.rb' - 'app/services/captcha/captcha_verification_service.rb' - 'app/services/chat_names/authorize_user_service.rb' @@ -2205,6 +2206,7 @@ Gitlab/BoundedContexts: - 'app/workers/bulk_imports/relation_export_worker.rb' - 'app/workers/bulk_imports/stale_import_worker.rb' - 'app/workers/bulk_imports/transform_references_worker.rb' + - 'app/workers/bulk_imports/user_contributions_export_worker.rb' - 'app/workers/chaos/cpu_spin_worker.rb' - 'app/workers/chaos/db_spin_worker.rb' - 'app/workers/chaos/kill_worker.rb' @@ -4605,6 +4607,7 @@ Gitlab/BoundedContexts: - 'lib/bulk_imports/source_url_builder.rb' - 'lib/bulk_imports/stage.rb' - 'lib/bulk_imports/uniquify.rb' + - 'lib/bulk_imports/user_contributions_export_mapper.rb' - 'lib/bulk_imports/users_mapper.rb' - 'lib/bulk_imports/visibility_level.rb' - 'lib/carrier_wave_string_file.rb' diff --git a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml index 700482cb46e..5f087c4159c 100644 --- a/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml +++ b/.rubocop_todo/layout/line_end_string_concatenation_indentation.yml @@ -505,7 +505,6 @@ Layout/LineEndStringConcatenationIndentation: - 'lib/bulk_imports/error.rb' - 'lib/feature/definition.rb' - 'lib/feature/shared.rb' - - 'lib/generators/gitlab/analytics/internal_events_generator.rb' - 'lib/gitlab/audit/auditor.rb' - 'lib/gitlab/auth/ldap/access.rb' - 'lib/gitlab/auth/user_access_denied_reason.rb' diff --git a/.rubocop_todo/lint/ambiguous_regexp_literal.yml b/.rubocop_todo/lint/ambiguous_regexp_literal.yml index cb6735f617a..d00aae4e0fb 100644 --- a/.rubocop_todo/lint/ambiguous_regexp_literal.yml +++ b/.rubocop_todo/lint/ambiguous_regexp_literal.yml @@ -2,18 +2,5 @@ # Cop supports --autocorrect. Lint/AmbiguousRegexpLiteral: Exclude: - - 'lib/api/features.rb' - - 'qa/spec/page/element_spec.rb' - - 'spec/components/pajamas/avatar_component_spec.rb' - - 'spec/features/atom/users_spec.rb' - - 'spec/features/issues/user_creates_branch_and_merge_request_spec.rb' - - 'spec/features/issues/user_creates_issue_spec.rb' - - 'spec/helpers/labels_helper_spec.rb' - - 'spec/helpers/users_helper_spec.rb' - - 'spec/helpers/visibility_level_helper_spec.rb' - - 'spec/initializers/direct_upload_support_spec.rb' - - 'spec/initializers/validate_database_config_spec.rb' - - 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb' - - 'spec/lib/feature_spec.rb' - 'spec/serializers/commit_entity_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 6745ca104a9..c70c3cebcf5 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -379,7 +379,6 @@ RSpec/ContextWording: - 'ee/spec/lib/gitlab/slash_commands/presenters/issue_show_spec.rb' - 'ee/spec/lib/gitlab/status_page/filter/image_filter_spec.rb' - 'ee/spec/lib/gitlab/status_page/storage/s3_client_spec.rb' - - 'ee/spec/lib/gitlab/tracking/snowplow_schema_validation_spec.rb' - 'ee/spec/lib/gitlab/tracking/standard_context_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/build_type_metric_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/distribution_metric_spec.rb' @@ -1920,7 +1919,6 @@ RSpec/ContextWording: - 'spec/lib/gitlab/time_tracking_formatter_spec.rb' - 'spec/lib/gitlab/tracking/destinations/snowplow_spec.rb' - 'spec/lib/gitlab/tracking/incident_management_spec.rb' - - 'spec/lib/gitlab/tracking/snowplow_schema_validation_spec.rb' - 'spec/lib/gitlab/tracking/standard_context_spec.rb' - 'spec/lib/gitlab/tracking_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' diff --git a/.rubocop_todo/rspec/feature_category.yml b/.rubocop_todo/rspec/feature_category.yml index 736f20f1984..def25d8c722 100644 --- a/.rubocop_todo/rspec/feature_category.yml +++ b/.rubocop_todo/rspec/feature_category.yml @@ -831,7 +831,6 @@ RSpec/FeatureCategory: - 'ee/spec/lib/gitlab/status_page_spec.rb' - 'ee/spec/lib/gitlab/subscription_portal/client_spec.rb' - 'ee/spec/lib/gitlab/template/custom_templates_spec.rb' - - 'ee/spec/lib/gitlab/tracking/snowplow_schema_validation_spec.rb' - 'ee/spec/lib/gitlab/tracking/standard_context_spec.rb' - 'ee/spec/lib/gitlab/tree_summary_spec.rb' - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/advanced_search/build_type_metric_spec.rb' @@ -3909,7 +3908,6 @@ RSpec/FeatureCategory: - 'spec/lib/gitlab/tracking/helpers/weak_password_error_event_spec.rb' - 'spec/lib/gitlab/tracking/incident_management_spec.rb' - 'spec/lib/gitlab/tracking/service_ping_context_spec.rb' - - 'spec/lib/gitlab/tracking/snowplow_schema_validation_spec.rb' - 'spec/lib/gitlab/tracking/standard_context_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - 'spec/lib/gitlab/unicode_spec.rb' diff --git a/app/assets/javascripts/design_management/components/design_sidebar.vue b/app/assets/javascripts/design_management/components/design_sidebar.vue index 80e7546d8ec..e3174a995a4 100644 --- a/app/assets/javascripts/design_management/components/design_sidebar.vue +++ b/app/assets/javascripts/design_management/components/design_sidebar.vue @@ -5,13 +5,13 @@ import { isLoggedIn } from '~/lib/utils/common_utils'; import { s__, n__ } from '~/locale'; import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin'; +import DesignDisclosure from '~/vue_shared/components/design_management/design_disclosure.vue'; import { ACTIVE_DISCUSSION_SOURCE_TYPES } from '../constants'; import updateActiveDiscussionMutation from '../graphql/mutations/update_active_discussion.mutation.graphql'; import { extractDiscussions, extractParticipants } from '../utils/design_management_utils'; import DesignDiscussion from './design_notes/design_discussion.vue'; import DescriptionForm from './design_description/description_form.vue'; import DesignNoteSignedOut from './design_notes/design_note_signed_out.vue'; -import DesignDisclosure from './design_disclosure.vue'; export default { components: { diff --git a/app/assets/javascripts/members/components/table/members_table.vue b/app/assets/javascripts/members/components/table/members_table.vue index 17252dc9c7d..8327e5e56a5 100644 --- a/app/assets/javascripts/members/components/table/members_table.vue +++ b/app/assets/javascripts/members/components/table/members_table.vue @@ -1,5 +1,5 @@ + + diff --git a/app/assets/javascripts/design_management/components/design_disclosure.vue b/app/assets/javascripts/vue_shared/components/design_management/design_disclosure.vue similarity index 60% rename from app/assets/javascripts/design_management/components/design_disclosure.vue rename to app/assets/javascripts/vue_shared/components/design_management/design_disclosure.vue index 4a8f4b6c2d1..a7803ed7d61 100644 --- a/app/assets/javascripts/design_management/components/design_disclosure.vue +++ b/app/assets/javascripts/vue_shared/components/design_management/design_disclosure.vue @@ -13,7 +13,7 @@ export default { diff --git a/app/assets/javascripts/work_items/components/design_management/design_preview/design_description.vue b/app/assets/javascripts/work_items/components/design_management/design_preview/design_description.vue new file mode 100644 index 00000000000..41c78fe334c --- /dev/null +++ b/app/assets/javascripts/work_items/components/design_management/design_preview/design_description.vue @@ -0,0 +1,39 @@ + + + diff --git a/app/assets/javascripts/work_items/components/design_management/design_preview/design_details.vue b/app/assets/javascripts/work_items/components/design_management/design_preview/design_details.vue index f3e39e11863..fd5e64394c3 100644 --- a/app/assets/javascripts/work_items/components/design_management/design_preview/design_details.vue +++ b/app/assets/javascripts/work_items/components/design_management/design_preview/design_details.vue @@ -12,6 +12,7 @@ import { DESIGN_DETAIL_LAYOUT_CLASSLIST } from '../constants'; import { DESIGN_NOT_FOUND_ERROR, DESIGN_VERSION_NOT_EXIST_ERROR } from '../error_messages'; import DesignPresentation from './design_presentation.vue'; import DesignToolbar from './design_toolbar.vue'; +import DesignSidebar from './design_sidebar.vue'; const DEFAULT_SCALE = 1; const DEFAULT_MAX_SCALE = 2; @@ -20,6 +21,7 @@ export default { WORK_ITEM_ROUTE_NAME, components: { DesignPresentation, + DesignSidebar, DesignToolbar, GlAlert, }, @@ -63,6 +65,7 @@ export default { discussions: [], workItemId: '', workItemTitle: '', + isSidebarOpen: true, }; }, apollo: { @@ -145,6 +148,9 @@ export default { setMaxScale(event) { this.maxScale = 1 / event; }, + toggleSidebar() { + this.isSidebarOpen = !this.isSidebarOpen; + }, }, }; @@ -154,7 +160,13 @@ export default { class="design-detail js-design-detail fixed-top gl-w-full gl-flex gl-justify-content-center gl-flex-col gl-lg-flex-direction-row gl-bg-gray-10" >
- +
@@ -175,6 +187,7 @@ export default { @setMaxScale="setMaxScale" />
+
diff --git a/app/assets/javascripts/work_items/components/design_management/design_preview/design_sidebar.vue b/app/assets/javascripts/work_items/components/design_management/design_preview/design_sidebar.vue new file mode 100644 index 00000000000..e42c99aea9f --- /dev/null +++ b/app/assets/javascripts/work_items/components/design_management/design_preview/design_sidebar.vue @@ -0,0 +1,55 @@ + + + diff --git a/app/assets/javascripts/work_items/components/design_management/design_preview/design_toolbar.vue b/app/assets/javascripts/work_items/components/design_management/design_preview/design_toolbar.vue index 6dd0d34f92c..380fbb136e2 100644 --- a/app/assets/javascripts/work_items/components/design_management/design_preview/design_toolbar.vue +++ b/app/assets/javascripts/work_items/components/design_management/design_preview/design_toolbar.vue @@ -1,16 +1,25 @@