From d7fd035dc387e9c2e5c31bbb53d867239689cfbf Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 12 Apr 2021 12:09:15 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_manual_todo.yml | 20 - .../javascripts/branches/divergence_graph.js | 8 +- app/assets/javascripts/delete_label_modal.js | 16 + app/assets/javascripts/jira_connect/api.js | 3 +- .../jira_connect/components/groups_list.vue | 96 ++-- .../components/groups_list_item.vue | 13 +- .../pages/groups/labels/index/index.js | 2 + .../pages/projects/branches/index/index.js | 7 +- .../pages/projects/labels/index/index.js | 2 + .../components/delete_label_modal.vue | 81 +++ .../page_bundles/jira_connect.scss | 3 +- app/graphql/resolvers/blobs_resolver.rb | 37 ++ .../concerns/resolves_merge_requests.rb | 3 +- app/graphql/resolvers/issues_resolver.rb | 3 +- .../resolvers/project_pipeline_resolver.rb | 2 +- app/graphql/types/issue_type.rb | 3 + app/graphql/types/merge_request_type.rb | 2 + app/graphql/types/repository_type.rb | 2 + app/helpers/profiles_helper.rb | 14 + app/helpers/sidebars_helper.rb | 12 + app/models/blob.rb | 1 + app/models/concerns/has_timelogs_report.rb | 3 +- app/models/project.rb | 6 +- app/models/sidebars/panel.rb | 20 + app/models/sidebars/projects/panel.rb | 22 + app/services/projects/update_pages_service.rb | 6 +- .../layouts/nav/sidebar/_project.html.haml | 472 +----------------- .../nav/sidebar/_project_menus.html.haml | 458 +++++++++++++++++ .../nav/sidebar/_project_scope_menu.html.haml | 6 + app/views/profiles/keys/_form.html.haml | 3 +- app/views/profiles/keys/_key.html.haml | 14 +- app/views/projects/branches/index.html.haml | 2 +- .../shared/_delete_label_modal.html.haml | 20 - app/views/shared/_label.html.haml | 10 +- app/views/shared/nav/_sidebar.html.haml | 10 + app/workers/concerns/each_shard_worker.rb | 8 +- ...ke-blob-info-available-through-graphql.yml | 5 + ...100-update-default-initial-branch-name.yml | 5 + ...a-way-to-filter-search-for-a-namespace.yml | 5 + ...209-fix-find-or-initialize-service-n-1.yml | 5 + ...2-Update GIicon in geo_node_header.vue.yml | 2 - ...ix-pipeline-loading-by-sha-for-graphql.yml | 5 + ...nsure_project_iid_before_drop_pipeline.yml | 5 + ...phql-expose-timelogs-against-issuables.yml | 5 + ...-line-after-let-it-be-gitlab-hook-data.yml | 5 + ...y-line-after-let-it-be-services-groups.yml | 5 + ...mpty-line-after-let-it-be-services-ide.yml | 5 + ...y-line-after-let-it-be-services-issues.yml | 5 + .../sh-pages-tmp-dir-use-build-id.yml | 5 + .../ci_pipeline_ensure_iid_on_drop.yml | 8 + doc/api/graphql/reference/index.md | 4 + lib/gitlab/ci/pipeline/chain/helpers.rb | 12 +- locale/gitlab.pot | 29 +- qa/qa/page/project/menu.rb | 2 +- qa/qa/page/project/sub_menus/ci_cd.rb | 2 +- qa/qa/page/project/sub_menus/issues.rb | 2 +- qa/qa/page/project/sub_menus/operations.rb | 2 +- qa/qa/page/project/sub_menus/project.rb | 2 +- qa/qa/page/project/sub_menus/repository.rb | 2 +- qa/qa/page/project/sub_menus/settings.rb | 2 +- spec/factories/timelogs.rb | 19 +- .../labels/user_removes_labels_spec.rb | 10 +- spec/frontend/delete_label_modal_spec.js | 83 +++ .../components/groups_list_spec.js | 99 +++- .../components/delete_label_modal_spec.js | 64 +++ spec/graphql/resolvers/blobs_resolver_spec.rb | 74 +++ .../project_pipeline_resolver_spec.rb | 15 +- .../resolvers/timelog_resolver_spec.rb | 57 ++- spec/graphql/types/issue_type_spec.rb | 2 +- spec/graphql/types/repository_type_spec.rb | 2 + spec/helpers/profiles_helper_spec.rb | 40 ++ .../gitlab/ci/pipeline/chain/helpers_spec.rb | 70 +++ spec/lib/gitlab/database_spec.rb | 4 +- .../gitlab/hook_data/issue_builder_spec.rb | 1 + .../hook_data/merge_request_builder_spec.rb | 1 + .../gitlab/hook_data/release_builder_spec.rb | 1 + .../concerns/has_timelogs_report_spec.rb | 10 +- spec/models/project_spec.rb | 32 +- spec/models/timelog_spec.rb | 12 +- .../api/graphql/group/timelogs_spec.rb | 19 +- .../api/graphql/project/issues_spec.rb | 71 ++- .../graphql/project/merge_requests_spec.rb | 9 +- .../groups/auto_devops_service_spec.rb | 1 + .../groups/group_links/update_service_spec.rb | 1 + spec/services/groups/transfer_service_spec.rb | 3 + .../update_shared_runners_service_spec.rb | 1 + spec/services/ide/base_config_service_spec.rb | 1 + .../ide/schemas_config_service_spec.rb | 1 + .../ide/terminal_config_service_spec.rb | 1 + spec/services/issues/build_service_spec.rb | 1 + spec/services/issues/clone_service_spec.rb | 1 + spec/services/issues/create_service_spec.rb | 1 + .../issues/export_csv_service_spec.rb | 1 + spec/services/issues/move_service_spec.rb | 1 + .../issues/related_branches_service_spec.rb | 1 + spec/services/projects/create_service_spec.rb | 4 +- .../projects/update_pages_service_spec.rb | 6 + .../profiles/keys/_form.html.haml_spec.rb | 50 ++ .../profiles/keys/_key.html.haml_spec.rb | 109 ++++ .../projects/post_creation_worker_spec.rb | 5 +- .../repository_check/dispatch_worker_spec.rb | 7 + 101 files changed, 1691 insertions(+), 719 deletions(-) create mode 100644 app/assets/javascripts/delete_label_modal.js create mode 100644 app/assets/javascripts/vue_shared/components/delete_label_modal.vue create mode 100644 app/graphql/resolvers/blobs_resolver.rb create mode 100644 app/models/sidebars/projects/panel.rb create mode 100644 app/views/layouts/nav/sidebar/_project_menus.html.haml create mode 100644 app/views/layouts/nav/sidebar/_project_scope_menu.html.haml delete mode 100644 app/views/shared/_delete_label_modal.html.haml create mode 100644 app/views/shared/nav/_sidebar.html.haml create mode 100644 changelogs/unreleased/323195-make-blob-info-available-through-graphql.yml create mode 100644 changelogs/unreleased/324100-update-default-initial-branch-name.yml create mode 100644 changelogs/unreleased/324263-add-a-way-to-filter-search-for-a-namespace.yml create mode 100644 changelogs/unreleased/326209-fix-find-or-initialize-service-n-1.yml rename 57952- Update GIicon in geo_node_header.vue.yml => changelogs/unreleased/57952-Update GIicon in geo_node_header.vue.yml (98%) create mode 100644 changelogs/unreleased/ci-fix-pipeline-loading-by-sha-for-graphql.yml create mode 100644 changelogs/unreleased/ensure_project_iid_before_drop_pipeline.yml create mode 100644 changelogs/unreleased/graphql-expose-timelogs-against-issuables.yml create mode 100644 changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-hook-data.yml create mode 100644 changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-services-groups.yml create mode 100644 changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-services-ide.yml create mode 100644 changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-services-issues.yml create mode 100644 changelogs/unreleased/sh-pages-tmp-dir-use-build-id.yml create mode 100644 config/feature_flags/development/ci_pipeline_ensure_iid_on_drop.yml create mode 100644 spec/frontend/delete_label_modal_spec.js create mode 100644 spec/frontend/vue_shared/components/delete_label_modal_spec.js create mode 100644 spec/graphql/resolvers/blobs_resolver_spec.rb create mode 100644 spec/lib/gitlab/ci/pipeline/chain/helpers_spec.rb create mode 100644 spec/views/profiles/keys/_form.html.haml_spec.rb create mode 100644 spec/views/profiles/keys/_key.html.haml_spec.rb diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index 0bda1b60623..4d8d5545a14 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -604,10 +604,6 @@ RSpec/EmptyLineAfterFinalLetItBe: - ee/spec/services/incident_management/incidents/upload_metric_service_spec.rb - ee/spec/services/incident_management/oncall_rotations/edit_service_spec.rb - ee/spec/services/merge_request_approval_settings/update_service_spec.rb - - ee/spec/services/merge_trains/check_status_service_spec.rb - - ee/spec/services/merge_trains/create_pipeline_service_spec.rb - - ee/spec/services/merge_trains/refresh_merge_request_service_spec.rb - - ee/spec/services/merge_trains/refresh_service_spec.rb - ee/spec/services/personal_access_tokens/create_service_audit_log_spec.rb - ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb - ee/spec/services/projects/after_rename_service_spec.rb @@ -779,9 +775,6 @@ RSpec/EmptyLineAfterFinalLetItBe: - spec/lib/gitlab/gitaly_client/operation_service_spec.rb - spec/lib/gitlab/gl_repository/repo_type_spec.rb - spec/lib/gitlab/group_search_results_spec.rb - - spec/lib/gitlab/hook_data/issue_builder_spec.rb - - spec/lib/gitlab/hook_data/merge_request_builder_spec.rb - - spec/lib/gitlab/hook_data/release_builder_spec.rb - spec/lib/gitlab/json_cache_spec.rb - spec/lib/gitlab/language_detection_spec.rb - spec/lib/gitlab/project_search_results_spec.rb @@ -1010,25 +1003,12 @@ RSpec/EmptyLineAfterFinalLetItBe: - spec/services/feature_flags/enable_service_spec.rb - spec/services/feature_flags/update_service_spec.rb - spec/services/git/branch_push_service_spec.rb - - spec/services/groups/auto_devops_service_spec.rb - - spec/services/groups/group_links/update_service_spec.rb - - spec/services/groups/transfer_service_spec.rb - - spec/services/groups/update_shared_runners_service_spec.rb - - spec/services/ide/base_config_service_spec.rb - - spec/services/ide/schemas_config_service_spec.rb - - spec/services/ide/terminal_config_service_spec.rb - spec/services/import/bitbucket_server_service_spec.rb - spec/services/incident_management/incidents/create_service_spec.rb - spec/services/incident_management/pager_duty/create_incident_issue_service_spec.rb - spec/services/incident_management/pager_duty/process_webhook_service_spec.rb - spec/services/integrations/test/project_service_spec.rb - spec/services/issuable/bulk_update_service_spec.rb - - spec/services/issues/build_service_spec.rb - - spec/services/issues/clone_service_spec.rb - - spec/services/issues/create_service_spec.rb - - spec/services/issues/export_csv_service_spec.rb - - spec/services/issues/move_service_spec.rb - - spec/services/issues/related_branches_service_spec.rb - spec/services/jira_connect/sync_service_spec.rb - spec/services/jira_import/start_import_service_spec.rb - spec/services/jira_import/users_importer_spec.rb diff --git a/app/assets/javascripts/branches/divergence_graph.js b/app/assets/javascripts/branches/divergence_graph.js index ca019bc4178..66e8d982113 100644 --- a/app/assets/javascripts/branches/divergence_graph.js +++ b/app/assets/javascripts/branches/divergence_graph.js @@ -4,13 +4,13 @@ import axios from '../lib/utils/axios_utils'; import { __ } from '../locale'; import DivergenceGraph from './components/divergence_graph.vue'; -export function createGraphVueApp(el, data, maxCommits) { +export function createGraphVueApp(el, data, maxCommits, defaultBranch) { return new Vue({ el, render(h) { return h(DivergenceGraph, { props: { - defaultBranch: 'master', + defaultBranch, distance: data.distance ? parseInt(data.distance, 10) : null, aheadCount: parseInt(data.ahead, 10), behindCount: parseInt(data.behind, 10), @@ -21,7 +21,7 @@ export function createGraphVueApp(el, data, maxCommits) { }); } -export default (endpoint) => { +export default (endpoint, defaultBranch) => { const names = [...document.querySelectorAll('.js-branch-item')].map( ({ dataset }) => dataset.name, ); @@ -47,7 +47,7 @@ export default (endpoint) => { if (!el) return; - createGraphVueApp(el, val, maxCommits); + createGraphVueApp(el, val, maxCommits, defaultBranch); }); }) .catch(() => diff --git a/app/assets/javascripts/delete_label_modal.js b/app/assets/javascripts/delete_label_modal.js new file mode 100644 index 00000000000..cf7c9e7734f --- /dev/null +++ b/app/assets/javascripts/delete_label_modal.js @@ -0,0 +1,16 @@ +import Vue from 'vue'; +import DeleteLabelModal from '~/vue_shared/components/delete_label_modal.vue'; + +const mountDeleteLabelModal = (optionalProps) => + new Vue({ + render(h) { + return h(DeleteLabelModal, { + props: { + selector: '.js-delete-label-modal-button', + ...optionalProps, + }, + }); + }, + }).$mount(); + +export default (optionalProps = {}) => mountDeleteLabelModal(optionalProps); diff --git a/app/assets/javascripts/jira_connect/api.js b/app/assets/javascripts/jira_connect/api.js index d78aba0a3f7..8da2ca73f9a 100644 --- a/app/assets/javascripts/jira_connect/api.js +++ b/app/assets/javascripts/jira_connect/api.js @@ -39,11 +39,12 @@ export const removeSubscription = async (removePath) => { }); }; -export const fetchGroups = async (groupsPath, { page, perPage }) => { +export const fetchGroups = async (groupsPath, { page, perPage, search }) => { return axios.get(groupsPath, { params: { page, per_page: perPage, + search, }, }); }; diff --git a/app/assets/javascripts/jira_connect/components/groups_list.vue b/app/assets/javascripts/jira_connect/components/groups_list.vue index 69f2903388c..275ff820419 100644 --- a/app/assets/javascripts/jira_connect/components/groups_list.vue +++ b/app/assets/javascripts/jira_connect/components/groups_list.vue @@ -1,5 +1,5 @@ diff --git a/app/assets/javascripts/jira_connect/components/groups_list_item.vue b/app/assets/javascripts/jira_connect/components/groups_list_item.vue index b8959a2a505..9c5722c44c7 100644 --- a/app/assets/javascripts/jira_connect/components/groups_list_item.vue +++ b/app/assets/javascripts/jira_connect/components/groups_list_item.vue @@ -21,6 +21,11 @@ export default { type: Object, required: true, }, + disabled: { + type: Boolean, + required: false, + default: false, + }, }, data() { return { @@ -60,7 +65,7 @@ export default {