From da73b48d560485f3e035f8c45458be5bc38e65fe Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 8 Apr 2025 15:11:35 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../gitlab/feature_flag_key_dynamic.yml | 9 + .rubocop_todo/gitlab/strong_memoize_attr.yml | 2 - .rubocop_todo/lint/symbol_conversion.yml | 1 - .rubocop_todo/rspec/receive_messages.yml | 1 - GITALY_SERVER_VERSION | 2 +- GITLAB_KAS_VERSION | 2 +- Gemfile.checksum | 2 +- Gemfile.lock | 4 +- Gemfile.next.checksum | 4 +- Gemfile.next.lock | 6 +- .../ci/runner/components/runner_details.vue | 2 +- .../ci/runner/project_runner_show/index.js | 34 +++ .../project_runner_show_app.vue | 57 ++++ .../add_extra_tokens_for_merge_requests.js | 4 +- app/assets/javascripts/gfm_auto_complete.js | 31 ++- .../graphql_shared/issuable_client.js | 20 +- .../javascripts/ide/init_gitlab_web_ide.js | 2 +- .../ide/lib/gitlab_web_ide/get_base_config.js | 16 +- .../javascripts/ide/mount_oauth_callback.js | 2 +- .../pages/projects/runners/show/index.js | 2 + .../projects/project_import_gitlab_project.js | 8 +- .../javascripts/projects/project_new.js | 4 +- .../rapid_diffs/stores/diffs_list.js | 18 +- .../components/header_area/open_mr_badge.vue | 6 +- .../filtered_search_bar/constants.js | 8 +- .../notes/work_item_comment_form.vue | 4 + .../work_item_relationships.vue | 2 - .../components/rapid_diffs/app.scss | 9 + .../page_bundles/runner_details.scss | 3 - .../rapid_diffs/app_component.html.haml | 2 +- .../rapid_diffs/diff_file_component.html.haml | 2 +- .../event_forward/event_forward_controller.rb | 2 +- app/views/admin/runners/show.html.haml | 1 - app/views/groups/runners/show.html.haml | 1 - .../projects/_import_project_pane.html.haml | 2 +- app/views/projects/runners/show.html.haml | 5 +- .../shared/runners/_runner_details.html.haml | 59 ---- .../runners/_runner_type_badge.html.haml | 7 - config/application.rb | 1 - ..._showing_recent_mrs_for_file_on_branch.yml | 20 ++ ..._secondary_stores_for_buffered_counter.yml | 9 - ..._store_as_default_for_buffered_counter.yml | 9 - config/initializers/validate_cell_config.rb | 2 +- ..._showing_recent_mrs_for_file_on_branch.yml | 24 ++ ..._showing_recent_mrs_for_file_on_branch.yml | 24 ++ config/redis.yml.example | 4 - config/settings.rb | 4 +- .../15-7-deprecate-zentao-integration.yml | 2 +- ...ll_issuable_metric_images_namespace_id.yml | 2 +- .../vulnerability_external_issue_links.yml | 12 +- ...ckages_npm_metadata_project_id_not_null.rb | 14 + ...metadata_project_id_not_null_validation.rb | 16 ++ ...xternal_issue_links_project_id_not_null.rb | 14 + ...ill_issuable_metric_images_namespace_id.rb | 21 ++ db/schema_migrations/20250404165157 | 1 + db/schema_migrations/20250404165327 | 1 + db/schema_migrations/20250407032135 | 1 + db/schema_migrations/20250407231859 | 1 + db/structure.sql | 6 +- doc/administration/cells.md | 10 +- .../advanced_search/elasticsearch.md | 2 +- .../elasticsearch/troubleshooting/indexing.md | 2 +- doc/update/breaking_windows.md | 1 - doc/update/deprecations.md | 34 +-- doc/user/duo_amazon_q/_index.md | 12 - doc/user/project/merge_requests/_index.md | 16 +- gems/gitlab-active-context/doc/usage.md | 11 +- .../lib/active_context/concerns/collection.rb | 27 ++ .../databases/concerns/query_result.rb | 20 ++ .../databases/elasticsearch/client.rb | 9 +- .../databases/elasticsearch/query_result.rb | 8 - .../databases/opensearch/client.rb | 9 +- .../databases/opensearch/query_result.rb | 8 - .../databases/postgresql/client.rb | 10 +- .../databases/postgresql/query_result.rb | 14 +- .../concerns/collection_spec.rb | 162 +++++++++++ .../databases/elasticsearch/client_spec.rb | 10 +- .../elasticsearch/query_result_spec.rb | 27 +- .../databases/opensearch/client_spec.rb | 10 +- .../databases/opensearch/query_result_spec.rb | 8 +- .../databases/postgresql/client_spec.rb | 7 +- .../databases/postgresql/query_result_spec.rb | 8 +- .../support/helpers/test/collections/mock.rb | 25 ++ lib/gitlab/counters/buffered_counter.rb | 2 +- lib/gitlab/redis.rb | 1 - lib/gitlab/redis/buffered_counter.rb | 17 -- locale/gitlab.pot | 48 +--- .../cop/gitlab/feature_flag_key_dynamic.rb | 21 +- .../rapid_diffs/user_views_diffs_spec.rb | 24 ++ .../user_filters_by_approvals_spec.rb | 14 +- .../user_filters_by_deployments_spec.rb | 8 +- ...maintainer_manages_project_runners_spec.rb | 10 +- .../project_runner_show_app_spec.js | 145 ++++++++++ spec/frontend/gfm_auto_complete/mock_data.js | 45 +++ spec/frontend/gfm_auto_complete_spec.js | 256 +++++++++++------- spec/frontend/ide/init_gitlab_web_ide_spec.js | 27 +- .../gitlab_web_ide/get_base_config_spec.js | 42 +-- .../project_import_gitlab_project_spec.js | 77 +++--- .../rapid_diffs/stores/diffs_list_spec.js | 6 + .../gitlab/counters/buffered_counter_spec.rb | 20 +- .../lib/gitlab/redis/buffered_counter_spec.rb | 13 - .../gitlab/feature_flag_key_dynamic_spec.rb | 99 +++++++ ..._artifacts_size_statistics_service_spec.rb | 4 +- .../runners/_runner_details.html.haml_spec.rb | 155 ----------- yarn.lock | 13 +- 105 files changed, 1320 insertions(+), 711 deletions(-) create mode 100644 app/assets/javascripts/ci/runner/project_runner_show/index.js create mode 100644 app/assets/javascripts/ci/runner/project_runner_show/project_runner_show_app.vue delete mode 100644 app/assets/stylesheets/page_bundles/runner_details.scss delete mode 100644 app/views/shared/runners/_runner_details.html.haml delete mode 100644 app/views/shared/runners/_runner_type_badge.html.haml create mode 100644 config/events/click_dropdown_showing_recent_mrs_for_file_on_branch.yml delete mode 100644 config/feature_flags/gitlab_com_derisk/use_primary_and_secondary_stores_for_buffered_counter.yml delete mode 100644 config/feature_flags/gitlab_com_derisk/use_primary_store_as_default_for_buffered_counter.yml create mode 100644 config/metrics/counts_all/count_distinct_user_id_from_click_dropdown_showing_recent_mrs_for_file_on_branch.yml create mode 100644 config/metrics/counts_all/count_total_click_dropdown_showing_recent_mrs_for_file_on_branch.yml create mode 100644 db/post_migrate/20250404165157_add_packages_npm_metadata_project_id_not_null.rb create mode 100644 db/post_migrate/20250404165327_prepare_packages_npm_metadata_project_id_not_null_validation.rb create mode 100644 db/post_migrate/20250407032135_add_vulnerability_external_issue_links_project_id_not_null.rb create mode 100644 db/post_migrate/20250407231859_finalize_hk_backfill_issuable_metric_images_namespace_id.rb create mode 100644 db/schema_migrations/20250404165157 create mode 100644 db/schema_migrations/20250404165327 create mode 100644 db/schema_migrations/20250407032135 create mode 100644 db/schema_migrations/20250407231859 create mode 100644 gems/gitlab-active-context/spec/lib/active_context/concerns/collection_spec.rb create mode 100644 gems/gitlab-active-context/spec/support/helpers/test/collections/mock.rb delete mode 100644 lib/gitlab/redis/buffered_counter.rb create mode 100644 spec/features/merge_request/rapid_diffs/user_views_diffs_spec.rb create mode 100644 spec/frontend/ci/runner/project_runner_show/project_runner_show_app_spec.js delete mode 100644 spec/lib/gitlab/redis/buffered_counter_spec.rb delete mode 100644 spec/views/shared/runners/_runner_details.html.haml_spec.rb diff --git a/.rubocop_todo/gitlab/feature_flag_key_dynamic.yml b/.rubocop_todo/gitlab/feature_flag_key_dynamic.yml index e56cffff60c..448af455330 100644 --- a/.rubocop_todo/gitlab/feature_flag_key_dynamic.yml +++ b/.rubocop_todo/gitlab/feature_flag_key_dynamic.yml @@ -5,6 +5,9 @@ Gitlab/FeatureFlagKeyDynamic: Exclude: - 'app/graphql/resolvers/app_config/gitlab_instance_feature_flags_resolver.rb' - 'app/graphql/resolvers/feature_flag_resolver.rb' + - 'app/models/concerns/ci/partitionable/switch.rb' + - 'app/models/concerns/limitable.rb' + - 'app/models/group.rb' - 'app/services/concerns/measurable.rb' - 'app/services/service_desk_settings/update_service.rb' - 'app/workers/concerns/worker_attributes.rb' @@ -13,6 +16,7 @@ Gitlab/FeatureFlagKeyDynamic: - 'ee/app/graphql/resolvers/ai/user_available_features_resolver.rb' - 'ee/app/graphql/resolvers/ai/user_code_suggestions_contexts_resolver.rb' - 'ee/app/models/concerns/geo/verifiable_replicator.rb' + - 'ee/app/models/members/member_role.rb' - 'ee/app/services/search/zoekt/info_service.rb' - 'ee/lib/gitlab/ai_gateway.rb' - 'ee/lib/gitlab/geo/replicator.rb' @@ -20,12 +24,17 @@ Gitlab/FeatureFlagKeyDynamic: - 'ee/lib/gitlab/llm/completions_factory.rb' - 'ee/lib/tasks/gitlab/nav/variant_generator.rb' - 'ee/spec/graphql/resolvers/ai/user_available_features_resolver_spec.rb' + - 'ee/spec/lib/gitlab/duo/developments/setup_spec.rb' - 'ee/spec/models/gitlab_subscriptions/features_spec.rb' - 'lib/feature/gitaly.rb' + - 'lib/gitlab/ci/config/feature_flags.rb' + - 'lib/gitlab/experiment_feature_rollout.rb' - 'lib/gitlab/gon_helper.rb' + - 'lib/gitlab/metrics/methods.rb' - 'lib/gitlab/redis/multi_store.rb' - 'lib/gitlab/sidekiq_middleware/skip_jobs.rb' - 'lib/gitlab/sidekiq_sharding/router.rb' + - 'lib/gitlab/tracking/event_eligibility_checker.rb' - 'lib/web_ide/extension_marketplace.rb' - 'spec/lib/feature_spec.rb' - 'spec/requests/api/features_spec.rb' diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index d817db96220..0f40c57b584 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -296,8 +296,6 @@ Gitlab/StrongMemoizeAttr: - 'ee/app/services/ee/projects/create_from_template_service.rb' - 'ee/app/services/ee/projects/gitlab_projects_import_service.rb' - 'ee/app/services/ee/protected_branches/create_service.rb' - - 'ee/app/services/ee/search/global_service.rb' - - 'ee/app/services/ee/search/group_service.rb' - 'ee/app/services/ee/users/authorized_build_service.rb' - 'ee/app/services/ee/users/build_service.rb' - 'ee/app/services/ee/users/update_service.rb' diff --git a/.rubocop_todo/lint/symbol_conversion.yml b/.rubocop_todo/lint/symbol_conversion.yml index 05a028f192e..4db76a734ad 100644 --- a/.rubocop_todo/lint/symbol_conversion.yml +++ b/.rubocop_todo/lint/symbol_conversion.yml @@ -43,7 +43,6 @@ Lint/SymbolConversion: - 'ee/lib/ee/api/helpers.rb' - 'ee/lib/gitlab/geo/replicator.rb' - 'ee/lib/gitlab/graphql/aggregations/epics/epic_node.rb' - - 'ee/lib/search/zoekt/search_results.rb' - 'ee/spec/factories/ci/builds.rb' - 'ee/spec/factories/ci/pipelines.rb' - 'ee/spec/features/groups/analytics/cycle_analytics/charts_spec.rb' diff --git a/.rubocop_todo/rspec/receive_messages.yml b/.rubocop_todo/rspec/receive_messages.yml index 14457b67d56..2254b32c516 100644 --- a/.rubocop_todo/rspec/receive_messages.yml +++ b/.rubocop_todo/rspec/receive_messages.yml @@ -13,7 +13,6 @@ RSpec/ReceiveMessages: - 'ee/spec/features/groups/iterations/user_edits_iteration_cadence_spec.rb' - 'ee/spec/features/projects/new_project_spec.rb' - 'ee/spec/features/projects/settings/ee/service_desk_setting_spec.rb' - - 'ee/spec/features/search/elastic/project_search_spec.rb' - 'ee/spec/finders/security/security_policies_finder_spec.rb' - 'ee/spec/frontend/fixtures/epic.rb' - 'ee/spec/graphql/resolvers/epic_issues_resolver_spec.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 5d0c5dafbf9..26ac103b7e8 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -bde1da2a11f978f937589b277c2b5bd5711036ed +6a69fdde9d24d290cc33e48d7062a57da2f0c508 diff --git a/GITLAB_KAS_VERSION b/GITLAB_KAS_VERSION index 0e9710af934..5be43f039c1 100644 --- a/GITLAB_KAS_VERSION +++ b/GITLAB_KAS_VERSION @@ -1 +1 @@ -69d41543ba9e650df1415c0f96a6df6d1cb3c352 +7e94489bc9d892e3cb25f9f9e7f4f7ce15ac0ee8 diff --git a/Gemfile.checksum b/Gemfile.checksum index 1297b32f615..016e1df859a 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -455,7 +455,7 @@ {"name":"omniauth-google-oauth2","version":"1.1.1","platform":"ruby","checksum":"4496f126e84eaf760f9c6a5c69e5e7511f98092d7f25ad79fd2c0ae5e09b5039"}, {"name":"omniauth-oauth2","version":"1.8.0","platform":"ruby","checksum":"b2f8e9559cc7e2d4efba57607691d6d2b634b879fc5b5b6ccfefa3da85089e78"}, {"name":"omniauth-oauth2-generic","version":"0.2.8","platform":"ruby","checksum":"ce6e8539019d5ebf2f48867072b9f248f148bb4cbe7166dee655865abfae7613"}, -{"name":"omniauth-saml","version":"2.2.2","platform":"ruby","checksum":"84cc650ac2d684fcd430a5a14dfbfa0f8677eebaf0bd9d86ab17b520edd0fbb3"}, +{"name":"omniauth-saml","version":"2.2.3","platform":"ruby","checksum":"d4e0dbdcb304e4bb74410eb75deaa1873b08a42afa7634c9c3171be0b34751b0"}, {"name":"omniauth-shibboleth-redux","version":"2.0.0","platform":"ruby","checksum":"e9b353fd103405fcc8549e8510b9cad857acf0b286d764fac5dba8a93ab8ffe1"}, {"name":"omniauth_openid_connect","version":"0.8.0","platform":"ruby","checksum":"1f2f3890386e2a742221cee0d2e903b78d874e6fab9ea3bfa31c1462f4793d25"}, {"name":"open4","version":"1.3.4","platform":"ruby","checksum":"a1df037310624ecc1ea1d81264b11c83e96d0c3c1c6043108d37d396dcd0f4b1"}, diff --git a/Gemfile.lock b/Gemfile.lock index 09998aa40d2..e522d41fa40 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1281,9 +1281,9 @@ GEM omniauth-oauth2-generic (0.2.8) omniauth-oauth2 (~> 1.0) rake - omniauth-saml (2.2.2) + omniauth-saml (2.2.3) omniauth (~> 2.1) - ruby-saml (~> 1.17) + ruby-saml (~> 1.18) omniauth-shibboleth-redux (2.0.0) omniauth (>= 2.0.0) omniauth_openid_connect (0.8.0) diff --git a/Gemfile.next.checksum b/Gemfile.next.checksum index a8af3b9aab2..0a7aedf3955 100644 --- a/Gemfile.next.checksum +++ b/Gemfile.next.checksum @@ -458,7 +458,7 @@ {"name":"omniauth-google-oauth2","version":"1.1.1","platform":"ruby","checksum":"4496f126e84eaf760f9c6a5c69e5e7511f98092d7f25ad79fd2c0ae5e09b5039"}, {"name":"omniauth-oauth2","version":"1.8.0","platform":"ruby","checksum":"b2f8e9559cc7e2d4efba57607691d6d2b634b879fc5b5b6ccfefa3da85089e78"}, {"name":"omniauth-oauth2-generic","version":"0.2.8","platform":"ruby","checksum":"ce6e8539019d5ebf2f48867072b9f248f148bb4cbe7166dee655865abfae7613"}, -{"name":"omniauth-saml","version":"2.2.2","platform":"ruby","checksum":"84cc650ac2d684fcd430a5a14dfbfa0f8677eebaf0bd9d86ab17b520edd0fbb3"}, +{"name":"omniauth-saml","version":"2.2.3","platform":"ruby","checksum":"d4e0dbdcb304e4bb74410eb75deaa1873b08a42afa7634c9c3171be0b34751b0"}, {"name":"omniauth-shibboleth-redux","version":"2.0.0","platform":"ruby","checksum":"e9b353fd103405fcc8549e8510b9cad857acf0b286d764fac5dba8a93ab8ffe1"}, {"name":"omniauth_openid_connect","version":"0.8.0","platform":"ruby","checksum":"1f2f3890386e2a742221cee0d2e903b78d874e6fab9ea3bfa31c1462f4793d25"}, {"name":"open4","version":"1.3.4","platform":"ruby","checksum":"a1df037310624ecc1ea1d81264b11c83e96d0c3c1c6043108d37d396dcd0f4b1"}, @@ -602,7 +602,7 @@ {"name":"regexp_parser","version":"2.10.0","platform":"ruby","checksum":"cb6f0ddde88772cd64bff1dbbf68df66d376043fe2e66a9ef77fcb1b0c548c61"}, {"name":"regexp_property_values","version":"1.0.0","platform":"java","checksum":"5e26782b01241616855c4ee7bb8a62fce9387e484f2d3eaf04f2a0633708222e"}, {"name":"regexp_property_values","version":"1.0.0","platform":"ruby","checksum":"162499dc0bba1e66d334273a059f207a61981cc8cc69d2ca743594e7886d080f"}, -{"name":"reline","version":"0.6.0","platform":"ruby","checksum":"57620375dcbe56ec09bac7192bfb7460c716bbf0054dc94345ecaa5438e539d2"}, +{"name":"reline","version":"0.6.1","platform":"ruby","checksum":"1afcc9d7cb1029cdbe780d72f2f09251ce46d3780050f3ec39c3ccc6b60675fb"}, {"name":"representable","version":"3.2.0","platform":"ruby","checksum":"cc29bf7eebc31653586849371a43ffe36c60b54b0a6365b5f7d95ec34d1ebace"}, {"name":"request_store","version":"1.7.0","platform":"ruby","checksum":"e1b75d5346a315f452242a68c937ef8e48b215b9453a77a6c0acdca2934c88cb"}, {"name":"responders","version":"3.0.1","platform":"ruby","checksum":"613fe28e498987f4feaa3230aa6313ca4bd5f0563a3da83511b0dd6cd8f47292"}, diff --git a/Gemfile.next.lock b/Gemfile.next.lock index 51c38d688fe..dbb74460a0c 100644 --- a/Gemfile.next.lock +++ b/Gemfile.next.lock @@ -1298,9 +1298,9 @@ GEM omniauth-oauth2-generic (0.2.8) omniauth-oauth2 (~> 1.0) rake - omniauth-saml (2.2.2) + omniauth-saml (2.2.3) omniauth (~> 2.1) - ruby-saml (~> 1.17) + ruby-saml (~> 1.18) omniauth-shibboleth-redux (2.0.0) omniauth (>= 2.0.0) omniauth_openid_connect (0.8.0) @@ -1624,7 +1624,7 @@ GEM redis (>= 4, < 6) regexp_parser (2.10.0) regexp_property_values (1.0.0) - reline (0.6.0) + reline (0.6.1) io-console (~> 0.5) representable (3.2.0) declarative (< 0.1.0) diff --git a/app/assets/javascripts/ci/runner/components/runner_details.vue b/app/assets/javascripts/ci/runner/components/runner_details.vue index 15420f4d844..22157851440 100644 --- a/app/assets/javascripts/ci/runner/components/runner_details.vue +++ b/app/assets/javascripts/ci/runner/components/runner_details.vue @@ -89,7 +89,7 @@ export default {