From dd240e5cc4e0abc4eef8b97962c247dab43e3777 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 30 Sep 2020 15:09:46 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- GITALY_SERVER_VERSION | 2 +- Gemfile.lock | 114 +++---- .../components/alert_details.vue | 3 - .../components/alert_sidebar.vue | 1 - .../behaviors/shortcuts/shortcuts.js | 4 +- .../components/fluentd_output_settings.vue | 17 +- .../design_management/pages/index.vue | 8 +- .../diffs/components/diff_file_header.vue | 2 +- .../javascripts/pages/admin/keys/index.js | 5 + .../pages/admin/users/keys/index.js | 5 + .../javascripts/pages/profiles/keys/index.js | 3 + .../components/pipeline_new_form.vue | 4 +- .../components/pipelines_list/time_ago.vue | 7 +- .../javascripts/snippet/snippet_show.js | 48 ++- app/assets/javascripts/snippets/index.js | 14 +- .../stylesheets/fontawesome_custom.scss | 4 - .../stylesheets/framework/dropdowns.scss | 18 - .../secondary_navigation_elements.scss | 4 - .../stylesheets/framework/typography.scss | 4 - app/assets/stylesheets/framework/wells.scss | 5 - app/assets/stylesheets/pages/diff.scss | 4 - .../projects/runners_controller.rb | 4 + .../metrics/dashboard/annotations/create.rb | 2 +- app/helpers/profiles_helper.rb | 15 + app/models/group.rb | 94 +++--- app/models/merge_request.rb | 4 + app/models/namespace.rb | 50 +++ app/models/project.rb | 10 + app/services/groups/create_service.rb | 9 + app/services/groups/transfer_service.rb | 14 + app/services/groups/update_service.rb | 13 + .../groups/update_shared_runners_service.rb | 32 +- app/services/merge_requests/base_service.rb | 4 + app/services/projects/create_service.rb | 4 + app/services/projects/transfer_service.rb | 4 + app/views/profiles/keys/_key.html.haml | 11 +- .../profiles/keys/_key_details.html.haml | 2 +- app/views/projects/diffs/_stats.html.haml | 4 +- .../13426-bugfix-copyState-and-padding.yml | 5 + ...nfirmation-dialog-with-a-pajamas-modal.yml | 5 + .../unreleased/ab-reindexing-limit-schema.yml | 5 + ...change-transfer-update-create-services.yml | 5 + .../okr-fluentd-output-settings.yml | 5 + .../set-performance-bar-cookie-expiry.yml | 5 + .../development/api_commits_without_count.yml | 7 + .../disable_shared_runners_on_group.yml | 7 + config/initializers/static_files.rb | 4 +- ...0930094812_update_postgres_indexes_view.rb | 54 +++ db/schema_migrations/20200930094812 | 1 + db/structure.sql | 2 +- doc/user/admin_area/credentials_inventory.md | 2 - .../group/contribution_analytics/index.md | 2 - .../project/settings/project_access_tokens.md | 2 +- lib/api/commits.rb | 32 +- lib/api/helpers/pagination.rb | 4 +- .../alert_management/alert_status_counts.rb | 2 +- lib/gitlab/ci/config/entry/product/matrix.rb | 2 - lib/gitlab/ci/runner/backoff.rb | 4 +- lib/gitlab/danger/commit_linter.rb | 2 +- lib/gitlab/experimentation.rb | 5 +- lib/gitlab/git_access.rb | 2 +- lib/gitlab/health_checks/unicorn_check.rb | 2 +- lib/gitlab/instrumentation/redis.rb | 2 +- .../metrics/dashboard/stages/url_validator.rb | 2 +- .../metrics/samplers/unicorn_sampler.rb | 2 +- lib/gitlab/pagination/offset_pagination.rb | 8 +- lib/gitlab/sidekiq_daemon/memory_killer.rb | 2 +- lib/gitlab/usage_data_queries.rb | 2 +- lib/gitlab/webpack/manifest.rb | 7 +- lib/peek/views/detailed_view.rb | 2 +- locale/gitlab.pot | 18 + package.json | 2 +- qa/Gemfile | 2 +- qa/Gemfile.lock | 14 +- qa/qa/page/profile/ssh_keys.rb | 12 +- rubocop/cop/code_reuse/active_record.rb | 35 +- .../projects/runners_controller_spec.rb | 41 +++ spec/factories/namespaces.rb | 8 + spec/features/admin/admin_users_spec.rb | 8 +- spec/features/profiles/keys_spec.rb | 36 +- .../design_management/pages/index_spec.js | 8 +- spec/frontend/pipeline_new/mock_data.js | 6 +- spec/frontend/snippet/snippet_edit_spec.js | 1 + spec/lib/gitlab/ci/runner/backoff_spec.rb | 30 ++ .../pagination/offset_pagination_spec.rb | 30 +- .../gitlab/prometheus/query_variables_spec.rb | 4 +- spec/lib/gitlab/webpack/manifest_spec.rb | 4 +- spec/models/group_spec.rb | 319 ++++++------------ spec/models/namespace_spec.rb | 136 ++++++++ spec/models/project_spec.rb | 32 ++ spec/requests/api/commits_spec.rb | 59 ++-- .../cop/code_reuse/active_record_spec.rb | 6 +- spec/services/groups/create_service_spec.rb | 40 +++ spec/services/groups/transfer_service_spec.rb | 38 +++ spec/services/groups/update_service_spec.rb | 25 ++ .../update_shared_runners_service_spec.rb | 202 ++--------- spec/services/projects/create_service_spec.rb | 96 ++++++ .../projects/transfer_service_spec.rb | 31 ++ spec/services/projects/update_service_spec.rb | 26 ++ .../services/merge_request_shared_examples.rb | 20 ++ yarn.lock | 8 +- 101 files changed, 1303 insertions(+), 739 deletions(-) create mode 100644 app/assets/javascripts/pages/admin/keys/index.js create mode 100644 app/assets/javascripts/pages/admin/users/keys/index.js create mode 100644 changelogs/unreleased/13426-bugfix-copyState-and-padding.yml create mode 100644 changelogs/unreleased/235945-replace-the-delete-ssh-confirmation-dialog-with-a-pajamas-modal.yml create mode 100644 changelogs/unreleased/ab-reindexing-limit-schema.yml create mode 100644 changelogs/unreleased/change-transfer-update-create-services.yml create mode 100644 changelogs/unreleased/okr-fluentd-output-settings.yml create mode 100644 changelogs/unreleased/set-performance-bar-cookie-expiry.yml create mode 100644 config/feature_flags/development/api_commits_without_count.yml create mode 100644 config/feature_flags/development/disable_shared_runners_on_group.yml create mode 100644 db/migrate/20200930094812_update_postgres_indexes_view.rb create mode 100644 db/schema_migrations/20200930094812 diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index adfadfb745e..cb9bc68e347 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -be4a37406e949983d483a4aabb7af0c0768e60af +61dcdf969231954c06f16a6222a7540460f4b4f0 diff --git a/Gemfile.lock b/Gemfile.lock index f1821c9ce9f..19abf6651a4 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -6,59 +6,59 @@ GEM ace-rails-ap (4.1.2) acme-client (2.0.6) faraday (>= 0.17, < 2.0.0) - actioncable (6.0.3.1) - actionpack (= 6.0.3.1) + actioncable (6.0.3.3) + actionpack (= 6.0.3.3) nio4r (~> 2.0) websocket-driver (>= 0.6.1) - actionmailbox (6.0.3.1) - actionpack (= 6.0.3.1) - activejob (= 6.0.3.1) - activerecord (= 6.0.3.1) - activestorage (= 6.0.3.1) - activesupport (= 6.0.3.1) + actionmailbox (6.0.3.3) + actionpack (= 6.0.3.3) + activejob (= 6.0.3.3) + activerecord (= 6.0.3.3) + activestorage (= 6.0.3.3) + activesupport (= 6.0.3.3) mail (>= 2.7.1) - actionmailer (6.0.3.1) - actionpack (= 6.0.3.1) - actionview (= 6.0.3.1) - activejob (= 6.0.3.1) + actionmailer (6.0.3.3) + actionpack (= 6.0.3.3) + actionview (= 6.0.3.3) + activejob (= 6.0.3.3) mail (~> 2.5, >= 2.5.4) rails-dom-testing (~> 2.0) - actionpack (6.0.3.1) - actionview (= 6.0.3.1) - activesupport (= 6.0.3.1) + actionpack (6.0.3.3) + actionview (= 6.0.3.3) + activesupport (= 6.0.3.3) rack (~> 2.0, >= 2.0.8) rack-test (>= 0.6.3) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.0, >= 1.2.0) - actiontext (6.0.3.1) - actionpack (= 6.0.3.1) - activerecord (= 6.0.3.1) - activestorage (= 6.0.3.1) - activesupport (= 6.0.3.1) + actiontext (6.0.3.3) + actionpack (= 6.0.3.3) + activerecord (= 6.0.3.3) + activestorage (= 6.0.3.3) + activesupport (= 6.0.3.3) nokogiri (>= 1.8.5) - actionview (6.0.3.1) - activesupport (= 6.0.3.1) + actionview (6.0.3.3) + activesupport (= 6.0.3.3) builder (~> 3.1) erubi (~> 1.4) rails-dom-testing (~> 2.0) rails-html-sanitizer (~> 1.1, >= 1.2.0) - activejob (6.0.3.1) - activesupport (= 6.0.3.1) + activejob (6.0.3.3) + activesupport (= 6.0.3.3) globalid (>= 0.3.6) - activemodel (6.0.3.1) - activesupport (= 6.0.3.1) - activerecord (6.0.3.1) - activemodel (= 6.0.3.1) - activesupport (= 6.0.3.1) + activemodel (6.0.3.3) + activesupport (= 6.0.3.3) + activerecord (6.0.3.3) + activemodel (= 6.0.3.3) + activesupport (= 6.0.3.3) activerecord-explain-analyze (0.1.0) activerecord (>= 4) pg - activestorage (6.0.3.1) - actionpack (= 6.0.3.1) - activejob (= 6.0.3.1) - activerecord (= 6.0.3.1) + activestorage (6.0.3.3) + actionpack (= 6.0.3.3) + activejob (= 6.0.3.3) + activerecord (= 6.0.3.3) marcel (~> 0.3.1) - activesupport (6.0.3.1) + activesupport (6.0.3.3) concurrent-ruby (~> 1.0, >= 1.0.2) i18n (>= 0.7, < 2) minitest (~> 5.1) @@ -183,7 +183,7 @@ GEM concord (0.1.5) adamantium (~> 0.2.0) equalizer (~> 0.0.9) - concurrent-ruby (1.1.6) + concurrent-ruby (1.1.7) connection_pool (2.2.2) contracts (0.11.0) cork (0.3.0) @@ -577,7 +577,7 @@ GEM mime-types (~> 3.0) multi_xml (>= 0.5.2) httpclient (2.8.3) - i18n (1.8.3) + i18n (1.8.5) concurrent-ruby (~> 1.0) i18n_data (0.8.0) icalendar (2.4.1) @@ -662,7 +662,7 @@ GEM activesupport (>= 4) railties (>= 4) request_store (~> 1.0) - loofah (2.5.0) + loofah (2.7.0) crass (~> 1.0.2) nokogiri (>= 1.5.9) lru_redux (1.1.0) @@ -713,7 +713,7 @@ GEM net-ntp (2.1.3) net-ssh (6.0.0) netrc (0.11.0) - nio4r (2.5.2) + nio4r (2.5.4) no_proxy_fix (0.1.2) nokogiri (1.10.10) mini_portile2 (~> 2.4.0) @@ -870,20 +870,20 @@ GEM rack-test (1.1.0) rack (>= 1.0, < 3) rack-timeout (0.5.2) - rails (6.0.3.1) - actioncable (= 6.0.3.1) - actionmailbox (= 6.0.3.1) - actionmailer (= 6.0.3.1) - actionpack (= 6.0.3.1) - actiontext (= 6.0.3.1) - actionview (= 6.0.3.1) - activejob (= 6.0.3.1) - activemodel (= 6.0.3.1) - activerecord (= 6.0.3.1) - activestorage (= 6.0.3.1) - activesupport (= 6.0.3.1) + rails (6.0.3.3) + actioncable (= 6.0.3.3) + actionmailbox (= 6.0.3.3) + actionmailer (= 6.0.3.3) + actionpack (= 6.0.3.3) + actiontext (= 6.0.3.3) + actionview (= 6.0.3.3) + activejob (= 6.0.3.3) + activemodel (= 6.0.3.3) + activerecord (= 6.0.3.3) + activestorage (= 6.0.3.3) + activesupport (= 6.0.3.3) bundler (>= 1.3.0) - railties (= 6.0.3.1) + railties (= 6.0.3.3) sprockets-rails (>= 2.0.0) rails-controller-testing (1.0.5) actionpack (>= 5.0.1.rc1) @@ -897,9 +897,9 @@ GEM rails-i18n (6.0.0) i18n (>= 0.7, < 2) railties (>= 6.0.0, < 7) - railties (6.0.3.1) - actionpack (= 6.0.3.1) - activesupport (= 6.0.3.1) + railties (6.0.3.3) + actionpack (= 6.0.3.3) + activesupport (= 6.0.3.3) method_source rake (>= 0.8.7) thor (>= 0.20.3, < 2.0) @@ -1106,7 +1106,7 @@ GEM sprockets (3.7.2) concurrent-ruby (~> 1.0) rack (> 1, < 3) - sprockets-rails (3.2.1) + sprockets-rails (3.2.2) actionpack (>= 4.0) activesupport (>= 4.0) sprockets (>= 3.0.0) @@ -1218,7 +1218,7 @@ GEM addressable (>= 2.3.6) crack (>= 0.3.2) hashdiff (>= 0.4.0, < 2.0.0) - websocket-driver (0.7.1) + websocket-driver (0.7.3) websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) wikicloth (0.8.1) @@ -1230,7 +1230,7 @@ GEM xpath (3.2.0) nokogiri (~> 1.8) yajl-ruby (1.4.1) - zeitwerk (2.3.0) + zeitwerk (2.4.0) PLATFORMS ruby diff --git a/app/assets/javascripts/alert_management/components/alert_details.vue b/app/assets/javascripts/alert_management/components/alert_details.vue index beb636ee8fa..072ed2fa663 100644 --- a/app/assets/javascripts/alert_management/components/alert_details.vue +++ b/app/assets/javascripts/alert_management/components/alert_details.vue @@ -81,15 +81,12 @@ export default { default: '', }, alertId: { - type: String, default: '', }, projectId: { - type: String, default: '', }, projectIssuesPath: { - type: String, default: '', }, }, diff --git a/app/assets/javascripts/alert_management/components/alert_sidebar.vue b/app/assets/javascripts/alert_management/components/alert_sidebar.vue index 64e4089c85a..41d77716592 100644 --- a/app/assets/javascripts/alert_management/components/alert_sidebar.vue +++ b/app/assets/javascripts/alert_management/components/alert_sidebar.vue @@ -18,7 +18,6 @@ export default { default: '', }, projectId: { - type: String, default: '', }, }, diff --git a/app/assets/javascripts/behaviors/shortcuts/shortcuts.js b/app/assets/javascripts/behaviors/shortcuts/shortcuts.js index 8a8b61a57cd..3cb2d6719c8 100644 --- a/app/assets/javascripts/behaviors/shortcuts/shortcuts.js +++ b/app/assets/javascripts/behaviors/shortcuts/shortcuts.js @@ -117,9 +117,9 @@ export default class Shortcuts { e.preventDefault(); const performanceBarCookieName = 'perf_bar_enabled'; if (parseBoolean(Cookies.get(performanceBarCookieName))) { - Cookies.set(performanceBarCookieName, 'false', { path: '/' }); + Cookies.set(performanceBarCookieName, 'false', { expires: 365, path: '/' }); } else { - Cookies.set(performanceBarCookieName, 'true', { path: '/' }); + Cookies.set(performanceBarCookieName, 'true', { expires: 365, path: '/' }); } refreshCurrentPage(); } diff --git a/app/assets/javascripts/clusters/components/fluentd_output_settings.vue b/app/assets/javascripts/clusters/components/fluentd_output_settings.vue index e6001b11296..7b55efaaccd 100644 --- a/app/assets/javascripts/clusters/components/fluentd_output_settings.vue +++ b/app/assets/javascripts/clusters/components/fluentd_output_settings.vue @@ -1,7 +1,7 @@