From ddcfba97daaf486899b30cd71f7ee2400389e527 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 27 May 2025 21:11:53 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop.yml | 16 ++ .../command_palette/constants.js | 1 + .../command_palette/search_item.vue | 16 +- .../components/frequent_item.vue | 7 +- .../components/frequent_item_skeleton.vue | 7 +- .../components/frequent_items.vue | 5 +- .../global_search_autocomplete_items.vue | 18 +- .../components/global_search_scoped_items.vue | 5 +- app/controllers/projects_controller.rb | 1 + app/models/merge_request_diff.rb | 3 + app/services/projects/create_service.rb | 9 + .../ci_configuration/base_create_service.rb | 4 +- .../secret_detection_create_service.rb | 22 +- .../projects/_new_project_fields.html.haml | 9 + ...ck_sidekiq_concurrency_limit_execution.yml | 9 - doc/administration/auditor_users.md | 2 +- doc/administration/auth/ldap/_index.md | 1 + .../auth/ldap/ldap_synchronization.md | 1 + .../background_verification.md | 1 + .../geo/replication/datatypes.md | 1 + doc/administration/geo/replication/faq.md | 1 + .../geo/replication/geo_validation_tests.md | 1 + .../geo/replication/object_storage.md | 1 + doc/administration/geo/replication/tuning.md | 1 + doc/administration/geo_sites.md | 1 + doc/administration/incoming_email.md | 1 + doc/administration/integration/mailgun.md | 1 + doc/administration/integration/plantuml.md | 1 + doc/administration/monitoring/health_check.md | 1 + .../monitoring/performance/_index.md | 1 + doc/administration/object_storage.md | 1 + .../operations/fast_ssh_key_lookup.md | 1 + doc/administration/raketasks/ldap.md | 1 + .../repository_storage_paths.md | 1 + doc/api/group_ldap_links.md | 1 + doc/ci/debugging.md | 8 +- doc/ci/docker/docker_build_troubleshooting.md | 205 ++++++++++++++ doc/ci/docker/using_docker_build.md | 201 -------------- doc/ci/jobs/job_artifacts_troubleshooting.md | 2 +- doc/ci/jobs/ssh_keys.md | 2 +- doc/ci/variables/_index.md | 258 ----------------- doc/ci/variables/predefined_variables.md | 4 +- doc/ci/variables/variables_troubleshooting.md | 262 ++++++++++++++++++ doc/ci/yaml/script.md | 130 --------- doc/ci/yaml/script_troubleshooting.md | 134 +++++++++ doc/development/secure_coding_guidelines.md | 4 +- .../advanced_search/elasticsearch.md | 3 +- doc/integration/salesforce.md | 1 + doc/tutorials/manage_user/_index.md | 1 + doc/user/gitlab_duo_chat/agentic_chat.md | 2 +- doc/user/permissions.md | 2 +- doc/user/project/_index.md | 2 + .../databases/opensearch/executor.rb | 2 +- .../concurrency_limit/middleware.rb | 9 - .../secret_detection_build_action.rb | 69 +++++ locale/gitlab.pot | 9 + qa/gems/gitlab-orchestrator/Gemfile | 2 +- qa/gems/gitlab-orchestrator/Gemfile.lock | 6 +- .../gitlab/deprecated_audit_event_service.rb | 60 ++++ .../workspaces_kubernetes_setup.sh | 12 +- spec/controllers/projects_controller_spec.rb | 31 +++ .../__snapshots__/search_item_spec.js.snap | 34 ++- .../components/frequent_item_spec.js | 2 +- .../concurrency_limit/server_spec.rb | 32 --- .../secret_detection_build_action_spec.rb | 69 ++++- spec/models/ci/job_artifact_spec.rb | 22 ++ spec/models/ci/pipeline_artifact_spec.rb | 22 ++ spec/models/ci/secure_file_spec.rb | 22 ++ spec/models/concerns/ci/artifactable_spec.rb | 18 -- spec/models/dependency_proxy/blob_spec.rb | 22 ++ spec/models/dependency_proxy/manifest_spec.rb | 22 ++ spec/models/fork_network_spec.rb | 6 + spec/models/lfs_object_spec.rb | 24 +- spec/models/merge_request_diff_spec.rb | 22 ++ spec/models/packages/package_file_spec.rb | 22 ++ spec/models/pages_deployment_spec.rb | 4 +- spec/models/terraform/state_version_spec.rb | 20 +- spec/models/upload_spec.rb | 22 ++ .../deprecated_audit_event_service_spec.rb | 28 ++ spec/services/projects/create_service_spec.rb | 16 ++ .../secret_detection_create_service_spec.rb | 116 +++++++- spec/support/helpers/test_env.rb | 17 +- .../object_storable_shared_examples.rb | 28 +- .../create_service_shared_examples.rb | 2 +- 84 files changed, 1413 insertions(+), 753 deletions(-) delete mode 100644 config/feature_flags/gitlab_com_derisk/track_sidekiq_concurrency_limit_execution.yml create mode 100644 doc/ci/docker/docker_build_troubleshooting.md create mode 100644 doc/ci/variables/variables_troubleshooting.md create mode 100644 doc/ci/yaml/script_troubleshooting.md create mode 100644 rubocop/cop/gitlab/deprecated_audit_event_service.rb create mode 100644 spec/rubocop/cop/gitlab/deprecated_audit_event_service_spec.rb diff --git a/.rubocop.yml b/.rubocop.yml index d854ac61359..b562db994a8 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -496,6 +496,22 @@ GitlabSecurity/PublicSend: - 'ee/lib/**/*.rake' - 'ee/spec/**/*' +Gitlab/DeprecatedAuditEventService: + Enabled: true + Exclude: + - 'ee/app/services/ee/audit_event_service.rb' + - 'ee/app/services/ee/applications/create_service.rb' + - 'ee/app/services/audit_events/release_audit_event_service.rb' + - 'ee/app/services/ee/keys/create_service.rb' + - 'ee/app/services/ee/users/migrate_records_to_ghost_user_service.rb' + - 'ee/spec/features/admin/admin_audit_logs_spec.rb' + - 'ee/spec/controllers/groups/omniauth_callbacks_controller_spec.rb' + - 'ee/spec/services/audit_event_service_spec.rb' + - 'ee/lib/gitlab/auth/group_saml/membership_updater.rb' + - 'app/controllers/sessions_controller.rb' + - 'app/services/audit_event_service.rb' + - 'spec/services/audit_event_service_spec.rb' + Database/MultipleDatabases: Enabled: true Exclude: diff --git a/app/assets/javascripts/super_sidebar/components/global_search/command_palette/constants.js b/app/assets/javascripts/super_sidebar/components/global_search/command_palette/constants.js index 2eaab26da75..4652b56b2e4 100644 --- a/app/assets/javascripts/super_sidebar/components/global_search/command_palette/constants.js +++ b/app/assets/javascripts/super_sidebar/components/global_search/command_palette/constants.js @@ -78,3 +78,4 @@ export const FREQUENTLY_VISITED_GROUPS_HANDLE = 'FREQUENTLY_VISITED_GROUPS_HANDL export const GROUPS_GROUP_HANDLE = 'Groups'; export const PROJECTS_GROUP_HANDLE = 'Projects'; +export const USER_CATEGORY_VALUE = 'Users'; diff --git a/app/assets/javascripts/super_sidebar/components/global_search/command_palette/search_item.vue b/app/assets/javascripts/super_sidebar/components/global_search/command_palette/search_item.vue index c0ed5350309..d2a1fa8b684 100644 --- a/app/assets/javascripts/super_sidebar/components/global_search/command_palette/search_item.vue +++ b/app/assets/javascripts/super_sidebar/components/global_search/command_palette/search_item.vue @@ -2,7 +2,8 @@ import { GlAvatar, GlIcon } from '@gitlab/ui'; import SafeHtml from '~/vue_shared/directives/safe_html'; import highlight from '~/lib/utils/highlight'; -import { AVATAR_SHAPE_OPTION_RECT } from '~/vue_shared/constants'; +import { AVATAR_SHAPE_OPTION_RECT, AVATAR_SHAPE_OPTION_CIRCLE } from '~/vue_shared/constants'; +import { USER_CATEGORY_VALUE } from './constants'; export default { name: 'CommandPaletteSearchItem', @@ -27,8 +28,14 @@ export default { highlightedName() { return highlight(this.item.text, this.searchQuery); }, + avatarShape() { + return this.item.category === USER_CATEGORY_VALUE + ? this.$options.AVATAR_SHAPE_OPTION_CIRCLE + : this.$options.AVATAR_SHAPE_OPTION_RECT; + }, }, AVATAR_SHAPE_OPTION_RECT, + AVATAR_SHAPE_OPTION_CIRCLE, }; @@ -40,13 +47,14 @@ export default { :src="item.avatar_url" :entity-id="item.entity_id" :entity-name="item.entity_name" - :size="item.avatar_size" - :shape="$options.AVATAR_SHAPE_OPTION_RECT" + :size="16" + :shape="avatarShape" aria-hidden="true" /> - + +