From ea090291bba6bb665b3631cc5a2659e6673a6959 Mon Sep 17 00:00:00 2001 From: Eric Eastwood Date: Wed, 31 May 2017 00:50:53 -0500 Subject: [PATCH] Rename "Slash commands" to "Quick actions" Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27070 Deprecate "chat commands" in favor of "slash commands" We looked for things like: - `slash commmand` - `slash_command` - `slash-command` - `SlashCommand` --- app/assets/javascripts/gfm_auto_complete.js | 6 +-- .../components/fields/description.vue | 2 +- app/assets/javascripts/notes.js | 44 ++++++++--------- app/assets/javascripts/preview_markdown.js | 2 +- .../components/time_tracking/help_state.js | 4 +- .../time_tracking/sidebar_time_tracking.js | 8 ++-- app/helpers/notes_helper.rb | 4 +- app/models/merge_request.rb | 2 +- app/models/note.rb | 2 +- .../mattermost_slash_commands_service.rb | 2 +- .../slack_slash_commands_service.rb | 2 +- ...s_service.rb => slash_commands_service.rb} | 6 +-- app/policies/global_policy.rb | 2 +- app/services/issuable_base_service.rb | 6 +-- app/services/merge_requests/update_service.rb | 6 +-- app/services/notes/create_service.rb | 8 ++-- ...ds_service.rb => quick_actions_service.rb} | 4 +- app/services/preview_markdown_service.rb | 12 ++--- app/services/projects/autocomplete_service.rb | 2 +- .../interpret_service.rb | 12 ++--- app/views/projects/_zen.html.haml | 4 +- .../projects/issues/_issue_by_email.html.haml | 2 +- .../form_elements/_description.html.haml | 10 ++-- app/views/shared/notes/_form.html.haml | 10 ++-- app/views/shared/notes/_hints.html.haml | 6 +-- ...rename-slash-commands-to-quick-actions.yml | 5 ++ doc/README.md | 2 +- doc/development/limit_ee_conflicts.md | 4 +- doc/integration/chat_commands.md | 15 +----- doc/integration/slash_commands.md | 14 ++++++ doc/user/discussions/index.md | 4 +- .../integrations/slack_slash_commands.md | 4 +- .../project/issues/issues_functionalities.md | 4 +- doc/user/project/quick_actions.md | 39 +++++++++++++++ doc/user/project/slash_commands.md | 40 +--------------- doc/workflow/README.md | 2 +- doc/workflow/time_tracking.md | 8 ++-- lib/api/services.rb | 4 +- lib/api/v3/services.rb | 4 +- .../command_definition.rb | 2 +- .../{slash_commands => quick_actions}/dsl.rb | 6 +-- .../extractor.rb | 6 +-- .../base_command.rb | 2 +- .../command.rb | 14 +++--- .../deploy.rb | 8 ++-- .../{chat_commands => slash_commands}/help.rb | 4 +- .../issue_command.rb | 2 +- .../issue_new.rb | 4 +- .../issue_search.rb | 2 +- .../issue_show.rb | 6 +-- .../presenters/access.rb | 2 +- .../presenters/base.rb | 2 +- .../presenters/deploy.rb | 2 +- .../presenters/help.rb | 2 +- .../presenters/issue_base.rb | 2 +- .../presenters/issue_new.rb | 2 +- .../presenters/issue_search.rb | 2 +- .../presenters/issue_show.rb | 2 +- .../result.rb | 2 +- .../projects/issues_controller_spec.rb | 2 +- spec/features/issues/award_emoji_spec.rb | 8 ++-- spec/features/issues/gfm_autocomplete_spec.rb | 2 +- .../issues/user_uses_slash_commands_spec.rb | 6 +-- .../user_uses_slash_commands_spec.rb | 6 +-- spec/javascripts/notes_spec.js | 48 +++++++++---------- .../email/handler/create_note_handler_spec.rb | 2 +- .../command_definition_spec.rb | 2 +- .../dsl_spec.rb | 4 +- .../extractor_spec.rb | 4 +- .../command_spec.rb | 8 ++-- .../deploy_spec.rb | 2 +- .../issue_new_spec.rb | 2 +- .../issue_search_spec.rb | 2 +- .../issue_show_spec.rb | 2 +- .../presenters/access_spec.rb | 2 +- .../presenters/deploy_spec.rb | 2 +- .../presenters/issue_new_spec.rb | 2 +- .../presenters/issue_search_spec.rb | 2 +- .../presenters/issue_show_spec.rb | 2 +- spec/models/merge_request_spec.rb | 24 +++++----- spec/services/issues/create_service_spec.rb | 4 +- .../merge_requests/create_service_spec.rb | 4 +- ..._spec.rb => quick_actions_service_spec.rb} | 12 ++--- .../services/preview_markdown_service_spec.rb | 18 +++---- .../interpret_service_spec.rb | 2 +- .../chat_slash_commands_shared_examples.rb | 2 +- ...issuable_slash_commands_shared_examples.rb | 6 +-- ...ds_helpers.rb => quick_actions_helpers.rb} | 2 +- ..._service_slash_commands_shared_examples.rb | 2 +- spec/support/time_tracking_shared_examples.rb | 8 ++-- .../shared/notes/_form.html.haml_spec.rb | 6 +-- 91 files changed, 299 insertions(+), 292 deletions(-) rename app/models/project_services/{chat_slash_commands_service.rb => slash_commands_service.rb} (84%) rename app/services/notes/{slash_commands_service.rb => quick_actions_service.rb} (88%) rename app/services/{slash_commands => quick_actions}/interpret_service.rb (97%) create mode 100644 changelogs/unreleased/27070-rename-slash-commands-to-quick-actions.yml create mode 100644 doc/integration/slash_commands.md create mode 100644 doc/user/project/quick_actions.md rename lib/gitlab/{slash_commands => quick_actions}/command_definition.rb (98%) rename lib/gitlab/{slash_commands => quick_actions}/dsl.rb (96%) rename lib/gitlab/{slash_commands => quick_actions}/extractor.rb (94%) rename lib/gitlab/{chat_commands => slash_commands}/base_command.rb (97%) rename lib/gitlab/{chat_commands => slash_commands}/command.rb (65%) rename lib/gitlab/{chat_commands => slash_commands}/deploy.rb (79%) rename lib/gitlab/{chat_commands => slash_commands}/help.rb (82%) rename lib/gitlab/{chat_commands => slash_commands}/issue_command.rb (92%) rename lib/gitlab/{chat_commands => slash_commands}/issue_new.rb (92%) rename lib/gitlab/{chat_commands => slash_commands}/issue_search.rb (95%) rename lib/gitlab/{chat_commands => slash_commands}/issue_show.rb (69%) rename lib/gitlab/{chat_commands => slash_commands}/presenters/access.rb (98%) rename lib/gitlab/{chat_commands => slash_commands}/presenters/base.rb (98%) rename lib/gitlab/{chat_commands => slash_commands}/presenters/deploy.rb (95%) rename lib/gitlab/{chat_commands => slash_commands}/presenters/help.rb (96%) rename lib/gitlab/{chat_commands => slash_commands}/presenters/issue_base.rb (97%) rename lib/gitlab/{chat_commands => slash_commands}/presenters/issue_new.rb (98%) rename lib/gitlab/{chat_commands => slash_commands}/presenters/issue_search.rb (98%) rename lib/gitlab/{chat_commands => slash_commands}/presenters/issue_show.rb (98%) rename lib/gitlab/{chat_commands => slash_commands}/result.rb (73%) rename spec/lib/gitlab/{slash_commands => quick_actions}/command_definition_spec.rb (99%) rename spec/lib/gitlab/{slash_commands => quick_actions}/dsl_spec.rb (97%) rename spec/lib/gitlab/{slash_commands => quick_actions}/extractor_spec.rb (98%) rename spec/lib/gitlab/{chat_commands => slash_commands}/command_spec.rb (93%) rename spec/lib/gitlab/{chat_commands => slash_commands}/deploy_spec.rb (98%) rename spec/lib/gitlab/{chat_commands => slash_commands}/issue_new_spec.rb (97%) rename spec/lib/gitlab/{chat_commands => slash_commands}/issue_search_spec.rb (95%) rename spec/lib/gitlab/{chat_commands => slash_commands}/issue_show_spec.rb (96%) rename spec/lib/gitlab/{chat_commands => slash_commands}/presenters/access_spec.rb (95%) rename spec/lib/gitlab/{chat_commands => slash_commands}/presenters/deploy_spec.rb (96%) rename spec/lib/gitlab/{chat_commands => slash_commands}/presenters/issue_new_spec.rb (88%) rename spec/lib/gitlab/{chat_commands => slash_commands}/presenters/issue_search_spec.rb (90%) rename spec/lib/gitlab/{chat_commands => slash_commands}/presenters/issue_show_spec.rb (96%) rename spec/services/notes/{slash_commands_service_spec.rb => quick_actions_service_spec.rb} (94%) rename spec/services/{slash_commands => quick_actions}/interpret_service_spec.rb (99%) rename spec/support/{slash_commands_helpers.rb => quick_actions_helpers.rb} (88%) diff --git a/app/assets/javascripts/gfm_auto_complete.js b/app/assets/javascripts/gfm_auto_complete.js index 401dec1a370..105762cb1ba 100644 --- a/app/assets/javascripts/gfm_auto_complete.js +++ b/app/assets/javascripts/gfm_auto_complete.js @@ -34,7 +34,7 @@ class GfmAutoComplete { const $input = $(input); $input.off('focus.setupAtWho').on('focus.setupAtWho', this.setupAtWho.bind(this, $input)); // This triggers at.js again - // Needed for slash commands with suffixes (ex: /label ~) + // Needed for quick actions with suffixes (ex: /label ~) $input.on('inserted-commands.atwho', $input.trigger.bind($input, 'keyup')); $input.on('clear-commands-cache.atwho', () => this.clearCache()); }); @@ -48,8 +48,8 @@ class GfmAutoComplete { if (this.enableMap.mergeRequests) this.setupMergeRequests($input); if (this.enableMap.labels) this.setupLabels($input); - // We don't instantiate the slash commands autocomplete for note and issue/MR edit forms - $input.filter('[data-supports-slash-commands="true"]').atwho({ + // We don't instantiate the quick actions autocomplete for note and issue/MR edit forms + $input.filter('[data-supports-quick-actions="true"]').atwho({ at: '/', alias: 'commands', searchKey: 'search', diff --git a/app/assets/javascripts/issue_show/components/fields/description.vue b/app/assets/javascripts/issue_show/components/fields/description.vue index 30a1be5cb50..54650d2f184 100644 --- a/app/assets/javascripts/issue_show/components/fields/description.vue +++ b/app/assets/javascripts/issue_show/components/fields/description.vue @@ -41,7 +41,7 @@