From ea1dcaef18edf97b3ac73892d64ebaf5eecd7f68 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 31 Mar 2021 12:08:55 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_manual_todo.yml | 20 --- GITALY_SERVER_VERSION | 2 +- .../javascripts/clusters/forms/show/index.js | 2 +- .../javascripts/diffs/components/diff_row.vue | 9 +- .../javascripts/diffs/store/mutations.js | 7 +- .../compare/components/revision_dropdown.vue | 59 +++++--- .../markdown/suggestion_diff_header.vue | 9 +- .../concerns/runner_setup_scripts.rb | 4 +- .../groups/settings/ci_cd_controller.rb | 2 +- .../projects/merge_requests_controller.rb | 1 - .../projects/settings/ci_cd_controller.rb | 2 +- .../resolvers/ci/runner_setup_resolver.rb | 6 +- .../project_services/jenkins_service.rb | 1 - .../_gitlab_integration_form.html.haml | 4 +- ...ption-or-any-custom-merge-commit-messa.yml | 5 + ...-remove-batch_suggestions-feature-flag.yml | 5 + .../324612-tag-not-visible-compare-page.yml | 5 + ...102-deprecate-runner-install-arguments.yml | 5 + ...40-fix-rails-savebang-presenter-module.yml | 5 + .../rails-save-bang-auth-controllers.yml | 5 + .../rails-save-bang-spec-features.yml | 5 + .../development/batch_suggestions.yml | 8 -- .../sentry_processors_before_send.yml | 8 ++ doc/api/graphql/reference/index.md | 4 +- .../site_architecture/release_process.md | 73 ++++++---- doc/development/i18n/externalization.md | 2 +- doc/development/usage_ping/dictionary.md | 48 +++++++ doc/user/discussions/index.md | 29 +--- doc/user/project/integrations/github.md | 45 +++--- .../integrations/img/github_configuration.png | Bin 12258 -> 0 bytes lib/api/entities/project.rb | 2 +- lib/api/internal/kubernetes.rb | 4 +- lib/gitlab/ci/runner_instructions.rb | 31 +--- lib/gitlab/error_tracking.rb | 10 +- .../processor/context_payload_processor.rb | 12 ++ .../processor/grpc_error_processor.rb | 136 +++++++++++++----- .../processor/sidekiq_processor.rb | 71 ++++++--- .../known_events/epic_events.yml | 18 +++ locale/gitlab.pot | 27 +++- scripts/review_apps/base-config.yaml | 6 +- .../oauth/authorizations_controller_spec.rb | 4 +- .../omniauth_callbacks_controller_spec.rb | 8 +- spec/features/calendar_spec.rb | 2 +- .../clusters/cluster_detail_page_spec.rb | 6 +- spec/features/commits_spec.rb | 2 +- .../user_sees_error_index_spec.rb | 2 +- spec/features/groups/clusters/user_spec.rb | 2 +- .../groups/members/request_access_spec.rb | 2 +- spec/features/profiles/emails_spec.rb | 8 +- spec/features/profiles/password_spec.rb | 2 +- .../profiles/personal_access_tokens_spec.rb | 2 +- spec/features/projects/clusters/gcp_spec.rb | 2 +- spec/features/projects/clusters/user_spec.rb | 2 +- spec/features/projects/clusters_spec.rb | 4 +- spec/features/runners_spec.rb | 6 +- .../security/project/internal_access_spec.rb | 12 +- .../security/project/private_access_spec.rb | 14 +- .../security/project/public_access_spec.rb | 12 +- spec/features/users/login_spec.rb | 2 +- spec/features/users/show_spec.rb | 6 +- .../components/revision_dropdown_spec.js | 41 +++++- .../markdown/suggestion_diff_header_spec.js | 20 +-- .../ci/runner_setup_resolver_spec.rb | 77 +--------- .../lib/gitlab/ci/runner_instructions_spec.rb | 116 ++------------- .../context_payload_processor_spec.rb | 87 ++++++----- .../processor/grpc_error_processor_spec.rb | 90 ++++++------ .../processor/sidekiq_processor_spec.rb | 96 ++++++++----- spec/lib/gitlab/error_tracking_spec.rb | 110 +++++++++++--- .../ci/build_runner_presenter_spec.rb | 4 +- spec/presenters/ci/trigger_presenter_spec.rb | 2 +- .../packages/conan/package_presenter_spec.rb | 2 +- spec/requests/api/internal/kubernetes_spec.rb | 8 +- workhorse/config_test.go | 2 +- workhorse/main.go | 2 +- 74 files changed, 809 insertions(+), 645 deletions(-) create mode 100644 changelogs/unreleased/232957-include-merge-request-description-or-any-custom-merge-commit-messa.yml create mode 100644 changelogs/unreleased/320755-remove-batch_suggestions-feature-flag.yml create mode 100644 changelogs/unreleased/324612-tag-not-visible-compare-page.yml create mode 100644 changelogs/unreleased/326102-deprecate-runner-install-arguments.yml create mode 100644 changelogs/unreleased/issue-220040-fix-rails-savebang-presenter-module.yml create mode 100644 changelogs/unreleased/rails-save-bang-auth-controllers.yml create mode 100644 changelogs/unreleased/rails-save-bang-spec-features.yml delete mode 100644 config/feature_flags/development/batch_suggestions.yml create mode 100644 config/feature_flags/development/sentry_processors_before_send.yml delete mode 100644 doc/user/project/integrations/img/github_configuration.png diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index 173bbafdf41..92dd20f484c 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -182,8 +182,6 @@ Rails/SaveBang: - 'spec/controllers/groups/runners_controller_spec.rb' - 'spec/controllers/groups/uploads_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - - 'spec/controllers/oauth/authorizations_controller_spec.rb' - - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/profiles/emails_controller_spec.rb' - 'spec/controllers/profiles/notifications_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' @@ -197,16 +195,10 @@ Rails/SaveBang: - 'spec/features/admin/admin_sees_project_statistics_spec.rb' - 'spec/features/admin/admin_sees_projects_statistics_spec.rb' - 'spec/features/admin/admin_users_impersonation_tokens_spec.rb' - - 'spec/features/boards/sidebar_spec.rb' - - 'spec/features/calendar_spec.rb' - - 'spec/features/commits_spec.rb' - 'spec/features/dashboard/datetime_on_tooltips_spec.rb' - 'spec/features/dashboard/issuables_counter_spec.rb' - 'spec/features/dashboard/project_member_activity_index_spec.rb' - 'spec/features/dashboard/projects_spec.rb' - - 'spec/features/error_tracking/user_sees_error_index_spec.rb' - - 'spec/features/groups/members/request_access_spec.rb' - - 'spec/features/issuables/close_reopen_report_toggle_spec.rb' - 'spec/features/issues/bulk_assignment_labels_spec.rb' - 'spec/features/issues/gfm_autocomplete_spec.rb' - 'spec/features/issues/issue_sidebar_spec.rb' @@ -217,9 +209,6 @@ Rails/SaveBang: - 'spec/features/issues/user_filters_issues_spec.rb' - 'spec/features/issues/user_sees_live_update_spec.rb' - 'spec/features/issues/user_sorts_issues_spec.rb' - - 'spec/features/profiles/emails_spec.rb' - - 'spec/features/profiles/password_spec.rb' - - 'spec/features/profiles/personal_access_tokens_spec.rb' - 'spec/features/projects/features_visibility_spec.rb' - 'spec/features/projects/fork_spec.rb' - 'spec/features/projects/jobs_spec.rb' @@ -236,12 +225,6 @@ Rails/SaveBang: - 'spec/features/projects/wiki/user_updates_wiki_page_spec.rb' - 'spec/features/projects/wiki/user_views_wiki_page_spec.rb' - 'spec/features/projects/wiki/users_views_asciidoc_page_with_includes_spec.rb' - - 'spec/features/runners_spec.rb' - - 'spec/features/security/project/internal_access_spec.rb' - - 'spec/features/security/project/private_access_spec.rb' - - 'spec/features/security/project/public_access_spec.rb' - - 'spec/features/users/login_spec.rb' - - 'spec/features/users/show_spec.rb' - 'spec/frontend/fixtures/issues.rb' - 'spec/frontend/fixtures/merge_requests.rb' - 'spec/graphql/mutations/merge_requests/set_locked_spec.rb' @@ -369,9 +352,6 @@ Rails/SaveBang: - 'spec/models/user_status_spec.rb' - 'spec/models/wiki_page/meta_spec.rb' - 'spec/models/wiki_page_spec.rb' - - 'spec/presenters/ci/build_runner_presenter_spec.rb' - - 'spec/presenters/ci/trigger_presenter_spec.rb' - - 'spec/presenters/packages/conan/package_presenter_spec.rb' - 'spec/requests/api/ci/runner_spec.rb' - 'spec/requests/api/commit_statuses_spec.rb' - 'spec/requests/api/conan_packages_spec.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 1ac9f38e3db..10800cff591 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -79003389aa5098a6ef37e73298cafbad4d9e6b79 +67a362bf7aaab3aae021d19fda728c24b7723d7a diff --git a/app/assets/javascripts/clusters/forms/show/index.js b/app/assets/javascripts/clusters/forms/show/index.js index 47a3016c777..3cb4376f41a 100644 --- a/app/assets/javascripts/clusters/forms/show/index.js +++ b/app/assets/javascripts/clusters/forms/show/index.js @@ -3,7 +3,7 @@ import IntegrationForm from '../components/integration_form.vue'; import { createStore } from '../stores'; export default () => { - const entryPoint = document.querySelector('#js-cluster-integration-form'); + const entryPoint = document.querySelector('#js-cluster-details-form'); if (!entryPoint) { return; diff --git a/app/assets/javascripts/diffs/components/diff_row.vue b/app/assets/javascripts/diffs/components/diff_row.vue index f8da3ad14ec..9f0f7d46804 100644 --- a/app/assets/javascripts/diffs/components/diff_row.vue +++ b/app/assets/javascripts/diffs/components/diff_row.vue @@ -1,5 +1,6 @@