From ecc11e5d608ff4393fb6c44d02416569e7d2785d Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 10 Dec 2021 15:10:24 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/rails/include_url_helper.yml | 4 - GITALY_SERVER_VERSION | 2 +- app/assets/javascripts/issues/form.js | 7 +- .../components/title_suggestions.vue} | 8 +- .../components/title_suggestions_item.vue} | 0 .../components/type_popover.vue} | 4 +- .../issues/{suggestions => new}/index.js | 32 +++- .../queries/issues.query.graphql | 0 .../javascripts/issues/type_selector/index.js | 16 -- .../javascripts/lib/utils/common_utils.js | 11 ++ .../runner/components/runner_list.vue | 14 +- app/assets/javascripts/runner/constants.js | 1 + .../graphql/runner_node.fragment.graphql | 1 + app/assets/stylesheets/pages/issuable.scss | 4 - app/controllers/application_controller.rb | 1 + app/controllers/concerns/check_rate_limit.rb | 22 ++- .../concerns/integrations/hooks_execution.rb | 12 -- app/controllers/concerns/notes_actions.rb | 7 +- app/controllers/groups_controller.rb | 10 +- app/controllers/import/base_controller.rb | 16 +- .../import/gitlab_groups_controller.rb | 11 +- app/controllers/profiles/emails_controller.rb | 16 +- app/controllers/projects/hooks_controller.rb | 2 +- app/controllers/projects/issues_controller.rb | 18 +- .../projects/pipeline_schedules_controller.rb | 10 +- app/controllers/projects/raw_controller.rb | 18 +- .../projects/repositories_controller.rb | 16 +- .../projects/settings/ci_cd_controller.rb | 1 + app/controllers/projects_controller.rb | 14 +- app/models/ci/namespace_mirror.rb | 30 ++- app/models/ci/project_mirror.rb | 9 +- app/models/container_repository.rb | 11 +- app/models/error_tracking/error_event.rb | 3 + .../loose_foreign_keys/deleted_record.rb | 36 +++- app/models/namespace.rb | 12 ++ app/models/namespaces/sync_event.rb | 16 ++ app/models/project.rb | 12 ++ app/models/projects/sync_event.rb | 16 ++ .../namespaces/user_namespace_policy.rb | 3 +- app/presenters/ci/pipeline_presenter.rb | 9 +- app/presenters/prometheus_alert_presenter.rb | 2 - ...ntainer_registry_authentication_service.rb | 2 +- .../ci/process_sync_events_service.rb | 58 ++++++ app/services/ci/retry_build_service.rb | 10 +- app/services/search_service.rb | 2 +- .../shared/milestones/_sidebar.html.haml | 4 +- app/workers/all_queues.yml | 18 ++ .../namespaces/process_sync_events_worker.rb | 22 +++ .../projects/process_sync_events_worker.rb | 22 +++ .../api_v3_commits_skip_diff_files.yml | 8 - ...y.yml => ci_namespace_project_mirrors.yml} | 8 +- .../lfk_automatic_partition_creation.yml | 8 + .../lfk_automatic_partition_dropping.yml | 8 + config/initializers/postgres_partitioning.rb | 3 +- config/sidekiq_queues.yml | 4 + db/fixtures/development/32_crm.rb | 47 +++++ ...011140932_create_namespaces_sync_events.rb | 9 + ...11011141239_create_projects_sync_events.rb | 9 + ...11141242_create_namespaces_sync_trigger.rb | 37 ++++ ...1011141243_create_projects_sync_trigger.rb | 37 ++++ ...se_fk_deleted_records_to_dynamic_schema.rb | 17 ++ db/schema_migrations/20211011140932 | 1 + db/schema_migrations/20211011141239 | 1 + db/schema_migrations/20211011141242 | 1 + db/schema_migrations/20211011141243 | 1 + db/schema_migrations/20211202094944 | 1 + db/structure.sql | 151 ++++++++++----- doc/administration/gitaly/recovery.md | 2 +- doc/administration/pages/index.md | 4 +- doc/api/graphql/reference/index.md | 2 +- doc/api/topics.md | 2 +- .../cloud_native_gitlab_pages/index.md | 2 +- .../index.md | 4 +- doc/ci/ci_cd_for_external_repos/index.md | 2 +- doc/ci/pipelines/merge_trains.md | 2 +- .../pipelines/pipelines_for_merged_results.md | 2 +- doc/ci/test_cases/index.md | 2 +- doc/development/go_guide/go_upgrade.md | 6 +- doc/development/go_guide/index.md | 10 +- doc/development/integrations/secure.md | 2 +- doc/development/secure_coding_guidelines.md | 2 +- .../shell_scripting_guide/index.md | 2 +- doc/install/installation.md | 4 +- doc/push_rules/push_rules.md | 2 +- doc/subscriptions/index.md | 2 +- doc/update/upgrading_from_source.md | 2 +- .../application_security/api_fuzzing/index.md | 2 +- .../container_scanning/index.md | 2 +- .../dast/browser_based.md | 18 +- doc/user/application_security/dast/index.md | 2 +- .../dependency_scanning/index.md | 4 +- doc/user/application_security/index.md | 2 +- .../security_dashboard/index.md | 2 +- doc/user/clusters/agent/index.md | 2 +- .../compliance/license_compliance/index.md | 16 +- doc/user/group/epics/epic_boards.md | 2 +- doc/user/group/epics/index.md | 2 +- doc/user/group/saml_sso/index.md | 2 +- doc/user/packages/go_proxy/index.md | 4 +- doc/user/project/clusters/serverless/index.md | 2 +- doc/user/project/code_owners.md | 2 +- .../pages/lets_encrypt_for_gitlab_pages.md | 2 +- doc/user/project/requirements/index.md | 2 +- doc/user/project/working_with_projects.md | 2 +- doc/user/search/advanced_search.md | 2 +- lib/api/group_export.rb | 4 +- lib/api/helpers/rate_limiter.rb | 27 +-- lib/api/issues.rb | 2 +- lib/api/notes.rb | 2 +- lib/api/project_export.rb | 4 +- lib/api/project_import.rb | 4 +- lib/api/repositories.rb | 6 +- lib/api/v3/github.rb | 2 - lib/gitlab/application_rate_limiter.rb | 9 +- lib/gitlab/ci/badge/metadata.rb | 3 +- lib/gitlab/database/gitlab_schemas.yml | 2 + lib/gitlab/database/schema_helpers.rb | 1 + lib/gitlab/database/type/json_pg_safe.rb | 24 +++ lib/gitlab/rate_limit_helpers.rb | 35 ---- lib/gitlab/repository_archive_rate_limiter.rb | 13 ++ locale/gitlab.pot | 15 +- .../profiles/emails_controller_spec.rb | 2 +- .../projects/repositories_controller_spec.rb | 2 +- .../settings/ci_cd_controller_spec.rb | 11 ++ spec/features/admin/admin_runners_spec.rb | 13 ++ .../parsed_event_nullbytes.json | 175 ++++++++++++++++++ .../__snapshots__/type_popover_spec.js.snap} | 6 +- .../title_suggestions_item_spec.js} | 6 +- .../components/title_suggestions_spec.js} | 10 +- .../components/type_popover_spec.js} | 6 +- .../issues/{suggestions => new}/mock_data.js | 0 spec/frontend/lib/utils/common_utils_spec.js | 11 ++ .../runner/components/runner_list_spec.js | 38 ++++ .../loose_foreign_key_helpers_spec.rb | 9 +- .../gitlab/database/type/json_pg_safe_spec.rb | 26 +++ spec/lib/gitlab/import_export/all_models.yml | 2 + spec/lib/gitlab/rate_limit_helpers_spec.rb | 50 ----- .../repository_archive_rate_limiter_spec.rb | 56 ++++++ spec/models/ci/namespace_mirror_spec.rb | 94 ++++++++++ spec/models/ci/project_mirror_spec.rb | 36 ++++ spec/models/container_repository_spec.rb | 33 +++- .../loose_foreign_keys/deleted_record_spec.rb | 149 +++++++++++++-- spec/models/namespace_spec.rb | 71 +++++++ spec/models/project_spec.rb | 71 +++++++ spec/models/user_spec.rb | 6 +- .../namespaces/user_namespace_policy_spec.rb | 22 +++ .../api/error_tracking/collector_spec.rb | 12 +- spec/requests/api/v3/github_spec.rb | 12 -- .../ci/process_sync_events_service_spec.rb | 129 +++++++++++++ spec/services/ci/retry_build_service_spec.rb | 24 +-- .../batch_cleaner_service_spec.rb | 2 +- spec/services/search_service_spec.rb | 21 +++ .../process_sync_events_worker_spec.rb | 32 ++++ .../process_sync_events_worker_spec.rb | 28 +++ 154 files changed, 1861 insertions(+), 511 deletions(-) rename app/assets/javascripts/issues/{suggestions/components/app.vue => new/components/title_suggestions.vue} (90%) rename app/assets/javascripts/issues/{suggestions/components/item.vue => new/components/title_suggestions_item.vue} (100%) rename app/assets/javascripts/issues/{type_selector/components/info_popover.vue => new/components/type_popover.vue} (88%) rename app/assets/javascripts/issues/{suggestions => new}/index.js (52%) rename app/assets/javascripts/issues/{suggestions => new}/queries/issues.query.graphql (100%) delete mode 100644 app/assets/javascripts/issues/type_selector/index.js create mode 100644 app/models/namespaces/sync_event.rb create mode 100644 app/models/projects/sync_event.rb create mode 100644 app/services/ci/process_sync_events_service.rb create mode 100644 app/workers/namespaces/process_sync_events_worker.rb create mode 100644 app/workers/projects/process_sync_events_worker.rb delete mode 100644 config/feature_flags/development/api_v3_commits_skip_diff_files.yml rename config/feature_flags/development/{clone_job_variables_at_job_retry.yml => ci_namespace_project_mirrors.yml} (66%) create mode 100644 config/feature_flags/development/lfk_automatic_partition_creation.yml create mode 100644 config/feature_flags/development/lfk_automatic_partition_dropping.yml create mode 100644 db/fixtures/development/32_crm.rb create mode 100644 db/migrate/20211011140932_create_namespaces_sync_events.rb create mode 100644 db/migrate/20211011141239_create_projects_sync_events.rb create mode 100644 db/migrate/20211011141242_create_namespaces_sync_trigger.rb create mode 100644 db/migrate/20211011141243_create_projects_sync_trigger.rb create mode 100644 db/migrate/20211202094944_move_loose_fk_deleted_records_to_dynamic_schema.rb create mode 100644 db/schema_migrations/20211011140932 create mode 100644 db/schema_migrations/20211011141239 create mode 100644 db/schema_migrations/20211011141242 create mode 100644 db/schema_migrations/20211011141243 create mode 100644 db/schema_migrations/20211202094944 create mode 100644 lib/gitlab/database/type/json_pg_safe.rb delete mode 100644 lib/gitlab/rate_limit_helpers.rb create mode 100644 lib/gitlab/repository_archive_rate_limiter.rb create mode 100644 spec/fixtures/error_tracking/parsed_event_nullbytes.json rename spec/frontend/issues/{type_selector/components/__snapshots__/info_popover_spec.js.snap => new/components/__snapshots__/type_popover_spec.js.snap} (88%) rename spec/frontend/issues/{suggestions/components/item_spec.js => new/components/title_suggestions_item_spec.js} (94%) rename spec/frontend/issues/{suggestions/components/app_spec.js => new/components/title_suggestions_spec.js} (86%) rename spec/frontend/issues/{type_selector/components/info_popover_spec.js => new/components/type_popover_spec.js} (60%) rename spec/frontend/issues/{suggestions => new}/mock_data.js (100%) create mode 100644 spec/lib/gitlab/database/type/json_pg_safe_spec.rb delete mode 100644 spec/lib/gitlab/rate_limit_helpers_spec.rb create mode 100644 spec/lib/gitlab/repository_archive_rate_limiter_spec.rb create mode 100644 spec/models/ci/namespace_mirror_spec.rb create mode 100644 spec/models/ci/project_mirror_spec.rb create mode 100644 spec/services/ci/process_sync_events_service_spec.rb create mode 100644 spec/workers/namespaces/process_sync_events_worker_spec.rb create mode 100644 spec/workers/projects/process_sync_events_worker_spec.rb diff --git a/.rubocop_todo/rails/include_url_helper.yml b/.rubocop_todo/rails/include_url_helper.yml index adc42663523..2dedba19c78 100644 --- a/.rubocop_todo/rails/include_url_helper.yml +++ b/.rubocop_todo/rails/include_url_helper.yml @@ -21,20 +21,16 @@ Rails/IncludeUrlHelper: - app/models/integrations/webex_teams.rb - app/models/integrations/youtrack.rb - app/presenters/alert_management/alert_presenter.rb - - app/presenters/ci/pipeline_presenter.rb - app/presenters/environment_presenter.rb - app/presenters/gitlab/blame_presenter.rb - app/presenters/merge_request_presenter.rb - app/presenters/project_presenter.rb - - app/presenters/prometheus_alert_presenter.rb - app/presenters/release_presenter.rb - app/presenters/releases/evidence_presenter.rb - ee/app/helpers/license_helper.rb - ee/app/models/integrations/github.rb - - ee/app/presenters/merge_request_approver_presenter.rb - ee/spec/helpers/ee/projects/security/configuration_helper_spec.rb - ee/spec/lib/banzai/filter/cross_project_issuable_information_filter_spec.rb - - lib/gitlab/ci/badge/metadata.rb - spec/helpers/merge_requests_helper_spec.rb - spec/helpers/nav/top_nav_helper_spec.rb - spec/helpers/notify_helper_spec.rb diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 21ff8d35786..b9abc36b3c3 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -4ba8618078d9107d52c0d735f76286ab0b113a8a +1de88e4247d4b940f843003781cb2bf75582b826 diff --git a/app/assets/javascripts/issues/form.js b/app/assets/javascripts/issues/form.js index 20a8c251304..33371d065f9 100644 --- a/app/assets/javascripts/issues/form.js +++ b/app/assets/javascripts/issues/form.js @@ -4,8 +4,7 @@ import $ from 'jquery'; import IssuableForm from 'ee_else_ce/issuable/issuable_form'; import ShortcutsNavigation from '~/behaviors/shortcuts/shortcuts_navigation'; import GLForm from '~/gl_form'; -import initSuggestions from '~/issues/suggestions'; -import initIssuableTypeSelector from '~/issues/type_selector'; +import { initTitleSuggestions, initTypePopover } from '~/issues/new'; import LabelsSelect from '~/labels/labels_select'; import MilestoneSelect from '~/milestones/milestone_select'; import IssuableTemplateSelectors from '~/issuable/issuable_template_selectors'; @@ -20,6 +19,6 @@ export default () => { warnTemplateOverride: true, }); - initSuggestions(); - initIssuableTypeSelector(); + initTitleSuggestions(); + initTypePopover(); }; diff --git a/app/assets/javascripts/issues/suggestions/components/app.vue b/app/assets/javascripts/issues/new/components/title_suggestions.vue similarity index 90% rename from app/assets/javascripts/issues/suggestions/components/app.vue rename to app/assets/javascripts/issues/new/components/title_suggestions.vue index 48a5e220abf..0a9cdb12519 100644 --- a/app/assets/javascripts/issues/suggestions/components/app.vue +++ b/app/assets/javascripts/issues/new/components/title_suggestions.vue @@ -2,12 +2,12 @@ import { GlTooltipDirective, GlIcon } from '@gitlab/ui'; import { __ } from '~/locale'; import query from '../queries/issues.query.graphql'; -import Suggestion from './item.vue'; +import TitleSuggestionsItem from './title_suggestions_item.vue'; export default { components: { - Suggestion, GlIcon, + TitleSuggestionsItem, }, directives: { GlTooltip: GlTooltipDirective, @@ -66,7 +66,7 @@ export default {