From ef53b9b911aaa28e951fa04c7876b6c0ed212808 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 29 Aug 2024 15:07:22 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../security.gitlab-ci.yml | 1 + CHANGELOG.md | 6 +- .../components/merge_request.vue | 4 +- .../queries/merge_request.fragment.graphql | 2 +- app/assets/javascripts/search/index.js | 5 +- .../search/results/components/app.vue | 78 +++- .../search/results/components/blob_body.vue | 2 +- .../search/results/components/blob_chunks.vue | 17 +- .../search/results/components/blob_header.vue | 6 +- .../search/results/components/status_bar.vue | 127 ++++++ .../results/components/zoekt_blob_results.vue | 97 ++-- .../javascripts/search/results/constants.js | 2 + .../javascripts/search/store/actions.js | 2 +- app/assets/javascripts/search/store/state.js | 2 + .../work_items/components/work_item_notes.vue | 15 +- .../components/content_editor.scss | 2 + .../stylesheets/page_bundles/boards.scss | 1 + .../stylesheets/page_bundles/branches.scss | 1 + .../stylesheets/page_bundles/incidents.scss | 3 + .../stylesheets/page_bundles/login.scss | 5 +- .../page_bundles/merge_request.scss | 1 + .../page_bundles/notes/_system_notes_v2.scss | 6 - .../stylesheets/page_bundles/pipeline.scss | 2 + .../stylesheets/page_bundles/pipelines.scss | 1 + .../page_bundles/profiles/preferences.scss | 1 + .../stylesheets/page_bundles/work_items.scss | 3 + app/assets/stylesheets/pages/note_form.scss | 2 + app/assets/stylesheets/pages/notes.scss | 8 + app/assets/stylesheets/performance_bar.scss | 1 + app/views/search/_results.html.haml | 2 +- app/views/search/show.html.haml | 2 +- ...ult_slugged_stream_name_click_dropdown.yml | 2 +- config/events/create_user.yml | 18 + .../ci_conditionals_reduce_gitaly_calls.yml | 9 + config/gitlab_loose_foreign_keys.yml | 13 + ..._index_to_subscription_add_on_purchases.rb | 20 + ...ndex_from_subscription_add_on_purchases.rb | 16 + ...ndex_from_subscription_add_on_purchases.rb | 18 + ...ulnerability_exports_organization_id_fk.rb | 21 + ...paces_vulnerability_exports_group_id_fk.rb | 21 + ...sers_vulnerability_exports_author_id_fk.rb | 21 + ...cts_vulnerability_exports_project_id_fk.rb | 21 + db/schema_migrations/20240808175619 | 1 + db/schema_migrations/20240808182052 | 1 + db/schema_migrations/20240808182231 | 1 + db/schema_migrations/20240827115134 | 1 + db/schema_migrations/20240827115156 | 1 + db/schema_migrations/20240827115218 | 1 + db/schema_migrations/20240827115239 | 1 + db/structure.sql | 16 +- doc/development/ai_features/duo_chat.md | 10 +- doc/development/ai_features/glossary.md | 2 +- doc/development/ai_features/index.md | 2 +- doc/development/code_suggestions/index.md | 4 +- doc/development/event_store.md | 29 +- doc/editor_extensions/visual_studio/index.md | 2 +- doc/user/gitlab_duo/index.md | 8 +- doc/user/gitlab_duo_chat/best_practices.md | 2 +- doc/user/permissions.md | 2 +- .../merge_requests/duo_in_merge_requests.md | 2 +- .../repository/code_suggestions/index.md | 2 +- lib/gitlab/ci/build/context/base.rb | 8 + locale/gitlab.pot | 26 +- spec/db/schema_spec.rb | 3 +- .../badges/components/badge_list_spec.js | 7 +- spec/frontend/boards/board_card_inner_spec.js | 42 +- .../empty_state/no_ci_empty_state_spec.js | 4 +- .../diffs/components/commit_item_spec.js | 68 +-- spec/frontend/environments/commit_spec.js | 12 +- .../components/avatars/group_avatar_spec.js | 2 +- .../components/avatars/invite_avatar_spec.js | 5 +- .../components/avatars/user_avatar_spec.js | 6 +- .../components/merge_request_spec.js | 2 +- .../merge_request_dashboard/mock_data.js | 2 +- .../components/user_achievements_spec.js | 25 +- .../components/release_block_footer_spec.js | 6 +- spec/frontend/search/mock_data.js | 13 + .../search/results/components/app_spec.js | 85 +++- .../results/components/blob_chunks_spec.js | 2 +- .../results/components/blob_footer_spec.js | 5 - .../results/components/status_bar_spec.js | 228 ++++++++++ .../components/zoekt_blob_results_spec.js | 53 +-- .../notes/work_item_discussion_spec.js | 2 +- .../notes/work_item_note_awards_list_spec.js | 4 +- .../components/work_item_notes_spec.js | 44 +- spec/frontend/work_items/mock_data.js | 414 +++++++++--------- .../work_items/notes/award_utils_spec.js | 4 +- spec/graphql/mutations/todos/create_spec.rb | 8 +- spec/helpers/search_helper_spec.rb | 6 +- .../gitlab/ci/build/context/global_spec.rb | 46 ++ spec/support/helpers/graphql_helpers.rb | 4 +- .../stylelint/gitlab_no_gl_class.plugin.js | 2 +- 92 files changed, 1306 insertions(+), 507 deletions(-) create mode 100644 app/assets/javascripts/search/results/components/status_bar.vue create mode 100644 config/events/create_user.yml create mode 100644 config/feature_flags/gitlab_com_derisk/ci_conditionals_reduce_gitaly_calls.yml create mode 100644 db/migrate/20240808175619_add_composite_index_to_subscription_add_on_purchases.rb create mode 100644 db/migrate/20240808182052_remove_namespace_id_index_from_subscription_add_on_purchases.rb create mode 100644 db/migrate/20240808182231_remove_subscription_add_on_id_index_from_subscription_add_on_purchases.rb create mode 100644 db/post_migrate/20240827115134_remove_organizations_vulnerability_exports_organization_id_fk.rb create mode 100644 db/post_migrate/20240827115156_remove_namespaces_vulnerability_exports_group_id_fk.rb create mode 100644 db/post_migrate/20240827115218_remove_users_vulnerability_exports_author_id_fk.rb create mode 100644 db/post_migrate/20240827115239_remove_projects_vulnerability_exports_project_id_fk.rb create mode 100644 db/schema_migrations/20240808175619 create mode 100644 db/schema_migrations/20240808182052 create mode 100644 db/schema_migrations/20240808182231 create mode 100644 db/schema_migrations/20240827115134 create mode 100644 db/schema_migrations/20240827115156 create mode 100644 db/schema_migrations/20240827115218 create mode 100644 db/schema_migrations/20240827115239 create mode 100644 spec/frontend/search/results/components/status_bar_spec.js diff --git a/.gitlab/ci/release-environments/security.gitlab-ci.yml b/.gitlab/ci/release-environments/security.gitlab-ci.yml index 57ed31d7ffd..615fd684aaf 100644 --- a/.gitlab/ci/release-environments/security.gitlab-ci.yml +++ b/.gitlab/ci/release-environments/security.gitlab-ci.yml @@ -103,6 +103,7 @@ release-environments-qa: - echo "$CI_REGISTRY_PASSWORD" | docker login "$CI_REGISTRY" -u "$CI_REGISTRY_USER" --password-stdin retry: max: 2 + when: always release-environments-notification-failure: stage: finish diff --git a/CHANGELOG.md b/CHANGELOG.md index f28e19e5e9a..672f17987f1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1335,7 +1335,7 @@ entry. - [Add UserStarredProjectsResolver sort argument](https://gitlab.com/gitlab-org/gitlab/-/commit/077ca496eaadc0a9383a552ed32294233de2f7e7) by @jzeng88 ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153651)) - [Migrates gl-display-inline-flex to gl-inline-flex](https://gitlab.com/gitlab-org/gitlab/-/commit/3aa4f990bde82a9c6fb59d7c726a02bddc693cea) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/154887)) - [Multiple frameworks labels](https://gitlab.com/gitlab-org/gitlab/-/commit/ca5a43e01aadde03cf32218f62f7e56eb5709f05) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/156570)) **GitLab Enterprise Edition** -- [Add permissions checking to AI impact dashboard](https://gitlab.com/gitlab-org/gitlab/-/commit/23bf0938f52424ec382ba745b57375234b769949) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/156555)) **GitLab Enterprise Edition** +- [Add permissions checking to AI Impact Dashboard](https://gitlab.com/gitlab-org/gitlab/-/commit/23bf0938f52424ec382ba745b57375234b769949) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/156555)) **GitLab Enterprise Edition** - [Admin settings: Migrate security settings to use SettingsBlock](https://gitlab.com/gitlab-org/gitlab/-/commit/467df2db45835010a9b4210982fe662f2f30e8b4) ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/157043)) - [Externalize strings on ldap_group_links](https://gitlab.com/gitlab-org/gitlab/-/commit/2fcc3e2fd12ea0c6813e7c88a1548c90cecf24e0) by @MAlvarez32 ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/155271)) - [Improve usability of environment folders](https://gitlab.com/gitlab-org/gitlab/-/commit/076d3d3a212c3a93ec60863090c3a0fa185ecd05) by @antonkalmykov ([merge request](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/157104)) @@ -2246,7 +2246,7 @@ entry. - [Rate limit project / group notifications per user](gitlab-org/gitlab@ea40bb22bfd028d687faeaaa6cf9734777decde0) ([merge request](gitlab-org/gitlab!153786)) - [Allow redirecting wiki directories on rename](gitlab-org/gitlab@8b9d3640355e73b9ed6196aeeafb923d3cb8f3be) ([merge request](gitlab-org/gitlab!153289)) - [Add NOT NULL constraint to "path_locks.project_id"](gitlab-org/gitlab@8630330b599fcd0e15cc28680fac9b0c31c0ebea) ([merge request](gitlab-org/gitlab!153090)) -- [Add metric start date tooltip to AI impact dashboard](gitlab-org/gitlab@8999b334c8612b21a553c2b14d7ef342700854f4) ([merge request](gitlab-org/gitlab!153141)) **GitLab Enterprise Edition** +- [Add metric start date tooltip to AI Impact Dashboard](gitlab-org/gitlab@8999b334c8612b21a553c2b14d7ef342700854f4) ([merge request](gitlab-org/gitlab!153141)) **GitLab Enterprise Edition** - [Create parent links for imported epics](gitlab-org/gitlab@d6132daae948ef8daada9fbbb37e0d98f7337040) ([merge request](gitlab-org/gitlab!154445)) - [Migrate d-inline-block to gl-inline-block](gitlab-org/gitlab@cb06f5c91a046b7b86dda6793d4c3a6ceff3b6d7) ([merge request](gitlab-org/gitlab!152739)) - [Docs(Epic Header): add entry to describe counts](gitlab-org/gitlab@494803b1a5ba348ce7ea43c0d94960e8ca6f68f1) ([merge request](gitlab-org/gitlab!154391)) **GitLab Enterprise Edition** @@ -3175,7 +3175,7 @@ entry. - [Include template in deprecated flafinder-sast job](gitlab-org/gitlab@7bce91fd3639660b11b7669831f9ddc0d13bbe50) ([merge request](gitlab-org/gitlab!151298)) - [Add AzureRM support to orphan artifacts cleanup](gitlab-org/gitlab@627eb5411af6f76a03c067131c7846c5c8d9129d) ([merge request](gitlab-org/gitlab!140497)) - [Fix work item child status icon color](gitlab-org/gitlab@e5770bc16824362e06c73d56957255c5500f60c7) ([merge request](gitlab-org/gitlab!151094)) -- [Use locale-specific formatting for numbers in the AI Impact dashboard](gitlab-org/gitlab@07a2c3c576b7d0574c0d649ac7931d14606b5305) ([merge request](gitlab-org/gitlab!150882)) **GitLab Enterprise Edition** +- [Use locale-specific formatting for numbers in the AI Impact Dashboard](gitlab-org/gitlab@07a2c3c576b7d0574c0d649ac7931d14606b5305) ([merge request](gitlab-org/gitlab!150882)) **GitLab Enterprise Edition** - [Allows ml_model pending destruction](gitlab-org/gitlab@4b3d7a7eaf03cb799fdd91781347bcafdd9fa040) ([merge request](gitlab-org/gitlab!150808)) - [Fixes issue with registry search query params when removed](gitlab-org/gitlab@2f13fba9b1c405de37dc7b618f5472f129859989) ([merge request](gitlab-org/gitlab!150934)) - [MR list: Fix overlapping search icon](gitlab-org/gitlab@7421cb36c6481acafb30435cb81695ff97bf6a3c) ([merge request](gitlab-org/gitlab!151045)) diff --git a/app/assets/javascripts/merge_request_dashboard/components/merge_request.vue b/app/assets/javascripts/merge_request_dashboard/components/merge_request.vue index 4c0d08f1dec..c5b47eec2e4 100644 --- a/app/assets/javascripts/merge_request_dashboard/components/merge_request.vue +++ b/app/assets/javascripts/merge_request_dashboard/components/merge_request.vue @@ -33,7 +33,7 @@ export default { }, computed: { statsAriaLabel() { - const comments = n__('%d comment', '%d comments', this.mergeRequest.userDiscussionsCount); + const comments = n__('%d comment', '%d comments', this.mergeRequest.userNotesCount); const fileAdditions = n__( '%d file addition', '%d file additions', @@ -109,7 +109,7 @@ export default {
- {{ mergeRequest.userDiscussionsCount }} + {{ mergeRequest.userNotesCount }}
diff --git a/app/assets/javascripts/merge_request_dashboard/queries/merge_request.fragment.graphql b/app/assets/javascripts/merge_request_dashboard/queries/merge_request.fragment.graphql index 077ae82594f..cdb50fe9900 100644 --- a/app/assets/javascripts/merge_request_dashboard/queries/merge_request.fragment.graphql +++ b/app/assets/javascripts/merge_request_dashboard/queries/merge_request.fragment.graphql @@ -38,7 +38,7 @@ fragment MergeRequestDashboardFragment on MergeRequest { ...CiIcon } } - userDiscussionsCount + userNotesCount createdAt updatedAt ...MergeRequestApprovalFragment diff --git a/app/assets/javascripts/search/index.js b/app/assets/javascripts/search/index.js index f5b405ab6b4..5c546056e60 100644 --- a/app/assets/javascripts/search/index.js +++ b/app/assets/javascripts/search/index.js @@ -13,7 +13,7 @@ const sidebarInitState = () => { const el = document.getElementById('js-search-sidebar'); if (!el) return {}; - const { navigationJson, searchType, searchLevel, groupInitialJson, projectInitialJson } = + const { navigationJson, searchType, searchLevel, groupInitialJson, projectInitialJson, ref } = el.dataset; const navigationJsonParsed = JSON.parse(navigationJson); @@ -26,6 +26,7 @@ const sidebarInitState = () => { searchLevel, groupInitialJsonParsed, projectInitialJsonParsed, + ref, }; }; @@ -49,6 +50,7 @@ export const initSearchApp = () => { searchLevel, groupInitialJsonParsed: groupInitialJson, projectInitialJsonParsed: projectInitialJson, + ref, } = sidebarInitState() || {}; const { defaultBranchName } = topBarInitState() || {}; @@ -61,6 +63,7 @@ export const initSearchApp = () => { groupInitialJson, projectInitialJson, defaultBranchName, + repositoryRef: ref, }); initTopbar(store); diff --git a/app/assets/javascripts/search/results/components/app.vue b/app/assets/javascripts/search/results/components/app.vue index 73a6c8f0b95..c87874e3152 100644 --- a/app/assets/javascripts/search/results/components/app.vue +++ b/app/assets/javascripts/search/results/components/app.vue @@ -1,33 +1,99 @@ diff --git a/app/assets/javascripts/search/results/components/blob_body.vue b/app/assets/javascripts/search/results/components/blob_body.vue index c2dcfe98082..3cfa63cb4ae 100644 --- a/app/assets/javascripts/search/results/components/blob_body.vue +++ b/app/assets/javascripts/search/results/components/blob_body.vue @@ -51,7 +51,7 @@ export default {
diff --git a/app/assets/javascripts/search/results/components/blob_chunks.vue b/app/assets/javascripts/search/results/components/blob_chunks.vue index 67638194da5..218675b2957 100644 --- a/app/assets/javascripts/search/results/components/blob_chunks.vue +++ b/app/assets/javascripts/search/results/components/blob_chunks.vue @@ -1,6 +1,7 @@ + + diff --git a/app/assets/javascripts/search/results/components/zoekt_blob_results.vue b/app/assets/javascripts/search/results/components/zoekt_blob_results.vue index 82aebe2511a..a4e18a31532 100644 --- a/app/assets/javascripts/search/results/components/zoekt_blob_results.vue +++ b/app/assets/javascripts/search/results/components/zoekt_blob_results.vue @@ -1,90 +1,55 @@