From ef826d81c650afbe69ae3953b0b8161e0fc7e5f5 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 19 Mar 2025 18:12:16 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .eslint_todo/vue-no-unused-properties.mjs | 4 - .gitlab/ci/global.gitlab-ci.yml | 2 +- .rubocop_todo/rails/pluck.yml | 1 - .../rspec/before_all_role_assignment.yml | 1 - .rubocop_todo/rspec/context_wording.yml | 1 - .rubocop_todo/rspec/repeated_subject_call.yml | 1 - .../components/canary_ingress.vue | 10 +- .../components/confirm_rollback_modal.vue | 57 +- .../environments/components/container.vue | 51 -- .../components/delete_environment_modal.vue | 50 +- .../environments/components/deploy_board.vue | 28 +- .../components/deploy_board_wrapper.vue | 1 - .../components/environment_actions.vue | 15 +- .../components/environment_delete.vue | 33 +- .../components/environment_item.vue | 859 ------------------ .../components/environment_pin.vue | 18 +- .../components/environment_rollback.vue | 24 +- .../components/environment_stop.vue | 55 +- .../components/environments_app.vue | 6 +- .../components/environments_table.vue | 217 ----- .../components/new_environment_item.vue | 5 - .../components/stop_environment_modal.vue | 20 +- .../components/deployment_actions.vue | 2 +- .../components/deployment_history.vue | 2 +- .../javascripts/environments/event_hub.js | 3 - .../folder/environments_folder_app.vue | 7 +- .../folder/environments_folder_bundle.js | 100 +- .../folder/environments_folder_view.vue | 80 -- .../environments/mixins/environments_mixin.js | 292 ------ .../environments_pagination_api_mixin.js | 68 -- .../javascripts/environments/mount_show.js | 8 +- .../services/environments_service.js | 27 - .../environments/stores/environments_store.js | 222 ----- .../environments/stores/helpers.js | 22 - .../glql/components/presenters/state.vue | 3 + .../components/assigned_users.vue | 2 +- app/assets/javascripts/sidebar/utils.js | 7 + .../super_sidebar/user_counts_manager.js | 14 + .../todos/components/todo_item_actions.vue | 23 +- .../todos/components/todos_app.vue | 17 +- .../components/toggle_snoozed_status.vue | 21 +- app/assets/javascripts/todos/utils.js | 21 +- .../async_tab_content_wrapper/index.js | 15 + .../index.stories.js | 33 + .../tab_content_loading_error.vue | 19 + .../tab_content_loading_indicator.vue | 15 + .../storage/namespace/tab_metadata.js | 9 +- .../storage/project/tab_metadata.js | 9 +- .../components/work_item_due_dates.vue | 261 ++---- .../page_bundles/environments.scss | 71 -- .../projects/environments_controller.rb | 4 - .../mutations/ci/pipeline_schedule/update.rb | 20 +- app/graphql/types/ci/inputs/input_type.rb | 11 + app/models/packages/package_file.rb | 6 +- app/views/projects/_sidebar.html.haml | 2 +- .../environments_folder_new_look.yml | 8 - config/initializers/1_settings.rb | 3 + .../gitlab_duo_self_hosted/_index.md | 2 +- doc/administration/lfs/_index.md | 7 +- .../postgresql_versions.md | 4 +- doc/api/graphql/reference/_index.md | 9 + doc/api/merge_trains.md | 3 +- doc/api/packages.md | 2 + doc/api/suggestions.md | 6 +- doc/development/activitypub/_index.md | 8 +- doc/development/lfs.md | 8 +- doc/topics/git/forks.md | 3 - doc/topics/git/how_to_install_git/_index.md | 9 +- doc/topics/git/repository.md | 2 - .../merge_request_approval_policies.md | 1 + doc/user/duo_workflow/risks.md | 41 +- doc/user/duo_workflow/troubleshooting.md | 6 + doc/user/gitlab_duo_chat/_index.md | 61 +- doc/user/gitlab_duo_chat/examples.md | 55 +- doc/user/packages/dependency_proxy/_index.md | 19 +- doc/user/project/codeowners/advanced.md | 4 +- .../project/repository/repository_size.md | 6 - gems/gitlab-active-context/README.md | 6 +- .../doc/getting_started.md | 59 +- .../gitlab-active-context/doc/how_it_works.md | 6 + gems/gitlab-active-context/doc/usage.md | 219 ++++- .../lib/active_context.rb | 4 + .../lib/active_context/concerns/collection.rb | 2 +- .../concerns/migration_worker.rb | 139 +++ .../concerns/reference_utils.rb | 4 + .../databases/concerns/elastic_indexer.rb | 4 +- .../lib/active_context/migration.rb | 4 + .../active_context/migration/dictionary.rb | 6 +- .../lib/active_context/reference.rb | 20 +- .../lib/active_context/bulk_processor_spec.rb | 1 + .../databases/elasticsearch/indexer_spec.rb | 1 + .../databases/opensearch/indexer_spec.rb | 1 + .../preprocessors/embeddings_spec.rb | 4 +- .../preprocessors/preload_spec.rb | 4 +- .../support/helpers/test/references/mock.rb | 4 +- lib/api/package_files.rb | 13 +- locale/gitlab.pot | 54 +- qa/qa/tools/knapsack_report_updater.rb | 4 +- qa/spec/tools/knapsack_report_updater_spec.rb | 4 +- scripts/frontend/quarantined_vue3_specs.txt | 1 - .../environments/environments_folder_spec.rb | 15 - .../environments/canary_ingress_spec.js | 3 +- .../confirm_rollback_modal_spec.js | 38 +- .../delete_environment_modal_spec.js | 1 - .../deploy_board_component_spec.js | 8 +- .../environments/deploy_board_wrapper_spec.js | 3 +- .../environments/environment_delete_spec.js | 58 +- .../components/deployment_actions_spec.js | 1 + .../environments/environment_item_spec.js | 437 --------- .../environments/environment_pin_spec.js | 64 +- .../environments/environment_rollback_spec.js | 24 +- .../environments/environment_stop_spec.js | 18 +- .../environments/environment_table_spec.js | 410 --------- .../environments_folder_view_spec.js | 58 -- .../environments/environments_store_spec.js | 240 ----- .../folder/environments_folder_app_spec.js | 1 - .../folder/environments_folder_view_spec.js | 131 --- .../environments_pagination_api_mixin_spec.js | 69 -- spec/frontend/environments/mock_data.js | 8 +- .../environments/new_environment_item_spec.js | 1 - .../glql/components/presenters/state_spec.js | 34 +- .../__snapshots__/assigned_users_spec.js.snap | 2 +- .../notes/components/note_form_spec.js | 3 +- .../super_sidebar/user_counts_manager_spec.js | 37 + .../components/todo_item_actions_spec.js | 18 +- .../todos/components/todos_app_spec.js | 12 +- .../components/toggle_snoozed_status_spec.js | 17 +- .../async_tab_content_wrapper/index_spec.js | 16 + .../components/work_item_due_dates_spec.js | 65 +- .../types/ci/inputs/input_type_spec.rb | 2 +- spec/models/packages/package_file_spec.rb | 29 + .../ci/pipeline_schedule/update_spec.rb | 62 ++ spec/requests/api/package_files_spec.rb | 85 +- 133 files changed, 1379 insertions(+), 4297 deletions(-) delete mode 100644 app/assets/javascripts/environments/components/container.vue delete mode 100644 app/assets/javascripts/environments/components/environment_item.vue delete mode 100644 app/assets/javascripts/environments/components/environments_table.vue delete mode 100644 app/assets/javascripts/environments/event_hub.js delete mode 100644 app/assets/javascripts/environments/folder/environments_folder_view.vue delete mode 100644 app/assets/javascripts/environments/mixins/environments_mixin.js delete mode 100644 app/assets/javascripts/environments/mixins/environments_pagination_api_mixin.js delete mode 100644 app/assets/javascripts/environments/services/environments_service.js delete mode 100644 app/assets/javascripts/environments/stores/environments_store.js delete mode 100644 app/assets/javascripts/environments/stores/helpers.js create mode 100644 app/assets/javascripts/usage_quotas/components/async_tab_content_wrapper/index.js create mode 100644 app/assets/javascripts/usage_quotas/components/async_tab_content_wrapper/index.stories.js create mode 100644 app/assets/javascripts/usage_quotas/components/async_tab_content_wrapper/tab_content_loading_error.vue create mode 100644 app/assets/javascripts/usage_quotas/components/async_tab_content_wrapper/tab_content_loading_indicator.vue delete mode 100644 config/feature_flags/development/environments_folder_new_look.yml create mode 100644 gems/gitlab-active-context/lib/active_context/concerns/migration_worker.rb delete mode 100644 spec/frontend/environments/environment_item_spec.js delete mode 100644 spec/frontend/environments/environment_table_spec.js delete mode 100644 spec/frontend/environments/environments_folder_view_spec.js delete mode 100644 spec/frontend/environments/environments_store_spec.js delete mode 100644 spec/frontend/environments/folder/environments_folder_view_spec.js delete mode 100644 spec/frontend/environments/mixins/environments_pagination_api_mixin_spec.js create mode 100644 spec/frontend/usage_quotas/components/async_tab_content_wrapper/index_spec.js diff --git a/.eslint_todo/vue-no-unused-properties.mjs b/.eslint_todo/vue-no-unused-properties.mjs index 6a0bf5f0f06..1151d5a1f51 100644 --- a/.eslint_todo/vue-no-unused-properties.mjs +++ b/.eslint_todo/vue-no-unused-properties.mjs @@ -101,11 +101,9 @@ export default { 'app/assets/javascripts/environments/components/enable_review_app_modal.vue', 'app/assets/javascripts/environments/components/environment_flux_resource_selector.vue', 'app/assets/javascripts/environments/components/environment_form.vue', - 'app/assets/javascripts/environments/components/environment_item.vue', 'app/assets/javascripts/environments/environment_details/components/deployment_actions.vue', 'app/assets/javascripts/environments/environment_details/components/deployment_history.vue', 'app/assets/javascripts/environments/environment_details/components/kubernetes/kubernetes_overview.vue', - 'app/assets/javascripts/environments/folder/environments_folder_view.vue', 'app/assets/javascripts/error_tracking/components/error_details.vue', 'app/assets/javascripts/error_tracking/components/error_tracking_list.vue', 'app/assets/javascripts/error_tracking_settings/components/project_dropdown.vue', @@ -367,7 +365,6 @@ export default { 'app/assets/javascripts/work_items/components/work_item_detail_modal.vue', 'app/assets/javascripts/work_items/components/work_item_development/work_item_create_branch_merge_request_modal.vue', 'app/assets/javascripts/work_items/components/work_item_development/work_item_development_mr_item.vue', - 'app/assets/javascripts/work_items/components/work_item_due_date.vue', 'app/assets/javascripts/work_items/components/work_item_labels.vue', 'app/assets/javascripts/work_items/components/work_item_links/work_item_children_wrapper.vue', 'app/assets/javascripts/work_items/components/work_item_links/work_item_groups_listbox.vue', @@ -596,7 +593,6 @@ export default { 'ee/app/assets/javascripts/work_items/components/work_item_iteration.vue', 'ee/app/assets/javascripts/work_items/components/work_item_links/work_item_rolled_up_health_status.vue', 'ee/app/assets/javascripts/work_items/components/work_item_progress.vue', - 'ee/app/assets/javascripts/work_items/components/work_item_rolledup_dates.vue', 'ee/app/assets/javascripts/workspaces/common/components/workspaces_list/workspaces_table.vue', 'ee/app/assets/javascripts/workspaces/dropdown_group/components/workspace_dropdown_item.vue', 'ee/app/assets/javascripts/workspaces/user/pages/list.vue', diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index 383c3a6f39b..c7416936d95 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -340,7 +340,7 @@ .zoekt-services: services: - - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:zoekt-ci-image-1.9 + - name: ${REGISTRY_HOST}/${REGISTRY_GROUP}/gitlab-build-images:zoekt-ci-image-1.10 alias: zoekt-ci-image .use-pg14: diff --git a/.rubocop_todo/rails/pluck.yml b/.rubocop_todo/rails/pluck.yml index aa6728d0351..bb6517dbfdf 100644 --- a/.rubocop_todo/rails/pluck.yml +++ b/.rubocop_todo/rails/pluck.yml @@ -201,7 +201,6 @@ Rails/Pluck: - 'spec/requests/api/members_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/namespaces_spec.rb' - - 'spec/requests/api/package_files_spec.rb' - 'spec/requests/api/pages_domains_spec.rb' - 'spec/requests/api/personal_access_tokens_spec.rb' - 'spec/requests/api/project_clusters_spec.rb' diff --git a/.rubocop_todo/rspec/before_all_role_assignment.yml b/.rubocop_todo/rspec/before_all_role_assignment.yml index 149af1b5371..9ce05c56b16 100644 --- a/.rubocop_todo/rspec/before_all_role_assignment.yml +++ b/.rubocop_todo/rspec/before_all_role_assignment.yml @@ -1108,7 +1108,6 @@ RSpec/BeforeAllRoleAssignment: - 'spec/requests/api/maven_packages_spec.rb' - 'spec/requests/api/merge_request_approvals_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - - 'spec/requests/api/package_files_spec.rb' - 'spec/requests/api/pages/internal_access_spec.rb' - 'spec/requests/api/pages/private_access_spec.rb' - 'spec/requests/api/pages/public_access_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index cc31eba3de0..07f31532e7b 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -2189,7 +2189,6 @@ RSpec/ContextWording: - 'spec/requests/api/notes_spec.rb' - 'spec/requests/api/npm_project_packages_spec.rb' - 'spec/requests/api/oauth_tokens_spec.rb' - - 'spec/requests/api/package_files_spec.rb' - 'spec/requests/api/pages/internal_access_spec.rb' - 'spec/requests/api/pages/private_access_spec.rb' - 'spec/requests/api/pages/public_access_spec.rb' diff --git a/.rubocop_todo/rspec/repeated_subject_call.yml b/.rubocop_todo/rspec/repeated_subject_call.yml index 0006cecc5ad..f4a616a73a6 100644 --- a/.rubocop_todo/rspec/repeated_subject_call.yml +++ b/.rubocop_todo/rspec/repeated_subject_call.yml @@ -48,7 +48,6 @@ RSpec/RepeatedSubjectCall: - 'spec/models/environment_spec.rb' - 'spec/models/packages/package_file_spec.rb' - 'spec/requests/api/groups_spec.rb' - - 'spec/requests/api/package_files_spec.rb' - 'spec/requests/api/projects_spec.rb' - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/users_spec.rb' diff --git a/app/assets/javascripts/environments/components/canary_ingress.vue b/app/assets/javascripts/environments/components/canary_ingress.vue index 4f611705c79..bfb3b55fe2c 100644 --- a/app/assets/javascripts/environments/components/canary_ingress.vue +++ b/app/assets/javascripts/environments/components/canary_ingress.vue @@ -13,11 +13,6 @@ export default { required: true, type: Object, }, - graphql: { - required: false, - type: Boolean, - default: false, - }, }, ingressOptions: Array(100 / 5 + 1) .fill(0) @@ -51,10 +46,7 @@ export default { return uniqueId('canary-weight-'); }, weight() { - if (this.graphql) { - return this.canaryIngress.canaryWeight; - } - return this.canaryIngress.canary_weight; + return this.canaryIngress.canaryWeight; }, stableWeight() { return 100 - this.weight; diff --git a/app/assets/javascripts/environments/components/confirm_rollback_modal.vue b/app/assets/javascripts/environments/components/confirm_rollback_modal.vue index 8e61714ca55..0621ac09ef6 100644 --- a/app/assets/javascripts/environments/components/confirm_rollback_modal.vue +++ b/app/assets/javascripts/environments/components/confirm_rollback_modal.vue @@ -10,7 +10,6 @@ import { __, s__, sprintf } from '~/locale'; import { helpPagePath } from '~/helpers/help_page_helper'; import rollbackEnvironment from '../graphql/mutations/rollback_environment.mutation.graphql'; -import eventHub from '../event_hub'; export default { name: 'ConfirmRollbackModal', @@ -43,11 +42,6 @@ export default { required: false, default: null, }, - graphql: { - type: Boolean, - required: false, - default: false, - }, }, computed: { modalTitle() { @@ -61,31 +55,18 @@ export default { }, commitShortSha() { if (this.hasMultipleCommits) { - if (this.graphql) { - const { lastDeployment } = this.environment; - return this.commitData(lastDeployment, 'shortId'); - } - - const { last_deployment } = this.environment; - return this.commitData(last_deployment, 'short_id'); + const { lastDeployment } = this.environment; + return this.commitData(lastDeployment, 'shortId'); } return this.environment.commitShortSha; }, commitUrl() { if (this.hasMultipleCommits) { - if (this.graphql) { - const { lastDeployment } = this.environment; - return ( - // data shape comming from REST and GraphQL is unfortunately different - // once we fully migrate to GraphQL it could be streamlined - this.commitData(lastDeployment, 'commitPath') || - this.commitData(lastDeployment, 'webUrl') - ); - } - - const { last_deployment } = this.environment; - return this.commitData(last_deployment, 'commit_path'); + const { lastDeployment } = this.environment; + return ( + this.commitData(lastDeployment, 'commitPath') || this.commitData(lastDeployment, 'webUrl') + ); } return this.environment.commitUrl; @@ -125,21 +106,17 @@ export default { this.$emit('change', event); }, onOk() { - if (this.graphql) { - this.$apollo - .mutate({ - mutation: rollbackEnvironment, - variables: { environment: this.environment }, - }) - .then(() => { - this.$emit('rollback'); - }) - .catch((e) => { - Sentry.captureException(e); - }); - } else { - eventHub.$emit('rollbackEnvironment', this.environment); - } + this.$apollo + .mutate({ + mutation: rollbackEnvironment, + variables: { environment: this.environment }, + }) + .then(() => { + this.$emit('rollback'); + }) + .catch((e) => { + Sentry.captureException(e); + }); }, commitData(lastDeployment, key) { return lastDeployment?.commit?.[key] ?? ''; diff --git a/app/assets/javascripts/environments/components/container.vue b/app/assets/javascripts/environments/components/container.vue deleted file mode 100644 index 2186941e00c..00000000000 --- a/app/assets/javascripts/environments/components/container.vue +++ /dev/null @@ -1,51 +0,0 @@ - - - - diff --git a/app/assets/javascripts/environments/components/delete_environment_modal.vue b/app/assets/javascripts/environments/components/delete_environment_modal.vue index 47f38980acc..bc9b0be03ba 100644 --- a/app/assets/javascripts/environments/components/delete_environment_modal.vue +++ b/app/assets/javascripts/environments/components/delete_environment_modal.vue @@ -2,7 +2,6 @@ import { GlTooltipDirective, GlModal } from '@gitlab/ui'; import { createAlert } from '~/alert'; import { __, s__, sprintf } from '~/locale'; -import eventHub from '../event_hub'; import deleteEnvironmentMutation from '../graphql/mutations/delete_environment.mutation.graphql'; export default { @@ -19,11 +18,6 @@ export default { type: Object, required: true, }, - graphql: { - type: Boolean, - required: false, - default: false, - }, }, computed: { primaryProps() { @@ -56,30 +50,26 @@ export default { }, methods: { onSubmit() { - if (this.graphql) { - this.$apollo - .mutate({ - mutation: deleteEnvironmentMutation, - variables: { environment: this.environment }, - }) - .then(({ data }) => { - const [message] = data?.deleteEvironment?.errors ?? []; - if (message) { - createAlert({ message }); - } - }) - .catch((error) => - createAlert({ - message: s__( - 'Environments|An error occurred while deleting the environment. Check if the environment stopped; if not, stop it and try again.', - ), - error, - captureError: true, - }), - ); - } else { - eventHub.$emit('deleteEnvironment', this.environment); - } + this.$apollo + .mutate({ + mutation: deleteEnvironmentMutation, + variables: { environment: this.environment }, + }) + .then(({ data }) => { + const [message] = data?.deleteEnvironment?.errors ?? []; + if (message) { + createAlert({ message }); + } + }) + .catch((error) => + createAlert({ + message: s__( + 'Environments|An error occurred while deleting the environment. Check if the environment stopped; if not, stop it and try again.', + ), + error, + captureError: true, + }), + ); }, }, }; diff --git a/app/assets/javascripts/environments/components/deploy_board.vue b/app/assets/javascripts/environments/components/deploy_board.vue index 2852278e799..9540652f83e 100644 --- a/app/assets/javascripts/environments/components/deploy_board.vue +++ b/app/assets/javascripts/environments/components/deploy_board.vue @@ -52,11 +52,6 @@ export default { type: Boolean, required: true, }, - graphql: { - type: Boolean, - required: false, - default: false, - }, }, computed: { canRenderDeployBoard() { @@ -66,11 +61,7 @@ export default { return this.isEmpty; }, canaryIngress() { - if (this.graphql) { - return this.deployBoardData.canaryIngress; - } - - return this.deployBoardData.canary_ingress; + return this.deployBoardData.canaryIngress; }, canRenderCanaryWeight() { return !isEmpty(this.canaryIngress); @@ -95,16 +86,10 @@ export default { return n__('Instance', 'Instances', this.instanceCount); }, rollbackUrl() { - if (this.graphql) { - return this.deployBoardData.rollbackUrl; - } - return this.deployBoardData.rollback_url; + return this.deployBoardData.rollbackUrl; }, abortUrl() { - if (this.graphql) { - return this.deployBoardData.abortUrl; - } - return this.deployBoardData.abort_url; + return this.deployBoardData.abortUrl; }, deployBoardActions() { return this.rollbackUrl || this.abortUrl; @@ -123,11 +108,7 @@ export default { this.$emit('changeCanaryWeight', weight); }, podName(instance) { - if (this.graphql) { - return instance.podName; - } - - return instance.pod_name; + return instance.podName; }, }, emptyStateText: s__( @@ -189,7 +170,6 @@ export default { v-if="canRenderCanaryWeight" class="deploy-board-canary-ingress" :canary-ingress="canaryIngress" - :graphql="graphql" @change="changeCanaryWeight" /> diff --git a/app/assets/javascripts/environments/components/deploy_board_wrapper.vue b/app/assets/javascripts/environments/components/deploy_board_wrapper.vue index 482f303e502..ee97797eab9 100644 --- a/app/assets/javascripts/environments/components/deploy_board_wrapper.vue +++ b/app/assets/javascripts/environments/components/deploy_board_wrapper.vue @@ -77,7 +77,6 @@ export default { :is-loading="isLoading" :is-empty="isEmpty" :environment="environment" - graphql class="!gl-bg-inherit" @changeCanaryWeight="changeCanaryWeight" /> diff --git a/app/assets/javascripts/environments/components/environment_actions.vue b/app/assets/javascripts/environments/components/environment_actions.vue index 7676460b754..3a4a7440c66 100644 --- a/app/assets/javascripts/environments/components/environment_actions.vue +++ b/app/assets/javascripts/environments/components/environment_actions.vue @@ -3,7 +3,6 @@ import { GlIcon, GlDisclosureDropdown, GlDisclosureDropdownItem } from '@gitlab/ import { confirmAction } from '~/lib/utils/confirm_via_gl_modal/confirm_via_gl_modal'; import { formatTime } from '~/lib/utils/datetime_utility'; import { __, s__, sprintf } from '~/locale'; -import eventHub from '../event_hub'; import actionMutation from '../graphql/mutations/action.mutation.graphql'; export default { @@ -18,11 +17,6 @@ export default { required: false, default: () => [], }, - graphql: { - type: Boolean, - required: false, - default: false, - }, }, data() { return { @@ -61,13 +55,8 @@ export default { } this.isLoading = true; - - if (this.graphql) { - await this.$apollo.mutate({ mutation: actionMutation, variables: { action } }); - this.isLoading = false; - } else { - eventHub.$emit('postAction', { endpoint: action.playPath }); - } + await this.$apollo.mutate({ mutation: actionMutation, variables: { action } }); + this.isLoading = false; }, isActionDisabled(action) { diff --git a/app/assets/javascripts/environments/components/environment_delete.vue b/app/assets/javascripts/environments/components/environment_delete.vue index b63b7731267..eb401a4211d 100644 --- a/app/assets/javascripts/environments/components/environment_delete.vue +++ b/app/assets/javascripts/environments/components/environment_delete.vue @@ -6,7 +6,6 @@ import { GlDisclosureDropdownItem, GlModalDirective } from '@gitlab/ui'; import { s__ } from '~/locale'; -import eventHub from '../event_hub'; import setEnvironmentToDelete from '../graphql/mutations/set_environment_to_delete.mutation.graphql'; export default { @@ -21,11 +20,6 @@ export default { type: Object, required: true, }, - graphql: { - type: Boolean, - required: false, - default: false, - }, }, data() { return { @@ -36,31 +30,12 @@ export default { }, }; }, - mounted() { - if (!this.graphql) { - eventHub.$on('deleteEnvironment', this.onDeleteEnvironment); - } - }, - beforeDestroy() { - if (!this.graphql) { - eventHub.$off('deleteEnvironment', this.onDeleteEnvironment); - } - }, methods: { onClick() { - if (this.graphql) { - this.$apollo.mutate({ - mutation: setEnvironmentToDelete, - variables: { environment: this.environment }, - }); - } else { - eventHub.$emit('requestDeleteEnvironment', this.environment); - } - }, - onDeleteEnvironment(environment) { - if (this.environment.id === environment.id) { - this.isLoading = true; - } + this.$apollo.mutate({ + mutation: setEnvironmentToDelete, + variables: { environment: this.environment }, + }); }, }, }; diff --git a/app/assets/javascripts/environments/components/environment_item.vue b/app/assets/javascripts/environments/components/environment_item.vue deleted file mode 100644 index f00e558a376..00000000000 --- a/app/assets/javascripts/environments/components/environment_item.vue +++ /dev/null @@ -1,859 +0,0 @@ - - diff --git a/app/assets/javascripts/environments/components/environment_pin.vue b/app/assets/javascripts/environments/components/environment_pin.vue index 1a63bfa2c1c..09ed7116271 100644 --- a/app/assets/javascripts/environments/components/environment_pin.vue +++ b/app/assets/javascripts/environments/components/environment_pin.vue @@ -5,7 +5,6 @@ */ import { GlDisclosureDropdownItem } from '@gitlab/ui'; import { __ } from '~/locale'; -import eventHub from '../event_hub'; import cancelAutoStopMutation from '../graphql/mutations/cancel_auto_stop.mutation.graphql'; export default { @@ -17,11 +16,6 @@ export default { type: String, required: true, }, - graphql: { - type: Boolean, - required: false, - default: false, - }, }, data() { return { @@ -30,14 +24,10 @@ export default { }, methods: { onPinClick() { - if (this.graphql) { - this.$apollo.mutate({ - mutation: cancelAutoStopMutation, - variables: { autoStopUrl: this.autoStopUrl }, - }); - } else { - eventHub.$emit('cancelAutoStop', this.autoStopUrl); - } + this.$apollo.mutate({ + mutation: cancelAutoStopMutation, + variables: { autoStopUrl: this.autoStopUrl }, + }); }, }, }; diff --git a/app/assets/javascripts/environments/components/environment_rollback.vue b/app/assets/javascripts/environments/components/environment_rollback.vue index 291d8558a74..07b136b36ff 100644 --- a/app/assets/javascripts/environments/components/environment_rollback.vue +++ b/app/assets/javascripts/environments/components/environment_rollback.vue @@ -7,7 +7,6 @@ */ import { GlDisclosureDropdownItem, GlModalDirective } from '@gitlab/ui'; import { s__ } from '~/locale'; -import eventHub from '../event_hub'; import setEnvironmentToRollback from '../graphql/mutations/set_environment_to_rollback.mutation.graphql'; export default { @@ -33,12 +32,6 @@ export default { type: String, required: true, }, - - graphql: { - type: Boolean, - required: false, - default: false, - }, }, data() { @@ -58,16 +51,13 @@ export default { retryUrl: this.retryUrl, isLastDeployment: this.isLastDeployment, }; - if (this.graphql) { - this.$apollo.mutate({ - mutation: setEnvironmentToRollback, - variables: { - environment: rollbackEnvironmentData, - }, - }); - } else { - eventHub.$emit('requestRollbackEnvironment', rollbackEnvironmentData); - } + + this.$apollo.mutate({ + mutation: setEnvironmentToRollback, + variables: { + environment: rollbackEnvironmentData, + }, + }); }, }, }; diff --git a/app/assets/javascripts/environments/components/environment_stop.vue b/app/assets/javascripts/environments/components/environment_stop.vue index d608eebd1ae..0b4d3f63f65 100644 --- a/app/assets/javascripts/environments/components/environment_stop.vue +++ b/app/assets/javascripts/environments/components/environment_stop.vue @@ -7,7 +7,6 @@ import { GlTooltipDirective, GlButton, GlModalDirective } from '@gitlab/ui'; import { BV_HIDE_TOOLTIP } from '~/lib/utils/constants'; import { s__ } from '~/locale'; -import eventHub from '../event_hub'; import setEnvironmentToStopMutation from '../graphql/mutations/set_environment_to_stop.mutation.graphql'; import isEnvironmentStoppingQuery from '../graphql/queries/is_environment_stopping.query.graphql'; @@ -24,11 +23,6 @@ export default { type: Object, required: true, }, - graphql: { - type: Boolean, - required: false, - default: false, - }, }, apollo: { isEnvironmentStopping: { @@ -56,51 +50,30 @@ export default { return this.isLoadingState ? this.$options.i18n.stoppingTitle : this.$options.i18n.stopTitle; }, }, - mounted() { - eventHub.$on('stopEnvironment', this.onStopEnvironment); - }, - beforeDestroy() { - eventHub.$off('stopEnvironment', this.onStopEnvironment); - }, methods: { onClick() { this.$root.$emit(BV_HIDE_TOOLTIP, this.$options.stopEnvironmentTooltipId); - if (this.graphql) { - this.$apollo.mutate({ - mutation: setEnvironmentToStopMutation, - variables: { environment: this.environment }, - }); - } else { - eventHub.$emit('requestStopEnvironment', this.environment); - } - }, - onStopEnvironment(environment) { - if (this.environment.id === environment.id) { - this.isLoading = true; - } + this.$apollo.mutate({ + mutation: setEnvironmentToStopMutation, + variables: { environment: this.environment }, + }); }, }, stopEnvironmentTooltipId: 'stop-environment-button-tooltip', }; diff --git a/app/assets/javascripts/environments/components/environments_app.vue b/app/assets/javascripts/environments/components/environments_app.vue index 9cc4b850fcb..f510fdaea6a 100644 --- a/app/assets/javascripts/environments/components/environments_app.vue +++ b/app/assets/javascripts/environments/components/environments_app.vue @@ -272,9 +272,9 @@ export default { :modal-id="$options.stopStaleEnvsModalId" data-testid="stop-stale-environments-modal" /> - - - + + +