From f6b95a66bc12adeb4fac7277d1eb345d9e7819fd Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 23 Feb 2023 18:09:16 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../admin_new_runner/admin_new_runner_app.vue | 7 +- .../branch_rules/components/view/index.vue | 6 +- .../branch_rules/mount_branch_rules.js | 5 + .../concerns/cycle_analytics_params.rb | 3 - .../concerns/product_analytics_tracking.rb | 1 + .../cycle_analytics/stages_controller.rb | 5 + .../cycle_analytics/summary_controller.rb | 6 + app/controllers/projects/blob_controller.rb | 14 +- .../projects/cycle_analytics_controller.rb | 2 +- .../analytics/cycle_analytics_helper.rb | 29 --- app/helpers/projects_helper.rb | 2 +- app/models/ci/runner.rb | 16 +- app/models/ci/runner_machine.rb | 11 +- app/models/project.rb | 18 -- .../projects/cycle_analytics/show.html.haml | 1 - .../settings/branch_rules/index.html.haml | 4 +- app/views/shared/_label.html.haml | 9 +- ..._fork_network_upon_visibility_decrease.yml | 8 - config/initializers/7_redis.rb | 1 + doc/ci/pipelines/cicd_minutes.md | 13 +- .../database/batched_background_migrations.md | 50 ++++- .../database/database_dictionary.md | 1 + doc/user/group/access_and_permissions.md | 12 +- doc/user/project/issue_board.md | 16 +- .../cycle_analytics/request_params.rb | 102 ++++----- lib/gitlab/database/gitlab_schema.rb | 10 + lib/gitlab/database/lock_writes_manager.rb | 2 + lib/gitlab/database/postgres_partition.rb | 10 +- lib/gitlab/database/tables_locker.rb | 34 ++- lib/gitlab/patch/node_loader.rb | 40 ++++ .../projects/menus/infrastructure_menu.rb | 9 +- locale/gitlab.pot | 6 +- package.json | 4 +- .../request_forwarding/gitlab_ci.yaml.erb | 8 + .../request_forwarding/settings.xml.erb | 23 ++ .../maven/maven_group_level_spec.rb | 91 +++++++- qa/spec/specs/helpers/feature_flag_spec.rb | 66 +++--- .../projects/blob_controller_spec.rb | 29 ++- .../user_changes_project_visibility_spec.rb | 19 -- .../admin_new_runner_app_spec.js | 4 +- .../analytics/cycle_analytics_helper_spec.rb | 61 ------ .../cycle_analytics/request_params_spec.rb | 27 +++ .../database/postgres_partition_spec.rb | 14 +- .../lib/gitlab/database/tables_locker_spec.rb | 203 ++++++++++++------ spec/lib/gitlab/patch/node_loader_spec.rb | 80 +++++++ .../editor_unique_counter_spec.rb | 21 ++ .../menus/infrastructure_menu_spec.rb | 12 ++ spec/models/ci/runner_machine_spec.rb | 116 +++++----- spec/models/ci/runner_spec.rb | 116 ++++++---- spec/requests/api/draft_notes_spec.rb | 28 +-- spec/services/projects/update_service_spec.rb | 46 +--- spec/support/rspec_order_todo.yml | 2 - .../request_params_examples.rb | 127 +++++++++++ yarn.lock | 20 +- 54 files changed, 1040 insertions(+), 530 deletions(-) delete mode 100644 app/helpers/analytics/cycle_analytics_helper.rb delete mode 100644 config/feature_flags/development/unlink_fork_network_upon_visibility_decrease.yml create mode 100644 lib/gitlab/patch/node_loader.rb create mode 100644 qa/qa/fixtures/package_managers/maven/group/consumer/request_forwarding/gitlab_ci.yaml.erb create mode 100644 qa/qa/fixtures/package_managers/maven/group/consumer/request_forwarding/settings.xml.erb delete mode 100644 spec/helpers/analytics/cycle_analytics_helper_spec.rb create mode 100644 spec/lib/gitlab/analytics/cycle_analytics/request_params_spec.rb create mode 100644 spec/lib/gitlab/patch/node_loader_spec.rb create mode 100644 spec/support/shared_examples/analytics/cycle_analytics/request_params_examples.rb diff --git a/app/assets/javascripts/ci/runner/admin_new_runner/admin_new_runner_app.vue b/app/assets/javascripts/ci/runner/admin_new_runner/admin_new_runner_app.vue index 6130b15a3bc..7675191f642 100644 --- a/app/assets/javascripts/ci/runner/admin_new_runner/admin_new_runner_app.vue +++ b/app/assets/javascripts/ci/runner/admin_new_runner/admin_new_runner_app.vue @@ -2,7 +2,7 @@ import { GlSprintf, GlLink, GlModalDirective } from '@gitlab/ui'; import { createAlert, VARIANT_SUCCESS } from '~/flash'; import { redirectTo, setUrlParams } from '~/lib/utils/url_utility'; -import { __ } from '~/locale'; +import { s__ } from '~/locale'; import RunnerInstructionsModal from '~/vue_shared/components/runner_instructions/runner_instructions_modal.vue'; import RunnerPlatformsRadioGroup from '~/ci/runner/components/runner_platforms_radio_group.vue'; import RunnerCreateForm from '~/ci/runner/components/runner_create_form.vue'; @@ -38,7 +38,10 @@ export default { { [PARAM_KEY_PLATFORM]: this.platform }, runner.registerAdminUrl, ); - saveAlertToLocalStorage({ message: __('Runner created.'), variant: VARIANT_SUCCESS }); + saveAlertToLocalStorage({ + message: s__('Runners|Runner created.'), + variant: VARIANT_SUCCESS, + }); redirectTo(registerUrl); }, onError(error) { diff --git a/app/assets/javascripts/projects/settings/branch_rules/components/view/index.vue b/app/assets/javascripts/projects/settings/branch_rules/components/view/index.vue index 740868e1d75..fc433355ad7 100644 --- a/app/assets/javascripts/projects/settings/branch_rules/components/view/index.vue +++ b/app/assets/javascripts/projects/settings/branch_rules/components/view/index.vue @@ -33,6 +33,8 @@ export default { branchesPath: { default: '', }, + showStatusChecks: { default: false }, + showApprovers: { default: false }, }, apollo: { project: { @@ -180,7 +182,7 @@ export default { -