From f84cdc5587ab664d3cb4e6d66e09742a0bd1f019 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 5 Feb 2025 09:11:43 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- GITLAB_KAS_VERSION | 2 +- .../group/components/exceptions_input.vue | 7 +- .../group/components/packages_settings.vue | 10 --- .../packages_and_registries_controller.rb | 1 - app/models/ci/runner.rb | 21 +++-- app/models/namespace/package_setting.rb | 8 +- app/policies/project_policy.rb | 7 ++ .../create_package_service.rb | 8 +- app/services/protected_tags/create_service.rb | 2 +- .../protected_tags/destroy_service.rb | 2 + .../packages_allow_duplicate_exceptions.yml | 9 -- .../15-6-deprecate-post-api-v4-runner.yml | 8 +- ...ner-registration-token-reset-endpoints.yml | 4 +- ...deprecate-ciMinutesUsed-graphql-field.yml} | 6 +- ...RunnersRegistrationTokenReset-mutation.yml | 4 +- .../dedicated/create_instance.md | 2 +- doc/development/advanced_search.md | 2 +- doc/development/ai_features/duo_chat.md | 2 +- doc/development/database_review.md | 2 +- doc/development/feature_flags/_index.md | 18 ++++ doc/development/lfs.md | 2 +- doc/development/migration_style_guide.md | 4 +- doc/update/breaking_windows.md | 2 +- doc/update/deprecations.md | 16 ++-- doc/user/packages/generic_packages/index.md | 3 + doc/user/packages/maven_repository/index.md | 3 + doc/user/packages/nuget_repository/index.md | 3 + .../terraform_module_registry/index.md | 5 +- lib/api/protected_tags.rb | 12 ++- .../settings/packages_and_registries_spec.rb | 64 ++------------ .../group/components/exceptions_input_spec.js | 1 - .../group/components/package_settings_spec.js | 83 ++----------------- spec/models/ci/runner_spec.rb | 37 ++++++++- spec/models/namespace/package_setting_spec.rb | 35 -------- spec/requests/api/generic_packages_spec.rb | 76 ----------------- .../create_package_file_service_spec.rb | 16 ---- .../find_or_create_package_service_spec.rb | 12 --- .../create_package_service_spec.rb | 25 ------ 38 files changed, 137 insertions(+), 387 deletions(-) delete mode 100644 config/feature_flags/gitlab_com_derisk/packages_allow_duplicate_exceptions.yml rename data/deprecations/{17-5-deprecate-ciUsedMinutes-graphql-field.yml => 17-5-deprecate-ciMinutesUsed-graphql-field.yml} (71%) diff --git a/GITLAB_KAS_VERSION b/GITLAB_KAS_VERSION index 84c766ba1af..0dd2907489d 100644 --- a/GITLAB_KAS_VERSION +++ b/GITLAB_KAS_VERSION @@ -1 +1 @@ -35cfdacad6baf3e031993625b9ce4e5d46dfd388 +7186455e61c1a6556cd6f0664a9c90c5da2e6bae diff --git a/app/assets/javascripts/packages_and_registries/settings/group/components/exceptions_input.vue b/app/assets/javascripts/packages_and_registries/settings/group/components/exceptions_input.vue index 2e6ad79942b..6b7df71bdb6 100644 --- a/app/assets/javascripts/packages_and_registries/settings/group/components/exceptions_input.vue +++ b/app/assets/javascripts/packages_and_registries/settings/group/components/exceptions_input.vue @@ -21,11 +21,6 @@ export default { required: false, default: false, }, - duplicatesAllowed: { - type: Boolean, - default: false, - required: false, - }, duplicateExceptionRegex: { type: String, default: '', @@ -68,7 +63,7 @@ export default { > import { GlTableLite, GlToggle } from '@gitlab/ui'; -import glFeatureFlagMixin from '~/vue_shared/mixins/gl_feature_flags_mixin'; import { GENERIC_PACKAGE_FORMAT, MAVEN_PACKAGE_FORMAT, @@ -49,7 +48,6 @@ export default { GlToggle, ExceptionsInput, }, - mixins: [glFeatureFlagMixin()], inject: ['groupPath'], props: { packageSettings: { @@ -160,13 +158,6 @@ export default { this.$emit('error'); } }, - allowDuplicateExceptions(item) { - if (item.format === NUGET_PACKAGE_FORMAT) return item.duplicatesAllowed; - - // We're also enabling the duplicate exceptions input when duplicates are allowed - // But the change is behind the packagesAllowDuplicateExceptions feature flag - return !this.glFeatures.packagesAllowDuplicateExceptions && item.duplicatesAllowed; - }, update(type, value) { this.updateSettings({ [type]: value }); }, @@ -204,7 +195,6 @@ export default {