From f8888a274f6b095075fd8648d3732ad577a3a742 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 25 Oct 2023 15:12:22 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../ci/gitlab-com/danger-review.gitlab-ci.yml | 2 +- .../badges/components/badge_form.vue | 6 +- .../components/board_add_new_column_form.vue | 1 - .../boards/components/new_board_button.vue | 2 +- .../components/ci_variable_table.vue | 1 - .../pipeline_mini_graph/legacy_job_item.vue | 1 - .../components/pipeline_schedules_form.vue | 6 +- .../components/triggers_list.vue | 8 +- .../components/deploy_freeze_modal.vue | 2 - .../components/delete_button.vue | 2 +- .../design_notes/design_discussion.vue | 1 - .../components/design_notes/design_note.vue | 12 +- .../design_notes/design_reply_form.vue | 4 +- .../components/design_overlay.vue | 2 +- .../components/list/item.vue | 17 +- .../design_management/pages/index.vue | 6 +- .../components/environments_table.vue | 8 +- .../components/error_details.vue | 6 +- .../components/feature_flags.vue | 1 - .../groups/components/item_actions.vue | 1 - .../components/transfer_locations.vue | 6 +- .../components/github_status_table.vue | 1 - .../components/import_projects_table.vue | 1 - .../components/project_select.vue | 1 - .../show/components/fields/description.vue | 1 - .../components/list/harbor_list_row.vue | 7 +- .../details/components/app.vue | 2 +- .../details/components/details_title.vue | 2 +- .../components/details/package_title.vue | 1 - .../shared/components/package_path.vue | 2 +- .../components/bulk_imports_history_app.vue | 7 +- .../history/components/import_history_app.vue | 7 +- .../components/service_desk_setting.vue | 1 - .../service_desk_template_dropdown.vue | 1 - .../components/assignees/assignee_title.vue | 1 - .../components/assignees/assignees.vue | 1 - .../labels_select_vue/dropdown_value.vue | 1 - .../components/reviewers/reviewer_avatar.vue | 1 - .../components/reviewers/reviewers.vue | 1 - .../super_sidebar/components/create_menu.vue | 1 - .../tags/components/delete_tag_modal.vue | 1 - .../components/states/ready_to_merge.vue | 1 - .../components/sidebar/sidebar_assignees.vue | 8 +- .../source_viewer/source_viewer_new.vue | 1 - .../vue_shared/components/toggle_labels.vue | 1 - .../webhooks/components/push_events.vue | 8 +- .../metrics_and_profiling.html.haml | 2 +- .../application_settings/network.html.haml | 4 +- .../application_settings/repository.html.haml | 2 +- app/views/admin/topics/_form.html.haml | 4 +- app/views/admin/topics/_topic.html.haml | 2 +- app/views/admin/topics/index.html.haml | 2 +- app/views/groups/projects.html.haml | 15 +- app/views/groups/settings/_export.html.haml | 4 +- .../settings/_git_access_protocols.html.haml | 2 +- .../_resource_access_token_creation.html.haml | 2 +- app/views/layouts/signup_onboarding.html.haml | 2 +- .../projects/_service_desk_settings.html.haml | 2 +- .../issues/service_desk/_issue.html.haml | 2 +- .../service_desk/_issue_estimate.html.haml | 2 +- .../shared/access_tokens/_form.html.haml | 2 +- .../shared/issuable/_assignees.html.haml | 2 +- app/views/shared/issuable/_nav.html.haml | 2 +- app/views/users/show.html.haml | 2 +- ...i_pipeline_chat_data_pipeline_id_bigint.rb | 29 +++ db/schema_migrations/20231024025629 | 1 + db/structure.sql | 17 -- doc/api/graphql/reference/index.md | 6 +- .../repository/code_suggestions/index.md | 21 +- package.json | 2 +- qa/lib/gitlab/page/admin/subscription.rb | 2 +- .../page/group/settings/usage_quotas.rb | 30 +-- .../page/group/settings/usage_quotas.stub.rb | 48 ++-- qa/qa/flow/purchase.rb | 12 +- qa/qa/page/component/design_management.rb | 58 ++--- qa/qa/support/helpers/plan.rb | 12 +- .../design_reply_form_spec.js.snap | 4 +- .../components/design_overlay_spec.js | 2 +- .../components/design_presentation_spec.js | 2 +- .../list/__snapshots__/item_spec.js.snap | 12 +- .../components/error_details_spec.js | 8 +- .../__snapshots__/push_events_spec.js.snap | 76 ++---- .../packages/protection/rule/create_spec.rb | 238 +++++++++--------- yarn.lock | 8 +- 84 files changed, 347 insertions(+), 451 deletions(-) create mode 100644 db/post_migrate/20231024025629_cleanup_ci_pipeline_chat_data_pipeline_id_bigint.rb create mode 100644 db/schema_migrations/20231024025629 diff --git a/.gitlab/ci/gitlab-com/danger-review.gitlab-ci.yml b/.gitlab/ci/gitlab-com/danger-review.gitlab-ci.yml index 8a1a0014539..c6fa9a9e179 100644 --- a/.gitlab/ci/gitlab-com/danger-review.gitlab-ci.yml +++ b/.gitlab/ci/gitlab-com/danger-review.gitlab-ci.yml @@ -1,6 +1,6 @@ include: - project: gitlab-org/quality/pipeline-common - ref: 7.7.0 + ref: 7.8.0 file: - /ci/danger-review.yml diff --git a/app/assets/javascripts/badges/components/badge_form.vue b/app/assets/javascripts/badges/components/badge_form.vue index 2be59f00773..19da1253a17 100644 --- a/app/assets/javascripts/badges/components/badge_form.vue +++ b/app/assets/javascripts/badges/components/badge_form.vue @@ -277,11 +277,7 @@ export default { > {{ saveText }} - + {{ __('Cancel') }} diff --git a/app/assets/javascripts/boards/components/board_add_new_column_form.vue b/app/assets/javascripts/boards/components/board_add_new_column_form.vue index 419d0b41d69..a3c0553d17c 100644 --- a/app/assets/javascripts/boards/components/board_add_new_column_form.vue +++ b/app/assets/javascripts/boards/components/board_add_new_column_form.vue @@ -43,7 +43,6 @@ export default {
-
+
{{ s__('Pipelines|No triggers have been created yet. Add one using the form above.') }}
diff --git a/app/assets/javascripts/deploy_freeze/components/deploy_freeze_modal.vue b/app/assets/javascripts/deploy_freeze/components/deploy_freeze_modal.vue index 72d1ce9768a..6210e82119f 100644 --- a/app/assets/javascripts/deploy_freeze/components/deploy_freeze_modal.vue +++ b/app/assets/javascripts/deploy_freeze/components/deploy_freeze_modal.vue @@ -142,7 +142,6 @@ export default { ref="freezeStartCron" v-model="freezeStartCron" class="gl-font-monospace!" - data-qa-selector="deploy_freeze_start_field" :placeholder="$options.i18n.cronPlaceholder" :state="freezeStartCronState" autofocus @@ -160,7 +159,6 @@ export default { id="deploy-freeze-end" v-model="freezeEndCron" class="gl-font-monospace!" - data-qa-selector="deploy_freeze_end_field" :placeholder="$options.i18n.cronPlaceholder" :state="freezeEndCronState" trim diff --git a/app/assets/javascripts/design_management/components/delete_button.vue b/app/assets/javascripts/design_management/components/delete_button.vue index dec1038d2e3..88c1b444b31 100644 --- a/app/assets/javascripts/design_management/components/delete_button.vue +++ b/app/assets/javascripts/design_management/components/delete_button.vue @@ -63,7 +63,7 @@ export default { title: s__('DesignManagement|Are you sure you want to archive the selected designs?'), actionPrimary: { text: s__('DesignManagement|Archive designs'), - attributes: { variant: 'confirm', 'data-qa-selector': 'confirm_archiving_button' }, + attributes: { variant: 'confirm', 'data-testid': 'confirm-archiving-button' }, }, actionCancel: { text: __('Cancel'), diff --git a/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue b/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue index f1ed7839bab..2a099b6f22d 100644 --- a/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue +++ b/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue @@ -293,7 +293,6 @@ export default {
{{ buttonText }} diff --git a/app/assets/javascripts/design_management/components/design_overlay.vue b/app/assets/javascripts/design_management/components/design_overlay.vue index 4ce6395140e..e4361f94026 100644 --- a/app/assets/javascripts/design_management/components/design_overlay.vue +++ b/app/assets/javascripts/design_management/components/design_overlay.vue @@ -272,7 +272,7 @@ export default { role="button" :aria-label="$options.i18n.newCommentButtonLabel" class="gl-absolute gl-w-full gl-h-full gl-p-0 gl-top-0 gl-left-0 gl-outline-0! btn-transparent gl-hover-cursor-crosshair" - data-qa-selector="design_image_button" + data-testid="design-image-button" @mouseup="onAddCommentMouseup" > diff --git a/app/assets/javascripts/design_management/components/list/item.vue b/app/assets/javascripts/design_management/components/list/item.vue index 7b98557f4f0..6400f939244 100644 --- a/app/assets/javascripts/design_management/components/list/item.vue +++ b/app/assets/javascripts/design_management/components/list/item.vue @@ -144,12 +144,17 @@ export default { :name="icon.name" :size="16" :class="icon.classes" - data-qa-selector="design_status_icon" + data-testid="design-status-icon" :data-qa-status="icon.name" />
- +