diff --git a/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml b/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml index b9b01b6be1f..b2535c44816 100644 --- a/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml +++ b/.rubocop_todo/gitlab/avoid_gitlab_instance_checks.yml @@ -83,7 +83,6 @@ Gitlab/AvoidGitlabInstanceChecks: - 'ee/app/workers/gitlab_subscriptions/schedule_refresh_seats_worker.rb' - 'ee/app/workers/update_all_mirrors_worker.rb' - 'ee/lib/api/code_suggestions.rb' - - 'ee/lib/api/internal/upcoming_reconciliations.rb' - 'ee/lib/api/scim/instance_scim.rb' - 'ee/lib/ee/api/namespaces.rb' - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_pipeline_artifacts_size_job.rb' diff --git a/.rubocop_todo/gitlab/bounded_contexts.yml b/.rubocop_todo/gitlab/bounded_contexts.yml index 548cd702c14..3d4d492ac13 100644 --- a/.rubocop_todo/gitlab/bounded_contexts.yml +++ b/.rubocop_todo/gitlab/bounded_contexts.yml @@ -3500,7 +3500,6 @@ Gitlab/BoundedContexts: - 'ee/app/services/timebox/report_service.rb' - 'ee/app/services/timebox_report_service.rb' - 'ee/app/services/todos/destroy/confidential_epic_service.rb' - - 'ee/app/services/upcoming_reconciliations/update_service.rb' - 'ee/app/services/user_permissions/export_service.rb' - 'ee/app/services/users_ops_dashboard_projects/base_service.rb' - 'ee/app/services/users_ops_dashboard_projects/destroy_service.rb' diff --git a/.rubocop_todo/layout/first_hash_element_indentation.yml b/.rubocop_todo/layout/first_hash_element_indentation.yml index a532e9b85b5..ade3a449297 100644 --- a/.rubocop_todo/layout/first_hash_element_indentation.yml +++ b/.rubocop_todo/layout/first_hash_element_indentation.yml @@ -10,7 +10,6 @@ Layout/FirstHashElementIndentation: - 'ee/spec/models/concerns/elastic/note_spec.rb' - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' - - 'ee/spec/requests/api/internal/upcoming_reconciliations_spec.rb' - 'ee/spec/requests/api/merge_requests_spec.rb' - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb' - 'ee/spec/requests/groups/group_members_controller_spec.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 6bc08c66404..4a818f89040 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -1812,7 +1812,6 @@ Layout/LineLength: - 'ee/spec/requests/api/internal/app_sec/dast/site_validations_spec.rb' - 'ee/spec/requests/api/internal/base_spec.rb' - 'ee/spec/requests/api/internal/kubernetes_spec.rb' - - 'ee/spec/requests/api/internal/upcoming_reconciliations_spec.rb' - 'ee/spec/requests/api/invitations_spec.rb' - 'ee/spec/requests/api/issues_spec.rb' - 'ee/spec/requests/api/iterations_spec.rb' diff --git a/.rubocop_todo/performance/map_compact.yml b/.rubocop_todo/performance/map_compact.yml index 9d5163ba241..53a7699ceab 100644 --- a/.rubocop_todo/performance/map_compact.yml +++ b/.rubocop_todo/performance/map_compact.yml @@ -56,7 +56,6 @@ Performance/MapCompact: - 'ee/app/services/members/activate_service.rb' - 'ee/app/services/security/override_uuids_service.rb' - 'ee/app/services/security/store_scan_service.rb' - - 'ee/app/services/upcoming_reconciliations/update_service.rb' - 'ee/app/services/vulnerabilities/findings/find_or_create_from_security_finding_service.rb' - 'ee/app/workers/geo/scheduler/scheduler_worker.rb' - 'ee/lib/banzai/filter/references/iteration_reference_filter.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 6bfb5602886..0e93b0e8340 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -758,7 +758,6 @@ RSpec/ContextWording: - 'ee/spec/services/system_notes/vulnerabilities_service_spec.rb' - 'ee/spec/services/timebox_report_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - 'ee/spec/services/user_permissions/export_service_spec.rb' - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' - 'ee/spec/support/features/manual_quarterly_co_term_banner_examples.rb' diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index 631a0c0965b..569ea7d60ae 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -58,7 +58,6 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/graphql/mutations/work_items/update_spec.rb' - 'ee/spec/requests/api/graphql/vulnerabilities/external_issue_links_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' - - 'ee/spec/requests/api/internal/upcoming_reconciliations_spec.rb' - 'ee/spec/requests/api/issues_spec.rb' - 'ee/spec/requests/api/provider_identity_spec.rb' - 'ee/spec/requests/groups/epics/related_epic_links_controller_spec.rb' diff --git a/.rubocop_todo/rspec/expect_in_hook.yml b/.rubocop_todo/rspec/expect_in_hook.yml index 0502684c5f8..f6b8d91bdbd 100644 --- a/.rubocop_todo/rspec/expect_in_hook.yml +++ b/.rubocop_todo/rspec/expect_in_hook.yml @@ -64,7 +64,6 @@ RSpec/ExpectInHook: - 'ee/spec/services/projects/create_from_template_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/update_mirror_service_spec.rb' - - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - 'ee/spec/support/shared_examples/lib/gitlab/graphql/issuables_lazy_links_aggregate_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/elastic/cannot_read_cross_project_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' diff --git a/.rubocop_todo/style/single_argument_dig.yml b/.rubocop_todo/style/single_argument_dig.yml index 58ad18241f5..9471d80c12b 100644 --- a/.rubocop_todo/style/single_argument_dig.yml +++ b/.rubocop_todo/style/single_argument_dig.yml @@ -25,7 +25,6 @@ Style/SingleArgumentDig: - 'ee/spec/requests/api/graphql/project/dast_site_profile_spec.rb' - 'ee/spec/requests/api/graphql/project/dast_site_profiles_spec.rb' - 'ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb' - - 'ee/spec/requests/api/internal/upcoming_reconciliations_spec.rb' - 'ee/spec/services/vulnerabilities/findings/find_or_create_from_security_finding_service_spec.rb' - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' - 'lib/gitlab/auth/o_auth/auth_hash.rb' diff --git a/app/assets/javascripts/content_editor/extensions/code.js b/app/assets/javascripts/content_editor/extensions/code.js index 8477c8dbd28..8e32975d341 100644 --- a/app/assets/javascripts/content_editor/extensions/code.js +++ b/app/assets/javascripts/content_editor/extensions/code.js @@ -1,4 +1,5 @@ import { Mark } from '@tiptap/core'; +import { Fragment } from '@tiptap/pm/model'; import Code from '@tiptap/extension-code'; import { EXTENSION_PRIORITY_LOWER } from '../constants'; @@ -12,6 +13,18 @@ export default Code.extend({ */ priority: EXTENSION_PRIORITY_LOWER, + parseHTML() { + return [ + { + tag: 'code', + preserveWhitespace: true, + getContent(element, schema) { + return Fragment.from(schema.text(element.textContent)); + }, + }, + ]; + }, + addKeyboardShortcuts() { return { ArrowRight: () => { diff --git a/app/assets/javascripts/content_editor/extensions/diagram.js b/app/assets/javascripts/content_editor/extensions/diagram.js index 60c337bc572..ba45e668686 100644 --- a/app/assets/javascripts/content_editor/extensions/diagram.js +++ b/app/assets/javascripts/content_editor/extensions/diagram.js @@ -1,5 +1,6 @@ import { lowlight } from 'lowlight/lib/core'; import { textblockTypeInputRule } from '@tiptap/core'; +import { Fragment } from '@tiptap/pm/model'; import { base64DecodeUnicode } from '~/lib/utils/text_utility'; import { PARSE_HTML_PRIORITY_HIGHEST } from '../constants'; import languageLoader from '../services/code_block_language_loader'; @@ -49,8 +50,7 @@ export default CodeBlockHighlight.extend({ const source = base64DecodeUnicode( element.dataset.diagramSrc.replace('data:text/plain;base64,', ''), ); - const node = schema.node('paragraph', {}, [schema.text(source)]); - return node.content; + return Fragment.from(schema.text(source)); }, }, ]; diff --git a/app/assets/javascripts/content_editor/services/serializer/code.js b/app/assets/javascripts/content_editor/services/serializer/code.js index 5cf72023682..46c2a5b02fe 100644 --- a/app/assets/javascripts/content_editor/services/serializer/code.js +++ b/app/assets/javascripts/content_editor/services/serializer/code.js @@ -24,7 +24,6 @@ const code = { close: generateCodeTag(closeTag), mixable: true, escape: false, - expelEnclosingWhitespace: true, }; export default code; diff --git a/app/assets/javascripts/merge_request_dashboard/components/app.vue b/app/assets/javascripts/merge_request_dashboard/components/app.vue index f66ad1808bf..3476e0e6761 100644 --- a/app/assets/javascripts/merge_request_dashboard/components/app.vue +++ b/app/assets/javascripts/merge_request_dashboard/components/app.vue @@ -42,7 +42,7 @@ export default {