From fa7c331b76ed59230cc56fc51bfc9e467c8bb9b4 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 15 Feb 2023 15:07:42 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab-ci.yml | 13 ++- GITALY_SERVER_VERSION | 2 +- app/assets/javascripts/issues/constants.js | 1 + .../issues/show/components/app.vue | 4 +- .../notes/components/sidebar_subscription.vue | 4 +- .../pipelines/components/parsing_utils.js | 7 +- .../pipelines_list/pipelines_table.vue | 7 +- .../sidebar_confidentiality_content.vue | 4 +- .../labels_select_root.vue | 6 +- .../sidebar/components/sidebar_dropdown.vue | 4 +- .../components/sidebar_dropdown_widget.vue | 4 +- .../sidebar_subscriptions_widget.vue | 4 +- app/assets/javascripts/sidebar/constants.js | 18 +-- .../super_sidebar/components/help_center.vue | 55 +++++++-- .../components/mr_widget_pipeline.vue | 7 +- app/controllers/concerns/issuable_actions.rb | 2 +- app/controllers/projects/issues_controller.rb | 2 +- app/graphql/mutations/issues/move.rb | 2 +- app/graphql/mutations/work_items/delete.rb | 2 +- app/graphql/types/issue_type.rb | 18 +++ app/helpers/sidebars_helper.rb | 5 +- app/helpers/web_hooks/web_hooks_helper.rb | 10 +- .../concerns/web_hooks/has_web_hooks.rb | 46 ++++++++ app/models/hooks/project_hook.rb | 16 ++- app/models/project.rb | 1 + app/models/repository.rb | 30 ++++- app/models/user_synced_attributes_metadata.rb | 16 ++- app/serializers/triggered_pipeline_entity.rb | 3 + .../copy_design_collection/copy_service.rb | 6 +- app/services/issuable/clone/base_service.rb | 5 + app/services/issuable/destroy_service.rb | 5 + app/services/issues/update_service.rb | 4 +- app/services/tasks_to_be_done/base_service.rb | 4 +- .../work_items/delete_task_service.rb | 2 +- .../projects/mirrors/_branch_filter.html.haml | 6 + .../projects/mirrors/_mirror_repos.html.haml | 7 +- .../mirrors/_mirror_repos_list.html.haml | 4 +- .../mirrors/_mirror_repos_push.html.haml | 1 + app/workers/tasks_to_be_done/create_worker.rb | 2 +- config/initializers/1_settings.rb | 1 + config/initializers/countries.rb | 54 +-------- ...al-field-in-graphql-release-asset-link.yml | 13 +++ ...0209131808_recount_epic_cache_counts_v3.rb | 29 +++++ db/schema_migrations/20230209131808 | 1 + doc/api/graphql/reference/index.md | 2 + doc/update/deprecations.md | 16 +++ doc/user/admin_area/settings/email.md | 4 +- doc/user/project/issues/managing_issues.md | 2 +- doc/user/project/merge_requests/index.md | 2 +- lib/api/issues.rb | 6 +- lib/api/merge_requests.rb | 2 +- lib/gitlab/auth/o_auth/user.rb | 2 +- .../third_recount_epic_cache_counts.rb | 20 ++++ lib/gitlab/git/repository.rb | 16 ++- lib/gitlab/gitaly_client/operation_service.rb | 9 +- lib/gitlab/redis/cache.rb | 13 ++- lib/gitlab/redis/rate_limiting.rb | 6 +- lib/gitlab/redis/repository_cache.rb | 3 +- lib/gitlab/slash_commands/issue_move.rb | 2 +- locale/gitlab.pot | 39 ++++++- .../settings/repository_settings_spec.rb | 1 + spec/frontend/commit/mock_data.js | 14 +-- spec/frontend/fixtures/pipelines.rb | 11 ++ .../issues/show/components/app_spec.js | 12 +- .../show/components/locked_warning_spec.js | 4 +- .../pipelines/pipelines_table_spec.js | 8 ++ spec/frontend/pipelines/utils_spec.js | 37 ++++++ .../labels_select_root_spec.js | 6 +- .../components/help_center_spec.js | 15 +++ spec/frontend/super_sidebar/mock_data.js | 3 + .../components/mr_widget_pipeline_spec.js | 8 ++ .../report_widget_container_spec.js | 8 +- .../vue_merge_request_widget/mock_data.js | 90 +++++++++++++++ .../components/confidentiality_badge_spec.js | 8 +- spec/helpers/sidebars_helper_spec.rb | 5 +- .../web_hooks/web_hooks_helper_spec.rb | 20 +--- spec/lib/gitlab/auth/o_auth/user_spec.rb | 61 +++++++--- spec/lib/gitlab/git/repository_spec.rb | 42 +++++-- .../gitaly_client/operation_service_spec.rb | 43 ++++++- spec/lib/gitlab/redis/cache_spec.rb | 17 +++ spec/lib/gitlab/redis/rate_limiting_spec.rb | 17 +++ .../lib/gitlab/redis/repository_cache_spec.rb | 15 +++ .../presenters/issue_move_spec.rb | 2 +- .../recount_epic_cache_counts_v3_spec.rb | 32 ++++++ spec/models/hooks/project_hook_spec.rb | 106 ++++++++++++++--- spec/models/hooks/web_hook_spec.rb | 2 +- spec/models/project_spec.rb | 8 ++ spec/models/repository_spec.rb | 57 +++++++++- spec/requests/api/graphql/issue/issue_spec.rb | 41 +++++++ .../project/alert_management/alerts_spec.rb | 2 +- spec/serializers/issue_entity_spec.rb | 2 +- .../pipeline_details_entity_spec.rb | 1 + .../services/issuable/destroy_service_spec.rb | 2 +- spec/services/issues/clone_service_spec.rb | 2 +- spec/services/issues/move_service_spec.rb | 2 +- .../tasks_to_be_done/base_service_spec.rb | 2 +- .../work_items/delete_service_spec.rb | 2 +- .../has_web_hooks_shared_examples.rb | 107 ++++++++++++++++++ .../api/graphql/issue_list_shared_examples.rb | 24 +++- .../tasks_to_be_done/create_worker_spec.rb | 2 +- 100 files changed, 1167 insertions(+), 255 deletions(-) create mode 100644 app/models/concerns/web_hooks/has_web_hooks.rb create mode 100644 app/views/projects/mirrors/_branch_filter.html.haml create mode 100644 data/deprecations/15-9-deprecate-external-field-in-graphql-release-asset-link.yml create mode 100644 db/post_migrate/20230209131808_recount_epic_cache_counts_v3.rb create mode 100644 db/schema_migrations/20230209131808 create mode 100644 lib/gitlab/background_migration/third_recount_epic_cache_counts.rb create mode 100644 spec/migrations/recount_epic_cache_counts_v3_spec.rb create mode 100644 spec/support/shared_examples/models/concerns/web_hooks/has_web_hooks_shared_examples.rb diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 9fa296be455..8644659198a 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -104,15 +104,20 @@ workflow: # If `$GITLAB_INTERNAL` isn't set, don't create a pipeline. - if: '$GITLAB_INTERNAL == null' when: never + # For last 3 stable branches, create a pipeline with failure notifications. + - if: '$CI_COMMIT_BRANCH =~ /^15-[6|7|8]-stable(-ee)?$/' + variables: + <<: *ruby2-variables + NOTIFY_PIPELINE_FAILURE_CHANNEL: "releases" + CREATE_INCIDENT_FOR_PIPELINE_FAILURE: "true" + BROKEN_BRANCH_INCIDENTS_PROJECT: "gitlab-org/release/tasks" + BROKEN_BRANCH_INCIDENTS_PROJECT_TOKEN: "${BROKEN_STABLE_INCIDENTS_PROJECT_TOKEN}" + PIPELINE_NAME: 'Ruby 2 $CI_COMMIT_BRANCH branch pipeline' # For stable, auto-deploy, and security branches, create a pipeline. - if: '$CI_COMMIT_BRANCH =~ /^[\d-]+-stable(-ee)?$/' variables: <<: *ruby2-variables - NOTIFY_PIPELINE_FAILURE_CHANNEL: "releases" PIPELINE_NAME: 'Ruby 2 $CI_COMMIT_BRANCH branch pipeline' - CREATE_INCIDENT_FOR_PIPELINE_FAILURE: "true" - BROKEN_BRANCH_INCIDENTS_PROJECT: "gitlab-org/release/tasks" - BROKEN_BRANCH_INCIDENTS_PROJECT_TOKEN: "${BROKEN_STABLE_INCIDENTS_PROJECT_TOKEN}" - if: '$CI_COMMIT_BRANCH =~ /^\d+-\d+-auto-deploy-\d+$/' variables: <<: *ruby2-variables diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index ab1f709de26..d29ac054b2c 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -994a537cefce6044125fa420cd7536a6efda0618 +a41c0909051714c0d6b58f8000589f82a66804a5 diff --git a/app/assets/javascripts/issues/constants.js b/app/assets/javascripts/issues/constants.js index 10d1a2d0dbf..ba05dd731f7 100644 --- a/app/assets/javascripts/issues/constants.js +++ b/app/assets/javascripts/issues/constants.js @@ -6,6 +6,7 @@ export const STATUS_REOPENED = 'reopened'; export const TITLE_LENGTH_MAX = 255; +export const TYPE_EPIC = 'epic'; export const TYPE_ISSUE = 'issue'; export const IssuableStatusText = { diff --git a/app/assets/javascripts/issues/show/components/app.vue b/app/assets/javascripts/issues/show/components/app.vue index a0db1ddcf6f..decb559ee81 100644 --- a/app/assets/javascripts/issues/show/components/app.vue +++ b/app/assets/javascripts/issues/show/components/app.vue @@ -4,8 +4,8 @@ import Visibility from 'visibilityjs'; import { createAlert } from '~/flash'; import { IssuableStatusText, - IssuableType, STATUS_CLOSED, + TYPE_EPIC, TYPE_ISSUE, WorkspaceType, } from '~/issues/constants'; @@ -277,7 +277,7 @@ export default { return IssuableStatusText[this.issuableStatus]; }, shouldShowStickyHeader() { - return [TYPE_ISSUE, IssuableType.Epic].includes(this.issuableType); + return [TYPE_ISSUE, TYPE_EPIC].includes(this.issuableType); }, }, created() { diff --git a/app/assets/javascripts/notes/components/sidebar_subscription.vue b/app/assets/javascripts/notes/components/sidebar_subscription.vue index a33f4364097..2a0a3d5414f 100644 --- a/app/assets/javascripts/notes/components/sidebar_subscription.vue +++ b/app/assets/javascripts/notes/components/sidebar_subscription.vue @@ -1,6 +1,6 @@