From fd767b7d65e0e9cb6f313b1803b859b8a7c0da57 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 23 Sep 2022 09:13:24 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/rules.gitlab-ci.yml | 20 +- .rubocop.yml | 4 +- GITALY_SERVER_VERSION | 2 +- .../components/profile_preferences.vue | 2 +- ...220905120848_backfill_epic_cache_counts.rb | 29 +++ ...pipeline_variables_raw_with_new_default.rb | 10 + ...ci_group_variables_raw_with_new_default.rb | 10 + ...instance_variables_raw_with_new_default.rb | 10 + ...d_ci_job_variables_raw_with_new_default.rb | 10 + ...schedule_variables_raw_with_new_default.rb | 10 + ...d_add_ci_variables_raw_with_new_default.rb | 10 + db/schema_migrations/20220905120848 | 1 + db/schema_migrations/20220921111823 | 1 + db/schema_migrations/20220921111831 | 1 + db/schema_migrations/20220921111840 | 1 + db/schema_migrations/20220921111849 | 1 + db/schema_migrations/20220921111857 | 1 + db/schema_migrations/20220921111907 | 1 + db/structure.sql | 14 +- .../blueprints/runner_scaling/index.md | 172 ++++++++++++++---- doc/integration/jira/development_panel.md | 2 +- doc/topics/autodevops/index.md | 128 +++++-------- .../backfill_epic_cache_counts.rb | 15 ++ rubocop/rubocop-ruby30.yml | 16 ++ .../backfill_epic_cache_counts_spec.rb | 32 ++++ .../web_hooks/log_execution_service_spec.rb | 2 + 26 files changed, 372 insertions(+), 133 deletions(-) create mode 100644 db/post_migrate/20220905120848_backfill_epic_cache_counts.rb create mode 100644 db/post_migrate/20220921111823_remove_and_add_ci_pipeline_variables_raw_with_new_default.rb create mode 100644 db/post_migrate/20220921111831_remove_and_add_ci_group_variables_raw_with_new_default.rb create mode 100644 db/post_migrate/20220921111840_remove_and_add_ci_instance_variables_raw_with_new_default.rb create mode 100644 db/post_migrate/20220921111849_remove_and_add_ci_job_variables_raw_with_new_default.rb create mode 100644 db/post_migrate/20220921111857_remove_and_add_ci_pipeline_schedule_variables_raw_with_new_default.rb create mode 100644 db/post_migrate/20220921111907_remove_and_add_ci_variables_raw_with_new_default.rb create mode 100644 db/schema_migrations/20220905120848 create mode 100644 db/schema_migrations/20220921111823 create mode 100644 db/schema_migrations/20220921111831 create mode 100644 db/schema_migrations/20220921111840 create mode 100644 db/schema_migrations/20220921111849 create mode 100644 db/schema_migrations/20220921111857 create mode 100644 db/schema_migrations/20220921111907 create mode 100644 lib/gitlab/background_migration/backfill_epic_cache_counts.rb create mode 100644 rubocop/rubocop-ruby30.yml create mode 100644 spec/migrations/backfill_epic_cache_counts_spec.rb diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index bc8f7596ff0..203aa779e5b 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -31,11 +31,14 @@ .if-merge-request: &if-merge-request if: '$CI_MERGE_REQUEST_IID' +# Once https://gitlab.com/gitlab-org/gitlab/-/issues/373904 is implemented, we should be able to change this back to +# if: '$CI_MERGE_REQUEST_IID && $CI_MERGE_REQUEST_APPROVALS_COUNT > 0' +# or any similar condition to check that the MR has *any* approval (not just required approval). .if-merge-request-approved: &if-merge-request-approved - if: '$CI_MERGE_REQUEST_IID && $CI_MERGE_REQUEST_APPROVED' + if: '$CI_MERGE_REQUEST_IID && $CI_MERGE_REQUEST_LABELS =~ /pipeline:run-full-rspec/' .if-merge-request-not-approved: &if-merge-request-not-approved - if: '$CI_MERGE_REQUEST_IID && $CI_MERGE_REQUEST_APPROVED != "true"' + if: '$CI_MERGE_REQUEST_IID && $CI_MERGE_REQUEST_LABELS !~ /pipeline:run-full-rspec/' .if-automated-merge-request: &if-automated-merge-request if: '$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME == "release-tools/update-gitaly" || $CI_MERGE_REQUEST_TARGET_BRANCH_NAME =~ /stable-ee$/' @@ -532,9 +535,6 @@ rules: - <<: *if-merge-request-approved when: never - # Temporarily disabled minimal rspec jobs before and after approval because of https://gitlab.com/gitlab-org/gitlab/-/issues/373064. - - <<: *if-merge-request-not-approved - when: never - <<: *if-automated-merge-request when: never - <<: *if-security-merge-request @@ -554,6 +554,8 @@ changes: *backend-patterns - <<: *if-security-merge-request changes: *backend-patterns + - <<: *if-merge-request-not-approved + when: never .rails:rules:as-if-foss-migration-unit-integration:minimal-default-rules: rules: @@ -581,6 +583,8 @@ changes: *code-backstage-patterns - <<: *if-security-merge-request changes: *code-backstage-patterns + - <<: *if-merge-request-not-approved + when: never .rails:rules:system:minimal-default-rules: rules: @@ -1007,6 +1011,8 @@ changes: *db-patterns - <<: *if-security-merge-request changes: *db-patterns + - <<: *if-merge-request-not-approved + when: never - changes: *db-patterns .rails:rules:ee-and-foss-migration:minimal: @@ -1108,6 +1114,8 @@ changes: *db-patterns - <<: *if-security-merge-request changes: *db-patterns + - <<: *if-merge-request-not-approved + when: never - changes: *db-patterns .rails:rules:ee-only-migration:minimal: @@ -1195,6 +1203,8 @@ changes: *db-patterns - <<: *if-security-merge-request changes: *db-patterns + - <<: *if-merge-request-not-approved + when: never .rails:rules:as-if-foss-migration:minimal: rules: diff --git a/.rubocop.yml b/.rubocop.yml index ee54d03d6af..21e2f8f2827 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -13,6 +13,9 @@ inherit_from: <% end %> - '.rubocop_todo.yml' <% end %> + <% if RUBY_VERSION[/^\d+\.\d+/, 0] == '3.0' %> + - ./rubocop/rubocop-ruby30.yml + <% end %> - ./rubocop/rubocop-migrations.yml - ./rubocop/rubocop-usage-data.yml - ./rubocop/rubocop-code_reuse.yml @@ -84,7 +87,6 @@ Lint/EmptyFile: # This cop checks whether some constant value isn't a # mutable literal (e.g. array or hash). Style/MutableConstant: - Enabled: true Exclude: - 'db/migrate/**/*' - 'db/post_migrate/**/*' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 80c8a866e1f..beb66fcc2b4 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -9498ab9459048cc595d8e2e411b027d080c0ab0f +e4d8f69ffa2efd3f2cb0adff5fa66f367f66f6fb diff --git a/app/assets/javascripts/profile/preferences/components/profile_preferences.vue b/app/assets/javascripts/profile/preferences/components/profile_preferences.vue index aa6d001c00e..b30b6a2faa9 100644 --- a/app/assets/javascripts/profile/preferences/components/profile_preferences.vue +++ b/app/assets/javascripts/profile/preferences/components/profile_preferences.vue @@ -110,7 +110,7 @@ export default {