From ff961c5927f71b7dc6d56980f823f00a2ad475d5 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 15 Oct 2024 21:15:03 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../lint/redundant_cop_disable_directive.yml | 2 - .../style/inline_disable_annotation.yml | 2 - .../components/ci_variable_shared.vue | 3 +- .../diffs/components/diff_view.vue | 6 +- .../javascripts/emoji/components/picker.vue | 11 +- app/controllers/concerns/renders_blob.rb | 23 +- .../groups/settings/ci_cd_controller.rb | 1 - app/controllers/projects/blob_controller.rb | 60 +- .../projects/settings/ci_cd_controller.rb | 1 - app/models/ci/variable_value.rb | 15 - app/models/concerns/ci/hidable_variable.rb | 15 - app/models/concerns/mirror_authentication.rb | 10 +- app/views/ci/variables/_attributes.html.haml | 4 +- .../development/ci_hidden_variables.yml | 8 - doc/ci/variables/index.md | 5 +- doc/development/duo_workflow/index.md | 2 +- .../visual_studio_code/index.md | 83 ++- doc/integration/jenkins.md | 2 +- doc/user/duo_workflow/index.md | 2 +- doc/user/project/integrations/index.md | 2 +- doc/user/project/integrations/webhooks.md | 584 +++++++++--------- doc/user/snippets.md | 2 +- .../fix_vulnerability_reads_has_issues.rb | 37 -- .../Browser-Performance-Testing.gitlab-ci.yml | 18 +- ...r-Performance-Testing.latest.gitlab-ci.yml | 16 +- .../Verify/Browser-Performance.gitlab-ci.yml | 16 +- .../Browser-Performance.latest.gitlab-ci.yml | 14 +- qa/gems/gitlab-cng/Gemfile | 4 +- qa/gems/gitlab-cng/Gemfile.lock | 85 +-- .../cng/commands/subcommands/deployment.rb | 2 +- .../unit/gitlab/cng/commands/doctor_spec.rb | 4 +- ...fix_vulnerability_reads_has_issues_spec.rb | 100 --- spec/models/ci/variable_value_spec.rb | 36 -- .../concerns/ci/hidable_variable_spec.rb | 44 -- spec/requests/api/ci/variables_spec.rb | 38 -- .../api/graphql/ci/group_variables_spec.rb | 33 - .../api/graphql/ci/project_variables_spec.rb | 35 -- spec/requests/api/group_variables_spec.rb | 36 -- .../search_labels_filter_shared_examples.rb | 16 - 39 files changed, 513 insertions(+), 864 deletions(-) delete mode 100644 config/feature_flags/development/ci_hidden_variables.yml delete mode 100644 lib/gitlab/background_migration/fix_vulnerability_reads_has_issues.rb delete mode 100644 spec/lib/gitlab/background_migration/fix_vulnerability_reads_has_issues_spec.rb diff --git a/.rubocop_todo/lint/redundant_cop_disable_directive.yml b/.rubocop_todo/lint/redundant_cop_disable_directive.yml index 23708cb8c75..32b4e4df30c 100644 --- a/.rubocop_todo/lint/redundant_cop_disable_directive.yml +++ b/.rubocop_todo/lint/redundant_cop_disable_directive.yml @@ -280,7 +280,6 @@ Lint/RedundantCopDisableDirective: - 'lib/gitlab/background_migration/destroy_invalid_project_members.rb' - 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb' - 'lib/gitlab/background_migration/fix_namespace_ids_of_vulnerability_reads.rb' - - 'lib/gitlab/background_migration/fix_vulnerability_reads_has_issues.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'lib/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb' @@ -404,7 +403,6 @@ Lint/RedundantCopDisableDirective: - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_statistics_with_container_registry_size_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/convert_credit_card_validation_data_to_hashes_spec.rb' - 'spec/lib/gitlab/background_migration/drop_vulnerabilities_without_finding_id_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_vulnerability_reads_has_issues_spec.rb' - 'spec/lib/gitlab/background_migration/populate_vulnerability_dismissal_fields_spec.rb' - 'spec/lib/gitlab/background_migration/resolve_vulnerabilities_for_removed_analyzers_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/validators/schema_validator_spec.rb' diff --git a/.rubocop_todo/style/inline_disable_annotation.yml b/.rubocop_todo/style/inline_disable_annotation.yml index aa8bb41d05a..dce29852ef4 100644 --- a/.rubocop_todo/style/inline_disable_annotation.yml +++ b/.rubocop_todo/style/inline_disable_annotation.yml @@ -2020,7 +2020,6 @@ Style/InlineDisableAnnotation: - 'lib/gitlab/background_migration/fix_first_mentioned_in_commit_at.rb' - 'lib/gitlab/background_migration/fix_namespace_ids_of_vulnerability_reads.rb' - 'lib/gitlab/background_migration/fix_projects_without_prometheus_service.rb' - - 'lib/gitlab/background_migration/fix_vulnerability_reads_has_issues.rb' - 'lib/gitlab/background_migration/job_coordinator.rb' - 'lib/gitlab/background_migration/legacy_upload_mover.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' @@ -2520,7 +2519,6 @@ Style/InlineDisableAnnotation: - 'spec/lib/gitlab/background_migration/delete_orphans_approval_merge_request_rules2_spec.rb' - 'spec/lib/gitlab/background_migration/delete_orphans_approval_project_rules2_spec.rb' - 'spec/lib/gitlab/background_migration/destroy_invalid_members_spec.rb' - - 'spec/lib/gitlab/background_migration/fix_vulnerability_reads_has_issues_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - 'spec/lib/gitlab/background_migration/populate_vulnerability_dismissal_fields_spec.rb' diff --git a/app/assets/javascripts/ci/ci_variable_list/components/ci_variable_shared.vue b/app/assets/javascripts/ci/ci_variable_list/components/ci_variable_shared.vue index 3363088aed2..9d4ba4fef2a 100644 --- a/app/assets/javascripts/ci/ci_variable_list/components/ci_variable_shared.vue +++ b/app/assets/javascripts/ci/ci_variable_list/components/ci_variable_shared.vue @@ -186,7 +186,8 @@ export default { return this.$apollo.queries.environments.loading; }, areHiddenVariablesAvailable() { - return Boolean(this.entity && this.glFeatures?.ciHiddenVariables); + // group and project variables can be hidden, instance variables cannot + return Boolean(this.entity); }, hasEnvScopeQuery() { return Boolean(this.queryData?.environments?.query); diff --git a/app/assets/javascripts/diffs/components/diff_view.vue b/app/assets/javascripts/diffs/components/diff_view.vue index 965ebdb4808..1fdc03ace6e 100644 --- a/app/assets/javascripts/diffs/components/diff_view.vue +++ b/app/assets/javascripts/diffs/components/diff_view.vue @@ -234,7 +234,7 @@ export default {
@@ -297,7 +297,7 @@ export default {
diff --git a/app/assets/javascripts/emoji/components/picker.vue b/app/assets/javascripts/emoji/components/picker.vue index 41b989d8996..92f7c8d6137 100644 --- a/app/assets/javascripts/emoji/components/picker.vue +++ b/app/assets/javascripts/emoji/components/picker.vue @@ -101,8 +101,10 @@ export default { } }, onSearchInput() { - this.$refs.virtualScoller.setScrollTop(0); - this.$refs.virtualScoller.forceRender(); + if (this.$refs.virtualScoller) { + this.$refs.virtualScoller.setScrollTop(0); + this.$refs.virtualScoller.forceRender(); + } }, async onScroll(event, { offset }) { const categories = await getEmojiCategories(); @@ -111,8 +113,6 @@ export default { }, onShow() { this.isVisible = true; - this.$refs.searchValue.focusInput(); - this.$emit('shown'); }, onHide() { @@ -166,7 +166,7 @@ export default { -