Commit Graph

56 Commits

Author SHA1 Message Date
GitLab Bot dbe0e56762 Add latest changes from gitlab-org/gitlab@master 2023-03-03 15:08:43 +00:00
GitLab Bot 510bc67dd2 Add latest changes from gitlab-org/gitlab@master 2023-02-01 06:07:27 +00:00
GitLab Bot a64e7a4066 Add latest changes from gitlab-org/gitlab@master 2022-12-14 21:08:30 +00:00
GitLab Bot f48ded4221 Add latest changes from gitlab-org/gitlab@master 2022-09-06 00:12:24 +00:00
GitLab Bot 6d82b3a0c5 Add latest changes from gitlab-org/gitlab@master 2022-04-27 15:10:01 +00:00
GitLab Bot 7b6a6bfc58 Add latest changes from gitlab-org/gitlab@master 2022-01-14 15:16:52 +00:00
GitLab Bot d6024427e8 Add latest changes from gitlab-org/gitlab@master 2021-04-28 09:10:13 +00:00
GitLab Bot 4d16568658 Add latest changes from gitlab-org/gitlab@master 2021-03-18 06:11:52 +00:00
GitLab Bot 8106ac487c Add latest changes from gitlab-org/gitlab@master 2021-01-14 15:10:46 +00:00
GitLab Bot 6535cf9c79 Add latest changes from gitlab-org/gitlab@master 2020-11-17 15:09:28 +00:00
GitLab Bot 22d08de610 Add latest changes from gitlab-org/gitlab@master 2020-11-09 15:08:56 +00:00
GitLab Bot 3e1c760141 Add latest changes from gitlab-org/gitlab@master 2020-11-05 18:08:48 +00:00
GitLab Bot a662b146ac Add latest changes from gitlab-org/gitlab@master 2020-11-05 12:09:05 +00:00
GitLab Bot 2b1e7f7dac Add latest changes from gitlab-org/gitlab@master 2020-10-27 15:08:39 +00:00
GitLab Bot a1908447b7 Add latest changes from gitlab-org/gitlab@master 2020-10-26 15:08:40 +00:00
GitLab Bot f4fb4d5948 Add latest changes from gitlab-org/gitlab@master 2020-09-25 15:09:36 +00:00
GitLab Bot 2e2cd0ea3e Add latest changes from gitlab-org/gitlab@master 2020-06-02 00:08:07 +00:00
GitLab Bot bd860c22f6 Add latest changes from gitlab-org/gitlab@master 2019-09-17 12:06:48 +00:00
Sean McGivern f9f9147290 Fix page_description helper performance
This helper is used for extracting part of the issue / MR / whatever
description for use in the description meta tag:

1. To do that, we look at the source of the Markdown description.
2. We then strip out all HTML tags.
3. And then take the first 30 words.

Doing that can be really slow - especially as Markdown is supposed to be
treated as plain text. There are many better ways to do this, but the
immediate performance fix is to swap steps 2 and 3. This does mean that
the description may be less than 30 words (or even empty), but it is
much faster when the description is very long.
2019-05-22 16:56:12 +01:00
George Tsiolis 733ae94921 Fix typos in comments and specs 2018-11-01 08:59:20 +02:00
gfyoung 1993a4449a Enable frozen string for app/helpers/**/*.rb
Partially addresses #47424.
2018-09-06 17:33:46 -07:00
Alexis Reigel 67fe0a17d8
call Gitlab::Favicon.status in serializer
this ways we can keep the `lib/gitlab/ci/status/*` classes to return the
bare favicon name as it was before.

also the favicon uploader versions are now have the same names as the
stock favicons (+ `favicon_` prefix), which makes working with the
status names easier.
2018-06-05 16:20:21 +02:00
Alexis Reigel a6f3f6b8cd
extract favicon logic to lib class 2018-06-05 16:20:19 +02:00
Alexis Reigel 8967fc0477
use custom main favicon 2018-06-05 16:20:19 +02:00
Eric Eastwood fca02e2476 Update styling and use Gitlab::Utils.to_boolean 2018-03-27 13:13:48 -05:00
Eric Eastwood de0c4730bb Merge branch 'master' into add-canary-favicon 2018-03-27 12:39:18 -05:00
Douwe Maan 711bb28568 Add Page-Title header to tree and blob JSON endpoints 2017-09-26 17:31:47 +02:00
Phil Hughes 80a013ef4f removed show_new_nav? references 2017-09-06 12:19:03 +01:00
Phil Hughes 2aa8a75f69 Merge branch 'master' into breadcrumbs-improvements 2017-09-06 12:12:19 +01:00
Phil Hughes ddb3692a22 Clean up new navigation templates 2017-09-06 10:58:24 +00:00
Phil Hughes de82bd8e44 fixed up JS to use a js-* class
fixed up Ruby based on review
2017-09-06 11:55:23 +01:00
Phil Hughes 85b272b223
updated a bunch of breadcrumb titles
[ci skip]
2017-08-18 11:07:05 +01:00
Phil Hughes 7b1affd426 use `.last` instead 2017-07-14 08:56:06 +01:00
Phil Hughes 13cc761a09 moved `@breadcrumb_title` out of the HAML & into a helper method 2017-07-12 09:16:32 +01:00
Phil Hughes 9fcc28d428 moved declaration of `breadcrumb_title` into `page_title` method
`breadcrumb_title` is then overriden when needed
2017-07-12 09:04:22 +01:00
Luke "Jared" Bennett ed31624970
Add temporary CANARY env vars to be set in Kubernetes-with-canary.gitlab-ci.yml and used in page_layout_helper.rb 2017-06-27 12:49:50 +01:00
Simon Knox 679ce9dbb3 dev favicon is blue, not purple 2017-02-16 06:55:52 +11:00
Simon Knox e15032eded override favicon for development to find tabs more easily 2017-02-16 01:07:29 +11:00
Mike Greiling 76ae5af8ce ensure the 'fixed layout' preference is honored whenever possible
see #22343 for issue description
2016-09-20 00:51:00 -05:00
Grzegorz Bizon 28bafd5354 Enable Style/SpaceAfterComma Rubocop cop 2016-06-29 15:23:44 +02:00
Dmitriy Zaporozhets 324e57693b
Implement top navigation concept for profile area
Main idea is to keep left sidebar static so user is not confused by
changing context. Instead we put changing navigation with changing
content in one main block

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-04-19 20:05:30 +02:00
Douwe Maan 384445eca6 Don't override issue page description in project layout. 2016-01-06 13:02:51 +01:00
Robert Speicher 43053c2e6f Make `page_description` less magical 2016-01-05 14:54:59 -05:00
Robert Speicher a298f69432 Use `User#avatar_url` instead of `avatar_icon` helper 2016-01-05 14:50:52 -05:00
Douwe Maan bd21e3d731 Add Open Graph data for group, project and commit. 2015-12-25 16:41:02 +01:00
Robert Speicher ab3d855c0e Add support for `twitter:label` meta tags 2015-12-24 17:11:08 -05:00
Robert Speicher c6d2508362 Truncate page_description to 30 words 2015-12-24 16:26:52 -05:00
Robert Speicher 5a3b9c97e3 Account for `@project.description` being nil 2015-12-23 17:14:18 -05:00
Robert Speicher b26eb782f5 Add page descriptions and images
A limited number of pages have defined their own descriptions, but
otherwise we default to the Project's description (if `@project` is
set), or the old `brand_title` fallback.

The image will either be the uploaded project icon (never a generated
one), the user's uploaded icon or Gravatar, or, finally, the GitLab
logo.
2015-12-23 16:56:27 -05:00
Douwe Maan 69709bbdd0 Separate page title segments by middot rather than pipe 2015-12-02 14:57:51 +01:00