0122d00cac
Add latest changes from gitlab-org/gitlab@master
2022-12-16 18:09:43 +00:00
ba689154ab
Add latest changes from gitlab-org/gitlab@master
2022-05-09 09:08:47 +00:00
6a5b78ac69
Add latest changes from gitlab-org/gitlab@master
2021-12-07 03:12:22 +00:00
6fd750c192
Add latest changes from gitlab-org/gitlab@master
2021-11-10 18:12:35 +00:00
f11dc14070
Add latest changes from gitlab-org/gitlab@master
2020-07-23 21:09:19 +00:00
c780abc85f
Add latest changes from gitlab-org/gitlab@master
2020-07-20 12:09:34 +00:00
e829ca213b
Add latest changes from gitlab-org/gitlab@master
2020-06-22 15:09:27 +00:00
640e72ca92
Add latest changes from gitlab-org/gitlab@master
2020-06-04 03:08:05 +00:00
1219a9dce9
Add latest changes from gitlab-org/gitlab@master
2020-04-01 15:07:45 +00:00
abae8f34f3
Add latest changes from gitlab-org/gitlab@master
2020-03-31 21:08:05 +00:00
0d6fa03312
Add latest changes from gitlab-org/gitlab@master
2020-02-06 18:08:54 +00:00
b082790134
Add latest changes from gitlab-org/gitlab@master
2019-09-18 18:06:14 +00:00
f1926b321d
Add controller concern for paginated collections
...
We had similar code in a few places to redirect to the last page if
the given page number is out of range. This unifies the handling in a
new controller concern and adds usage of it in all snippet listings.
2019-09-10 15:24:29 +02:00
211a00473b
Eliminate N+1 queries in Dashboard::TodosController
...
This appears to bring down the number of SQL queries on GitLab.com for
my Todos page from 672 to 100.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/43042
2019-06-24 09:57:38 -07:00
93a44e135b
Add some frozen string to spec/**/*.rb
...
Adds frozen string to the following:
* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb
xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-04-15 10:17:05 +00:00
9bc5ed14fe
Move Contribution Analytics related spec in spec/features/groups/group_page_with_external_authorization_service_spec to EE
2019-04-09 15:38:58 +00:00
46b1b9c1d6
Revert "Merge branch 'if-57131-external_auth_to_ce' into 'master'"
...
This reverts merge request !26823
2019-04-05 13:02:56 +00:00
d9d7237d2e
Move Contribution Analytics related spec in spec/features/groups/group_page_with_external_authorization_service_spec to EE
2019-04-05 11:45:47 +00:00
b44a2c801a
Update specs to rails5 format
...
Updates specs to use new rails5 format.
The old format:
`get :show, { some: params }, { some: headers }`
The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
1be0174b6a
Merge branch 'security-private-group' into 'master'
...
[master] Fixed read private group names
See merge request gitlab/gitlabhq!2589
2018-11-28 19:07:15 -05:00
27c95364b5
Replace '.team << [user, role]' with 'add_role(user)' in specs
2017-12-22 19:18:28 +11:00
acf49c6d89
Fix access to the final page of todos
...
The todos page limit is 20, and both that and a user's pending todo count are
integers. Using integer division means that the result's floor will be taken,
defeating the point of the later call to `#ceil`.
So we need to convert one side of the division to a float first, otherwise the
last page won't be treated as available.
2017-11-09 13:13:48 +00:00
2f40dac352
Refactor `have_http_status` into `have_gitlab_http_status` in the specs
2017-10-20 10:13:18 +02:00
063b9edc77
Save a query on the todos index page
...
When there are no filters, we can get the total todos count from the cached
count on the user object, instead of performing a DB query. This query takes
about 80ms for me on GitLab.com.
2017-10-04 17:37:38 +01:00
72a7b30c9f
Change all `:empty_project` to `:project`
2017-08-02 17:47:31 -04:00
ceda6bd5a6
Merge branch '33303-404-for-unauthorized-project' into 'security-9-3'
...
[9.3 security fix] Renders 404 if given project is not readable by the user on Todos dashboard
See merge request !2118
2017-07-19 22:28:34 -05:00
387c4b2c21
Backport of multiple_assignees_feature [ci skip]
2017-05-04 17:11:53 +03:00
ff76adb547
Unnecessary "include WaitForAjax" and "include ApiHelpers"
...
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs.
Removed unnecessary usage of `api:true`
2017-04-21 22:32:02 +02:00
b80653bb6a
Merge branch 'open-redirect-host-fix' into 'security'
...
Fix for three open redirect vulns using redirect_to url_for(params.merge)))
See merge request !2082
2017-04-05 21:06:58 -07:00
5f9ace8eb1
Add 'Undo mark all as done' to Todos
...
Added the ability to 'Undo mark all as done' todos marked as complete with 'Mark all as done'
in the 'Todo' tab of the Todo dashboard.
The operation undos only the todo previously marked as done with the 'Mark al as done' button.
2017-03-16 07:15:00 +01:00
6f5b3dc7a0
fix rspec issue after delimiter fix
2017-02-22 14:44:01 +06:00
26160459b5
Todo done clicking is kind of unusable.
...
The Done button will change to an Undo button and the line item will be greyed out.
Bold links will be unbolded.
The user can undo the task by clicking the Undo button.
2017-02-17 22:12:19 +01:00
4642ca6686
Use `empty_project` where possible in controller specs
2017-01-25 17:14:38 -05:00
bf4a042f6a
fixes the issue
2017-01-12 15:49:48 -05:00
d7a2e92ca0
applies url_for so that we dont lose filters when redirecting
2016-12-23 15:09:34 +00:00
805bbe8893
adds specs for respective behaviour
2016-12-21 23:53:24 +00:00
GitLab Bot
Markus Koller
Stan Hu
gfyoung
Imre Farkas
Andreas Brandl
blackst0ne
Cindy Pallares
Sean McGivern
Jacopo
Robert Speicher
Valery Sizov
Nur Rony
Tiago Botelho