GitLab Bot
9d9331740a
Add latest changes from gitlab-org/gitlab@master
2024-05-30 12:13:19 +00:00
GitLab Bot
2b3cc47aca
Add latest changes from gitlab-org/gitlab@master
2024-04-10 21:09:39 +00:00
GitLab Bot
0e08747b3d
Add latest changes from gitlab-org/gitlab@master
2023-12-28 15:20:21 +00:00
GitLab Bot
dce8d0c6a7
Add latest changes from gitlab-org/gitlab@master
2023-10-13 00:10:17 +00:00
GitLab Bot
ae9f43a2c4
Add latest changes from gitlab-org/gitlab@master
2023-02-02 12:07:33 +00:00
GitLab Bot
a7698afc6e
Add latest changes from gitlab-org/gitlab@master
2022-09-23 00:10:38 +00:00
GitLab Bot
5f85444a43
Add latest changes from gitlab-org/gitlab@master
2022-08-25 15:12:14 +00:00
GitLab Bot
80c12cd5b2
Add latest changes from gitlab-org/gitlab@master
2022-03-24 18:07:52 +00:00
GitLab Bot
bc85eaf615
Add latest changes from gitlab-org/gitlab@master
2022-03-22 00:07:23 +00:00
GitLab Bot
aea64c367b
Add latest changes from gitlab-org/gitlab@master
2021-09-06 09:11:02 +00:00
GitLab Bot
4a6e6c740b
Add latest changes from gitlab-org/gitlab@master
2021-07-23 18:10:06 +00:00
GitLab Bot
25db9c1230
Add latest changes from gitlab-org/gitlab@master
2021-05-06 12:10:38 +00:00
GitLab Bot
537882ad40
Add latest changes from gitlab-org/gitlab@master
2020-09-10 00:08:32 +00:00
GitLab Bot
f1a40d0db9
Add latest changes from gitlab-org/gitlab@master
2020-03-09 15:07:45 +00:00
Mayra Cabrera
0ab89d8e36
Add a rubocop for Rails.logger
...
Suggests to use a JSON structured log instead
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102
2019-07-10 19:26:47 +00:00
Bob Van Landuyt
8c5b3d0302
Allow streaming io objects into Gitaly
...
This allows us to set the encoding of an IO passed without reading it
into memory.
This is useful if we want to stream files into Gitaly. Like we do when
uploading a new file to the repository.
2019-04-01 20:17:40 +02:00
gfyoung
c858f70d07
Enable frozen string for lib/gitlab/*.rb
2018-10-22 07:00:50 +00:00
Stan Hu
038be9fffa
Fix Error 500s due to encoding issues when Wiki hooks fire
...
Saved Wiki content goes through the GitalyClient::WikiService, which calls
StringIO#set_encoding on the input stream. The problem is that this call
mutates the encoding of the given string object to ASCII-88BIT, which
causes problems for models expecting the data to still be in UTF-8.
Freezing the input disables this behavior:
https://github.com/ruby/ruby/blob/v2_4_4/ext/stringio/stringio.c#L1583
Closes #50590
2018-08-29 09:46:46 -07:00
Lin Jen-Shin
3bfe306624
Resolve Naming/UncommunicativeMethod
2018-07-09 21:13:08 +08:00
Lin Jen-Shin
4ee08b77bc
Updates from `rubocop -a`
2018-07-09 21:13:08 +08:00
Ahmad Sherif
1f2cc29c8f
Fix EncodingHelper#clean blowing up on UTF-16BE strings
...
Closes gitaly#1101
2018-03-22 21:22:20 +01:00
Ahmad Sherif
0d9107374a
Return a warning string if we try to encode to unsupported encoding
...
Fixes gitlab-development-kit#321
2018-02-09 22:19:43 +01:00
Alejandro Rodríguez
5152cc3bfb
Fix a bug where charlock_holmes was used needlessly to encode strings
2018-01-04 19:27:37 -03:00
Alejandro Rodríguez
11247ac97c
Move encoding methods to the more general EncodingHelper
2017-12-28 12:32:33 -03:00
Jacob Vosmaer (GitLab)
4cfcc97544
Fix encoding bugs in Gitlab::Git::User
2017-11-23 10:48:57 +00:00
Alejandro Rodríguez
520866a0d0
Avoind unnecesary `force_encoding` operations
...
They're costly. This will also avoid some edge cases where
charlock_holmes assigns a weird encoding to a perfectly valid UTF-8
string.
2017-10-18 21:30:29 -03:00
micael.bergeron
c1f66cc7f0
remove useless comment
2017-09-06 09:15:27 -04:00
micael.bergeron
a6af5522d7
renames ambiguous methods and add spec
2017-09-06 09:01:53 -04:00
micael.bergeron
dbaed90c8d
fix refactoring error with Blob.binary?
...
remove some lint
2017-09-06 09:01:53 -04:00
micael.bergeron
c9aa793215
revert to using a simple representation
2017-09-06 09:01:53 -04:00
micael.bergeron
bca72f5906
wip: fake its a binary diff
2017-09-06 09:01:53 -04:00
Lin Jen-Shin
8e2350ae95
Raise encoding confidence threshold to 50
...
It is recommended that we set this to 50:
https://gitlab.com/gitlab-org/gitlab-ce/issues/35098#note_35036746
In this particular issue, the confidence was 42 for Shift JIS,
but in fact that's encoded in UTF-8 just with a single bad
character. In this case, we shouldn't try to treat it as Shift JIS,
but just treat it as UTF-8 and remove invalid bytes.
Treating it like Shift JIS would corrupt the whole data.
Unfortunately, the diff which would cause this could not be
disclosed therefore we can't use it as a test example.
2017-08-08 19:09:56 +08:00
James Lopez
6b53add3f9
Fix binary encoding error on MR diffs
2017-06-06 16:40:07 +00:00
Bob Van Landuyt
e564fe971f
Rename `Gitlab::Git::EncodingHelper` to `Gitlab::EncodingHelper`
2017-06-01 21:21:14 +00:00