Commit Graph

100 Commits

Author SHA1 Message Date
Winnie Hellmann 19737aeaa9 Remove parsePikadayDate test 2017-11-06 14:54:33 +01:00
Filipa Lacerda 941c11824a Fix Pikaday 2017-10-18 11:31:01 +00:00
Clement Ho 22a120a24d Improve sprite icon spec 2017-10-17 16:19:40 +00:00
Clement Ho 13b299f4ff Add ability to pass class name to spriteIcon helper 2017-10-12 12:43:00 -05:00
Filipa Lacerda 67f4408d74 Fix bad type checking to prevent 0 count badge to be shown 2017-10-10 07:47:42 +00:00
Felipe Artur b54203f0ad Commenting on image diffs 2017-10-07 04:25:17 +00:00
Phil Hughes d729aa7383
spec fix 2017-09-29 09:40:21 +01:00
Phil Hughes 333cb069af
Fixed anchored content not being scrolled into view
Correctly scrolls anchored content into view when the user loads the
page. This is most obvious when the user loads a link note in a
merge request & the page does not scroll down to the note.

Closes #38326
2017-09-29 09:24:56 +01:00
Phil Hughes 1544bc3228
remove the sticky el from the test DOM after each test 2017-09-25 11:55:33 +01:00
Phil Hughes f389f9081f
refactor tests to actually test browser behaviour 2017-09-25 11:40:40 +01:00
Phil Hughes 734bb73625
fixed and added specs for removing placeholder element 2017-09-22 11:13:19 +01:00
Tim Zallmann 55f772bb98 Resolve "Better SVG Usage in the Frontend" 2017-09-22 08:39:47 +00:00
Bryce Johnson cca06da2e4 Standardize access to CSRF token in JavaScript 2017-09-21 17:53:28 +00:00
Filipa Lacerda 96e6fc70b4 Import modules instead of using the ones in global namespace
Removes set favicon related methods from global scope
Improves test related with favicon

Removes convertPermissionToBoolean from global scope.
Adds tests for convertPermissionToBoolean - were non existant

Removes setParamInURL from gl.utils

Removes parseIntPagination from gl.utils namespace

Remove normalizeCRLFHeaders from gl.utils namespace

Removes normalizeHeaders from gl.utils namespace

Use gl.utils for filtered search

Fix bad import

Fix broken test by cleaning window.history namespace

Adds changelog
2017-09-09 09:54:27 +01:00
Filipa Lacerda 6a1b84c7b4 Use modules in common utils 2017-09-09 09:54:24 +01:00
Tim Zallmann 955d684cde Merge branch '36517-failing-karma-tests-for-chrome-60' into 'master'
Resolve "Failing karma tests for Chrome 60"

Closes #36517

See merge request !13646
2017-08-21 07:18:44 +00:00
Mike Greiling d4cb1ec9e9 fix unnecessarily long gl.utils.backOff test 2017-08-18 03:01:23 -05:00
Mike Greiling 2f35a266e1 fix test failures in text_utility_spec.js on Chrome 60 2017-08-18 02:50:11 -05:00
Phil Hughes 30777178e3
fixed jumping when bar gets stuck
added specs to sticky util file
added `No files found.` text when results are empty
2017-08-03 17:03:49 +01:00
Clement Ho 974a04026d Add filtered search to group issue dashboard 2017-08-02 09:27:24 +00:00
Simon Knox 53e7bf0470 fix transient rspec failure due to Poll.js race condition
don't treat aborted requests as failures, they are often triggered during unload (e.g after clicking a link)
2017-07-18 12:17:55 +10:00
Filipa Lacerda b2b527a690 Update tests to test what the component renders and what the clicks calls 2017-07-07 22:23:13 +01:00
winh 6ab12777bc Introduce addClassIfElementExists utility 2017-06-27 20:37:30 +02:00
Alfredo Sumaran 3ec37e2622 Merge branch 'master' into 25426-group-dashboard-ui 2017-06-07 14:45:57 -05:00
Alfredo Sumaran a65f07a256 Address feedback 2017-06-07 10:05:17 -05:00
Kushal Pandya 7abe27b425 Improve user experience around slash commands in instant comments 2017-06-05 09:12:15 +00:00
Lin Jen-Shin 6c72d8a219 Merge remote-tracking branch 'upstream/master' into rename-builds-controller
* upstream/master: (116 commits)
  Revert "Merge branch 'grpc-1.3.4' into 'master'"
  Return nil when looking up config for unknown LDAP provider
  Avoid crash when trying to parse string with invalid UTF-8 sequence
  Enable Gitaly by default in GitLab 9.3
  Don’t create comment on JIRA if link already exists
  Disable sub_group_issuables_spec.rb for mysql
  Fix math rendering on blob pages
  Add changelog
  Don't allow to pass a user to ProjectWiki#http_url_to_repo
  Revert "Merge branch '1937-https-clone-url-username' into 'master'
"
  Fix bottom padding for build page
  Fix /unsubscribe slash command creating extra todos
  Fix omniauth-google-oauth2 dependencies in Gemfile.lock
  Update looks job log
  'New issue'/'New merge request' dropdowns should show only projects with issues/merge requests feature enabled
  Fix spec for Members::AuthorizedDestroyService
  31616-add-uptime-of-gitlab-instance-in-admin-area
  Set head pipeline when creating merge requests
  Create a separate helper to check if we show particular tab on a search page
  Add performance deltas between app deployments on Merge Request widget
  ...
2017-05-31 18:14:11 +08:00
Kushal Pandya 069783b5cc Add performance deltas between app deployments on Merge Request widget 2017-05-29 15:04:47 +00:00
Lin Jen-Shin c94db0c290 Use - as the prefix so we don't conflict with namespaces
The decision was made around:
https://gitlab.com/gitlab-org/gitlab-ce/issues/26407#note_30624641
2017-05-26 23:06:20 +08:00
Lin Jen-Shin 70eb0c6a88 Merge remote-tracking branch 'upstream/master' into rename-builds-controller
* upstream/master: (307 commits)
  Address feedback
  Add small update for the i18n guide.
  update webpack to v2.6.1 patch release to fix "Can't find variable: Promise" error
  update webpack-bundle-analyzer past v2.4.1 to support NamedChunksPlugin
  name all webpack chunks to improve long term cacheability
  add NameAllModulesPlugin to cover shortcomings of NamedModulesPlugin
  upgrade to latest webpack version
  Only use DROP INDEX CONCURRENTLY on postgreql 9.2+
  Provide default for calculating label text color (!11681)
  Add failing test for #32728
  Bugfix: Always use the default language when generating emails.
  Remove unecessary commit pattern check
  Add regexp_for_value helper method
  Remove shared example and improve sub_group_issuables_spec.rb
  Remove 'should' from scenario in has_subgroup_title_spec.rb
  Cartfile git and binary methods cannot take a GitHub repo
  Fix terminals support for Kubernetes service
  Add review comments to compare_spec.rb
  Fix transient error clicking dropdown items in compare_spec.rb
  Use non-global jQuery reference within raven bundle
  ...
2017-05-26 18:25:32 +08:00
Filipa Lacerda 43a28cfee2 Merge branch 'winh-frontend-user-cache' into 'master'
Introduce UsersCache for storing user entities in frontend

See merge request !11404
2017-05-23 14:09:48 +00:00
winh d7f9b408bf Add frontend UsersCache class (!11404) 2017-05-23 10:45:59 +02:00
winh c102656736 Extract Cache class from AjaxCache 2017-05-21 23:59:47 +02:00
Lin Jen-Shin 71777a4a18 Rename BuildsController to JobsController
Rename other URL generators

admin_builds_path -> admin_jobs_path

Fix tests and more renaming

Fix more tests

Also change build_id to job_id in the controller
2017-05-17 20:17:30 +08:00
Mike Greiling 283f968ef2 update frontend specs to use ES module syntax 2017-05-16 16:01:51 -05:00
Filipa Lacerda 17806d7619 Merge branch 'issue-boards-label-filtering' into 'master'
Fixed issue boards not filtering when URL params are encoded

Closes #32084

See merge request !11320
2017-05-16 08:18:53 +00:00
Filipa Lacerda f99e8c07fe Merge branch 'remove-vue-from-poll_spec-fix-transient-failures' into 'master'
Fix poll_spec transient failures

See merge request !11264
2017-05-12 09:54:05 +00:00
Phil Hughes 477be05661 Fixed issue boards not filtering when URL params are encoded
Closes #32084
2017-05-12 09:27:21 +01:00
Luke "Jared" Bennett 55b6232c74 Removed unneeded false from poll_spec mockServiceCall call 2017-05-11 19:11:03 +00:00
Luke "Jared" Bennett 2d7b9455e1
Fixed promise action binding and simplified callbacks spy 2017-05-11 13:09:13 +01:00
Luke "Jared" Bennett dbab076b05
improved mockservicecall and fixed up a settimeout 2017-05-11 12:48:24 +01:00
Winnie Hellmann b304d41232 Track pending requests in AjaxCache 2017-05-10 22:01:00 +00:00
Luke "Jared" Bennett 4a4b586aa0
Removed vue and vue-resource from poll_spec in an attempt to fix the transient failures relating to async timeout 2017-05-10 20:41:06 +01:00
Winnie Hellmann b51f2a6080 Colorize labels in issue search field 2017-05-05 22:47:32 +00:00
Luke "Jared" Bennett bef42d9a36 Fallback localstorage cases 2017-05-05 17:59:41 +00:00
Kushal Pandya 645593e5af Add instant comments support 2017-05-05 10:57:29 +00:00
Kushal Pandya d586b6cced Add ES lint support to identify poorly written Promises 2017-04-20 11:11:51 +00:00
Filipa Lacerda c15a2d7ffd Merge branch 'use-favicon-full-path-for-pipeline-status-favicon' into 'master'
Use favicon full path

See merge request !10676
2017-04-18 16:22:08 +00:00
Filipa Lacerda b67bb566b3 Improves support for long build traces: 2017-04-18 12:27:10 +00:00
Luke "Jared" Bennett b24cb99856
Updated specs 2017-04-13 12:50:03 +01:00