f682cc189a
Merge branch 'master' into sh-headless-chrome-support
2017-10-03 12:11:56 -05:00
b74c643c66
Only copy old/new code when selecting left/right side of parallel diff
2017-10-02 18:39:25 +02:00
08172ff595
Expand Spinach window size and remove unsupported trigger calls
2017-08-11 23:02:21 -07:00
408df2edcb
Merge branch 'master' into sh-headless-chrome-support
2017-08-02 16:58:28 -07:00
81e9c28425
Render add-diff-note button with server.
...
This commit moves the rendering of the button back to the server, and
shows/hides it using opacity rather than display. It also removes the
transform applied to the button on hover (scale). Previously, both of these
factors automatically triggered a reflow, which creates a performance
bottleneck on pages with larger DOM size.
MR: !12103
2017-06-29 12:50:45 -04:00
5854ab2f7d
Convert variants of trigger('click') -> click
2017-06-16 23:08:27 -07:00
2338785ec9
Use wait_for_requests to wait all JS request
2017-05-22 20:39:49 -03:00
f7d69a74a8
Fix up emoji tests that should have failed :/
...
Some discussion,
https://gitlab.slack.com/archives/C0GQHHPGW/p1490398531185144
-> MR to fix failing emoji test:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10230
2017-03-24 21:19:34 -05:00
6683fdcfb0
Add nested groups support to the routing
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-11-23 14:08:36 +02:00
5d0f68f26b
Fix diff_comments failure
2016-11-04 11:23:58 -05:00
5a8f727fd5
Merge branch 'master' into faster-diffs
...
# Conflicts:
# app/helpers/notes_helper.rb
# app/views/projects/diffs/_line.html.haml
# app/views/projects/diffs/_parallel_view.html.haml
# app/views/projects/diffs/_text_file.html.haml
# features/steps/shared/diff_note.rb
2016-07-07 18:05:34 -04:00
29d574868a
Display new diff notes and allow creation through the web interface
2016-07-06 18:51:00 -04:00
50dfdf0296
fix up tests
...
Added more exceptions
Added handling inline view type
2016-07-06 08:29:57 +02:00
e065f4848b
Diffs will create button/diff form on demand no on server side
2016-07-06 08:29:57 +02:00
c452fa8124
Update specs
2016-05-13 17:31:58 -05:00
2f81baf476
Update click_diff_line
2016-04-14 09:10:40 -05:00
dab4ac54b6
Diff design updates
2016-04-07 15:33:18 -07:00
87b3c73ea5
Update diff_comments tests
2016-04-07 15:33:18 -07:00
29f414aa5a
Tests update
2016-04-04 10:48:49 +01:00
f95f242cfa
Updated tests
2016-03-04 13:52:29 +00:00
82571eab43
Fix failing specs
2016-01-21 10:08:12 +01:00
a4e0c7c7d6
Upgrade Poltergeist to 1.8.1. #4131
2015-12-17 01:01:08 -05:00
2b57755117
Add feature test for emoji-only diff notes
...
This specs is related to bug described in #3734 (award-emojis).
2015-12-03 13:39:00 +01:00
c2a9e6ea67
Fix tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2015-09-03 22:15:21 +02:00
afec5efc7d
Fix features syntax
2015-06-22 12:13:45 +02:00
a7932fe2fd
Support commenting on a diff in side-by-side view
...
Closes https://github.com/gitlabhq/gitlabhq/issues/9283
2015-06-16 06:11:59 -07:00
584f8601ef
Change `within` to `page.within` in feature steps
2015-06-12 05:12:42 -04:00
69bbc413fe
Update all `should`-style syntax to `expect` in features
2015-06-12 05:12:09 -04:00
67b06e7a9b
Change always passing visible true tests to false.
2015-01-02 00:20:19 +01:00
7a5072c5a8
Fix test assertions
...
Make sure we're asserting the correct thing when testing visible and
invisible DOM elements.
2014-10-21 23:29:31 -05:00
74c82ae325
Fix houndci warnings
2014-10-18 18:24:12 -05:00
e06f0ead98
Fix Markdown preview tests
...
Update Spinach tests for Markdown previews for the new-ish tab UI that
replaced the old preview/edit toggle button.
2014-10-18 18:07:23 -05:00
e1491465de
Refactor Markdown preview tests
...
Create a new shared module for common issue/merge request behavior,
use `expect` syntax instead of `should`, and avoid `visible: false` in
the `have_css` matcher.
2014-10-18 17:58:34 -05:00
5700842ba8
Add Markdown preview to more forms
...
Enable Markdown previews when creating and editing issues, merge
requests, and milestones, and when editing notes.
2014-10-15 23:52:33 -05:00
778afb699f
Replace javascript:; links with buttons.
2014-09-22 21:01:19 +02:00
ef6e94e37e
Replace old spinach step definitions with step.
2014-09-22 10:01:50 +02:00
5a68c20fba
Fix MR factory and some MR tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-07-31 18:07:24 +03:00
69baa3afb2
Dont render difscussion for commit diffs
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-06-24 20:22:33 +03:00
ef933ae69b
Even more tests fixed :)
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-05-24 14:41:13 +03:00
6c8a17d06d
Fix diff tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-02-24 12:17:39 +02:00
1743cbf1d8
Update capybara to 2.1, poltergeist to master
2013-04-11 10:45:18 +03:00
42ce2c1080
improve selectors to pass capybara 2.0
2013-02-21 11:27:22 +02:00
e33debc214
Updated commit diff view with some minor visual modifications
...
Prepared diff view for multiple view modes
Converted commits.js to coffeescript
image info in separate coffeescript file
Added swipe view mode
Added onion skin viewMode
2013-01-27 18:27:32 +01:00
953db8477e
More fixes for test
2013-01-15 14:28:04 +02:00
ac983319d3
fixing some test
2013-01-15 12:42:54 +02:00
d28176b132
Replace commit diff note request specs with spinach features
2013-01-15 00:52:57 +01:00
Jose Ivan Vargas
Douwe Maan
Stan Hu
Bryce Johnson
Oswaldo Ferreira
Eric Eastwood
Dmitriy Zaporozhets
Annabel Dunstone Gray
Luke "Jared" Bennett
Jacob Schatz
Phil Hughes
Rémy Coutable
Rubén Dávila
Grzegorz Bizon
Robert Speicher
Ciro Santilli
Vinnie Okada
Koen Punt
Riyad Preukschas