181cd299f9
Adds Rubocop rule for line break after guard clause
...
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
2017-11-16 17:58:29 +01:00
f097e4dbcd
Don't send rejection mails for all auto-generated mails
...
Also make it easier to have mailer helper
2017-08-03 00:40:10 +08:00
7af4c0c4f7
Fix email receiver metrics events
...
`Project#inspect` isn't very useful for examining usage of these features.
2017-05-05 10:37:54 +01:00
0bb31e54d1
Make handler metric params more explicit
2017-04-21 16:11:21 +01:00
19970e1dba
Store projects in metrics for email replies
2017-04-20 13:19:16 +01:00
79889a6aa3
Add specs
2017-04-05 17:44:14 +01:00
08bbb9fce6
Add option to start a new discussion on an MR
2017-04-05 17:44:14 +01:00
a0586dbc16
replace `find_with_namespace` with `find_by_full_path`
...
add complete changelog for !8949
2017-02-03 07:14:04 +07:00
c3a940000e
Handles unsubscribe from notifications via email
...
- allows unsubscription processing of email in format "reply+%{key}+unsubscribe@acme.com" (example)
- if config.address includes %{key} and replies are enabled every unsubscriable message will include mailto: link in its List-Unsubscribe header
2017-01-13 10:11:46 -05:00
9d51421346
Use separate email-friendly token for incoming email and let incoming
...
email token be reset
2016-11-07 15:55:42 +00:00
a4ef4244d4
Preserve note_type and position for notes from emails
...
Closes #23208
2016-10-20 16:18:53 +08:00
0eea8c8857
Support slash commands in noteable description and notes
...
Some important things to note:
- commands are removed from noteable.description / note.note
- commands are translated to params so that they are treated as normal
params in noteable Creation services
- the logic is not in the models but in the Creation services, which is
the right place for advanced logic that has nothing to do with what
models should be responsible of!
- UI/JS needs to be updated to handle notes which consist of commands
only
- the `/merge` command is not handled yet
Other improvements:
- Don't process commands in commit notes and display a flash is note is only commands
- Add autocomplete for slash commands
- Add description and params to slash command DSL methods
- Ensure replying by email with a commands-only note works
- Use :subscription_event instead of calling noteable.subscribe
- Support :todo_event in IssuableBaseService
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-08-13 00:05:57 +02:00
176fa21cb7
raise UnknownIncomingEmail when there's no mail_key:
...
So that we don't have to pretend that CreateNoteHandler
could handle a nil mail_key. Also, since NilClass#=~ would
just return nil for any regular expression, we could just
match it without checking nilness.
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3363#note_12566407
2016-06-20 19:15:54 +08:00
0671db52a8
Use keyword args to be more clear:
...
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3363#note_12566374
2016-06-20 19:11:42 +08:00
c491f66952
Use a separate line for separate actions:
...
Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3363#note_12420487
2016-06-20 17:58:05 +08:00
09c38e46e5
Only pass item name
2016-06-15 20:10:16 +08:00
9417814970
More space for private concern
2016-06-15 19:41:31 +08:00
fcc6a59247
Blank line for private
2016-06-15 16:18:31 +08:00
3b64c4f9d6
A blank line to separate exception raising
2016-06-15 16:16:44 +08:00
4c09871450
Avoid using bang bang
2016-06-15 16:15:49 +08:00
72184c16ab
Rename to project_path which is more accurate
2016-06-15 15:54:04 +08:00
cb168c347a
Remove empty lines at the beginning of files
2016-06-15 15:47:40 +08:00
1f5d55907a
Merge the places where exceptions could be raised
2016-05-24 01:23:07 +08:00
863d8e5ae5
use split and try to unify error raising
2016-05-23 22:16:40 +08:00
c64cd113cc
Add ! for verify_record! because it could raise
2016-05-21 09:46:27 -07:00
75415663f8
Rename handlers and introduce Handler.for
2016-05-21 09:40:08 -07:00
c2bc15a766
Use the authentication_token for finding the user
2016-05-20 17:38:08 -05:00
a7c823a573
Give ProjectNotFound when the project is not readable
2016-05-18 17:57:14 -05:00
c337e748d3
so we use separate classes to handle different tasks
2016-05-18 17:25:45 -05:00
Jacopo
Lin Jen-Shin
Sean McGivern
Douwe Maan
Adam Pahlevi
Pawel Chojnacki
Rémy Coutable