35b8f103a8
Prevent comments by email when issue is locked
...
This changes the permission check so it uses the policy on Noteable
instead of Project. This prevents bypassing of rules defined in
Noteable for locked discussions and confidential issues.
Also rechecks permissions when reply_to_discussion_id is provided since the
discussion_id may be from a different noteable.
2019-01-31 16:52:48 +01:00
40983f4a9c
Show tooltip for malicious looking links
...
Such as those with IDN homographs or embedded
right-to-left (RTLO) characters.
Autolinked hrefs should be escaped
2019-01-31 16:52:20 +01:00
b3c13bbb3c
Added validations to prevent LFS object forgery
2019-01-31 16:51:54 +01:00
f27cba0fee
Fix private user email being visible in tag webhooks
...
Fixes #54721
2019-01-31 16:51:18 +01:00
7327fb4aa7
Present all pipeline triggers using trigger presenter
2019-01-31 16:51:17 +01:00
084b7edb17
Do not expose trigger token when user should not see it
2019-01-31 16:51:17 +01:00
219d24fe52
Fix slow project reference pattern regex
2019-01-31 16:51:16 +01:00
57f082d969
Fix path disclosure on Project Import
2019-01-31 16:51:16 +01:00
232a7a36e2
Add number of repositories to usage ping data
2019-01-31 18:46:07 +05:30
5841a7d5ef
Update Sentry client to get project list
2019-01-31 10:05:29 +00:00
4c2096b46a
Merge branch 'an-opentracing-render-tracing' into 'master'
...
Add OpenTracing instrumentation for Action View Render events
See merge request gitlab-org/gitlab-ce!24728
2019-01-30 12:33:02 +00:00
d022ce8655
Add OpenTracing instrumentation for Action View Render events
...
This change adds three new instrumentations, driven through rails
notifications: render_template.action_view,
render_collection.action_view and render_partial.action_view.
These can help developers understand why renders are taking a long
time which may in turn help them to improve their performance.
2019-01-30 13:38:19 +02:00
6fc5495703
Merge branch 'anan-add-MethodCallWithoutArgsParentheses-cop' into 'master'
...
Re-enable MethodCallWithoutArgsParentheses Cop
Closes #56795
See merge request gitlab-org/gitlab-ce!24631
2019-01-30 10:02:38 +00:00
def2b548d2
Revert the "What's new" feature
2019-01-29 20:45:47 +00:00
5652533a9c
Merge branch '55820-adds-common-name-chart-value' into 'master'
...
Overrides commonName Helm chart value
Closes #55820
See merge request gitlab-org/gitlab-ce!24683
2019-01-29 20:04:32 +00:00
ff0b2cc61f
Re-enable MethodCallWithoutArgsParentheses Cop
...
Re-enables and autocorrects all instances of the
Style/MethodCallWithoutArgsParentheses rule
2019-01-29 21:05:30 +02:00
965f40d9ac
Port this style change from EE
2019-01-30 01:16:43 +08:00
4ac06d344b
Revert " Trigger iid logic from GitHub importer for merge requests."
...
This reverts commit fb98496f49
2019-01-29 15:38:40 +01:00
820739eb09
Revert "Trigger iid logic from GitHub importer for issues."
...
This reverts commit b78a69b06c
2019-01-29 15:38:40 +01:00
852e68fd95
Revert "Trigger iid logic from GitHub importer for milestones."
...
This reverts commit 358675d09f
2019-01-29 15:38:40 +01:00
f13f308c56
Common name needs to be lower case
2019-01-28 20:26:54 +00:00
a245519641
Merge branch 'bw-enable-sourcepos' into 'master'
...
Enable CommonMark source line position information
See merge request gitlab-org/gitlab-ce!23971
2019-01-28 17:19:23 +00:00
7bc16889df
Refactor Storage Migration
...
Specs were reviewed and improved to better cover the current behavior.
There was some standardization done as well to facilitate the
implementation of the rollback functionality.
StorageMigratorWorker was extracted to HashedStorage namespace were
RollbackerWorker will live one as well.
2019-01-25 20:26:35 +01:00
c2c34eba62
Prepare rake task for storage rollback
...
We are keeping compatibility with existing scheduled jobs.
2019-01-25 20:26:35 +01:00
43005f2df2
Allow suggestions to be copied and pasted as GFM
...
Supports both suggestions transformed from GFM to HTML and from GFM to
HTML to Vue component.
2019-01-25 18:40:36 +01:00
1295598649
Overrides commonName Helm chart attr with default value
2019-01-25 17:25:25 +01:00
2b8f19435b
Merge branch 'elasticsearch-via-gitaly-ee' into 'master'
...
Add connection_data method to Gitaly client
See merge request gitlab-org/gitlab-ce!24669
2019-01-25 16:06:55 +00:00
dc6091876d
Merge branch 'container-repository-cleanup-api' into 'master'
...
Container repository cleanup API
Closes #55978
See merge request gitlab-org/gitlab-ce!24303
2019-01-25 13:24:35 +00:00
dfa31d5f2f
Merge branch '54905-milestone-search' into 'master'
...
Resolve "Milestone search"
Closes #54905
See merge request gitlab-org/gitlab-ce!24265
2019-01-25 13:22:34 +00:00
5ab285490a
Merge branch 'feature/gb/cross-project-pipeline-trigger' into 'master'
...
Cross-project pipeline triggers /CE
See merge request gitlab-org/gitlab-ce!24664
2019-01-25 12:31:49 +00:00
e3cacb95a8
Add connection_data method to Gitaly client
...
Backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7434
2019-01-25 14:16:42 +02:00
045d07bab3
Add Container Registry API
...
This includes a set of APIs to manipulate container registry.
This includes also an ability to delete tags based on requested
criteria, like keep-last-n, matching-name, older-than.
2019-01-25 13:13:48 +01:00
cc29bc61e0
Merge branch 'db-copy-as-gfm-prosemirror' into 'master'
...
Reimplement Copy-as-GFM using the prosemirror document model
See merge request gitlab-org/gitlab-ce!22797
2019-01-25 11:38:42 +00:00
53b8e6e389
Merge branch '54250-upstream-kubeclient-redirect-patch' into 'master'
...
Use http_max_redirects opt to replace monkeypatch
Closes #54250
See merge request gitlab-org/gitlab-ce!24284
2019-01-25 11:00:54 +00:00
552f803283
Merge branch '40997-gitlab-pages-deploy-jobs-have-a-null-status' into 'master'
...
Fix empty labels for `pages:deploy` job
Closes #40997
See merge request gitlab-org/gitlab-ce!24451
2019-01-25 10:51:47 +00:00
ca52a1254e
Merge branch 'an-opentracing-active-record-tracing' into 'master'
...
Adds tracing support for ActiveRecord notifications
See merge request gitlab-org/gitlab-ce!24604
2019-01-25 10:48:50 +00:00
3508948dfe
Add a new relation between a stage and related bridges
2019-01-25 10:39:26 +01:00
20e7d4882c
Make CI/CD bridge job a pipeline processable entity
2019-01-25 10:37:18 +01:00
9f26729af5
Use defauly `only` policy defined as a constant
...
We reuse this constant in EE.
2019-01-25 10:35:24 +01:00
4967fe9454
Do not assigne unused attributes to CI/CD builds
2019-01-25 10:33:53 +01:00
5d85a04927
Make it possible to fabricate CI/CD bridge jobs
2019-01-25 10:32:40 +01:00
5692c282af
Make it possible to override config jobs composition in EE
2019-01-25 10:29:01 +01:00
f234aef994
Use http_max_redirects opt to replace monkeypatch
...
http_max_redirects was introduced in 4.2.2, so upgrade kubeclient.
The monkey-patch was global so we will have to check that all instances
of Kubeclient::Client are handled.
Spec all methods of KubeClient
This should provide better confidence that we are indeed disallowing
redirection in all cases
2019-01-25 16:48:37 +13:00
22eb2e4c22
Adds milestone search
...
Adds to search ILIKE search for milestones title in:
- Milestones dashboard
- Group milestones page
- Project milestones page
2019-01-24 18:44:09 +01:00
61c51d3b6e
Merge branch '56392-enable-the-layout-extraspacing-cop' into 'master'
...
Enable the Layout/ExtraSpacing cop
Closes #56392
See merge request gitlab-org/gitlab-ce!24423
2019-01-24 15:09:52 +00:00
fac725c9e5
Merge branch '53676-ip-address-of-gitlab-runner-is-wrong-in-the-runners-description' into 'master'
...
Get remote address for runner
Closes #53676
See merge request gitlab-org/gitlab-ce!24624
2019-01-24 14:04:55 +00:00
3a2abc1d50
Enable the Layout/ExtraSpacing cop
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-01-24 13:05:45 +01:00
3cc3650dfe
Remove expired artifacts periodically
...
Rename
Introduce Destroy expired job artifacts service
Revert a bit
Add changelog
Use expired
Improve
Fix spec
Fix spec
Use bang for destroy
Introduce iteration limit
Update comment
Simplify more
Refacor
Remove unnecessary thing
Fix comments
Fix coding offence
Make loop helper exception free
2019-01-24 20:50:42 +09:00
1b90ffc573
Adds tracing support for ActiveRecord notifications
...
This change will publish distributed tracing spans related to
SQL ActiveRecord queries. These queries are unbound, so will still
contain parameter substitution strings in place of actual parameter
values.
This ensures that the SQL strings do not need to be scrubbed, since the
values are not included in the SQL.
More details of rails instrumentation can be found here:
https://guides.rubyonrails.org/active_support_instrumentation.html
2019-01-24 13:11:09 +02:00
8a03dbf8b7
Use nodes and marks to power Copy-as-GFM
...
The spec needed to be updated because in some cases the resulting
Markdown is slightly different, though equally valid.
2019-01-24 12:06:53 +01:00
Heinrich Lee Yu
Brett Walker
Francisco Javier López
Luke Duncalfe
Grzegorz Bizon
James Lopez
Balasankar "Balu" C
Reuben Pereira
Douwe Maan
Andrew Newdigate
Lin Jen-Shin
Brandon Labuschagne
Stan Hu
Andreas Brandl
João Cunha
Robert Speicher
Gabriel Mazetto
Douwe Maan
Nick Thomas
Grzegorz Bizon
Sean McGivern
Valery Sizov
Kamil Trzciński
Phil Hughes
Thong Kuah
Jacopo
Rémy Coutable
Shinya Maeda