Commit Graph

30 Commits

Author SHA1 Message Date
Jan Provaznik 9ccf8d032f Enabled feature flag for fast deletions
Fast destroy is used only if the feature flag is enabled, otherwise
uploads are still deleted using carrier wave. It's disabled by default.
2018-12-06 22:00:19 +01:00
Jan Provaznik 239fdc78b1 Use FastDestroy for deleting uploads
It gathers list of file paths to delete before destroying
the parent object. Then after the parent_object is destroyed
these paths are scheduled for deletion asynchronously.

Carrierwave needed associated model for deleting upload file.
To avoid this requirement, simple Fog/File layer is used directly
for file deletion, this allows us to use just a simple list of paths.
2018-12-06 22:00:19 +01:00
James Lopez 64c11f104c Resolve "Can add an existing group member into a group project with new permissions but permissions are not overridden" 2018-12-06 13:15:29 +00:00
Dylan Griffith fe1469e12f Upgrade helm to 2.11.0 and upgrade on every install 2018-11-16 10:22:40 +00:00
Sean McGivern ca3e9b9759 Merge branch 'blackst0ne-add-discord-service' into 'master'
Add Discord integration

Closes #21635

See merge request gitlab-org/gitlab-ce!22684
2018-11-12 10:12:48 +00:00
blackst0ne 079a75088e Refactor specs 2018-11-07 09:12:02 +11:00
Chris Baumbauer e5c408e445 Refactor cluster application tests to centralize helm CA cert verification 2018-11-06 11:52:15 -08:00
blackst0ne 762959465c DRY specs, fix typos in docs 2018-11-06 22:07:07 +11:00
Peter Leitzen 3a3ec6f021
Show available clusters when installed or updated
Before this commit updating Prometheus (e.g. adding alerts) made it
"updated" therefore not installed.
2018-10-16 09:16:43 +02:00
Jan Provaznik fa53297090 Sort labels by reference
Labels are sorted by reference, not title. This caused random CI
failure.
2018-09-07 18:38:17 +02:00
Jan Provaznik d95c1f0335 Use ResourceLabelEvent for tracking label changes 2018-09-07 13:39:20 +00:00
Jamie Schembri e72388246b Resolve "Allow issue's Internal ID (`iid`) to be set when creating via the API" 2018-08-01 09:03:14 +00:00
Mark Chao a63bce1a4b Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
Shinya Maeda c89e57842e Use shared examples for populate spec 2018-06-01 15:46:15 +09:00
Shinya Maeda c754b6937c Clean up presence validation spec 2018-06-01 15:37:36 +09:00
Shinya Maeda 1c636b8080 Merge branch 'master' into per-project-pipeline-iid 2018-05-17 15:51:33 +09:00
Jan Provaznik 7da3b2cdd0 Delete remote uploads
ObjectStore uploader requires presence of associated `uploads` record
when deleting the upload file (through the carrierwave's after_commit
hook) because we keep info whether file is LOCAL or REMOTE in `upload`
object.

For this reason we can not destroy uploads as "dependent: :destroy" hook
because these would be deleted too soon. Instead we rely on
carrierwave's hook to destroy `uploads` in after_commit hook.

But in before_destroy hook we still have to delete not-mounted uploads
(which don't use carrierwave's destroy hook). This has to be done in
before_Destroy instead of after_commit because `FileUpload` requires
existence of model's object on destroy action.

This is not ideal state of things, in a next step we should investigate
how to unify model dependencies so we can use same workflow for all
uploads.

Related to #45425
2018-05-16 08:58:07 +02:00
Shinya Maeda 82a49d0fea Clarify scope for AtomicInternalId shared spec 2018-05-14 17:41:56 +09:00
Shinya Maeda 46fa3089c8 Rescue RecordNotUnique when pipeline is created with non-unique iid 2018-05-11 16:49:18 +09:00
Shinya Maeda 910a7d02a8 Remove numericality as it's redandant with integer column and validates nil IID 2018-05-11 15:34:36 +09:00
Shinya Maeda 30a6fb64db Fix atomic internal id spec to allow generate pipeline 2018-05-10 15:56:47 +09:00
Shinya Maeda 04dc80dbb5 Fix spec 2018-05-08 16:01:18 +09:00
Rémy Coutable 8d381b359f
Ensure member notifications are sent after the member actual creation/update in the DB
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-04-26 08:28:05 +02:00
Andreas Brandl 9ea2fc85a3 Atomic internal ids for all models 2018-04-20 14:00:15 +00:00
Andreas Brandl fb6d6fce5a Address review comments. 2018-03-16 13:35:27 +01:00
Andreas Brandl 6568b4a98e Add shared specs for AtomicInternalId concern. 2018-03-16 13:35:26 +01:00
Mayra Cabrera c607008ee5 Extend Cluster Applications to install GitLab Runner to Kubernetes cluster 2018-03-01 23:46:02 +00:00
Rémy Coutable f070265a6d
Introduce new hook data builders for Issue and MergeRequest
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-10-09 16:44:47 +02:00
Rémy Coutable 075d651604 Start adding Gitlab::HookData::IssuableBuilder
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-10-09 15:07:10 +02:00
Rémy Coutable 67d5ca9f92 Include the changes in issuable webhook payloads
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-10-09 15:07:10 +02:00