31749779da
Remove feature flag for FindAllRemoteBranches
...
Acceptance testing done through:
https://gitlab.com/gitlab-org/gitaly/issues/1312
Relatively short AT period, but given its not a hard RPC, nor anything
funky is going on, I felt that this was decent enough to remove the
feature flag.
Closes https://gitlab.com/gitlab-org/gitaly/issues/1243
2018-08-16 09:42:31 +02:00
bbbcb9142e
Merge branch 'zj-remove-feature-gate-list-commits' into 'master'
...
Remove feature gate for ListNewCommits
Closes gitaly#1286 and gitaly#1233
See merge request gitlab-org/gitlab-ce!21184
2018-08-14 09:14:23 +00:00
5ddc9ad0b9
Remove feature gate for ListNewCommits
...
Introduced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20087 ,
this has been tested on .com now, and is stable.
Closes https://gitlab.com/gitlab-org/gitaly/issues/1286
Closes https://gitlab.com/gitlab-org/gitaly/issues/1233
2018-08-14 10:34:15 +02:00
7466df872c
Get the `merge-base` of 2 refs trough the API
...
This adds an endpoint to get the common ancestor of 2 refs from the API.
2018-08-13 11:58:54 +02:00
6688a719c4
Backport of gitlab-org/gitlab-ee!6848
2018-08-08 16:18:37 -05:00
5c748a0bd9
Backport some changes from gitlab-org/gitlab-ee!6767
2018-08-07 06:13:48 -05:00
01de2b5df8
Refactor gitlab:import:repos task to remove direct disk access
2018-07-31 16:28:44 -04:00
3f0e6d9205
More Gitaly cleanup: fetch_ref, allow disk access blocks
2018-07-27 08:43:19 +00:00
c8ff6b7c73
Use limit parameter to retrieve Wikis from Gitaly
...
Without this parameter, every load of a Wiki page will load all the Wiki pages
in the repository for the sidebar. This is a significant performance penalty
that can significant slow the display of all Wiki pages.
Relates to #40101
2018-07-24 15:36:31 -07:00
ad73953772
Make repository cleanup mandatory
2018-07-24 13:25:27 +02:00
4147a2dbbd
Annotate Gitlab::Git::Repository#fetch_ref
2018-07-24 06:33:55 +00:00
d4c3a9ab41
Remove unused rugged code that is currently on Gitaly
2018-07-20 14:47:50 -04:00
256e7a6396
Merge branch 'zj-gitaly-migrate-old-migrations' into 'master'
...
Gitaly migrate old DB migrations
Closes gitaly#1106
See merge request gitlab-org/gitlab-ce!20708
2018-07-20 10:21:05 +00:00
fa1ea656f7
Migrate add_remote, remove_remote, fetch_internal_remote to gitaly
2018-07-19 15:07:37 -04:00
805de7fb8d
Add missing Gitaly branch_update nil checks
2018-07-19 17:48:58 +00:00
cfbb256b8b
MigrateProcessCommitWorkerJobs to use Gitaly
...
This old migration used Rugged to find a commit, while Gitaly is the
prefered way now. By migrating this to Gitaly, Gitaly is now a required
running component for this migration.
Part of https://gitlab.com/gitlab-org/gitaly/issues/1106
2018-07-19 13:34:10 +02:00
68b1e5a97c
Incorporate Gitaly's RefService.FindAllRemoteBranches RPC
2018-07-18 16:48:47 -04:00
9348efc6ba
Client implementation for Repository#new_commits
...
After trying to remove the whole method in
8f69014af2902d8d53fe931268bec60f6858f160, this is a more gentle
approach to the method. :)
Prior to this change, new commit detection wasn't implemented in Gitaly,
this was done through: https://gitlab.com/gitlab-org/gitaly/merge_requests/779
As the new implemented got moved around a bit, the whole RevList class
got removed.
Part of https://gitlab.com/gitlab-org/gitaly/issues/1233
2018-07-18 14:46:27 +02:00
5c651daa97
Remove unreachable Git code
2018-07-18 11:12:57 +00:00
830940f422
Migrate merge base, merged branches, write ref
2018-07-17 09:00:32 +00:00
37eca76583
Remove Repository#lookup and unreachable rugged code
2018-07-16 10:34:31 +00:00
9451c80ac9
Merge branch 'sh-fix-stderr-pipe-consumption' into 'master'
...
Avoid process deadlock in popen by consuming input pipes
Closes gitlab-ee#6895
See merge request gitlab-org/gitlab-ce!20600
2018-07-13 13:14:34 +00:00
fd392cd725
Avoid process deadlock in popen by consuming input pipes
...
A process that spews a lot of output to stderr or stdout could stall out
due to the pipe buffer being full. As described in https://bugs.ruby-lang.org/issues/9082 ,
we can use the trick used in Ruby's capture3 function to read the pipes in separate
threads.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/6895
2018-07-12 16:21:30 -07:00
9d93a61a70
Fix find_branch call sites
2018-07-12 18:06:31 +02:00
d1d7144b96
Make more ref RPC's mandatory
2018-07-12 15:12:00 +02:00
62ffad0802
Remove Repository#path memoization
2018-07-12 09:49:25 +00:00
723f74d49d
Remove last flags from Blob and Workhorse
2018-07-11 12:59:15 +02:00
7358211ece
Merge branch '49057-fix-repository-typo' into 'master'
...
Fix a typo in Gitlab::Git::Repository
See merge request gitlab-org/gitlab-ce!20520
2018-07-10 13:32:20 +00:00
937d916b5f
Merge branch 'gitaly-mandatory-20180709-jv' into 'master'
...
Use Gitaly for fetches and creating bundles
Closes gitaly#387, gitaly#874, gitaly#750, and gitaly#665
See merge request gitlab-org/gitlab-ce!20490
2018-07-10 10:22:05 +00:00
1f28f4567b
Fix a typo? gitaly_operation{-s-}_client
2018-07-10 16:52:34 +08:00
2a4039cf66
Merge branch 'update-rubocop'
2018-07-09 17:23:30 +01:00
2cedb243ee
Merge branch 'gitaly-update-branch' into 'master'
...
Use Gitaly's OperationService.UserUpdateBranch RPC
Closes gitaly#1252
See merge request gitlab-org/gitlab-ce!20231
2018-07-09 16:12:18 +00:00
9286f5b934
Use stable gitlab-styles and eliminate offenses
2018-07-09 21:13:08 +08:00
4ee08b77bc
Updates from `rubocop -a`
2018-07-09 21:13:08 +08:00
a4e75e7a83
Use Gitaly for fetches and creating bundles
2018-07-09 12:50:17 +02:00
3082b7d1c2
Make blob and other RPC's mandatory
2018-07-09 10:02:02 +00:00
090f4d9e9f
Merge branch 'gitaly-mandatory-20180706-jv' into 'master'
...
Remove gitaly_list_commits_by_oid, gitaly_commit_deltas, gitaly_create_repository flags
Closes gitaly#593, gitaly#566, and gitaly#670
See merge request gitlab-org/gitlab-ce!20432
2018-07-09 09:59:51 +00:00
1a78483b49
Merge branch 'gitaly-diff-mandatory' into 'master'
...
Make all Gitaly diff flags mandatory
Closes gitaly#528 and gitaly#222
See merge request gitlab-org/gitlab-ce!20424
2018-07-09 09:42:30 +00:00
4a4338fcc6
Use Gitaly's OperationService.UserUpdateBranch RPC
2018-07-08 23:27:20 -04:00
7a17f8d85d
Merge branch 'gitaly-set-delete-config' into 'master'
...
Add Repository#set_config and #delete_config
See merge request gitlab-org/gitlab-ce!20372
2018-07-06 15:55:10 +00:00
c770d2f96e
Make more things mandatory
2018-07-06 14:44:54 +02:00
ff112ce641
Add Repository#set_config and #delete_config
2018-07-06 12:06:54 +02:00
b012abee8b
Make all Gitaly diff flags mandatory
2018-07-06 12:01:15 +02:00
9f8326995c
Partially rever "Revert "Merge branch 'gitaly-mandatory-20180703-jv' into 'master'""
...
This partially reverts commit 64dfe2cba1
2018-07-06 11:43:01 +02:00
64dfe2cba1
Revert "Merge branch 'gitaly-mandatory-20180703-jv' into 'master'"
...
This reverts merge request !20339
2018-07-05 10:22:04 +00:00
7a355f6856
Merge branch 'gitaly-mandatory-20180703-jv-2' into 'master'
...
Remove more Gitaly feature flags
Closes gitaly#329, gitaly#320, gitaly#323, and gitaly#328
See merge request gitlab-org/gitlab-ce!20343
2018-07-04 10:39:59 +00:00
78708b1932
Make more Gitaly features mandatory
2018-07-04 07:39:59 +00:00
201802f723
Remove more feature flags
2018-07-03 17:39:08 +02:00
15aadc665f
Make OperationService RPC's mandatory
2018-07-03 09:12:03 +00:00
e28896ce0d
Merge branch 'zj-find-all-commits' into 'master'
...
FindAllCommits mandatory
Closes gitaly#326
See merge request gitlab-org/gitlab-ce!20242
2018-06-28 13:11:00 +00:00
37b1922237
Merge branch 'zj-commits-between-mandatory' into 'master'
...
Commits between in Gitaly only
Closes gitaly#315
See merge request gitlab-org/gitlab-ce!20239
2018-06-28 13:10:07 +00:00
ec78d29a6e
FindAllCommits mandatory
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/326
2018-06-28 13:42:10 +02:00
f369da063f
Commits between in Gitaly only
...
Prior to this change, most the commits counted were done through Gitaly.
This removes the last point where this wasn't the case.
This makes the `rugged_count_commits` method obsolete, with its tests.
Closes https://gitlab.com/gitlab-org/gitaly/issues/315
2018-06-28 12:09:20 +02:00
e38db19659
Merge branch 'gitaly-mandatory-20180627-jv-2' into 'master'
...
Make Gitaly signature RPC's mandatory
Closes gitaly#745, gitaly#1044, and gitaly#876
See merge request gitlab-org/gitlab-ce!20212
2018-06-28 07:45:31 +00:00
f4d6834786
Make Gitaly signature RPC's mandatory
2018-06-27 14:32:09 +02:00
be5e6d586f
Make search and message RPC's mandatory
2018-06-27 13:46:51 +02:00
2452f1a73e
Merge branch 'gitaly-tree-entry-dot-dot' into 'master'
...
Client-side fix for Gitaly TreeEntry bug
See merge request gitlab-org/gitlab-ce!20176
2018-06-27 09:04:34 +00:00
33c950f293
Client-side fix for Gitaly TreeEntry bug
2018-06-26 14:12:08 +02:00
c6ff7bfaec
Move git calls for `Repository#update_branch` inside Gitlab::Git
...
This prepares this code for migration to Gitaly.
2018-06-25 19:49:55 -04:00
77fe416681
Merge branch 'zj-create-from-bundle-mandatory' into 'master'
...
Moves CreateFromBundle RPC to mandatory
Closes gitaly#944
See merge request gitlab-org/gitlab-ce!20144
2018-06-25 15:29:57 +00:00
fe03ff90c2
Merge branch 'zj-is-anchestor' into 'master'
...
Ancestor check is Gitaly only now
Closes gitaly#789 and gitaly#308
See merge request gitlab-org/gitlab-ce!20095
2018-06-25 15:28:19 +00:00
246ce5b5f9
Merge branch 'zj-write-config' into 'master'
...
Write Config is mandatory
Closes gitaly#879
See merge request gitlab-org/gitlab-ce!20146
2018-06-25 15:27:41 +00:00
51f047aaad
Merge branch 'zj-missing-part-linguist' into 'master'
...
Remove Languages feature gate
See merge request gitlab-org/gitlab-ce!20128
2018-06-25 15:23:25 +00:00
29b4d657be
Moves another RPC to mandatory
...
This specific one isn't used on most machines, therefor low risk.
Closes https://gitlab.com/gitlab-org/gitaly/issues/944
2018-06-25 15:55:22 +02:00
8354ae3cef
Update remote happens through Gitaly only
...
This change makes closes another migration! And remotes tests around it,
mostly due to stubbing this was needed. Also, these are tested on the
Gitaly side too:
- https://gitlab.com/gitlab-org/gitaly/issues/791
-
6dd74543f6/internal/service/repository/fetch_remote_test.gohttps://gitlab.com/gitlab-org/gitaly/issues/789
2018-06-25 15:47:42 +02:00
0855478726
Write Config is mandatory
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/879
2018-06-25 15:08:20 +02:00
af20d7816e
Remove feature gate
2018-06-25 13:51:06 +02:00
e91b2b5dff
Gitaly tree entry is mandatory
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/310
2018-06-25 13:48:28 +02:00
9d438edb34
Anchestor check is Gitaly only now
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/308
2018-06-25 09:25:15 +02:00
70bc866563
Merge branch 'zj-commit-raw-diffs' into 'master'
...
Raw diffs are served from Gitaly
Closes gitaly#222
See merge request gitlab-org/gitlab-ce!20091
2018-06-22 16:00:02 +00:00
254e589de9
Merge branch 'rs-lib-gitlab-git-gitlab_projects-parity' into 'master'
...
CE-EE parity for lib/gitlab/git/gitlab_projects.rb
See merge request gitlab-org/gitlab-ce!20047
2018-06-22 15:25:36 +00:00
510e45fd1e
Merge branch 'zj-find-ref-name' into 'master'
...
FindRefName RPC now mandatory
Closes gitaly#221
See merge request gitlab-org/gitlab-ce!20090
2018-06-22 13:35:49 +00:00
417a21a123
Raw diffs are served from Gitaly
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/222
2018-06-22 13:40:38 +02:00
4e9491f7bb
Repository size is Gitaly only
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/393
2018-06-22 11:53:18 +02:00
21c4ffe36f
FindRefName RPC now mandatory
...
Has never been in OPT_OUT, dispite being ages old. The time where
feature flags are still set by env vars.
Closes https://gitlab.com/gitlab-org/gitaly/issues/221
2018-06-22 11:41:07 +02:00
3247f47c8d
Git ls files is Gitaly only now
...
Moved to the front on the line through: https://gitlab.com/gitlab-org/gitlab-ce/issues/47893
Closes: https://gitlab.com/gitlab-org/gitlab-ce/issues/47893
Closes: https://gitlab.com/gitlab-org/gitaly/issues/327
2018-06-22 11:14:34 +02:00
2ac672280b
Raw changes calculation is Gitaly only now
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/1138
2018-06-21 10:12:51 +02:00
f87e702ece
CE-EE parity for lib/gitlab/git/gitlab_projects.rb
2018-06-20 15:08:11 -05:00
937bd9e386
Fix possiblilty of branch not found
...
This now can happen because can_be_merged? is called
during MR merge_status transition to cannot_be_merged.
It is possible branch_name is invalid.
2018-06-20 23:38:13 +08:00
a5245fd8b8
Merge branch 'zj-can-be-merged' into 'master'
...
Move mergablility check to Gitaly
Closes gitaly#889
See merge request gitlab-org/gitlab-ce!20019
2018-06-20 14:15:28 +00:00
b60415c2b7
Merge branch '48105-git-version-detection-using-gitaly' into 'master'
...
Move git version detection to gitaly for usage ping data
Closes #48105 and charts/gitlab#530
See merge request gitlab-org/gitlab-ce!19993
2018-06-20 09:00:32 +00:00
c67d8c2478
Merge branch 'zj-lfs-pointers' into 'master'
...
LFS changes are detected by Gitaly
Closes gitaly#935
See merge request gitlab-org/gitlab-ce!19995
2018-06-20 08:29:47 +00:00
46b56b18f5
Move mergablility check to Gitaly
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/889
2018-06-20 09:11:55 +02:00
c0f0ccf222
Merge branch 'zj-force-push-opt-out' into 'master'
...
Force push is handled by Gitaly now
Closes gitaly#348
See merge request gitlab-org/gitlab-ce!19992
2018-06-19 14:19:18 +00:00
64cda7746c
LFS changes are detected by Gitaly
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/935
2018-06-19 15:59:27 +02:00
c2cdefd441
Force push is handled by Gitaly now
...
Closes gitlab-org/gitaly#348
2018-06-19 15:35:17 +02:00
5607c57c41
Use gitaly to figure out git version for usage ping
2018-06-19 18:39:47 +05:30
b0fadeee83
Merge branch 'zj-counting-commits' into 'master'
...
Counting commits is done by Gitaly
Closes gitaly#382
See merge request gitlab-org/gitlab-ce!19983
2018-06-19 12:45:49 +00:00
51334904f5
Merge branch 'zj-gitaly-squash' into 'master'
...
Rebase and Squash in progress are Gitaly only
Closes gitaly#865 and gitaly#1018
See merge request gitlab-org/gitlab-ce!19987
2018-06-19 09:56:33 +00:00
14dda26b25
Merge branch 'zj-info-attributes' into 'master'
...
Move info attributes to mandatory
Closes gitaly#1082
See merge request gitlab-org/gitlab-ce!19988
2018-06-19 09:55:48 +00:00
9e82c32b31
Merge branch 'zj-commit-count' into 'master'
...
Move count commit to mandatory
Closes gitaly#330
See merge request gitlab-org/gitlab-ce!19984
2018-06-19 09:55:38 +00:00
c24e39ab88
Counting commits is done by Gitaly
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/382
2018-06-19 10:37:51 +02:00
012948b849
Move info attributes to mandatory
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/1082
2018-06-19 10:02:12 +02:00
5053dc84b0
Rebase and Squash in progress are Gitaly only
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/865
Closes https://gitlab.com/gitlab-org/gitaly/issues/1018
2018-06-19 09:41:09 +02:00
da8419a1ba
License detection happens soley through Gitaly now
...
Migration: https://gitlab.com/gitlab-org/gitaly/issues/1026
Conflicts:
lib/gitlab/git/repository.rb
2018-06-19 09:35:15 +02:00
6e25935f73
Move count commit to mandatory
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/330
2018-06-19 09:24:46 +02:00
14000a561b
Make Gitaly wiki RPC's mandatory
2018-06-18 08:19:11 +00:00
15f0cef1d0
Local branches go through Gitaly
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/217
2018-06-14 10:44:33 +02:00
3ed4a1b3aa
HasLocalBranches check is done by Gitaly only
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/217
2018-06-14 10:31:24 +02:00
89ab32c6b2
Branches are fully migrated to Gitaly
...
Closes: https://gitlab.com/gitlab-org/gitaly/issues/389
2018-06-14 10:25:28 +02:00
143a632ebe
Tags are migrated to Gitaly
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/390
2018-06-14 10:18:45 +02:00
36d75be393
Move TagNames to mandatory through Gitaly
...
Closes: https://gitlab.com/gitlab-org/gitaly/issues/220
2018-06-14 10:13:15 +02:00
89095530bc
Tag names returned through Gitaly
...
Migration: https://gitlab.com/gitlab-org/gitaly/issues/220
2018-06-14 10:00:47 +02:00
4fc4600747
Default branch detection happens through Gitaly
...
Migration: https://gitlab.com/gitlab-org/gitaly/issues/220
2018-06-14 09:56:16 +02:00
f195a7436d
RawBlame only called through Gitaly
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/376
2018-06-13 16:44:59 +02:00
4666ef683c
Merge branch 'zj-compare-source-branch' into 'master'
...
Migrate compare_source_branch to use only Gitaly
Closes gitaly#771
See merge request gitlab-org/gitlab-ce!19700
2018-06-13 08:26:00 +00:00
8b0d2283d7
Merge branch 'gitaly-disk-access-3' into 'master'
...
Find and mark more Git disk access locations, part 2
See merge request gitlab-org/gitlab-ce!19437
2018-06-12 13:32:46 +00:00
f376347f24
Find and mark more Git disk access locations, part 2
2018-06-12 14:33:37 +02:00
d65db552af
Migrate compare_source_branch to use only Gitaly
...
Initially expected this to be a full blown migration, but that wasn't
the case as we could fetch to a reference that would be deleted after
the instanciation of the Diff object.
This is a racy RPC, as #delete_refs is called and garbage collections
runs right than, the commit can't be found later.
Closes https://gitlab.com/gitlab-org/gitaly/issues/771
2018-06-12 12:48:09 +02:00
8749641838
Move Gitaly branch/tag/ref RPC's to opt-out
2018-06-12 09:24:05 +00:00
ea8dc10772
Don't use Gitlab::Utils.nlbr in Gitlab::Git
2018-06-11 10:42:09 +00:00
ab40c7e3c8
Move gitaly_blame, gitaly_count_commits, gitaly_commit_count to opt-out
2018-06-11 10:39:23 +00:00
2120391441
Remove Gitlab::Popen dependency from lib/gitlab/git
2018-06-08 11:16:21 +02:00
c5d4f10b80
Pass the --in-commit-order arg to `git-rev-list`
...
@jamedjo has found a good improvement in the performance of the LFS
integrity check by passing this arg
2018-06-07 12:09:45 -05:00
ea2bd9cb4f
Add git filter flag only if it is supported
2018-06-07 15:49:01 +00:00
86d39016a2
Moving rev-list lfs options to Lfschanges
2018-06-06 21:55:32 +02:00
e8f49b4bee
Support LFS objects when creating a project by import
2018-06-06 16:42:18 +00:00
e7ef91339e
Simplify server feature flags
2018-06-06 11:20:41 +02:00
f131757fc8
Set Gitaly Server feature flags from Rails
...
Gitaly itself hold very little state, other than the data on disk. This
limits the interfaces to set feature flags. Gitaly now has the ability
to interpret the request metadata to check for feature flags.
https://gitlab.com/gitlab-org/gitaly/merge_requests/704
This allows clients control on the Gitaly server, and given that Rails
has an internal chatops interface to set these values this was chosen as
solution.
Known limitation right now, is that this package doesn't support the opt
out that other Gitaly features do.
2018-06-06 11:20:41 +02:00
65dbead796
Fix repository archive generation when hashed storage is enabled
2018-06-05 20:44:07 +01:00
a0808df0b6
Find and mark more Git disk access locations
2018-06-05 15:51:14 +00:00
3a4ecfd0c9
Prevent Gitaly WriteConfig log noise
2018-06-05 12:55:41 +00:00
edb9db37ed
Add "deny disk access" Gitaly feature (tripswitch)
2018-06-01 11:56:29 +00:00
d6d7abb1d0
Merge branch 'gitaly-repo-squash-in-progress-opt-out' into 'master'
...
Make Repo#squash_in_progress Opt-Out
See merge request gitlab-org/gitlab-ce!19088
2018-05-23 09:52:11 +00:00
91f3930cc1
Merge branch 'gitaly-wiki-get-formatted-data-opt-out' into 'master'
...
Move Wiki::GetFormattedData to OptOut
See merge request gitlab-org/gitlab-ce!19091
2018-05-23 09:51:37 +00:00
68b5cd71e0
Merge branch 'gitaly-import-project-opt-out' into 'master'
...
Move ImportProject to OptOut in Gitaly
See merge request gitlab-org/gitlab-ce!19090
2018-05-23 09:50:54 +00:00
f0ef31a114
Move Repository#info_attributes to OptOut in gitaly
2018-05-22 16:05:02 +00:00
cb2a541027
Move Wiki::GetFormattedData to OptOut
2018-05-22 15:58:36 +00:00
2a781f7f5b
Move ImportProject to OptOut in Gitaly
2018-05-22 15:52:54 +00:00
536b32c8fa
Make Repo#squash_in_progress Opt-Out
2018-05-22 15:44:42 +00:00
b113330fab
Merge branch 'zj-workhorse-archive-mandatory' into 'master'
...
Move git archives downloading to Gitaly
See merge request gitlab-org/gitlab-ce!18990
2018-05-21 07:08:58 +00:00
ad9e00917f
Merge branch 'xeodon/gitlab-ce-fix/45743-master-fix-gitaly-delete-refs' into 'master'
...
Fix error when deleting an empty list of refs
Closes #45743
See merge request gitlab-org/gitlab-ce!19053
2018-05-19 05:42:16 +00:00
100c687cbc
Fix error when deleting an empty list of refs
...
Closes #45743
2018-05-18 20:47:46 -07:00
95dacabe4b
Merge branch '46498-do-not-modify-strings' into 'master'
...
Resolve "Blob#batch can't handle frozen string paths"
Closes #46498
See merge request gitlab-org/gitlab-ce!19039
2018-05-19 00:03:49 +00:00
076ab2e8e0
Merge branch 'fix/handle-large-commit-tag-message' into 'master'
...
Add handling for commit/tags with big messages
See merge request gitlab-org/gitlab-ce!17892
2018-05-18 19:28:25 +00:00
019f5e2469
Add handling for commit/tags with big messages
2018-05-18 20:51:10 +02:00
ee59fdf566
Merge branch 'gitaly-1182-search-by-content-name' into 'master'
...
Migrate Repo#search_by_{content,name} to Gitaly
See merge request gitlab-org/gitlab-ce!18750
2018-05-18 18:28:32 +00:00
8bacfbd1cc
Merge branch 'zj-calculate-checksum-mandator' into 'master'
...
Calculating repository checksums executed by Gitaly
Closes gitaly#1105 and #46293
See merge request gitlab-org/gitlab-ce!18907
2018-05-18 15:53:35 +00:00
73903ae884
Fix a RuntimeError: cannot modify frozen string
2018-05-18 15:19:58 +01:00
18a8eb96b3
Calculating repository checksums executed by Gitaly
...
OPT_OUT status has been removed, and alternative implementation removed.
Also checks if the repository exists before executing the checksum RPC
to guard against NotFound errors.
Closes gitlab-org/gitaly#1105
2018-05-18 16:07:29 +02:00
61a5994db6
Migrate RepositoryService#SearchFilesBy{Content,Name}
2018-05-18 12:51:28 +02:00
48877dfc7e
Merge branch 'zj-workhorse-commit-patch-diff' into 'master'
...
Workhorse to send raw diff and patch for commits
Closes gitaly#1196
See merge request gitlab-org/gitlab-ce!18974
2018-05-17 08:12:33 +00:00
94b209b32c
Move git archives downloading to Gitaly
2018-05-17 09:31:50 +02:00
f05ff2d93d
Merge branch 'zj-add-branch-mandatory' into 'master'
...
Move Gitlab::Git::Repository#add_branch to mandatory
Closes gitaly#540
See merge request gitlab-org/gitlab-ce!18939
2018-05-16 11:15:15 +00:00
dfdd881510
Workhorse to send raw diff and patch for commits
...
Prior to this change, this was done through unicorn. In theory this
could time out. Workhorse has been sending these raw patches and diffs
for a long time and is stable in doing so.
Added bonus is the fact that `Commit#to_patch` can be removed.
`Commit#to_diff` too, which closes
https://gitlab.com/gitlab-org/gitaly/issues/324
Closes https://gitlab.com/gitlab-org/gitaly/issues/1196
2018-05-16 11:52:43 +02:00
7fc185ab25
Ref contains oid check done by Gitaly
...
These two endpoints are in opt-out, and no one noticed. Has been running
on .com for 4 months now and considered stable.
Closes https://gitlab.com/gitlab-org/gitaly/issues/884
2018-05-14 15:55:27 +02:00
e012485a99
Move Gitlab::Git::Repository#add_branch to mandatory
...
Prior to this change, a feature flag could be used to disable this
feature. Now all requests go through Gitaly's OperationService.
Closes https://gitlab.com/gitlab-org/gitaly/issues/540
When vendoring `Gitlab::Git` again in Gitaly, this implemenation will be
gone, but this is readded there through:
https://gitlab.com/gitlab-org/gitaly/merge_requests/717
2018-05-14 12:18:23 +02:00
40683268b2
Merge branch 'rd-remove-duplicate-method' into 'master'
...
Remove duplicate method
See merge request gitlab-org/gitlab-ce!18886
2018-05-11 18:15:44 +00:00
4cf3a6094a
Wiki Find Page to opt_out
...
Closes https://gitlab.com/gitlab-org/gitaly/issues/894
2018-05-11 09:30:08 +02:00
0a0d4912f5
Remove duplicate method
2018-05-10 15:25:17 -05:00
05a6e2b866
Merge branch 'backport-rd-5566-improve-performance-of-repository-size-limit-check' into 'master'
...
Backport some changes from gitlab-ee!5476
See merge request gitlab-org/gitlab-ce!18760
2018-05-10 09:29:55 +00:00
5b584a0fd2
Backport some changes from gitlab-ee!5476
...
The lib/gitlab/git/repository.rb needs to have the same content between
gitlab-ce and gitlab-ee in order to have Gitaly working fine.
2018-05-09 13:20:28 -05:00
ce793073d7
Merge branch 'zj-remove-rugged-call' into 'master'
...
Remove rugged call in blame controller
See merge request gitlab-org/gitlab-ce!18817
2018-05-09 16:07:21 +00:00
4f15460d2c
Remove rugged call in blame controller
...
Fetching commits through #lookup uses rugged, and this is phased out.
Also adds a short circuit in the `feature_enabled?` Gitaly method to
allow Gitaly to be used when objects are set up with `let` before an
example is run.
2018-05-08 17:18:31 +02:00
17258b37c8
Raise InvalidRepository error for non-valid git repositories
2018-05-07 14:22:16 -03:00
713c7fa9a5
Client implementation GetRawChanges
...
Part of https://gitlab.com/gitlab-org/gitaly/issues/1138
2018-05-07 15:37:49 +02:00
8cbabe43be
Update repository.rb
2018-05-04 11:27:08 +00:00
3fe555a751
Add note about rebase/squash duplication in Gitaly
2018-05-04 10:45:20 +00:00
639cf5617f
Merge branch 'zj-fork-opt-out' into 'master'
...
Forking repositories is handled by Gitaly by default
See merge request gitlab-org/gitlab-ce!18679
2018-05-03 08:12:04 +00:00
6b93fafb56
Merge branch 'zj-repo-checksum-opt-out' into 'master'
...
Compute repository checksum by default
Closes gitaly#1146
See merge request gitlab-org/gitlab-ce!18648
2018-05-02 18:45:29 +00:00
2bbfa4cc66
Forking repositories is handled by Gitaly by default
...
Initial Rails implementation was introduced in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16018 , and
acceptance testing was done in
https://gitlab.com/gitlab-org/gitaly/issues/881
Part of https://gitlab.com/gitlab-org/gitaly/issues/817
2018-05-02 18:29:39 +02:00
3fcb9c115d
Merge branch 'zj-fix-index-rails' into 'master'
...
Use Ruby methods, not Rails' String#first
See merge request gitlab-org/gitlab-ce!18669
2018-05-01 10:16:18 +00:00
5e75d37705
Use Ruby methods, not Rails' String#first
...
Gitaly-Ruby is not a Rails application, which made the method not exist
after the vendor. This patch uses direct indexing, which has the same
properties that `#first` has.
Found while working on: https://gitlab.com/gitlab-org/gitaly/merge_requests/699
2018-05-01 10:49:58 +02:00
9cf4e47341
Merge branch 'security-45689-fix-archive-cache-bug' into 'security-10-7'
...
Serve archive requests with the correct file in all cases (10.7)
See merge request gitlab/gitlabhq!2376
2018-04-30 15:00:14 -05:00
660a902891
Merge branch 'zj-remove-repo-path-remote-repository' into 'master'
...
Remove legacy storage path call
See merge request gitlab-org/gitlab-ce!18598
2018-04-30 10:17:09 +00:00
27d2f407fb
Compute repository checksum by default
...
Acceptance testing was done in:
https://gitlab.com/gitlab-org/gitaly/issues/1146 . Errors were limited to
NotFound errors, as the repository really doesn't exists.
Closes https://gitlab.com/gitlab-org/gitaly/issues/1146
Optimistically moved https://gitlab.com/gitlab-org/gitaly/issues/1105 to
opt out on the Gitaly migration board.
2018-04-30 09:16:00 +02:00
7d23a2bfdf
Remove legacy storage path call
...
Storage shards should only be used, the exact paths are the
responsibilty of Gitaly. This will create deprecation warning, and in
this instance the path is initialized, but never used so it could be
removed.
2018-04-30 09:02:23 +02:00
5cd57cf250
Repository#exists? can only be queried with Gitaly
...
Has been in opt out for 5 months, and within GitLab been in production
for longer than that.
No code needs to be migrated as this is implemented in GoLang over at
Gitaly.
Closes https://gitlab.com/gitlab-org/gitaly/issues/314
2018-04-25 14:51:04 +02:00
c921e686b8
Moved committer and spec. Added some extra code to run hooks or not depending on the options
2018-04-23 10:56:46 +00:00
672733aa66
Add an API endpoint to download git repository snapshots
2018-04-19 17:25:01 +01:00
e8a27a67fa
Fix Custom hooks are not triggered by UI wiki edit
2018-04-18 17:50:56 +00:00
c6b1043e9d
Resolve "Make a Rubocop that forbids returning from a block"
2018-04-18 09:19:40 +00:00
019e881d44
Merge branch 'zj-uri-type-empty' into 'master'
...
Return nil on empty path
Closes gitaly#1115
See merge request gitlab-org/gitlab-ce!18430
2018-04-18 08:20:21 +00:00
b3ed751c0e
Merge branch 'zj-ref-exists-opt-out' into 'master'
...
Move Gitaly RefExists check to OPT_OUT
Closes gitaly#401
See merge request gitlab-org/gitlab-ce!18333
2018-04-17 17:37:08 +00:00
e02f1271f5
Return nil on empty path
...
The execution path wasn't clear from the error, but either way this is a
fix.
Closes gitlab-org/gitaly#1115
2018-04-17 16:30:18 +02:00
cf955af157
Move uncached_has_local_branches? to a private method
2018-04-14 15:38:53 -07:00
74e5ec198c
Fix failing ./spec/lib/backup/repository_spec.rb by clearing the memoized value
2018-04-14 15:36:36 -07:00
b1f15dfa42
Memoize Git::Repository#has_visible_content?
...
This is called repeatedly when viewing a merge request, and this should
improve performance significantly by avoiding shelling out to git every time.
This should help https://gitlab.com/gitlab-com/infrastructure/issues/4027 .
2018-04-14 14:37:28 -07:00
0c357db3a4
Remove bogus '|' symbol
2018-04-13 13:16:07 +00:00
ac149be040
Merge branch 'zj-storage-path-deprecation' into 'master'
...
Deprecate legacy disk paths
See merge request gitlab-org/gitlab-ce!18332
2018-04-13 08:16:39 +00:00
a752c56ca8
Deprecate legacy disk paths
...
Direct disk access is impossible on environments where components run in
their own container. There for constructing the path should not be done
except for exceptional cases.
One of the considerations, instead of logging, was to use Sentry. For
now I've chosen not to use this as the impact of this change is hard to
determine. Getting this in now will allow us to checkout the impact on
dev.gitlab.org and staging.
2018-04-12 15:23:36 +02:00
db6854b2cd
Merge branch 'backport-of-rd-3429-enabling-maximum-file-size-limit-in-repository-causes-pushes-to-fail' into 'master'
...
Backport of EE !4989
See merge request gitlab-org/gitlab-ce!18238
2018-04-12 08:46:36 +00:00
5173bc8a4c
Move Gitaly RefExists check to OPT_OUT
...
Part of the Gitaly migration as tracked in: https://gitlab.com/gitlab-org/gitaly/issues/401
Acceptance testing was done in: https://gitlab.com/gitlab-org/gitaly/issues/1014
2018-04-12 10:22:04 +02:00
d28b1dfc46
Backport of EE !4989
2018-04-11 22:05:07 -05:00
b2f57a561f
Merge branch 'zj-info-attributes' into 'master'
...
Client implementation for InfoAttributes
See merge request gitlab-org/gitlab-ce!18261
2018-04-11 12:58:52 +00:00
c830b8e3b7
Client implementation for InfoAttributes
...
Clients can now request the attributes from `$GIT_DIR/info/attributes`
through Gitaly. The Gitaly migration is described in gitlab-org/gitaly#1082 .
The parser algorithm was implemented in a way it could handle both file
contents or a File handle, and both were already tested.
Other than that, using the boy scout rule, I've removed a class,
InfoAttributes, as it was delegating everything to the parser and
therefor wasn't really needed in my opinion.
2018-04-11 14:21:27 +02:00
2a7d011afd
Merge branch 'zj-branch-containing-sha-opt-out' into 'master'
...
Branch with a commit detection defaults to Gitaly
See merge request gitlab-org/gitlab-ce!18304
2018-04-11 09:53:38 +00:00
bbbe40eae5
Tag with a commit detection defaults to Gitaly
...
By default this was an OPT_IN RPC, and now graduates to OPT_OUT as the
acceptance testing was successful in:
gitaly#1009
This follows the conventions of our [migration
process](https://gitlab.com/gitlab-org/gitaly/blob/master/doc/MIGRATION_PROCESS.md )
2018-04-11 09:31:11 +02:00
4d3f0998e0
Branch with a commit detection defaults to Gitaly
...
By default this was an OPT_IN RPC, and now graduates to OPT_OUT as the
acceptance testing was successful in:
https://gitlab.com/gitlab-org/gitaly/issues/1008
This follows the conventions of our [migration
process](https://gitlab.com/gitlab-org/gitaly/blob/master/doc/MIGRATION_PROCESS.md )
2018-04-11 09:13:02 +02:00
a2a6a5cab6
Merge branch 'zj-find-license-opt-out' into 'master'
...
Move FindLicense RPC to OPT OUT status
See merge request gitlab-org/gitlab-ce!18228
2018-04-09 09:32:58 +00:00
151d87e4a0
Merge branch 'da-gitaly-calculate-repository-checksum' into 'master'
...
Repository checksum calculation is handled by Gitaly when feature is enabled
See merge request gitlab-org/gitlab-ce!18210
2018-04-06 21:32:42 +00:00
9e8f3058af
Merge branch 'fix-500-error-when-mr-ref-is-not-yet-fetched' into 'master'
...
Fix 500 error when MR from fork has conflicts but worker has not run
See merge request gitlab-org/gitlab-ce!18226
2018-04-06 16:38:41 +00:00
76cd2d7881
Move checksum calculation to Gitlab::Git::Repository
2018-04-06 13:25:07 -03:00
13992ac92e
Checksum calculation is handled by Gitaly when feature is enabled
2018-04-06 13:23:23 -03:00
a18eea8c32
Automatically cleanup stale worktrees and lock files upon a push
...
git 2.16 will fail badly if there are stale worktrees.
Closes #44115
2018-04-06 08:17:07 -07:00
44f4a674e2
Merge branch 'jramsay-38830-tarball' into 'master'
...
Add alternative archive route
Closes #38830
See merge request gitlab-org/gitlab-ce!17225
2018-04-06 14:14:39 +00:00
4ca00b52cd
Move FindLicense RPC to OPT OUT status
...
Acceptance testing was successful in
https://gitlab.com/gitlab-org/gitaly/issues/1058 . So this is moved to
OPT OUT.
Part of https://gitlab.com/gitlab-org/gitaly/issues/1026
2018-04-06 16:13:01 +02:00
07f517d441
Add new repository archive route
...
Repository archives are always named `<project>-<ref>-<sha>` even if
the ref is a commit. A consequence of always including the sha even
for tags is that packaging a release is more difficult because both
the ref and sha must be known by the packager.
- add `<project>/-/archive/<ref>/<filename>.<format>` route using the
`-` separator to prevent namespace collisions. If the filename is
`<project>-<ref>` or the ref is a sha, the sha will be omitted,
otherwise the default filename will be used.
- deprecate previous archive route `repository/<ref>/archive`
2018-04-06 08:45:17 -04:00
30bca22d08
Fix 500 error when MR from fork has conflicts but worker has not run
...
If the ref hasn't been fetched into the target repository yet, this will fail
with a Rugged::ReferencError (assuming we're not using Gitaly). We should handle
this in the same way as a missing ref.
2018-04-06 12:16:51 +01:00
dda326f1d3
Merge branch 'ce-4474-custom-additional-text-in-confirmation-email' into 'master'
...
Add custom additional text to emails -- CE backport
Closes gitlab-ee#4474
See merge request gitlab-org/gitlab-ce!18183
2018-04-05 10:20:15 +00:00
Zeger-Jan van de Weg
Douwe Maan
Bob Van Landuyt
Rubén Dávila
Alejandro Rodríguez
Jacob Vosmaer (GitLab)
Stan Hu
Sean McGivern
Yorick Peterse
Rémy Coutable
Lin Jen-Shin
Sean McGivern
Robert Speicher
Grzegorz Bizon
Nick Thomas
Robert Speicher
Mark Chao
Balasankar "Balu" C
Francisco Javier López
Kim Carlbäcker
Sergey Sinev
Ahmad Sherif
Douglas Barbosa Alexandre
🙈 jacopo beschi 🙉
James Ramsay