Commit Graph

32 Commits

Author SHA1 Message Date
GitLab Bot bdca097916 Add latest changes from gitlab-org/gitlab@master 2020-08-11 03:11:00 +00:00
GitLab Bot 8b0ef13236 Add latest changes from gitlab-org/gitlab@master 2020-06-03 18:08:28 +00:00
Hordur Freyr Yngvason 5f82ff1469 Bring scoped environment variables to core
As decided in https://gitlab.com/gitlab-org/gitlab-ce/issues/53593
2019-08-08 18:51:52 +00:00
gfyoung 93a44e135b Add some frozen string to spec/**/*.rb
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-04-15 10:17:05 +00:00
blackst0ne b44a2c801a Update specs to rails5 format
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
Mark Chao a63bce1a4b Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
Matija Čupić f7ed096455
Extract Variables controllers specs to shared_examples 2018-02-05 18:58:21 +01:00
Matija Čupić 45a14b4f58
Refactor Variable controllers specs 2018-02-05 18:58:21 +01:00
Matija Čupić 18232d7efb
Extract Variable into separate JSON Schema 2018-02-05 18:58:21 +01:00
Matija Čupić 558057010f
Extract variable parameters in VariablesController specs 2018-02-05 18:58:20 +01:00
Matija Čupić 9be519c199
Add VariableSerializer for Ci::Variable 2018-02-05 18:58:19 +01:00
Matija Čupić b48d8c8ad0
Return all variables after UPDATE 2018-02-05 18:58:19 +01:00
Matija Čupić 9eb3bb5cff
Change POST to PATCH requests in the controller specs 2018-02-05 18:58:19 +01:00
Matija Čupić 0bfcdd66bf
Use `resource` in Project Variables routing scheme 2018-02-05 18:58:18 +01:00
Matija Čupić 2592aec9e3
Use all parameters in VariablesController specs 2018-02-05 18:58:18 +01:00
Matija Čupić edbe911b04
Remove redundant routes in VariablesController 2018-02-05 18:57:43 +01:00
Matija Čupić 5de85708ce
Use nested attributes for updating multiple variables 2018-02-05 18:57:43 +01:00
Matija Čupić ba07784192
Add destroy functionality to save_multiple 2018-02-05 18:57:43 +01:00
Matija Čupić 121d84d774
Implement multiple variable handling action 2018-02-05 18:57:42 +01:00
Matija Čupić fe96a1f268
Stub multiple variable controller method 2018-02-05 18:57:42 +01:00
blackst0ne 27c95364b5 Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
Jacopo 2f40dac352 Refactor `have_http_status` into `have_gitlab_http_status` in the specs 2017-10-20 10:13:18 +02:00
Robert Speicher 72a7b30c9f Change all `:empty_project` to `:project` 2017-08-02 17:47:31 -04:00
Shinya Maeda 8c434a52fc gb nice catches 2017-07-07 15:35:12 +09:00
Shinya Maeda 5b0954759c Basic BE change
Fix static-snalysis

Move the precedence of group secure variable before project secure variable. Allow project_id to be null.

Separate Ci::VariableProject and Ci::VariableGroup

Add the forgotton files

Add migration file to update type of ci_variables

Fix form_for fpr VariableProject

Fix test

Change the table structure according to the yorik advice

Add necessary migration files. Remove unnecessary migration spec.

Revert safe_model_attributes.yml

Fix models

Fix spec

Avoid self.variable. Use becomes for correct routing.

Use unique index on group_id and key

Add null: false for t.timestamps

Fix schema version

Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable

Rename the rest of them

Add the rest of files

Basic BE change

Fix static-snalysis

Move the precedence of group secure variable before project secure variable. Allow project_id to be null.

Separate Ci::VariableProject and Ci::VariableGroup

Add the forgotton files

Add migration file to update type of ci_variables

Fix form_for fpr VariableProject

Fix test

Change the table structure according to the yorik advice

Add necessary migration files. Remove unnecessary migration spec.

Revert safe_model_attributes.yml

Fix models

Fix spec

Avoid self.variable. Use becomes for correct routing.

Use unique index on group_id and key

Add null: false for t.timestamps

Fix schema version

Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable

Rename the rest of them

Add the rest of files

Implement CURD

Rename codes related to VariableGroup and VariableProject FE part

Remove unneccesary changes

Make Fe code up-to-date

Add protected flag to migration file

Protected group variables essential package

Update schema

Improve doc

Fix logic and spec for models

Fix logic and spec for controllers

 Fix logic and spec for views(pre feature)

Add feature spec

Fixed bugs. placeholder. reveal button. doc.

Add changelog

Remove unnecessary comment

godfat nice catches

Improve secret_variables_for arctecture

Fix spec

Fix StaticAnlysys & path_regex spec

Revert "Improve secret_variables_for arctecture"

This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1.

Use ayufan suggestion for secret_variables_for

Use find instead of find_by

Fix spec message for variable is invalid

Fix spec remove variable.group_id = group.id

godffat spec nitpicks

Use include Gitlab::Routing.url_helpers for presenter spec
2017-07-07 15:33:17 +09:00
Douwe Maan fe13f11041 Create and use project path helpers that only need a project, no namespace 2017-07-05 11:11:59 -05:00
Kamil Trzciński 12dd5ac221 All CI offline migrations 2017-03-17 23:06:11 +00:00
Douwe Maan ad640bc5f9 Use Namespace#full_path instead of #path where appropriate 2017-02-23 17:55:01 -06:00
Jose Ivan Vargas 1e9280a9d2 Fixed variables_controller_spec.rb test 2017-02-06 16:21:24 -06:00
Jose Ivan Vargas 44bb70c8c9 Improved code styling on the variables_controller_spec
Also updated the #update action inside the variables controller as
to render the show and not redirect back to the settings route
2017-02-06 14:51:19 -06:00
Jose Ivan Vargas f3aaf906d4 Added tests for the variables controller #update action 2017-02-06 14:51:19 -06:00
Jose Ivan Vargas d9d417d405 Added a variable_controller_spec test to test for flash messages on the #create action 2017-02-06 14:51:19 -06:00