Commit Graph

274 Commits

Author SHA1 Message Date
Phil Hughes 12edecd002
Add headers to files in the tree list on merge requests
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54807
2019-01-08 09:31:23 +00:00
Kushal Pandya 77de006319 Merge branch 'ee1979-user-avatar-list-component' into 'master'
Create shared user-avatar-list component

See merge request gitlab-org/gitlab-ce!24139
2019-01-07 09:05:18 +00:00
Kushal Pandya 32f80629bd Merge branch 'suggestion-dashes' into 'master'
Fixes diff sugestions removing dashes from diff

Closes #55634

See merge request gitlab-org/gitlab-ce!23994
2019-01-07 08:55:43 +00:00
Paul Slaughter ed7f44aaba
Create shared user-avatar-list component
**Why?**
We need a component that can expand / collapse a list of avatars for
approval rules table.

See issue https://gitlab.com/gitlab-org/gitlab-ee/issues/1979
2019-01-04 16:50:47 -06:00
Paul Slaughter 708df374f5
Create shared gl-modal-vuex component and module
**Why?**
It is significantly easier to manage the visibility of the modal in
Vuex. The module contains the state and mutations to manage this.
The component wraps GlModal and syncs the visibility with the module.
2019-01-03 23:34:15 -06:00
Clement Ho 0e20c8eb8b Merge branch 'tz-user-popover-follow-up' into 'master'
Added Comment to user avatar Image, Changed Fixtures to created ones, added shadow color

See merge request gitlab-org/gitlab-ce!23768
2019-01-03 21:04:16 +00:00
Paul Slaughter aedaef2b2c
Update callout component to receive slot
**Why?**
- This is needed to add buttons to the callout
2019-01-02 09:01:41 -06:00
Phil Hughes e6f1209ebf
Fixes diff sugestions removing dashes from diff
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55634
2018-12-21 17:22:59 +00:00
Martin Wortschack 63307ade1c Split bio into individual line in extended user tooltips
- Remove leading 'at' in organzation info
- Update karma tests
2018-12-21 11:18:37 +01:00
Tim Zallmann dac38419fe Merge branch '55276-encoding-issue-with-the-user-centric-tooltips' into 'master'
Resolve "Encoding issue with the user centric tooltips"

Closes #55276

See merge request gitlab-org/gitlab-ce!23794
2018-12-17 10:24:14 +00:00
Natalia Tepluhina 3c3701c97e Add a test for special characters 2018-12-14 20:23:29 +00:00
Oswaldo Ferreira ed3034bbb7 Allow suggesting single line changes in diffs 2018-12-13 19:17:19 +00:00
Tim Zallmann 14d3b53aa8 Comment user avatar Image, Changed Fixtures, added new shadow color
Needed to reorder css variables

Neede to reorder vars again

Added Changelog
2018-12-12 22:49:45 +01:00
Phil Hughes 2155395025 Merge branch 'winh-markdown-preview-lists' into 'master'
Remove unnecessary div from MarkdownField to apply list styles correctly

Closes #55190

See merge request gitlab-org/gitlab-ce!23733
2018-12-12 09:31:22 +00:00
Winnie Hellmann 1285fe6874 Remove unnecessary div from MarkdownField to apply list styles correctly 2018-12-12 08:48:18 +01:00
Winnie Hellmann d0d776b69d Move timeline_entry_item_spec.js to Jest 2018-12-11 15:03:59 +01:00
Kushal Pandya 295e8b9bed CE Backport: Epic issue list and related issue list re-design 2018-12-08 09:58:45 +00:00
Tim Zallmann ddd4cc649f Resolve "Extended user centric tooltips" 2018-12-08 03:12:23 +00:00
Phil Hughes 2ed65be1c3
Fixed renamed and mode changed diff viewers
Renders mode changed and renamed file merge request diff
viewers on the frontend.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52607
2018-12-06 14:39:29 +00:00
Winnie Hellmann e3bddb6223 Replace existing uses of timeline-entry with timeline entry component 2018-11-29 23:15:40 +01:00
Winnie Hellmann 99862050de Create shared timeline entry component 2018-11-29 19:10:28 +01:00
George Tsiolis 88e8ee0f6c Remove redundant specs for tooltip 2018-11-21 23:11:41 +02:00
George Tsiolis ccd1d6826b Fix typos in comments for js 2018-11-15 14:50:40 +02:00
Phil Hughes 73d3cb8c89
Fixed image commenting on moved files 2018-11-13 15:43:37 +00:00
Filipa Lacerda 9d45332fd2
Updates clipboard button with gitlab-ui
Updates clipboard button component to use
the new glTooltipDirective and the new glButton
component from gitlab-ui
2018-11-09 16:14:06 +00:00
Constance Okoghenun baa37edd93 Resolve "Issue board card design" 2018-11-07 17:20:17 +00:00
Filipa Lacerda e1e315ee28 Merge branch 'mr-image-commenting' into 'master'
Re-implemented image commenting on diffs

Closes #48956

See merge request gitlab-org/gitlab-ce!22443
2018-11-07 10:04:54 +00:00
Lukas Eipert 26ab92d3f3
Improve performance of rendering large reports
Instead of rendering all report items in 4 big lists, we make use of
vue-virtual-scroll-list and render only few dozens at once. This
improves the performance in several metrics:

- Initial load time
- Memory Pressure
- CPU Load
- DOM node count

In an example with around 11k reported security vulnerabilities:

- Initial load time: 27s -> 4.1s
- Memory Pressure: ~750 MB -> ~270 MB
- CPU Load (time spent on executing JS/Rendering): 22s -> 2.5s
- DOM node count: 430k -> 7k up to 30k while scrolling
2018-11-06 11:39:11 +01:00
Phil Hughes f7df9ddb52
Re-implemented image commenting on diffs
This re-implements image commenting in merge request diffs.
This feature was previously lost when the merge request
page was refactored into Vue.

With this, we create an overlay component. The overlay
component handles displaying the comment badges
and the comment form badge.
Badges are displayed based on the position attribute
sent with the discussion.

Comment forms for diff files are controlled through
a different state property. This is so we don't
tie comment forms to diff files directly creating
deep nested state. Instead we create a flat array
which holds the file hash & the X & Y position of
the comment form.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/48956
2018-11-05 14:02:41 +00:00
Achilleas Pipinellis 7f47e13218 Merge branch 'gt-update-typos-in-comments-and-specs' into 'master'
Fix typos in comments and specs

See merge request gitlab-org/gitlab-ce!22683
2018-11-01 10:34:23 +00:00
George Tsiolis 733ae94921 Fix typos in comments and specs 2018-11-01 08:59:20 +02:00
Mike Greiling 160157a92b
Prettify remaining files with differences in CE and EE 2018-10-31 14:33:12 -05:00
Kushal Pandya 8861885773 Update tooltip for when no date is present, port back EE changes 2018-10-29 15:08:53 +05:30
Winnie Hellmann 6bf2cb91bb Add validation for date strings passed to GlCountdown 2018-10-25 18:46:45 +02:00
Winnie Hellmann 6e680647c2 Add reusable component for counting down 2018-10-25 18:46:45 +02:00
Phil Hughes 9fd5a78d8b
Fixed failing specs
Added tests to file row truncated text computed prop
2018-10-23 09:12:37 +01:00
Filipa Lacerda 25170fbe7b Frontend: Review app changes 2018-10-22 08:31:24 +00:00
Jose Vargas d32abeece3
Fix transient failure from the bar_chart.vue component 2018-10-19 10:16:41 -05:00
George Tsiolis 1af6ddffed Change markdown header tab anchor links to buttons 2018-10-19 11:35:33 +00:00
Filipa Lacerda d6b684e42c Fixes broken test in master for ci status bagde 2018-10-18 15:09:06 +01:00
Mike Greiling 7a3e605350
Resolve eslint violations 2018-10-17 11:18:17 -05:00
Mike Greiling f666026d71
Prettify all spec files 2018-10-17 11:18:17 -05:00
Filipa Lacerda 5ed91cf81b Resolve "Integrate new vue+vuex code base with new API and remove old haml code" 2018-10-17 10:34:19 +00:00
Johann Hubert Sonntagbauer 6f5723a169 enable jasmine/new-line-before-expect 2018-10-17 06:57:29 +02:00
Johann Hubert Sonntagbauer db4c1f665f enable jasmine/prefer-jasmine-matcher 2018-10-09 20:30:03 +02:00
George Tsiolis e9f7908f5e Add button to insert table in markdown editor 2018-10-06 14:30:35 +00:00
Filipa Lacerda c375171bfd Merge branch 'mr-file-tree-data' into 'master'
Merge Request file tree

Closes #14249

See merge request gitlab-org/gitlab-ce!21833
2018-10-03 10:30:15 +00:00
Phil Hughes 33c4c5b8f3
Added file tree to merge request diffs
This file tree displays all the diff files in a tree like format
Each file is taken and converted into a tree with folders
Each folder can be toggled open & closed
Clicking a file will scroll to the diff file & highlight with a glow affect

Searching the tree list will search only files & return a list of the
files without any folders

Each file row contains an icon to show changed, new file or deleted
Each row will also contain the added & removed lines count

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14249
2018-10-03 10:05:43 +01:00
Jan Beckmann ceafbbd317 Resolve "Add "Link" shortcut/icon in markdown editor to make it easier to add references" 2018-10-02 13:59:42 +00:00
George Tsiolis 7f395e862a Rename block scope local variable in table pagination spec 2018-09-27 18:42:17 +03:00